67156 2011-08-29 15:06:22 -0700 Add HAVE(VASPRINTF) macro to test for vasprintf() support 2011-08-29 22:00:57 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates webkit.review.bot oldest_to_newest 458476 0 dbates 2011-08-29 15:06:22 -0700 Currently in XMLDocumentParser::error() (http://trac.webkit.org/browser/trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp?rev=93638#L941) we hardcode compiler-specific testing for vasprintf() support. Instead, we should abstract this decision into a HAVE(VASPRINTF) macro so as to reduce duplicate code in XMLDocumentParser::error() as well as to centralize a definition for vasprintf() support. This would also make testing for vasprintf() support similar to testing for strnstr() support. 458481 1 105530 dbates 2011-08-29 15:22:20 -0700 Created attachment 105530 Patch No change in functionality. 458691 2 105530 webkit.review.bot 2011-08-29 22:00:53 -0700 Comment on attachment 105530 Patch Clearing flags on attachment: 105530 Committed r94044: <http://trac.webkit.org/changeset/94044> 458692 3 webkit.review.bot 2011-08-29 22:00:57 -0700 All reviewed patches have been landed. Closing bug. 105530 2011-08-29 15:22:20 -0700 2011-08-29 22:00:53 -0700 Patch Bug67156.patch text/plain 2883 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQwMTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMjkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAg IEFkZCBIQVZFKFZBU1BSSU5URikgbWFjcm8gdG8gdGVzdCBmb3IgdmFzcHJpbnRmKCkgc3VwcG9y dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcxNTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmNhcHN1 bGF0ZSB0ZXN0aW5nIG9mIHZhc3ByaW50ZigpIHN1cHBvcnQgaW4gYSBIQVZFIG1hY3JvCisgICAg ICAgIGluc3RlYWQgb2YgaGFyZGNvZGluZyB0aGUgbGlzdCBvZiBzdXBwb3J0ZWQvdW5zdXBwb3J0 ZWQKKyAgICAgICAgY29tcGlsZXJzIGF0IHRoZSBjYWxsIHNpdGUuCisKKyAgICAgICAgKiB3dGYv UGxhdGZvcm0uaDoKKwogMjAxMS0wOC0yOSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgcjkzOTkwLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gOTQwMTUpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4MSw2 ICs2ODEsMTIgQEAKICNkZWZpbmUgSEFWRV9TSUdOQUxfSCAxCiAjZW5kaWYKIAorI2lmICFkZWZp bmVkKEhBVkVfVkFTUFJJTlRGKQorI2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIoUlZD VCkgJiYgIUNPTVBJTEVSKE1JTkdXKQorI2RlZmluZSBIQVZFX1ZBU1BSSU5URiAxCisjZW5kaWYK KyNlbmRpZgorCiAjaWYgIWRlZmluZWQoSEFWRV9TVFJOU1RSKQogI2lmIE9TKERBUldJTikgfHwg T1MoRlJFRUJTRCkKICNkZWZpbmUgSEFWRV9TVFJOU1RSIDEKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDk0MDE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIEFkZCBIQVZFKFZBU1BSSU5URikgbWFjcm8gdG8gdGVzdCBmb3IgdmFz cHJpbnRmKCkgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjcxNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHhtbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlhNTERvY3VtZW50UGFyc2VyOjplcnJvcik6IE1vZGlmaWVkIHRvIHVzZSBI QVZFKFZBU1BSSU5URikuCisKIDIwMTEtMDgtMjkgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZy YWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gUmVuZGVyTGF5 ZXI6OmNvbXB1dGVSZXBhaW50UmVjdHMgd2hlbiBzY3JvbGxpbmcKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAJ KHJldmlzaW9uIDk0MDE1KQorKysgU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVu dFBhcnNlckxpYnhtbDIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MzgsMTMgKzkzOCwxMyBAQCB2 b2lkIFhNTERvY3VtZW50UGFyc2VyOjplcnJvcihYTUxFcnJvcnM6CiAgICAgaWYgKGlzU3RvcHBl ZCgpKQogICAgICAgICByZXR1cm47CiAKLSNpZiBDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihS VkNUKSB8fCBDT01QSUxFUihNSU5HVykKLSAgICBjaGFyIG1bMTAyNF07Ci0gICAgdnNucHJpbnRm KG0sIHNpemVvZihtKSAtIDEsIG1lc3NhZ2UsIGFyZ3MpOwotI2Vsc2UKKyNpZiBIQVZFKFZBU1BS SU5URikKICAgICBjaGFyKiBtOwogICAgIGlmICh2YXNwcmludGYoJm0sIG1lc3NhZ2UsIGFyZ3Mp ID09IC0xKQogICAgICAgICByZXR1cm47CisjZWxzZQorICAgIGNoYXIgbVsxMDI0XTsKKyAgICB2 c25wcmludGYobSwgc2l6ZW9mKG0pIC0gMSwgbWVzc2FnZSwgYXJncyk7CiAjZW5kaWYKIAogICAg IGlmIChtX3BhcnNlclBhdXNlZCkKQEAgLTk1Miw3ICs5NTIsNyBAQCB2b2lkIFhNTERvY3VtZW50 UGFyc2VyOjplcnJvcihYTUxFcnJvcnM6CiAgICAgZWxzZQogICAgICAgICBoYW5kbGVFcnJvcih0 eXBlLCBtLCBsaW5lTnVtYmVyKCksIGNvbHVtbk51bWJlcigpKTsKIAotI2lmICFDT01QSUxFUihN U1ZDKSAmJiAhQ09NUElMRVIoUlZDVCkgJiYgIUNPTVBJTEVSKE1JTkdXKQorI2lmIEhBVkUoVkFT UFJJTlRGKQogICAgIGZyZWUobSk7CiAjZW5kaWYKIH0K