67155 2011-08-29 14:31:48 -0700 [Qt] QDesktopWebView url property test missing 2011-08-29 16:20:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned menard webkit.review.bot oldest_to_newest 458456 0 gopal.1.raghavan 2011-08-29 14:31:48 -0700 Need test for url property in QDesktopWebView 458462 1 105523 gopal.1.raghavan 2011-08-29 14:37:39 -0700 Created attachment 105523 url property test for DesktopWebView Here is the test results: ********* Start testing of tst_CommonViewTests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_CommonViewTests::initTestCase() PASS : tst_CommonViewTests::baseUrl() PASS : tst_CommonViewTests::loadEmptyUrl() QWARN : tst_CommonViewTests::loadEmptyPageViewVisible() QSocketNotifier: socket notifiers cannot be enabled from another thread QWARN : tst_CommonViewTests::loadEmptyPageViewVisible() QSocketNotifier: socket notifiers cannot be enabled from another thread QWARN : tst_CommonViewTests::loadEmptyPageViewVisible() QObject::startTimer: timers cannot be started from another thread PASS : tst_CommonViewTests::loadEmptyPageViewVisible() QWARN : tst_CommonViewTests::loadEmptyPageViewHidden() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_CommonViewTests::loadEmptyPageViewHidden() QWARN : tst_CommonViewTests::loadNonexistentFileUrl() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_CommonViewTests::loadNonexistentFileUrl() QWARN : tst_CommonViewTests::backAndForward() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_CommonViewTests::backAndForward() QWARN : tst_CommonViewTests::reload() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_CommonViewTests::reload() PASS : tst_CommonViewTests::stop() PASS : tst_CommonViewTests::loadProgress() QWARN : tst_CommonViewTests::show() QSocketNotifier: socket notifiers cannot be enabled from another thread QWARN : tst_CommonViewTests::show() QObject::startTimer: timers cannot be started from another thread PASS : tst_CommonViewTests::show() PASS : tst_CommonViewTests::cleanupTestCase() Totals: 12 passed, 0 failed, 0 skipped ********* Finished testing of tst_CommonViewTests ********* ********* Start testing of tst_QTouchWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QTouchWebView::initTestCase() PASS : tst_QTouchWebView::accessPage() PASS : tst_QTouchWebView::navigationActionsStatusAtStartup() PASS : tst_QTouchWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QTouchWebView ********* ********* Start testing of tst_QDesktopWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QDesktopWebView::initTestCase() PASS : tst_QDesktopWebView::navigationActionsStatusAtStartup() QWARN : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() PASS : tst_QDesktopWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QDesktopWebView ********* ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::test_url() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 11 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* ********************************************************************** ** TOTALS: 31 passed, 0 failed, 0 skipped ** ********************************************************************** 458468 2 105523 noam 2011-08-29 14:52:18 -0700 Comment on attachment 105523 url property test for DesktopWebView View in context: https://bugs.webkit.org/attachment.cgi?id=105523&action=review > Source/WebKit2/ChangeLog:8 > + Added qml test case to check url property Period at end of sentence please. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:30 > + var tstUrl = Qt.resolvedUrl("../common/test1.html") > + webView.load(tstUrl) > + spy.wait() > + compare(webView.url, tstUrl) > + } This doesn't test anything. Please test that the page actually loaded, e.g. by testing that the title has changed (like the test above it). Also, use testUrl instead of tstUrl. Abbvs don't smplfy reading the code :) 458471 3 gopal.1.raghavan 2011-08-29 14:56:56 -0700 webView.url is a read only property. All it does is to check and see if the url is set properly. This is not a title test. That is already take care of in previous test case. I can take care of tstUrl. Thanks 458475 4 105526 gopal.1.raghavan 2011-08-29 15:03:40 -0700 Created attachment 105526 updated desktopwebview patch Taken care of reviewer comments. 458488 5 menard 2011-08-29 15:32:05 -0700 (In reply to comment #3) > webView.url is a read only property. All it does is to check and see if the url is set properly. > This is not a title test. That is already take care of in previous test case. > > I can take care of tstUrl. > Thanks What Noam said is that load is async therefore in theory testing the property right away is not valid. 458490 6 gopal.1.raghavan 2011-08-29 15:34:40 -0700 That's why we wait on spy for signal "loadSucceeded". 458497 7 105526 menard 2011-08-29 15:40:20 -0700 Comment on attachment 105526 updated desktopwebview patch Ah yes perfect then. 458531 8 105526 webkit.review.bot 2011-08-29 16:19:56 -0700 Comment on attachment 105526 updated desktopwebview patch Clearing flags on attachment: 105526 Committed r94027: <http://trac.webkit.org/changeset/94027> 458532 9 webkit.review.bot 2011-08-29 16:20:01 -0700 All reviewed patches have been landed. Closing bug. 105523 2011-08-29 14:37:39 -0700 2011-08-29 15:03:40 -0700 url property test for DesktopWebView 67155.patch text/plain 1413 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MDE1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgdXJsIHByb3BlcnR5IHRlc3QgbWlzc2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcxNTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBxbWwgdGVzdCBjYXNlIHRvIGNoZWNr IHVybCBwcm9wZXJ0eQorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9EZXNrdG9wV2ViVmlldy90c3RfcHJvcGVydGllcy5xbWw6CisKIDIwMTEtMDgtMjkgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI5Mzk4NywgcjkzOTkyLCByOTM5OTUsIHI5Mzk5OCwgYW5kCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BX ZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0 aWVzLnFtbAkocmV2aXNpb24gOTM5ODgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbAkod29y a2luZyBjb3B5KQpAQCAtMjAsNSArMjAsMTMgQEAgRGVza3RvcFdlYlZpZXcgewogICAgICAgICAg ICAgc3B5LndhaXQoKQogICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnRpdGxlLCAiVGVzdCBw YWdlIDEiKQogICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF91cmwoKSB7CisgICAg ICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMSkKKyAgICAgICAgICAgIHZhciB0c3RVcmwgPSBR dC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Rlc3QxLmh0bWwiKQorICAgICAgICAgICAgd2ViVmll dy5sb2FkKHRzdFVybCkKKyAgICAgICAgICAgIHNweS53YWl0KCkKKyAgICAgICAgICAgIGNvbXBh cmUod2ViVmlldy51cmwsIHRzdFVybCkKKyAgICAgICAgfQogICAgIH0KIH0K 105526 2011-08-29 15:03:40 -0700 2011-08-29 16:19:56 -0700 updated desktopwebview patch 67155a.patch text/plain 1502 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MDE1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgdXJsIHByb3BlcnR5IHRlc3QgbWlzc2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcxNTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBxbWwgdGVzdCBjYXNlIHRvIGNoZWNr IHVybCBwcm9wZXJ0eS4gU2luY2UgdXJsIGlzIGEgcmVhZG9ubHkgcHJvcGVydHksIHdlIG1ha2Ug c3VyZSB0aGF0IGl0J3Mgc2V0IGFmdGVyIGxvYWQoKSBpcyBjYWxsZWQuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0 aWVzLnFtbDoKKwogMjAxMS0wOC0yOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkzOTg3LCByOTM5 OTIsIHI5Mzk5NSwgcjkzOTk4LCBhbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMucW1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvRGVza3RvcFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMucW1sCShyZXZpc2lvbiA5Mzk4OCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdl YlZpZXcvdHN0X3Byb3BlcnRpZXMucW1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw1ICsyMCwxMyBA QCBEZXNrdG9wV2ViVmlldyB7CiAgICAgICAgICAgICBzcHkud2FpdCgpCiAgICAgICAgICAgICBj b21wYXJlKHdlYlZpZXcudGl0bGUsICJUZXN0IHBhZ2UgMSIpCiAgICAgICAgIH0KKworICAgICAg ICBmdW5jdGlvbiB0ZXN0X3VybCgpIHsKKyAgICAgICAgICAgIGNvbXBhcmUoc3B5LmNvdW50LCAx KQorICAgICAgICAgICAgdmFyIHRlc3RVcmwgPSBRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Rl c3QxLmh0bWwiKQorICAgICAgICAgICAgd2ViVmlldy5sb2FkKHRlc3RVcmwpCisgICAgICAgICAg ICBzcHkud2FpdCgpCisgICAgICAgICAgICBjb21wYXJlKHdlYlZpZXcudXJsLCB0ZXN0VXJsKQor ICAgICAgICB9CiAgICAgfQogfQo=