67123 2011-08-29 05:46:02 -0700 [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API DEFINE in WebKit2 2011-08-29 09:07:46 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 1 pierre.rossi pierre.rossi kling webkit.review.bot oldest_to_newest 458185 0 pierre.rossi 2011-08-29 05:46:02 -0700 If that define is set to 0, there will be things missing in WebCore. :/ 458187 1 105482 pierre.rossi 2011-08-29 05:56:40 -0700 Created attachment 105482 Patch 458191 2 105482 kling 2011-08-29 06:09:50 -0700 Comment on attachment 105482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105482&action=review Looks sane. > Source/WebKit2/ChangeLog:3 > + [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API DEFINE in WebKit2 s/DEFINE/define/ > Source/WebKit2/WebKit2.pro:582 > + DEFINES += PLUGIN_ARCHITECTURE_UNSUPPORTED Indentation should be 4 spaces here, not 8. 458219 3 105491 pierre.rossi 2011-08-29 07:57:29 -0700 Created attachment 105491 Patch 458237 4 105491 webkit.review.bot 2011-08-29 09:07:41 -0700 Comment on attachment 105491 Patch Clearing flags on attachment: 105491 Committed r93979: <http://trac.webkit.org/changeset/93979> 458238 5 webkit.review.bot 2011-08-29 09:07:46 -0700 All reviewed patches have been landed. Closing bug. 105482 2011-08-29 05:56:40 -0700 2011-08-29 07:57:23 -0700 Patch bug-67123-20110829145605.patch text/plain 1293 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTMyMDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2MmRkYjdlYzI0MDg1ODcy Y2ZmNmFkY2Q1YWM2OTc3NWIxNjcyYWM5Li5jNjU1ZjRiZTczMDU0ZWU1MjA3ZjlhNmYxODY1MzQy NDRiNzViZDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjkgIFBpZXJy ZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisKKyAgICAgICAgW1F0XSBOUEFQSSBz dXBwb3J0IGRvZXNuJ3QgaG9ub3IgdGhlIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIERFRklO RSBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NzEyMworCisgICAgICAgIFdlIGNvdWxkIHNpbXBseSB1c2UgdGhlIGRlZmluZXMgYWxy ZWFkeSBpbiBwbGFjZSBmb3IgdGhpcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYktpdDIucHJvOgorCiAyMDExLTA4LTE1ICBEbWl0cnkgVGl0 b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50Ojp0 cmFuc2ZlckxvYWRpbmdSZXNvdXJjZUZyb21QYWdlIGRvZXMgbm90IGhhdmUgZW5vdWdoIHBhcmFt ZXRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYktpdDIucHJvIGIvU291cmNlL1dl YktpdDIvV2ViS2l0Mi5wcm8KaW5kZXggNDRlYmI2OWNkYzJkZGQyNWFhMTI1ODNhYmRiOTVkZjEx MzhjNjI3NC4uMjE1OGIzNmFjYTZkMWQxZDgyOTg3Y2RmYjVmYzYwNzhiYWMwNmRjZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViS2l0Mi5wcm8KKysrIGIvU291cmNlL1dlYktpdDIvV2Vi S2l0Mi5wcm8KQEAgLTU3OCw2ICs1NzgsMTAgQEAgU09VUkNFUyArPSBcCiAgICAgV2ViUHJvY2Vz cy9xdC9XZWJQcm9jZXNzUXQuY3BwIFwKICAgICAkJFdFQktJVDJfR0VORVJBVEVEX1NPVVJDRVMK IAorY29udGFpbnMoREVGSU5FUywgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEk9MCkgeworICAg ICAgICBERUZJTkVTICs9IFBMVUdJTl9BUkNISVRFQ1RVUkVfVU5TVVBQT1JURUQKK30KKwogY29u dGFpbnMoREVGSU5FUywgRU5BQkxFX1RPVUNIX0VWRU5UUz0xKSB7CiAgICAgSEVBREVSUyArPSBc CiAgICAgICAgIFNoYXJlZC9OYXRpdmVXZWJUb3VjaEV2ZW50LmgK 105491 2011-08-29 07:57:29 -0700 2011-08-29 09:07:41 -0700 Patch bug-67123-20110829165653.patch text/plain 1289 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTMyMDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2MmRkYjdlYzI0MDg1ODcy Y2ZmNmFkY2Q1YWM2OTc3NWIxNjcyYWM5Li4xYzI0ODJlMWQ4Yjk1N2VhZGQ4ZTIwNmVhN2UyYmM0 MGVlZjFiNGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjkgIFBpZXJy ZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisKKyAgICAgICAgW1F0XSBOUEFQSSBz dXBwb3J0IGRvZXNuJ3QgaG9ub3IgdGhlIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIGRlZmlu ZSBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NzEyMworCisgICAgICAgIFdlIGNvdWxkIHNpbXBseSB1c2UgdGhlIGRlZmluZXMgYWxy ZWFkeSBpbiBwbGFjZSBmb3IgdGhpcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYktpdDIucHJvOgorCiAyMDExLTA4LTE1ICBEbWl0cnkgVGl0 b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50Ojp0 cmFuc2ZlckxvYWRpbmdSZXNvdXJjZUZyb21QYWdlIGRvZXMgbm90IGhhdmUgZW5vdWdoIHBhcmFt ZXRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYktpdDIucHJvIGIvU291cmNlL1dl YktpdDIvV2ViS2l0Mi5wcm8KaW5kZXggNDRlYmI2OWNkYzJkZGQyNWFhMTI1ODNhYmRiOTVkZjEx MzhjNjI3NC4uY2NmZTY0ZDI1ZTY5YTI0NTgzMDk1N2JmOWQ2ZjExMTNmZDk5ZDFlZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViS2l0Mi5wcm8KKysrIGIvU291cmNlL1dlYktpdDIvV2Vi S2l0Mi5wcm8KQEAgLTU3OCw2ICs1NzgsMTAgQEAgU09VUkNFUyArPSBcCiAgICAgV2ViUHJvY2Vz cy9xdC9XZWJQcm9jZXNzUXQuY3BwIFwKICAgICAkJFdFQktJVDJfR0VORVJBVEVEX1NPVVJDRVMK IAorY29udGFpbnMoREVGSU5FUywgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEk9MCkgeworICAg IERFRklORVMgKz0gUExVR0lOX0FSQ0hJVEVDVFVSRV9VTlNVUFBPUlRFRAorfQorCiBjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfVE9VQ0hfRVZFTlRTPTEpIHsKICAgICBIRUFERVJTICs9IFwKICAg ICAgICAgU2hhcmVkL05hdGl2ZVdlYlRvdWNoRXZlbnQuaAo=