67104 2011-08-28 22:12:14 -0700 Update registerProtocolHandler scheme whitelist to match spec 2011-08-30 08:59:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benwells benwells abarth koz mikelawther webkit.review.bot oldest_to_newest 458067 0 benwells 2011-08-28 22:12:14 -0700 Update registerProtocolHandler scheme whitelist to match spec 458071 1 105460 benwells 2011-08-28 22:31:08 -0700 Created attachment 105460 Patch 458288 2 105460 darin 2011-08-29 10:57:09 -0700 Comment on attachment 105460 Patch Can we test this? 458352 3 abarth 2011-08-29 12:19:33 -0700 > Can we test this? Does registerProtocolHandler report some sort of error when you register something off the whitelist? Maybe we could register something and try to use the registration? Seems like it ought to be testable. 458690 4 105575 benwells 2011-08-29 22:00:20 -0700 Created attachment 105575 Patch 458693 5 105575 benwells 2011-08-29 22:01:27 -0700 Comment on attachment 105575 Patch There is already a test which checks that schemes not in the whitelist fail to register. I've added to this test to make sure all schemes in the whitelist can be registered. 458929 6 105575 webkit.review.bot 2011-08-30 08:59:53 -0700 Comment on attachment 105575 Patch Clearing flags on attachment: 105575 Committed r94079: <http://trac.webkit.org/changeset/94079> 458930 7 webkit.review.bot 2011-08-30 08:59:57 -0700 All reviewed patches have been landed. Closing bug. 105460 2011-08-28 22:31:08 -0700 2011-08-29 22:00:13 -0700 Patch bug-67104-20110829153106.patch text/plain 1363 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTM5NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMGZjYzRjMTZkMzFmZjY1 YzgzZGU4YTVjMjJiYzhiZmM3MGU4MDg4Li41ZTA3NmNmNDAzY2Y2MDNhN2FjMmFhMDg1YmI1Mzc0 Yzg1ZTYzY2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjggIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgcmVnaXN0ZXJQ cm90b2NvbEhhbmRsZXIgc2NoZW1lIHdoaXRlbGlzdCB0byBtYXRjaCBzcGVjCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzEwNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9OYXZpZ2F0b3IuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6aW5pdFByb3RvY29sSGFuZGxlcldoaXRlbGlzdCk6CisKIDIw MTEtMDgtMjggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAg Q2hyb21pdW0gV2luOiBTZXR0aW5nIHNxdWFyZS1idXR0b24gYXBwZWFyYW5jZSByZWFjaGVzIE5P VFJFQUNIRUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcAppbmRleCAwMmZmOTM3YWQ2Nzk5NTU5 MDEzNzIyZjI1ZDQxNzQ4OTY0OTNlZjY4Li5iMWU0YWIxZmZkNjY5Y2Q5OGU1Y2I3OTBlYTc0YjAz ODI5OTc1OTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuY3BwCkBAIC0xOTAsMTAgKzE5MCwx NSBAQCBzdGF0aWMgdm9pZCBpbml0UHJvdG9jb2xIYW5kbGVyV2hpdGVsaXN0KCkKIHsKICAgICBw cm90b2NvbFdoaXRlbGlzdCA9IG5ldyBIYXNoU2V0PFN0cmluZz47CiAgICAgc3RhdGljIGNvbnN0 IGNoYXIqIHByb3RvY29sc1tdID0geworICAgICAgICAiaXJjIiwKICAgICAgICAgIm1haWx0byIs CiAgICAgICAgICJtbXMiLAorICAgICAgICAibmV3cyIsCiAgICAgICAgICJubnRwIiwKLSAgICAg ICAgInJ0c3AiLAorICAgICAgICAic21zIiwKKyAgICAgICAgInNtc3RvIiwKKyAgICAgICAgInRl bCIsCisgICAgICAgICJ1cm4iLAogICAgICAgICAid2ViY2FsIiwKICAgICB9OwogICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgV1RGX0FSUkFZX0xFTkdUSChwcm90b2NvbHMpOyArK2kpCg== 105575 2011-08-29 22:00:20 -0700 2011-08-30 08:59:53 -0700 Patch bug-67104-20110830150018.patch text/plain 5443 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTQwMjYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyOWE2NDlmNWY5NjY0MDgwOWEzYjUz MzUxMWRhOTE0M2Y3NTdkYTFkLi5mZTk0NjM3M2FiMWE3MThjN2M1ZmZjMTkyY2Y0ZGE2MmRjM2Nl OGJiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjkgIEJlbiBXZWxscyAgPGJlbndl bGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgcmVnaXN0ZXJQcm90b2NvbEhhbmRs ZXIgc2NoZW1lIHdoaXRlbGlzdCB0byBtYXRjaCBzcGVjCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzEwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wtaGFu ZGxlci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wt aGFuZGxlci5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL3JlZ2lz dGVyLXByb3RvY29sLWhhbmRsZXItZXhwZWN0ZWQudHh0OgorCiAyMDExLTA4LTI5ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHBhdGggdG8gc3R5bGUgc2hlZXQg aW4gZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2V2ZW50LWNvbnN0cnVjdG9ycy5odG1sLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wtaGFuZGxlci1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9yZWdpc3Rlci1wcm90b2NvbC1oYW5k bGVyLWV4cGVjdGVkLnR4dAppbmRleCA1ZmIzYTRkNGVmZDFhNzVkMzAxNTY4ZDA4MGZjZjFhZjY4 OGVmZmUzLi5iOTY0YjgwYjY3N2RkM2FlNzU5MzkzNGI4MmQ5Zjk1NTQwYzEyYjg1IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9yZWdpc3Rlci1wcm90b2NvbC1oYW5kbGVyLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9yZWdpc3Rlci1wcm90b2NvbC1oYW5k bGVyLWV4cGVjdGVkLnR4dApAQCAtNCw2ICs0LDE2IEBAIEZhaWw6IHdpbmRvdy5uYXZpZ2F0b3Iu cmVnaXN0ZXJQcm90b2NvbEhhbmRsZXIgaXMgbm90IGRlZmluZWQuCiBGYWlsOiBJbnZhbGlkIHBy b3RvY29sICJodHRwIiBhbGxvd2VkLgogRmFpbDogSW52YWxpZCBwcm90b2NvbCAiaHR0cHMiIGFs bG93ZWQuCiBGYWlsOiBJbnZhbGlkIHByb3RvY29sICJmaWxlIiBhbGxvd2VkLgorRmFpbDogVmFs aWQgcHJvdG9jb2wgImlyYyIgZmFpbGVkLgorRmFpbDogVmFsaWQgcHJvdG9jb2wgIm1haWx0byIg ZmFpbGVkLgorRmFpbDogVmFsaWQgcHJvdG9jb2wgIm1tcyIgZmFpbGVkLgorRmFpbDogVmFsaWQg cHJvdG9jb2wgIm5ld3MiIGZhaWxlZC4KK0ZhaWw6IFZhbGlkIHByb3RvY29sICJubnRwIiBmYWls ZWQuCitGYWlsOiBWYWxpZCBwcm90b2NvbCAic21zIiBmYWlsZWQuCitGYWlsOiBWYWxpZCBwcm90 b2NvbCAic21zdG8iIGZhaWxlZC4KK0ZhaWw6IFZhbGlkIHByb3RvY29sICJ0ZWwiIGZhaWxlZC4K K0ZhaWw6IFZhbGlkIHByb3RvY29sICJ1cm4iIGZhaWxlZC4KK0ZhaWw6IFZhbGlkIHByb3RvY29s ICJ3ZWJjYWwiIGZhaWxlZC4KIEZhaWw6IEludmFsaWQgdXJsICIiIGFsbG93ZWQuCiBGYWlsOiBJ bnZhbGlkIHVybCAiJVMiIGFsbG93ZWQuCiBGYWlsOiBJbnZhbGlkIGNhbGwgZGlkIG5vdCBzdWNj ZWVkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wt aGFuZGxlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wtaGFu ZGxlci5odG1sCmluZGV4IGUxYmJmZjg5OWQzNDY0MjNhMjViZTYxZjNkOTU5NjI0NjE2YmVlYTEu LjE3YTUxNzc1MjAzZDBiN2U0MWY1MmEzYzcxNTEzMmEyZWRmYzIxZmIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL3JlZ2lzdGVyLXByb3RvY29sLWhhbmRsZXIuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9yZWdpc3Rlci1wcm90b2NvbC1oYW5kbGVyLmh0bWwKQEAgLTMy LDYgKzMyLDIyIEBAIGludmFsaWRfcHJvdG9jb2xzLmZvckVhY2goZnVuY3Rpb24gKHByb3RvY29s KSB7CiAgICAgICAgIGRlYnVnKCdGYWlsOiBJbnZhbGlkIHByb3RvY29sICInICsgcHJvdG9jb2wg KyAnIiBhbGxvd2VkLicpOwogfSk7CiAKK3ZhciB2YWxpZF9wcm90b2NvbHMgPSBbJ2lyYycsICdt YWlsdG8nLCAnbW1zJywgJ25ld3MnLCAnbm50cCcsICdzbXMnLCAnc21zdG8nLCAndGVsJywgJ3Vy bicsICd3ZWJjYWwnXTsKK3ZhbGlkX3Byb3RvY29scy5mb3JFYWNoKGZ1bmN0aW9uIChwcm90b2Nv bCkgeworICAgIHZhciBzdWNjZWVkZWQgPSBmYWxzZTsKKyAgICB0cnkgeworICAgICAgICB3aW5k b3cubmF2aWdhdG9yLnJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyKHByb3RvY29sLCAidmFsaWQgcHJv dG9jb2wgJXMiLCAidGl0bGUiKTsKKyAgICAgICAgc3VjY2VlZGVkID0gdHJ1ZTsKKyAgICB9IGNh dGNoIChlKSB7CisgICAgICAgIHN1Y2NlZWRlZCA9IGZhbHNlOworICAgIH0KKworICAgIGlmIChz dWNjZWVkZWQpCisgICAgICAgIGRlYnVnKCdQYXNzOiBWYWxpZCBwcm90b2NvbCAiJyArIHByb3Rv Y29sICsgJyIgYWxsb3dlZC4nKTsKKyAgICBlbHNlCisgICAgICAgIGRlYnVnKCdGYWlsOiBWYWxp ZCBwcm90b2NvbCAiJyArIHByb3RvY29sICsgJyIgZmFpbGVkLicpOworfSk7CisKIHZhciBpbnZh bGlkX3VybHMgPSBbIiIsICIlUyJdOwogaW52YWxpZF91cmxzLmZvckVhY2goZnVuY3Rpb24gKHVy bCkgewogICAgdmFyIHN1Y2NlZWRlZCA9IGZhbHNlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vcmVnaXN0ZXItcHJvdG9jb2wtaGFuZGxlci1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9yZWdpc3Rl ci1wcm90b2NvbC1oYW5kbGVyLWV4cGVjdGVkLnR4dAppbmRleCA1NWY0MjBkMGJjY2FlNjBiOTM1 MGJkYzQxNTllYjEzZmY3NmNmNTMwLi5jMDY3MzU2NzliNTJmMzkwMTJjNWJiMTg1YzBkOWQ1Mjkw NzJiY2YwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2Rv bS9yZWdpc3Rlci1wcm90b2NvbC1oYW5kbGVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2RvbS9yZWdpc3Rlci1wcm90b2NvbC1oYW5kbGVyLWV4 cGVjdGVkLnR4dApAQCAtNCw2ICs0LDE2IEBAIFBhc3M6IHdpbmRvdy5uYXZpZ2F0b3IucmVnaXN0 ZXJQcm90b2NvbEhhbmRsZXIgaXMgZGVmaW5lZC4KIFBhc3M6IEludmFsaWQgcHJvdG9jb2wgImh0 dHAiIHRocmV3IFNFQ1VSSVRZX0VSUiBleGNlcHRpb24uCiBQYXNzOiBJbnZhbGlkIHByb3RvY29s ICJodHRwcyIgdGhyZXcgU0VDVVJJVFlfRVJSIGV4Y2VwdGlvbi4KIFBhc3M6IEludmFsaWQgcHJv dG9jb2wgImZpbGUiIHRocmV3IFNFQ1VSSVRZX0VSUiBleGNlcHRpb24uCitQYXNzOiBWYWxpZCBw cm90b2NvbCAiaXJjIiBhbGxvd2VkLgorUGFzczogVmFsaWQgcHJvdG9jb2wgIm1haWx0byIgYWxs b3dlZC4KK1Bhc3M6IFZhbGlkIHByb3RvY29sICJtbXMiIGFsbG93ZWQuCitQYXNzOiBWYWxpZCBw cm90b2NvbCAibmV3cyIgYWxsb3dlZC4KK1Bhc3M6IFZhbGlkIHByb3RvY29sICJubnRwIiBhbGxv d2VkLgorUGFzczogVmFsaWQgcHJvdG9jb2wgInNtcyIgYWxsb3dlZC4KK1Bhc3M6IFZhbGlkIHBy b3RvY29sICJzbXN0byIgYWxsb3dlZC4KK1Bhc3M6IFZhbGlkIHByb3RvY29sICJ0ZWwiIGFsbG93 ZWQuCitQYXNzOiBWYWxpZCBwcm90b2NvbCAidXJuIiBhbGxvd2VkLgorUGFzczogVmFsaWQgcHJv dG9jb2wgIndlYmNhbCIgYWxsb3dlZC4KIFBhc3M6IEludmFsaWQgdXJsICIiIHRocmV3IFNZTlRB WF9FUlIgZXhjZXB0aW9uLgogUGFzczogSW52YWxpZCB1cmwgIiVTIiB0aHJldyBTWU5UQVhfRVJS IGV4Y2VwdGlvbi4KIFBhc3M6IFZhbGlkIGNhbGwgc3VjY2VlZGVkLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRj OGU4MzEwNDRlZjNiM2Q5OGM4ZGRmZmZlMTkzYjUxNzg5MGY0NzguLmY0ZjhjNWJkZWY1YjdkZjNj ZmRiOTczZTc3MzJhZThjNmUxODM5OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx MS0wOC0yOSAgQmVuIFdlbGxzICA8YmVud2VsbHNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVw ZGF0ZSByZWdpc3RlclByb3RvY29sSGFuZGxlciBzY2hlbWUgd2hpdGVsaXN0IHRvIG1hdGNoIHNw ZWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MTA0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdl L05hdmlnYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbml0UHJvdG9jb2xIYW5kbGVyV2hp dGVsaXN0KToKKwogMjAxMS0wOC0yOSAgSm9obiBCYXVtYW4gIDxqYmF1bWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBTcGVlZCB1cCB0ZXhJbWFnZSBmcm9tIEJHUkEKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2 aWdhdG9yLmNwcAppbmRleCAwMmZmOTM3YWQ2Nzk5NTU5MDEzNzIyZjI1ZDQxNzQ4OTY0OTNlZjY4 Li5iMWU0YWIxZmZkNjY5Y2Q5OGU1Y2I3OTBlYTc0YjAzODI5OTc1OTE5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9OYXZpZ2F0b3IuY3BwCkBAIC0xOTAsMTAgKzE5MCwxNSBAQCBzdGF0aWMgdm9pZCBpbml0UHJv dG9jb2xIYW5kbGVyV2hpdGVsaXN0KCkKIHsKICAgICBwcm90b2NvbFdoaXRlbGlzdCA9IG5ldyBI YXNoU2V0PFN0cmluZz47CiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIHByb3RvY29sc1tdID0gewor ICAgICAgICAiaXJjIiwKICAgICAgICAgIm1haWx0byIsCiAgICAgICAgICJtbXMiLAorICAgICAg ICAibmV3cyIsCiAgICAgICAgICJubnRwIiwKLSAgICAgICAgInJ0c3AiLAorICAgICAgICAic21z IiwKKyAgICAgICAgInNtc3RvIiwKKyAgICAgICAgInRlbCIsCisgICAgICAgICJ1cm4iLAogICAg ICAgICAid2ViY2FsIiwKICAgICB9OwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgV1RGX0FS UkFZX0xFTkdUSChwcm90b2NvbHMpOyArK2kpCg==