67099 2011-08-28 20:55:35 -0700 [CG] ImageBufferCG should handle IOSurface allocation failure gracefully 2011-08-29 15:52:42 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mdelaney7 mdelaney7 mdelaney7 simon.fraser webkit-bug-importer oldest_to_newest 458054 0 mdelaney7 2011-08-28 20:55:35 -0700 In ImageBufferCG ctor, if IOSurface creation fails we just bail out, but instead should just attempt the create a backing store via the (old) non-accel path. 458055 1 mdelaney7 2011-08-28 20:55:49 -0700 <rdar://problem/9948461> 458066 2 105459 mdelaney7 2011-08-28 22:08:13 -0700 Created attachment 105459 patch1 458072 3 105459 simon.fraser 2011-08-28 22:33:41 -0700 Comment on attachment 105459 patch1 View in context: https://bugs.webkit.org/attachment.cgi?id=105459&action=review > Source/WebCore/ChangeLog:9 > + No new tests - doesn't change behavior. > + Sure it does, just not in a way that's easily testable. 458511 4 mdelaney7 2011-08-29 15:52:42 -0700 Committed r94024: <http://trac.webkit.org/changeset/94024> 105459 2011-08-28 22:08:13 -0700 2011-08-28 22:33:41 -0700 patch1 6709.patch text/plain 2563 mdelaney7 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTZlZDhkLi4zYTllYzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDgtMjggIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKwor ICAgICAgICBbQ0ddIEltYWdlQnVmZmVyQ0cgc2hvdWxkIGhhbmRsZSBJT1N1cmZhY2UgYWxsb2Nh dGlvbiBmYWlsdXJlIGdyYWNlZnVsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY3MDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gZG9lc24ndCBjaGFuZ2UgYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcDogUmVhcnJh bmdlZCBiYWNraW5nIHN0b3JlIGNyZWF0aW9uIHRvIGZhbGwgYmFjayB0bworICAgICAgICAgIG9s ZCBwYXRoIGlmIElPU3VyZmFjZSBjcmVhdGlvbiBwYXRoIGZhaWxzLgorICAgICAgICAoV2ViQ29y ZTo6SW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKToKKwogMjAxMS0wOC0yNiAgQ2hyaXMgUm9nZXJz ICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIEFkZCBNZWRpYVBsYXllcjo6YXVkaW9T b3VyY2VQcm92aWRlcigpIG1ldGhvZCBmb3IgYXVkaW8gc3RyZWFtIGFjY2VzcyBieSB0aGUgV2Vi IEF1ZGlvIEFQSS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NnL0ltYWdlQnVmZmVyQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvSW1hZ2VCdWZmZXJDRy5jcHAKaW5kZXggNDg5M2IwNC4uNmE1OTAzOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAK QEAgLTEzNyw2ICsxMzcsMTUgQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IEludFNp emUmIHNpemUsIENvbG9yU3BhY2UgaW1hZ2VDb2xvclNwYWNlLCBSZW5kZXIKICAgICB9CiAKICAg ICBSZXRhaW5QdHI8Q0dDb250ZXh0UmVmPiBjZ0NvbnRleHQ7CisgICAgaWYgKG1fYWNjZWxlcmF0 ZVJlbmRlcmluZykgeworI2lmIFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUpCisg ICAgICAgIG1fZGF0YS5tX3N1cmZhY2UgPSBjcmVhdGVJT1N1cmZhY2Uoc2l6ZSk7CisgICAgICAg IGNnQ29udGV4dC5hZG9wdENGKHdrSU9TdXJmYWNlQ29udGV4dENyZWF0ZShtX2RhdGEubV9zdXJm YWNlLmdldCgpLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCksIG1fZGF0YS5tX2NvbG9yU3Bh Y2UpKTsKKyNlbmRpZgorICAgICAgICBpZiAoIWNnQ29udGV4dCkKKyAgICAgICAgICAgIG1fYWNj ZWxlcmF0ZVJlbmRlcmluZyA9IGZhbHNlOyAvLyBJZiBhbGxvY2F0aW9uIGZhaWxzLCBmYWxsIGJh Y2sgdG8gbm9uLWFjY2VsZXJhdGVkIHBhdGguCisgICAgfQorCiAgICAgaWYgKCFtX2FjY2VsZXJh dGVSZW5kZXJpbmcpIHsKICAgICAgICAgaWYgKCF0cnlGYXN0Q2FsbG9jKHNpemUuaGVpZ2h0KCks IGJ5dGVzUGVyUm93KS5nZXRWYWx1ZShtX2RhdGEubV9kYXRhKSkKICAgICAgICAgICAgIHJldHVy bjsKQEAgLTE0NiwxMyArMTU1LDYgQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IElu dFNpemUmIHNpemUsIENvbG9yU3BhY2UgaW1hZ2VDb2xvclNwYWNlLCBSZW5kZXIKICAgICAgICAg Y2dDb250ZXh0LmFkb3B0Q0YoQ0dCaXRtYXBDb250ZXh0Q3JlYXRlKG1fZGF0YS5tX2RhdGEsIHNp emUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSwgOCwgYnl0ZXNQZXJSb3csIG1fZGF0YS5tX2NvbG9y U3BhY2UsIG1fZGF0YS5tX2JpdG1hcEluZm8pKTsKICAgICAgICAgLy8gQ3JlYXRlIGEgbGl2ZSBp bWFnZSB0aGF0IHdyYXBzIHRoZSBkYXRhLgogICAgICAgICBtX2RhdGEubV9kYXRhUHJvdmlkZXIu YWRvcHRDRihDR0RhdGFQcm92aWRlckNyZWF0ZVdpdGhEYXRhKDAsIG1fZGF0YS5tX2RhdGEsIGRh dGFTaXplLCByZWxlYXNlSW1hZ2VEYXRhKSk7Ci0gICAgfSBlbHNlIHsKLSNpZiBVU0UoSU9TVVJG QUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFKQotICAgICAgICBtX2RhdGEubV9zdXJmYWNlID0gY3Jl YXRlSU9TdXJmYWNlKHNpemUpOwotICAgICAgICBjZ0NvbnRleHQuYWRvcHRDRih3a0lPU3VyZmFj ZUNvbnRleHRDcmVhdGUobV9kYXRhLm1fc3VyZmFjZS5nZXQoKSwgc2l6ZS53aWR0aCgpLCBzaXpl LmhlaWdodCgpLCBtX2RhdGEubV9jb2xvclNwYWNlKSk7Ci0jZWxzZQotICAgICAgICBtX2FjY2Vs ZXJhdGVSZW5kZXJpbmcgPSBmYWxzZTsgLy8gRm9yY2UgdG8gZmFsc2Ugb24gb2xkZXIgcGxhdGZv cm1zCi0jZW5kaWYKICAgICB9CiAKICAgICBpZiAoIWNnQ29udGV4dCkKLS0gCjEuNy41LjQKCg==