67090 2011-08-27 07:15:55 -0700 SQLiteStatement::getColumnText() could construct WTF::String result more efficiently. 2011-08-27 14:12:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling benjamin webkit.review.bot oldest_to_newest 457943 0 kling 2011-08-27 07:15:55 -0700 Instead of using the WTF::String(const UChar*) constructor and traversing the string to determine the length, we should use sqlite3_column_bytes16() . 457944 1 105437 kling 2011-08-27 07:18:31 -0700 Created attachment 105437 Proposed patch 457947 2 benjamin 2011-08-27 09:37:50 -0700 How much improvement? 457948 3 kling 2011-08-27 09:44:19 -0700 (In reply to comment #2) > How much improvement? Over 9000. 457950 4 kling 2011-08-27 10:11:23 -0700 (In reply to comment #3) > (In reply to comment #2) > > How much improvement? > > Over 9000. To clarify, I just spoke with Benjamin about this, he's concerned that the additional mutex lock (happens implicitly with any sqlite3 call) would negate any gains from avoiding the string traversal. 457985 5 105437 webkit.review.bot 2011-08-27 14:12:37 -0700 Comment on attachment 105437 Proposed patch Clearing flags on attachment: 105437 Committed r93945: <http://trac.webkit.org/changeset/93945> 457986 6 webkit.review.bot 2011-08-27 14:12:41 -0700 All reviewed patches have been landed. Closing bug. 105437 2011-08-27 07:18:31 -0700 2011-08-27 14:12:37 -0700 Proposed patch bug-67090.diff text/plain 1451 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Y2Q0ZDEzLi43ODc2OTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDgtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNRTGl0ZVN0YXRlbWVudDo6Z2V0Q29sdW1uVGV4dCgpIGNvdWxkIGNvbnN0cnVjdCBXVEY6 OlN0cmluZyByZXN1bHQgbW9yZSBlZmZpY2llbnRseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZVN0YXRlbWVudDo6Z2V0Q29sdW1uVGV4dCk6IFVz ZSBzcWxpdGUzX2NvbHVtbl9ieXRlczE2KCkKKyAgICAgICAgdG8gZ2V0IHRoZSBsZW5ndGggb2Yg dGhlIGNvbHVtbiB0ZXh0IHdpdGhvdXQgbG9va2luZyBmb3IgdGhlIG51bGwgdGVybWluYXRvci4K KwogMjAxMS0wOC0yNiAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmVncmVzc2lvbig5MTc4OCk6IEJhZCBjYXN0IGluIFdlYkNvcmU6OmJsb2NrV2l0aE5leHRMaW5l Qm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3Bw CmluZGV4IDEzODA0ZmQuLjVjOTUzMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwCkBAIC0zNDUsNyArMzQ1LDcgQEAgU3RyaW5nIFNRTGl0 ZVN0YXRlbWVudDo6Z2V0Q29sdW1uVGV4dChpbnQgY29sKQogICAgICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwogICAgIGlmIChjb2x1bW5Db3VudCgpIDw9IGNvbCkKICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwotICAgIHJldHVybiBTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+ KHNxbGl0ZTNfY29sdW1uX3RleHQxNihtX3N0YXRlbWVudCwgY29sKSkpOworICAgIHJldHVybiBT dHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KHNxbGl0ZTNfY29sdW1uX3RleHQx NihtX3N0YXRlbWVudCwgY29sKSksIHNxbGl0ZTNfY29sdW1uX2J5dGVzMTYobV9zdGF0ZW1lbnQs IGNvbCkgLyBzaXplb2YoVUNoYXIpKTsKIH0KICAgICAKIGRvdWJsZSBTUUxpdGVTdGF0ZW1lbnQ6 OmdldENvbHVtbkRvdWJsZShpbnQgY29sKQo=