67078 2011-08-26 19:08:40 -0700 new-run-webkit-tests chromium port fails a windows test in test-webkitpy 2011-08-29 14:38:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 shawnsingh webkit-unassigned dpranke eric levin tony webkit.review.bot oldest_to_newest 457896 0 shawnsingh 2011-08-26 19:08:40 -0700 Missed one small fix that caused test-webkitpy to fail when testing chromium port of NRWT on windows. 457899 1 105431 shawnsingh 2011-08-26 19:16:20 -0700 Created attachment 105431 Patch 458342 2 105431 eric 2011-08-29 12:04:26 -0700 Comment on attachment 105431 Patch How do we test this? 458344 3 tony 2011-08-29 12:06:21 -0700 Which test is failing? Why doesn't it show up on the the build.webkit.org bots? 458346 4 105431 dpranke 2011-08-29 12:10:02 -0700 Comment on attachment 105431 Patch Whoops. The change seems fine to me, but it would be good to answer Tony and Eric's questions, and it would be good to have a test if it wouldn't be too much of a hassle (I haven't thought about what it would take to test this but we can discuss it if you like). Clearing R+/CQ+ for now. 458368 5 shawnsingh 2011-08-29 12:29:23 -0700 Right, I should have explained. In my opinion there already is an appropriate test for this patch. It is the unit test code for NWRT itself, which can be run by Tools/Scripts/test-webkitpy. The specific test that was failing is test_diff_image() in Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py. This patch fixes a previous fix that I submitted for https://bugs.webkit.org/show_bug.cgi?id=47240 that patch did fail (as it should have) the test-webkitpy script, so I feel the existing tests are appropriate. 458380 6 105431 dpranke 2011-08-29 12:46:43 -0700 Comment on attachment 105431 Patch ok. 458404 7 105431 webkit.review.bot 2011-08-29 13:17:03 -0700 Comment on attachment 105431 Patch Clearing flags on attachment: 105431 Committed r94008: <http://trac.webkit.org/changeset/94008> 458405 8 webkit.review.bot 2011-08-29 13:17:08 -0700 All reviewed patches have been landed. Closing bug. 458450 9 levin 2011-08-29 14:21:19 -0700 Note it is good to mention something about the testing in the ChangeLog. For example, this fixes test_diff_image() from Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py. Then it would answer people's questions in the bug and when they see the check in. 458463 10 shawnsingh 2011-08-29 14:38:43 -0700 OK, I will do that from now on. Thanks! 105431 2011-08-26 19:16:20 -0700 2011-08-29 13:17:03 -0700 Patch bug-67078-20110826191619.patch text/plain 1287 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogOTM4NjEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OGUxZWJmZmUzMmM4YWJhMWE4M2QyOWVlNzliNjFhZThl NDEyNjBjLi5hZWRhN2JlNWNiNjQ0ODIyYjYwZjc5MTQ2NjNiOTE3ZWNlOTRjYTc2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDgtMjYgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgU21hbGwgZml4IGluIGNocm9taXVtIHBvcnQgb2YgbmV3LXJ1bi13ZWJraXQtdGVz dHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzA3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKwogMjAxMS0wOC0y NiAgTm9lbCBHb3Jkb24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CiAKICAgICAgICAgTWFrZSBz aG93LXByZXR0eS1kaWZmIHdvcmsgb24gbGludXgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IDA3MDM1NGQ0MzhhYjAy YmQ4ZjY4MzQ2ZmE4MTJiZGJiZmVlNDdmYzAuLmNkMDYwMDMwYzliMTc2YzI4YWQ3ZDE1ODQyZTMy NGFiODMwNTNiOWYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtMjEwLDcgKzIxMCw3IEBAIGNsYXNzIENocm9taXVt UG9ydChQb3J0KToKICAgICAgICAgICAgICAgICByYWlzZQogICAgICAgICBmaW5hbGx5OgogICAg ICAgICAgICAgaWYgZXhpdF9jb2RlID09IDE6Ci0gICAgICAgICAgICAgICAgcmVzdWx0ID0gc2Vs Zi5fZmlsZXN5c3RlbS5yZWFkX2JpbmFyeV9maWxlKGRpZmZfZmlsZW5hbWUpCisgICAgICAgICAg ICAgICAgcmVzdWx0ID0gc2VsZi5fZmlsZXN5c3RlbS5yZWFkX2JpbmFyeV9maWxlKG5hdGl2ZV9k aWZmX2ZpbGVuYW1lKQogICAgICAgICAgICAgc2VsZi5fZmlsZXN5c3RlbS5ybXRyZWUoc3RyKHRl bXBkaXIpKQogICAgICAgICByZXR1cm4gcmVzdWx0CiAK