67074 2011-08-26 17:45:55 -0700 REGRESSION (r93913): Failures in fast/replaced/frame-removed-during-resize.html and scrollbars/scrollable-iframe-remove-crash.html 2011-08-30 10:35:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Windows 2000 RESOLVED FIXED P2 Normal --- 1 levin dimich ap levin mrobinson ossy voliver webkit.review.bot oldest_to_newest 457876 0 levin 2011-08-26 17:45:55 -0700 So far I see this on Chromium Linux but it is in generic code so it seems like other platforms may be affected (so I'm cc'ing ap). I'm doing a OS X WebKit build right now to check it out. dimich said that he would look into fixing this. ASSERTION FAILED: !m_queuedEvents.isEmpty() third_party/WebKit/Source/WebCore/dom/EventQueue.cpp(121) : void WebCore::EventQueue::pendingEventTimerFired() [25891:25891:4881599612:ERROR:process_util_posix.cc(134)] Received signal 11 base::debug::StackTrace::StackTrace() [0x8c8f8e] base::(anonymous namespace)::StackDumpSignalHandler() [0x885b2d] 0x7f18575d4af0 WebCore::EventQueue::pendingEventTimerFired() [0xe2970a] WebCore::EventQueueTimer::fired() [0xe29af8] WebCore::ThreadTimers::sharedTimerFiredInternal() [0xfd2fb4] WebCore::ThreadTimers::sharedTimerFired() [0xfd2eeb] webkit_glue::WebKitClientImpl::DoTimeout() [0x19c70c8] 458232 1 mrobinson 2011-08-29 08:40:53 -0700 This also occurs on WebKitGTK+. 458616 2 105555 dimich 2011-08-29 18:10:11 -0700 Created attachment 105555 Patch 458618 3 webkit.review.bot 2011-08-29 18:11:52 -0700 Attachment 105555 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 150. If any of these errors are false positives, please file a bug against check-webkit-style. 458622 4 105555 darin 2011-08-29 18:25:12 -0700 Comment on attachment 105555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105555&action=review > Source/WebCore/dom/EventQueue.cpp:118 > +// The accumulated and future events should be discarded. > +// This method is called when Document is prepared for destruction. > void EventQueue::cancelQueuedEvents() This changes the semantics of this function. It’s OK because the one caller wants a behavior different from what the function name implies, but would not OK if there was more than one caller. The function’s name should change along with its change in semantics. It now has a meaning something more like “close” or “shut down” or “stop”. 458637 5 105561 dimich 2011-08-29 18:45:07 -0700 Created attachment 105561 Updated patch Thanks! Renamed the method. Here is more info on what exactly caused the crashes: The EventQueue contains a loop that processes all the accumulated events. Now with the r93913 landed, the Frame may be destroyed upon exiting from event dispatch. This may immediately queue more events (Frame::setSelection() in this case, clearing the frame's selection state) - and the new events would be processed on the next loop iteration, while the timer which is started when new event is enqued would be not reset. Next time the timer fires we get an empty queue (because the event was actually processed before) and ASSERT fires. Instead of removing ASSERT and say it's ok when events enque other events (this apparently started to happen after r93913), I think we can stop accepting new events after EventQueue was explicitly 'stopped', which is a good thing to do anyways. That covers the cases of failing tests and still keeps ASSERT in place so we can find out what other events can cause new events to be added. 458878 6 levin 2011-08-30 06:54:15 -0700 *** Bug 67197 has been marked as a duplicate of this bug. *** 459000 7 dimich 2011-08-30 10:35:43 -0700 Landed: http://trac.webkit.org/changeset/94088 105555 2011-08-29 18:10:11 -0700 2011-08-29 18:45:07 -0700 Patch patch.txt text/plain 2567 dimich ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzhlODMxLi5iZmIwYzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDgtMjkgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjkzOTEzKTogRmFpbHVyZXMgaW4gZmFzdC9yZXBsYWNlZC9mcmFt ZS1yZW1vdmVkLWR1cmluZy1yZXNpemUuaHRtbCBhbmQgc2Nyb2xsYmFycy9zY3JvbGxhYmxlLWlm cmFtZS1yZW1vdmUtY3Jhc2guaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjcwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBmbGFnIG1faWdub3JlRnV0dXJlRXZlbnRzIHRvIHByZXZlbnQg ZXZlbnRzIHRoYXQgY2F1c2UgRnJhbWUgdG8gYmUgZGVzdHJveWVkCisgICAgICAgIGZyb20gcG9z dGluZyBtb3JlIGV2ZW50cyBpbnRvIEV2ZW50UXVldWUgb2YgYSBkeWluZyBEb2N1bWVudC4KKwor ICAgICAgICBUaGUgdGVzdHMgbWVudGlvbmVkIGFib3ZlIHNob3VsZCBub3cgcGFzcy4KKworICAg ICAgICAqIGRvbS9FdmVudFF1ZXVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50UXVldWU6 OkV2ZW50UXVldWUpOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50UXVldWU6OmNhbmNlbFF1ZXVlZEV2ZW50cyk6Cisg ICAgICAgICogZG9tL0V2ZW50UXVldWUuaDoKKwogMjAxMS0wOC0yOSAgSm9obiBCYXVtYW4gIDxq YmF1bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBTcGVlZCB1cCB0ZXhJbWFnZSBmcm9tIEJH UkEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcAppbmRleCAzZmZhZmY1Li4xODFiYjNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0V2ZW50UXVldWUuY3BwCkBAIC02Miw2ICs2Miw3IEBAIFBhc3NSZWZQdHI8RXZl bnRRdWV1ZT4gRXZlbnRRdWV1ZTo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRl eHQpCiAKIEV2ZW50UXVldWU6OkV2ZW50UXVldWUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29u dGV4dCkKICAgICA6IG1fcGVuZGluZ0V2ZW50VGltZXIoYWRvcHRQdHIobmV3IEV2ZW50UXVldWVU aW1lcih0aGlzLCBjb250ZXh0KSkpCisgICAgLCBtX2lnbm9yZUZ1dHVyZUV2ZW50cyhmYWxzZSkK IHsKIH0KIApAQCAtNzEsNiArNzIsOSBAQCBFdmVudFF1ZXVlOjp+RXZlbnRRdWV1ZSgpCiAKIHZv aWQgRXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KQogewor ICAgIGlmIChtX2lnbm9yZUZ1dHVyZUV2ZW50cykKKyAgICAgICAgcmV0dXJuOworCiAgICAgQVNT RVJUKGV2ZW50LT50YXJnZXQoKSk7CiAgICAgYm9vbCB3YXNBZGRlZCA9IG1fcXVldWVkRXZlbnRz LmFkZChldmVudCkuc2Vjb25kOwogICAgIEFTU0VSVF9VTlVTRUQod2FzQWRkZWQsIHdhc0FkZGVk KTsgLy8gSXQgc2hvdWxkIG5vdCBoYXZlIGFscmVhZHkgYmVlbiBpbiB0aGUgbGlzdC4KQEAgLTEw OSw4ICsxMTMsMTEgQEAgYm9vbCBFdmVudFF1ZXVlOjpjYW5jZWxFdmVudChFdmVudCogZXZlbnQp CiAgICAgcmV0dXJuIGZvdW5kOwogfQogCisvLyBUaGUgYWNjdW11bGF0ZWQgYW5kIGZ1dHVyZSBl dmVudHMgc2hvdWxkIGJlIGRpc2NhcmRlZC4gCisvLyBUaGlzIG1ldGhvZCBpcyBjYWxsZWQgd2hl biBEb2N1bWVudCBpcyBwcmVwYXJlZCBmb3IgZGVzdHJ1Y3Rpb24uCiB2b2lkIEV2ZW50UXVldWU6 OmNhbmNlbFF1ZXVlZEV2ZW50cygpCiB7CisgICAgbV9pZ25vcmVGdXR1cmVFdmVudHMgPSB0cnVl OwogICAgIG1fcGVuZGluZ0V2ZW50VGltZXItPnN0b3AoKTsKICAgICBtX3F1ZXVlZEV2ZW50cy5j bGVhcigpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmgKaW5kZXggMmNiMzhmNC4uZmYzMWY1OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5oCkBAIC02NCw3ICs2NCw4IEBAIHByaXZhdGU6CiAgICAg T3duUHRyPEV2ZW50UXVldWVUaW1lcj4gbV9wZW5kaW5nRXZlbnRUaW1lcjsKICAgICBMaXN0SGFz aFNldDxSZWZQdHI8RXZlbnQ+ID4gbV9xdWV1ZWRFdmVudHM7CiAgICAgSGFzaFNldDxOb2RlKj4g bV9ub2Rlc1dpdGhRdWV1ZWRTY3JvbGxFdmVudHM7Ci0gICAgCisgICAgYm9vbCBtX2lnbm9yZUZ1 dHVyZUV2ZW50czsKKwogICAgIGZyaWVuZCBjbGFzcyBFdmVudFF1ZXVlVGltZXI7ICAgIAogfTsK IAo= 105561 2011-08-29 18:45:07 -0700 2011-08-29 18:48:43 -0700 Updated patch patch.txt text/plain 3363 dimich ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzhlODMxLi5jYjVlYTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMDgtMjkgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjkzOTEzKTogRmFpbHVyZXMgaW4gZmFzdC9yZXBsYWNlZC9mcmFt ZS1yZW1vdmVkLWR1cmluZy1yZXNpemUuaHRtbCBhbmQgc2Nyb2xsYmFycy9zY3JvbGxhYmxlLWlm cmFtZS1yZW1vdmUtY3Jhc2guaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjcwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBmbGFnIG1faXNDbG9zZWQgdG8gcHJldmVudCBldmVudHMgdGhh dCBjYXVzZSBGcmFtZSB0byBiZSBkZXN0cm95ZWQKKyAgICAgICAgZnJvbSBwb3N0aW5nIG1vcmUg ZXZlbnRzIGludG8gRXZlbnRRdWV1ZSBvZiBhIGR5aW5nIERvY3VtZW50LgorCisgICAgICAgIFRo ZSB0ZXN0cyBtZW50aW9uZWQgYWJvdmUgc2hvdWxkIG5vdyBwYXNzLgorCisgICAgICAgICogZG9t L0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpkZXRhY2gpOgorICAg ICAgICAqIGRvbS9FdmVudFF1ZXVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50UXVldWU6 OkV2ZW50UXVldWUpOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50UXVldWU6OmNsb3NlKTogUmVuYW1lZCBtZXRob2Qg dG8gcmVmbGVjdCBiZXR0ZXIgd2hhdCBpdCBkb2VzLgorICAgICAgICAqIGRvbS9FdmVudFF1ZXVl Lmg6CisKIDIwMTEtMDgtMjkgIEpvaG4gQmF1bWFuICA8amJhdW1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgU3BlZWQgdXAgdGV4SW1hZ2UgZnJvbSBCR1JBCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAppbmRleCAxNTBjMGZjLi5lMzI5ODUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTE3 NzYsNyArMTc3Niw3IEBAIHZvaWQgRG9jdW1lbnQ6OmRldGFjaCgpCiAKICAgICBjbGVhckFYT2Jq ZWN0Q2FjaGUoKTsKICAgICBzdG9wQWN0aXZlRE9NT2JqZWN0cygpOwotICAgIG1fZXZlbnRRdWV1 ZS0+Y2FuY2VsUXVldWVkRXZlbnRzKCk7CisgICAgbV9ldmVudFF1ZXVlLT5jbG9zZSgpOwogCiAj aWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQogICAgIC8vIEZJWE1FOiBjb25zaWRl ciB1c2luZyBBY3RpdmVET01PYmplY3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RXZlbnRRdWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5jcHAKaW5kZXgg M2ZmYWZmNS4uYjBlZTI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVl dWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcApAQCAtNjIsNiAr NjIsNyBAQCBQYXNzUmVmUHRyPEV2ZW50UXVldWU+IEV2ZW50UXVldWU6OmNyZWF0ZShTY3JpcHRF eGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogCiBFdmVudFF1ZXVlOjpFdmVudFF1ZXVlKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCiAgICAgOiBtX3BlbmRpbmdFdmVudFRpbWVyKGFk b3B0UHRyKG5ldyBFdmVudFF1ZXVlVGltZXIodGhpcywgY29udGV4dCkpKQorICAgICwgbV9pc0Ns b3NlZChmYWxzZSkKIHsKIH0KIApAQCAtNzEsNiArNzIsOSBAQCBFdmVudFF1ZXVlOjp+RXZlbnRR dWV1ZSgpCiAKIHZvaWQgRXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+ IGV2ZW50KQogeworICAgIGlmIChtX2lzQ2xvc2VkKQorICAgICAgICByZXR1cm47CisKICAgICBB U1NFUlQoZXZlbnQtPnRhcmdldCgpKTsKICAgICBib29sIHdhc0FkZGVkID0gbV9xdWV1ZWRFdmVu dHMuYWRkKGV2ZW50KS5zZWNvbmQ7CiAgICAgQVNTRVJUX1VOVVNFRCh3YXNBZGRlZCwgd2FzQWRk ZWQpOyAvLyBJdCBzaG91bGQgbm90IGhhdmUgYWxyZWFkeSBiZWVuIGluIHRoZSBsaXN0LgpAQCAt MTA5LDggKzExMyw5IEBAIGJvb2wgRXZlbnRRdWV1ZTo6Y2FuY2VsRXZlbnQoRXZlbnQqIGV2ZW50 KQogICAgIHJldHVybiBmb3VuZDsKIH0KIAotdm9pZCBFdmVudFF1ZXVlOjpjYW5jZWxRdWV1ZWRF dmVudHMoKQordm9pZCBFdmVudFF1ZXVlOjpjbG9zZSgpCiB7CisgICAgbV9pc0Nsb3NlZCA9IHRy dWU7CiAgICAgbV9wZW5kaW5nRXZlbnRUaW1lci0+c3RvcCgpOwogICAgIG1fcXVldWVkRXZlbnRz LmNsZWFyKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5o IGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuaAppbmRleCAyY2IzOGY0Li5jOTk3OTcy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmgKQEAgLTUzLDcgKzUzLDkgQEAgcHVibGljOgogICAg IHZvaWQgZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KTsKICAgICB2b2lkIGVucXVldWVP ckRpc3BhdGNoU2Nyb2xsRXZlbnQoUGFzc1JlZlB0cjxOb2RlPiwgU2Nyb2xsRXZlbnRUYXJnZXRU eXBlKTsKICAgICBib29sIGNhbmNlbEV2ZW50KEV2ZW50Kik7Ci0gICAgdm9pZCBjYW5jZWxRdWV1 ZWRFdmVudHMoKTsKKworICAgIC8vIFRoZSBhY2N1bXVsYXRlZCBhbmQgYWxsIHRoZSBmdXR1cmUg ZXZlbnRzIHdpbGwgYmUgZGlzY2FyZGVkLCBubyBldmVudHMgd2lsbCBiZSBkaXNwYXRjaGVkIGFu eW1vcmUuIAorICAgIHZvaWQgY2xvc2UoKTsKIAogcHJpdmF0ZToKICAgICBleHBsaWNpdCBFdmVu dFF1ZXVlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqKTsKQEAgLTY0LDcgKzY2LDggQEAgcHJpdmF0 ZToKICAgICBPd25QdHI8RXZlbnRRdWV1ZVRpbWVyPiBtX3BlbmRpbmdFdmVudFRpbWVyOwogICAg IExpc3RIYXNoU2V0PFJlZlB0cjxFdmVudD4gPiBtX3F1ZXVlZEV2ZW50czsKICAgICBIYXNoU2V0 PE5vZGUqPiBtX25vZGVzV2l0aFF1ZXVlZFNjcm9sbEV2ZW50czsKLSAgICAKKyAgICBib29sIG1f aXNDbG9zZWQ7CisKICAgICBmcmllbmQgY2xhc3MgRXZlbnRRdWV1ZVRpbWVyOyAgICAKIH07CiAK