67063 2011-08-26 13:53:11 -0700 Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2 2011-08-26 16:44:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam darin oldest_to_newest 457760 0 sam 2011-08-26 13:53:11 -0700 Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2 457761 1 105403 sam 2011-08-26 13:53:38 -0700 Created attachment 105403 Patch 457762 2 105403 darin 2011-08-26 13:54:40 -0700 Comment on attachment 105403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105403&action=review > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:88 > + return [[[NSError alloc] initWithDomain:domain code:code userInfo:dict] autorelease]; Why the change from self to NSError? 457766 3 105403 andersca 2011-08-26 14:02:56 -0700 Comment on attachment 105403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105403&action=review >> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:88 >> + return [[[NSError alloc] initWithDomain:domain code:code userInfo:dict] autorelease]; > > Why the change from self to NSError? I'd like to know this too! (Not that it matters since nobody subclasses NSError in the web process). 457851 4 sam 2011-08-26 16:38:39 -0700 (In reply to comment #2) > (From update of attachment 105403 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105403&action=review > > > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:88 > > + return [[[NSError alloc] initWithDomain:domain code:code userInfo:dict] autorelease]; > > Why the change from self to NSError? No good reason. Will change it back. 457852 5 sam 2011-08-26 16:44:06 -0700 Committed r93925: <http://trac.webkit.org/changeset/93925> 105403 2011-08-26 13:53:38 -0700 2011-08-26 14:02:55 -0700 Patch bug-67063-20110826135337.patch text/plain 1879 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzOTEwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjYgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBGb2xkIF93ZWJraXRfaW5pdFdpdGhEb21h aW4gaW50byBfd2Via2l0X2Vycm9yV2l0aERvbWFpbiBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzA2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9tYWMvV2ViRXJyb3JzTWFjLm1tOgorICAgICAgICAoK1tOU0Vycm9yIF93ZWJraXRfZXJy b3JXaXRoRG9tYWluOmNvZGU6VVJMOl0pOgorCiAyMDExLTA4LTI2ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHR5cG8gaW4gQ29ubmVjdGlvbi5jcHAKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkVycm9yc01h Yy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L21hYy9XZWJFcnJvcnNNYWMubW0JKHJldmlzaW9uIDkzODI5KQorKysgU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRXJyb3JzTWFjLm1tCSh3b3JraW5n IGNvcHkpCkBAIC03MSw3ICs3MSw3IEBAICsgKHZvaWQpX3JlZ2lzdGVyV2ViS2l0RXJyb3JzCiAg ICAgcHRocmVhZF9vbmNlKCZyZWdpc3RlckVycm9yc0NvbnRyb2wsIHJlZ2lzdGVyRXJyb3JzKTsK IH0KIAotLShpZClfd2Via2l0X2luaXRXaXRoRG9tYWluOihOU1N0cmluZyAqKWRvbWFpbiBjb2Rl OihpbnQpY29kZSBVUkw6KE5TVVJMICopVVJMCisrKGlkKV93ZWJraXRfZXJyb3JXaXRoRG9tYWlu OihOU1N0cmluZyAqKWRvbWFpbiBjb2RlOihpbnQpY29kZSBVUkw6KE5TVVJMICopVVJMCiB7CiAg ICAgTlNEaWN0aW9uYXJ5ICpkZXNjcmlwdGlvbnNEaWN0OwogICAgIE5TU3RyaW5nICpsb2NhbGl6 ZWREZXNjOwpAQCAtODQsMTIgKzg0LDggQEAgLShpZClfd2Via2l0X2luaXRXaXRoRG9tYWluOihO U1N0cmluZyAqKQogICAgICAgICBbVVJMIGFic29sdXRlU3RyaW5nXSwgQCJOU0Vycm9yRmFpbGlu Z1VSTFN0cmluZ0tleSIsCiAgICAgICAgIGxvY2FsaXplZERlc2MsIE5TTG9jYWxpemVkRGVzY3Jp cHRpb25LZXksCiAgICAgICAgIG5pbF07Ci0gICAgcmV0dXJuIFtzZWxmIGluaXRXaXRoRG9tYWlu OmRvbWFpbiBjb2RlOmNvZGUgdXNlckluZm86ZGljdF07Ci19CiAKLSsoaWQpX3dlYmtpdF9lcnJv cldpdGhEb21haW46KE5TU3RyaW5nICopZG9tYWluIGNvZGU6KGludCljb2RlIFVSTDooTlNVUkwg KilVUkwKLXsKLSAgICByZXR1cm4gW1tbc2VsZiBhbGxvY10gX3dlYmtpdF9pbml0V2l0aERvbWFp bjpkb21haW4gY29kZTpjb2RlIFVSTDpVUkxdIGF1dG9yZWxlYXNlXTsKKyAgICByZXR1cm4gW1tb TlNFcnJvciBhbGxvY10gaW5pdFdpdGhEb21haW46ZG9tYWluIGNvZGU6Y29kZSB1c2VySW5mbzpk aWN0XSBhdXRvcmVsZWFzZV07CiB9CiAKICsgKE5TRXJyb3IgKilfd2ViS2l0RXJyb3JXaXRoRG9t YWluOihOU1N0cmluZyAqKWRvbWFpbiBjb2RlOihpbnQpY29kZSBVUkw6KE5TVVJMICopVVJMCg==