67055 2011-08-26 13:03:56 -0700 [Qt] Do not unconditionally use pkg-config in .pro files 2011-08-30 10:52:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ademar ademar webkit.review.bot oldest_to_newest 457717 0 ademar 2011-08-26 13:03:56 -0700 [Qt] Do not unconditionally use pkg-config in .pro files 458416 1 105516 ademar 2011-08-29 13:27:22 -0700 Created attachment 105516 Patch 458495 2 105516 menard 2011-08-29 15:39:36 -0700 Comment on attachment 105516 Patch LGTM. 458583 3 105516 kling 2011-08-29 17:13:49 -0700 Comment on attachment 105516 Patch r=me 458620 4 105516 webkit.review.bot 2011-08-29 18:18:47 -0700 Comment on attachment 105516 Patch Rejecting attachment 105516 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: NS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 150. Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 150. Full output: http://queues.webkit.org/results/9564305 458880 5 105516 webkit.review.bot 2011-08-30 06:56:44 -0700 Comment on attachment 105516 Patch Clearing flags on attachment: 105516 Committed r94075: <http://trac.webkit.org/changeset/94075> 458881 6 webkit.review.bot 2011-08-30 06:56:49 -0700 All reviewed patches have been landed. Closing bug. 459015 7 ademar 2011-08-30 10:52:29 -0700 Revision r94075 cherry-picked into qtwebkit-2.2 with commit fb3b470 <http://gitorious.org/webkit/qtwebkit/commit/fb3b470> 105516 2011-08-29 13:27:22 -0700 2011-08-30 06:56:44 -0700 Patch bug-67055-20110829172720.patch text/plain 3912 ademar U3VidmVyc2lvbiBSZXZpc2lvbjogOTM5NzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA0 YTg0NDA3YTQwOTgyNDc4NTVjZTljMWU1MmFiYWIwMjdjMjg2MzQuLmI3M2FmZDNiMmZkYWUwYmI5 MGVlYjYwYjYyYWVlZGQzZWVhZDQzN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI2IEBACisyMDExLTA4LTI2ICBBZGVtYXIgZGUgU291emEgUmVpcyBKci4gIDxhZGVtYXIu cmVpc0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gRG8gbm90IHVuY29uZGl0aW9uYWxs eSB1c2UgcGtnLWNvbmZpZyBpbiAucHJvIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzA1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNoIGZyb20gUm9oYW4gTWNHb3Zlcm4g PHJvaGFuLm1jZ292ZXJuQG5va2lhLmNvbT4KKworICAgICAgICBVc2luZyB0aGUgZmlyc3QgcGtn LWNvbmZpZyBpbiBQQVRIIGlzIHByb25lIHRvIGVycm9ycyB3aGVuIGNyb3NzCisgICAgICAgIGNv bXBpbGluZyBpbnNpZGUgdGhlIFF0IHJlcG9zaXRvcnkgKHVzaW5nIFF0J3MgYnVpbGQtc3lzdGVt KS4KKworICAgICAgICBUaGlzIHBhdGNoIHByb3RlY3QgY2FsbHMgZm9yIHBrZy1jb25maWcgd2l0 aAorICAgICAgICAhY29udGFpbnMoUVRfQ09ORklHLCBuby1wa2ctY29uZmlnKS4gbm8tcGtnLWNv bmZpZyBpcyBhZGRlZCB0bworICAgICAgICBRVF9DT05GSUcgYnkgUXQncyAnY29uZmlndXJlJyB3 aGVuIGNyb3NzLWNvbXBpbGluZyBvbiBzeXN0ZW1zCisgICAgICAgIHdpdGhvdXQgcGtnLWNvbmZp Zy4KKworICAgICAgICBUaGUgcmVzcGVjdGl2ZSBjaGFuZ2UgaW4gUXQncyBjb25maWd1cmUgaGFz IGJlZW4gc3VibWl0ZWQgYWxyZWFkeS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBp cyBqdXN0IGEgYnVpbGQgY2hhbmdlLgorCisgICAgICAgICogd3RmL3d0Zi5wcmk6IHByb3RlY3Qg cGtnLWNvbmZpZyBjYWxscworCiAyMDExLTA4LTI4ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21h aWwuY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBlcnJvciB3aGVuIGNvbXBpbGluZyB3aXRoIE1p bkdXLXc2NCBieSBkaXNhYmxpbmcgSklUCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL3d0Zi5wcmkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3d0Zi5wcmkKaW5kZXgg NWU0OGY5YTUwMWRjMzllMWY1YWM2MjhiOTUxMzk5ZTY4NmIzNTQ3MC4uY2NjMmY2MDJjY2UwNWY1 YTA5ZDE5NmJiNzNlNmRmNDdmZWJiMzdhOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi93dGYucHJpCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvd3RmLnByaQpA QCAtNDIsNyArNDIsNyBAQCBTT1VSQ0VTICs9IFwKICAgICB3dGYvdW5pY29kZS9VVEY4LmNwcAog CiBsaW51eC0qOiFjb250YWlucyhERUZJTkVTLCBVU0VfUVRNVUxUSU1FRElBPTEpIHsKLSAgICBz eXN0ZW0ocGtnLWNvbmZpZyAtLWV4aXN0cyBnbGliLTIuMCBnaW8tMi4wIGdzdHJlYW1lci0wLjEw KTogeworICAgICFjb250YWlucyhRVF9DT05GSUcsIG5vLXBrZy1jb25maWcpOnN5c3RlbShwa2ct Y29uZmlnIC0tZXhpc3RzIGdsaWItMi4wIGdpby0yLjAgZ3N0cmVhbWVyLTAuMTApOiB7CiAgICAg ICAgIERFRklORVMgKz0gRU5BQkxFX0dMSUJfU1VQUE9SVD0xCiAgICAgICAgIFBLR0NPTkZJRyAr PSBnbGliLTIuMCBnaW8tMi4wCiAgICAgICAgIENPTkZJRyArPSBsaW5rX3BrZ2NvbmZpZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDk1ZWE4ZDVhNTg4NTYxNzQzYzBlNjY5NWIwM2NjM2QwZTlhMmQ2OGMuLjBlMWZk NmNmNjIwZDM0YzM1ZjNjYTgwYjRjYzk2YjYzZTBkMzNhNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyNiBAQAorMjAxMS0wOC0yNiAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIuICA8YWRlbWFyLnJl aXNAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdIERvIG5vdCB1bmNvbmRpdGlvbmFsbHkg dXNlIHBrZy1jb25maWcgaW4gLnBybyBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcwNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbCBwYXRjaCBmcm9tIFJvaGFuIE1jR292ZXJuIDxy b2hhbi5tY2dvdmVybkBub2tpYS5jb20+CisKKyAgICAgICAgVXNpbmcgdGhlIGZpcnN0IHBrZy1j b25maWcgaW4gUEFUSCBpcyBwcm9uZSB0byBlcnJvcnMgd2hlbiBjcm9zcworICAgICAgICBjb21w aWxpbmcgaW5zaWRlIHRoZSBRdCByZXBvc2l0b3J5ICh1c2luZyBRdCdzIGJ1aWxkLXN5c3RlbSku CisKKyAgICAgICAgVGhpcyBwYXRjaCBwcm90ZWN0IGNhbGxzIGZvciBwa2ctY29uZmlnIHdpdGgK KyAgICAgICAgIWNvbnRhaW5zKFFUX0NPTkZJRywgbm8tcGtnLWNvbmZpZykuIG5vLXBrZy1jb25m aWcgaXMgYWRkZWQgdG8KKyAgICAgICAgUVRfQ09ORklHIGJ5IFF0J3MgJ2NvbmZpZ3VyZScgd2hl biBjcm9zcy1jb21waWxpbmcgb24gc3lzdGVtcworICAgICAgICB3aXRob3V0IHBrZy1jb25maWcu CisKKyAgICAgICAgVGhlIHJlc3BlY3RpdmUgY2hhbmdlIGluIFF0J3MgY29uZmlndXJlIGhhcyBi ZWVuIHN1Ym1pdGVkIGFscmVhZHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgaXMg anVzdCBhIGJ1aWxkIGNoYW5nZS4KKworICAgICAgICAqIGZlYXR1cmVzLnByaTogcHJvdGVjdCBw a2ctY29uZmlnIGNhbGxzCisKIDIwMTEtMDgtMjkgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNhY2hlZCBwZXJtYW5lbnQg cmVkaXJlY3RzIGRvbid0IHNob3cgcmVkaXJlY3QgY29kZSBhbmQgdGV4dCBpbiBOZXR3b3JrIHBh bmVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpIGIvU291cmNlL1dl YkNvcmUvZmVhdHVyZXMucHJpCmluZGV4IDhhZDUxZGYzZGY4NzE1MmNhZjllYWM3MDQxNWQ2NzY3 YTMyODQyNDQuLmRkMTM5NzI0MzRjM2U1YzNhNTVkNmM5MDI4MDU5Y2UzNWE2NjgzZDggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9m ZWF0dXJlcy5wcmkKQEAgLTE5Niw3ICsxOTYsNyBAQCBzeW1iaWFufG1hZW1vNXxtYWVtbzYgewog ICAgICAgICBERUZJTkVTICs9IFdURl9VU0VfUVRLSVQ9MQogICAgICAgICBERUZJTkVTIC09IFdU Rl9VU0VfUVRLSVQ9MAogICAgIH0gZWxzZTogbGludXgtKjohY29udGFpbnMoREVGSU5FUywgVVNF X1FUTVVMVElNRURJQT0xKSB7Ci0gICAgICAgIHN5c3RlbShwa2ctY29uZmlnIC0tZXhpc3RzIGds aWItMi4wIGdpby0yLjAgZ3N0cmVhbWVyLTAuMTApOiB7CisgICAgICAgICFjb250YWlucyhRVF9D T05GSUcsIG5vLXBrZy1jb25maWcpOnN5c3RlbShwa2ctY29uZmlnIC0tZXhpc3RzIGdsaWItMi4w IGdpby0yLjAgZ3N0cmVhbWVyLTAuMTApOiB7CiAgICAgICAgICAgICBERUZJTkVTIC09IEVOQUJM RV9WSURFTz0wCiAgICAgICAgICAgICBERUZJTkVTICs9IEVOQUJMRV9WSURFTz0xCiAgICAgICAg ICAgICBERUZJTkVTICs9IFdURl9VU0VfR1NUUkVBTUVSPTEK