67052 2011-08-26 12:26:14 -0700 Remove offset hack from GraphicsContextCG setShadow code 2011-09-15 14:22:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac Unspecified RESOLVED DUPLICATE 68041 InRadar P2 Normal --- 1 mdelaney7 mdelaney7 eoconnor hyatt mitz simon.fraser webkit-bug-importer oldest_to_newest 457703 0 mdelaney7 2011-08-26 12:26:14 -0700 A hack was introduced in http://trac.webkit.org/changeset/28714 for an issue with offsets in an old version of cg that's long since been fixed. Since this hack is no longer necessary it's best removed. 457713 1 105393 mdelaney7 2011-08-26 12:53:27 -0700 Created attachment 105393 Patch 457722 2 105393 simon.fraser 2011-08-26 13:16:26 -0700 Comment on attachment 105393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105393&action=review > Source/WebCore/ChangeLog:3 > + Remove offset hack from graphicscontextcg setShadow code graphicscontextcg -> GraphicsContextCG > Source/WebCore/ChangeLog:12 > + for an issue with offsets in an old version of cg that's long since been fixed. cg -> CoreGraphics. 457813 3 mdelaney7 2011-08-26 15:26:43 -0700 Committed r93919: <http://trac.webkit.org/changeset/93919> 457831 4 webkit-bug-importer 2011-08-26 16:06:30 -0700 <rdar://problem/10033019> 458508 5 simon.fraser 2011-08-29 15:47:26 -0700 ...but conditionality put back via bug 67107. 464894 6 simon.fraser 2011-09-09 10:47:12 -0700 This seems to have affected LayoutTests/fast/repaint/box-shadow-h.html 464920 7 hyatt 2011-09-09 11:11:57 -0700 box-shadow-v.html as well. 464946 8 mdelaney7 2011-09-09 11:37:03 -0700 Unless I'm misreading the tests, it appears that they're "more" correct now. The only difference is the non-blurred shadow above the last "lorem ipsum" - It now shows an offset of -5,-5 as requested, instead of having only the x and y offset component for the vertical and horizontal tests, respectively. I haven't double checked to see if those tests (using box-shadow) hit the ShadowBlur code path or not. If they do, then this patch wouldn't have affected that, correct? 464956 9 mdelaney7 2011-09-09 11:53:27 -0700 Hmm, reverting my change for Lion does show those tests changing. So, again, unless I'm misreading it then this change helps us on those tests and we should rebaseline them. I can do that if others agree. 466651 10 mitz 2011-09-13 16:19:50 -0700 This is now broken in TOT in OS X Lion: <div style="width: 100px; height: 100px; -webkit-box-shadow: black 1px 1px; background: red;"> 466654 11 simon.fraser 2011-09-13 16:22:40 -0700 Reopening. 466662 12 mitz 2011-09-13 16:28:15 -0700 Filed bug 68041. 468083 13 mdelaney7 2011-09-15 14:22:49 -0700 This issue is resolved by https://bugs.webkit.org/show_bug.cgi?id=68041. Closing. *** This bug has been marked as a duplicate of bug 68041 *** 105393 2011-08-26 12:53:27 -0700 2011-08-26 13:16:26 -0700 Patch bug-67052-20110826125326.patch text/plain 2025 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzOTAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjYgIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgb2Zmc2V0IGhh Y2sgZnJvbSBncmFwaGljc2NvbnRleHRjZyBzZXRTaGFkb3cgY29kZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjcwNTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSBjdXJyZW50IHRl c3RzIGNvdmVyIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3ND b250ZXh0Q0cuY3BwOgorICAgICAgICBSZW1vdmluZyB0aGUgb2Zmc2V0IGhhY2sgaW50cm9kdWNl ZCBpbiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yODcxNAorICAgICAgICBmb3Ig YW4gaXNzdWUgd2l0aCBvZmZzZXRzIGluIGFuIG9sZCB2ZXJzaW9uIG9mIGNnIHRoYXQncyBsb25n IHNpbmNlIGJlZW4gZml4ZWQuCisKIDIwMTEtMDgtMjYgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNA Z29vZ2xlLmNvbT4KIAogICAgICAgICBBZGQgTWVkaWFQbGF5ZXI6OmF1ZGlvU291cmNlUHJvdmlk ZXIoKSBtZXRob2QgZm9yIGF1ZGlvIHN0cmVhbSBhY2Nlc3MgYnkgdGhlIFdlYiBBdWRpbyBBUEku CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRl eHRDRy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCShyZXZpc2lvbiA5MzkwMikKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTAyMSwxOSArMTAyMSw2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0 Zm9ybVNoYWRvdygKICAgICAvLyBFeHRyZW1lICJibHVyIiB2YWx1ZXMgY2FuIG1ha2UgdGV4dCBk cmF3aW5nIGNyYXNoIG9yIHRha2UgY3JhenkgbG9uZyB0aW1lcywgc28gY2xhbXAKICAgICBibHVy UmFkaXVzID0gbWluKGJsdXJSYWRpdXMsIG5hcnJvd1ByZWNpc2lvblRvQ0dGbG9hdCgxMDAwLjAp KTsKIAotICAgIC8vIFdvcmsgYXJvdW5kIDxyZGFyOi8vcHJvYmxlbS81NTM5Mzg4PiBieSBlbnN1 cmluZyB0aGF0IHRoZSBvZmZzZXRzIHdpbGwgZ2V0IHRydW5jYXRlZAotICAgIC8vIHRvIHRoZSBk ZXNpcmVkIGludGVnZXIuCi0gICAgc3RhdGljIGNvbnN0IENHRmxvYXQgZXh0cmFTaGFkb3dPZmZz ZXQgPSBuYXJyb3dQcmVjaXNpb25Ub0NHRmxvYXQoMS4wIC8gMTI4KTsKLSAgICBpZiAoeE9mZnNl dCA+IDApCi0gICAgICAgIHhPZmZzZXQgKz0gZXh0cmFTaGFkb3dPZmZzZXQ7Ci0gICAgZWxzZSBp ZiAoeE9mZnNldCA8IDApCi0gICAgICAgIHhPZmZzZXQgLT0gZXh0cmFTaGFkb3dPZmZzZXQ7Ci0K LSAgICBpZiAoeU9mZnNldCA+IDApCi0gICAgICAgIHlPZmZzZXQgKz0gZXh0cmFTaGFkb3dPZmZz ZXQ7Ci0gICAgZWxzZSBpZiAoeU9mZnNldCA8IDApCi0gICAgICAgIHlPZmZzZXQgLT0gZXh0cmFT aGFkb3dPZmZzZXQ7Ci0KICAgICAvLyBDaGVjayBmb3IgYW4gaW52YWxpZCBjb2xvciwgYXMgdGhp cyBtZWFucyB0aGF0IHRoZSBjb2xvciB3YXMgbm90IHNldCBmb3IgdGhlIHNoYWRvdwogICAgIC8v IGFuZCB3ZSBzaG91bGQgdGhlcmVmb3JlIGp1c3QgdXNlIHRoZSBkZWZhdWx0IHNoYWRvdyBjb2xv ci4KICAgICBpZiAoIWNvbG9yLmlzVmFsaWQoKSkK