67039 2011-08-26 09:38:02 -0700 Web Inspector: [REGRESSION] No way to expand hovered objects while debugging. 2011-08-26 09:57:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein caseq joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 457582 0 pfeldman 2011-08-26 09:38:02 -0700 Fix to follow. 457584 1 pfeldman 2011-08-26 09:46:08 -0700 Total problems found: 1. Popup renamed to Popover in half of the places, as a result, this._hidePopoverTimer is not getting removed. [regression] 2. contentElement.addEventListener("mousemove", this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true); was entirely forgotten and caused this [regression]. 3. Strange delete this._popupInstanceMarker in the code We will need to hold off commits like this in the future since they compromise the "polish" activity we are performing. 457586 2 105366 pfeldman 2011-08-26 09:50:45 -0700 Created attachment 105366 Patch 457592 3 105366 yurys 2011-08-26 09:55:24 -0700 Comment on attachment 105366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105366&action=review > Source/WebCore/inspector/front-end/Popover.js:33 > + * @param {WebInspector.Popover} popoverHelper Popover -> PopoverHelper=? 457593 4 pfeldman 2011-08-26 09:57:48 -0700 Committed r93882: <http://trac.webkit.org/changeset/93882> 105366 2011-08-26 09:50:45 -0700 2011-08-26 09:55:24 -0700 Patch bug-67039-20110826205043.patch text/plain 3411 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogOTM4NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxNmQ1N2U2YTNkYTZjMTUy YjQzZDkwZTJiOWYzNTdhYTVjN2JlNzdlLi5iZjRmNjQwMzg3ZjQyY2JhYjEyNTVkNTUzYTg2OTEx ODEzZjA0N2ExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMjYgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFtSRUdSRVNTSU9OXSBObyB3YXkgdG8gZXhwYW5kIGhvdmVyZWQgb2JqZWN0cyB3aGlsZSBkZWJ1 Z2dpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NzAzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBv cG92ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXIucHJvdG90eXBlLnNob3cpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlLl9tb3VzZURvd24p OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlLl9oaWRlUG9w b3Zlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUuX21v dXNlSG92ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBl Ll9raWxsSGlkZVBvcG92ZXJUaW1lcik6CisKIDIwMTEtMDgtMjUgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU29ja2V0OiBGaXggaW5kZW50YXRpb24g b2YgV2ViU29ja2V0IGhlYWRlciBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Qb3BvdmVyLmpzCmluZGV4IDU1MWQ4YzhkMWFhZDg5MmFjNjcxZTdkMDIyMDRiOGRm ZWI5OGE0MTUuLjZjZWQ5Nzc5YTQ5Y2JkMTNlM2E4ZDBkYjAyYjgwZjVhODNkN2FhOTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zlci5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMKQEAgLTMwLDkg KzMwLDkgQEAKIAogLyoqCiAgKiBAY29uc3RydWN0b3IKLSAqIEBwYXJhbSB7RWxlbWVudH0gY29u dGVudEVsZW1lbnQKKyAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlBvcG92ZXJ9IHBvcG92ZXJIZWxw ZXIKICAqLwotV2ViSW5zcGVjdG9yLlBvcG92ZXIgPSBmdW5jdGlvbigpCitXZWJJbnNwZWN0b3Iu UG9wb3ZlciA9IGZ1bmN0aW9uKHBvcG92ZXJIZWxwZXIpCiB7CiAgICAgdGhpcy5lbGVtZW50ID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdGhpcy5lbGVtZW50LmNsYXNzTmFt ZSA9ICJwb3BvdmVyIjsKQEAgLTQ0LDYgKzQ0LDcgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXIgPSBm dW5jdGlvbigpCiAgICAgdGhpcy5fY29udGVudERpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImRpdiIpOwogICAgIHRoaXMuX2NvbnRlbnREaXYuY2xhc3NOYW1lID0gImNvbnRlbnQiOwogICAg IHRoaXMuX3Zpc2libGUgPSBmYWxzZTsKKyAgICB0aGlzLl9wb3BvdmVySGVscGVyID0gcG9wb3Zl ckhlbHBlcjsKIH0KIAogV2ViSW5zcGVjdG9yLlBvcG92ZXIucHJvdG90eXBlID0gewpAQCAtNjks NiArNzAsOCBAQCBXZWJJbnNwZWN0b3IuUG9wb3Zlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRv Y3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodGhpcy5lbGVtZW50KTsKICAgICAgICAgdGhpcy5fcG9z aXRpb25FbGVtZW50KGFuY2hvciwgcHJlZmVycmVkV2lkdGgsIHByZWZlcnJlZEhlaWdodCk7CiAg ICAgICAgIHRoaXMuX3Zpc2libGUgPSB0cnVlOworICAgICAgICBpZiAodGhpcy5fcG9wb3Zlckhl bHBlcikKKyAgICAgICAgICAgIGNvbnRlbnRFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNl bW92ZSIsIHRoaXMuX3BvcG92ZXJIZWxwZXIuX2tpbGxIaWRlUG9wb3ZlclRpbWVyLmJpbmQodGhp cy5fcG9wb3ZlckhlbHBlciksIHRydWUpOwogICAgIH0sCiAKICAgICBoaWRlOiBmdW5jdGlvbigp CkBAIC0xOTcsNyArMjAwLDcgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBl ID0gewogCiAgICAgX21vdXNlRG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAgICB0 aGlzLl9raWxsSGlkZVBvcHVwVGltZXIoKTsKKyAgICAgICAgdGhpcy5fa2lsbEhpZGVQb3BvdmVy VGltZXIoKTsKICAgICAgICAgdGhpcy5faGFuZGxlTW91c2VBY3Rpb24oZXZlbnQsIHRydWUpOwog ICAgIH0sCiAKQEAgLTI0OSw3ICsyNTIsNiBAQCBXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5w cm90b3R5cGUgPSB7CiAKICAgICBfaGlkZVBvcG92ZXI6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAg ICAgIGRlbGV0ZSB0aGlzLl9wb3B1cEluc3RhbmNlTWFya2VyOwogICAgICAgICBpZiAoIXRoaXMu X3BvcG92ZXIpCiAgICAgICAgICAgICByZXR1cm47CiAKQEAgLTI2NSwxNSArMjY3LDE1IEBAIFdl Ykluc3BlY3Rvci5Qb3BvdmVySGVscGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgZGVsZXRlIHRo aXMuX2hvdmVyVGltZXI7CiAKICAgICAgICAgdGhpcy5faGlkZVBvcG92ZXIoKTsKLSAgICAgICAg dGhpcy5fcG9wb3ZlciA9IG5ldyBXZWJJbnNwZWN0b3IuUG9wb3ZlcigpOworICAgICAgICB0aGlz Ll9wb3BvdmVyID0gbmV3IFdlYkluc3BlY3Rvci5Qb3BvdmVyKHRoaXMpOwogICAgICAgICB0aGlz Ll9zaG93UG9wb3ZlcihlbGVtZW50LCB0aGlzLl9wb3BvdmVyKTsKICAgICB9LAogCi0gICAgX2tp bGxIaWRlUG9wdXBUaW1lcjogZnVuY3Rpb24oKQorICAgIF9raWxsSGlkZVBvcG92ZXJUaW1lcjog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2hpZGVQb3BvdmVyVGltZXIpIHsK ICAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlzLl9oaWRlUG9wb3ZlclRpbWVyKTsKLSAgICAg ICAgICAgIGRlbGV0ZSB0aGlzLl9oaWRlUG9wdXBUaW1lcjsKKyAgICAgICAgICAgIGRlbGV0ZSB0 aGlzLl9oaWRlUG9wb3ZlclRpbWVyOwogCiAgICAgICAgICAgICAvLyBXZSBrbm93IHRoYXQgd2Ug cmVhY2hlZCB0aGUgcG9wdXAsIGJ1dCB3ZSBtaWdodCBoYXZlIG1vdmVkIG92ZXIgb3RoZXIgZWxl bWVudHMuCiAgICAgICAgICAgICAvLyBEaXNjYXJkIHBlbmRpbmcgY29tbWFuZC4K