<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67021</bug_id>
          
          <creation_ts>2011-08-25 23:31:39 -0700</creation_ts>
          <short_desc>Web Inspector: assign CtrlOrMeta+s shortcut to saveAs in ScriptsPanel.</short_desc>
          <delta_ts>2014-05-27 04:07:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>116924</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ilya Tikhonovsky">loislo</reporter>
          <assigned_to name="Roland Takacs">rtakacs</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>mmatyas</cc>
    
    <cc>noam</cc>
    
    <cc>ossy</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>rtakacs</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>457419</commentid>
    <comment_count>0</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2011-08-25 23:31:39 -0700</bug_when>
    <thetext>%subj%</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>457421</commentid>
    <comment_count>1</comment_count>
      <attachid>105317</attachid>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2011-08-25 23:37:44 -0700</bug_when>
    <thetext>Created attachment 105317
[patch] initial version</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>457429</commentid>
    <comment_count>2</comment_count>
      <attachid>105317</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2011-08-25 23:46:50 -0700</bug_when>
    <thetext>Comment on attachment 105317
[patch] initial version

We should not show dialog upon each commit into the VM. Either there should be a way to commit without saving or Save should be done using different shortcut.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>895507</commentid>
    <comment_count>3</comment_count>
    <who name="Roland Takacs">rtakacs</who>
    <bug_when>2013-05-30 06:02:49 -0700</bug_when>
    <thetext>Since there is no activity on the bug for a long time I had the courage to take over the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>897731</commentid>
    <comment_count>4</comment_count>
      <attachid>203925</attachid>
    <who name="Mátyás Mustoha">mmatyas</who>
    <bug_when>2013-06-06 05:41:49 -0700</bug_when>
    <thetext>Created attachment 203925
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>898587</commentid>
    <comment_count>5</comment_count>
      <attachid>203925</attachid>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2013-06-10 02:36:36 -0700</bug_when>
    <thetext>Comment on attachment 203925
Patch

Does this actually open a &quot;Save as&quot; dialog? or does it just save the script with a constructed filename?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>898592</commentid>
    <comment_count>6</comment_count>
    <who name="Mátyás Mustoha">mmatyas</who>
    <bug_when>2013-06-10 02:41:22 -0700</bug_when>
    <thetext>Yes, it should open the dialog (except when auto-download is set in the browser).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941797</commentid>
    <comment_count>7</comment_count>
      <attachid>203925</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-10-21 03:51:22 -0700</bug_when>
    <thetext>Comment on attachment 203925
Patch

r-, because old inspector UI was removed, so it is obsolete.

Do we have this feature in the new inspector?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011934</commentid>
    <comment_count>8</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-05-27 04:07:42 -0700</bug_when>
    <thetext>It is a bug for the old inspector UI.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>105317</attachid>
            <date>2011-08-25 23:37:44 -0700</date>
            <delta_ts>2011-08-25 23:46:50 -0700</delta_ts>
            <desc>[patch] initial version</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2044</size>
            <attacher name="Ilya Tikhonovsky">loislo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBkOGFjMjg1Li43N2EwODNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg
QEAKKzIwMTEtMDgtMjUgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor
CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEN0cmxPck1ldGErcyBhcyBhIHNob3J0Y3V0IGZvciBU
ZXh0Vmlld2VyLnNhdmVBcyB3b3VsZCBiZSB2ZXJ5IHVzZWZ1bC4KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MDIxCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRW
aWV3ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dFZpZXdlci5wcm90b3R5cGUuX3Jl
Z2lzdGVyU2hvcnRjdXRzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3Rv
dHlwZS5fc2F2ZUFzKToKKwogMjAxMS0wOC0yNCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBnb29n
bGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBhIGtleXBhdGggcGFyc2VyIHN0cmljdGx5IGZv
bGxvd2luZyB0aGUgc3BlY2lmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z
cGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y
L2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IGMwMzM4MWQuLjBiMDZhOTIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcworKysg
Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKQEAgLTI0
OSw3ICsyNDksNyBAQCBXZWJJbnNwZWN0b3IuVGV4dFZpZXdlci5wcm90b3R5cGUgPSB7CiAgICAg
ICAgIHRoaXMuX3Nob3J0Y3V0cyA9IHt9OwogICAgICAgICB2YXIgY29tbWl0RWRpdGluZyA9IHRo
aXMuX2NvbW1pdEVkaXRpbmcuYmluZCh0aGlzKTsKICAgICAgICAgdmFyIGNhbmNlbEVkaXRpbmcg
PSB0aGlzLl9jYW5jZWxFZGl0aW5nLmJpbmQodGhpcyk7Ci0gICAgICAgIHRoaXMuX3Nob3J0Y3V0
c1tXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlS2V5KCJzIiwgbW9kaWZpZXJzLkN0
cmxPck1ldGEpXSA9IGNvbW1pdEVkaXRpbmc7CisgICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tXZWJJ
bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlS2V5KCJzIiwgbW9kaWZpZXJzLkN0cmxPck1l
dGEpXSA9IHRoaXMuX3NhdmVBcy5iaW5kKHRoaXMpOwogICAgICAgICB0aGlzLl9zaG9ydGN1dHNb
V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleShrZXlzLkVudGVyLmNvZGUsIG1v
ZGlmaWVycy5DdHJsT3JNZXRhKV0gPSBjb21taXRFZGl0aW5nOwogICAgICAgICB0aGlzLl9zaG9y
dGN1dHNbV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleShrZXlzLkVzYy5jb2Rl
KV0gPSBjYW5jZWxFZGl0aW5nOwogCkBAIC0zMDMsNiArMzAzLDE1IEBAIFdlYkluc3BlY3Rvci5U
ZXh0Vmlld2VyLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAor
ICAgIF9zYXZlQXM6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgdGhpcy5fZGVsZWdh
dGUuY29tbWl0RWRpdGluZygpOworICAgICAgICB2YXIgZmlsZU5hbWUgPSB0aGlzLl9kZWxlZ2F0
ZS5zdWdnZXN0ZWRGaWxlTmFtZSgpOworICAgICAgICBpZiAoZmlsZU5hbWUpCisgICAgICAgICAg
ICBJbnNwZWN0b3JGcm9udGVuZEhvc3Quc2F2ZUFzKGZpbGVOYW1lLCB0aGlzLl90ZXh0TW9kZWwu
dGV4dCk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0sCisKICAgICBfY2FuY2VsRWRpdGlu
ZzogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMucmVhZE9ubHkpCg==
</data>
<flag name="review"
          id="101421"
          type_id="1"
          status="-"
          setter="pfeldman"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>203925</attachid>
            <date>2013-06-06 05:41:49 -0700</date>
            <delta_ts>2013-10-21 03:51:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>67021_kesz.diff</filename>
            <type>text/plain</type>
            <size>2305</size>
            <attacher name="Mátyás Mustoha">mmatyas</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA0ZjFhNjQ2Li42NWIzNTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg
QEAKKzIwMTMtMDYtMDYgIE3DoXR5w6FzIE11c3RvaGEgIDxtbWF0eWFzQGluZi51LXN6ZWdlZC5o
dT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhc3NpZ24gQ3RybE9yTWV0YStzIHNob3J0Y3V0
IHRvIHNhdmVBcyBpbiBTY3JpcHRzUGFuZWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD02NzAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIEFzc2lnbmVkIEN0cmwtU2hpZnQtUyBzaG9ydGN1dCBpbiBTY3Jp
cHQgUGFuZWwgdG8gJ1NhdmUgQXMnLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9T
b3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZSk6CisgICAg
ICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9zYXZlQXMpOgorCiAyMDEz
LTA2LTA2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgU1ZHIG9i
amVjdHMgYXJlIG1pc3BsYWNlZCB3aGVuIFNWRyByb290IGhhcyBDU1MgdHJhbnNmb3JtLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5q
cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKaW5k
ZXggMjk2NDM3MC4uMjEwZTJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y
L2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv
ZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCkBAIC02NCw2ICs2NCw3IEBAIFdlYkluc3BlY3Rvci5T
b3VyY2VGcmFtZSA9IGZ1bmN0aW9uKGNvbnRlbnRQcm92aWRlcikKIAogICAgIHRoaXMuX3Nob3J0
Y3V0cyA9IHt9OwogICAgIHRoaXMuX3Nob3J0Y3V0c1tXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y
dGN1dC5tYWtlS2V5KCJzIiwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJz
LkN0cmxPck1ldGEpXSA9IHRoaXMuX2NvbW1pdEVkaXRpbmcuYmluZCh0aGlzKTsKKyAgICB0aGlz
Ll9zaG9ydGN1dHNbV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleSgicyIsIFdl
Ykluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5DdHJsT3JNZXRhIHwgV2ViSW5z
cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLlNoaWZ0KV0gPSB0aGlzLl9zYXZlQXMu
YmluZCh0aGlzKTsKICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigia2V5ZG93biIs
IHRoaXMuX2hhbmRsZUtleURvd24uYmluZCh0aGlzKSwgZmFsc2UpOwogCiAgICAgdGhpcy5fc291
cmNlUG9zaXRpb25FbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CkBAIC03
MDYsNiArNzA3LDIzIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAg
ICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKKyAgICBfc2F2ZUFzOiBmdW5jdGlvbigpCisg
ICAgeworICAgICAgICB2YXIgcXVlc3Rpb25tYXJrSW5kZXggPSB0aGlzLl91cmwuaW5kZXhPZigi
PyIpOworICAgICAgICBpZiAocXVlc3Rpb25tYXJrSW5kZXggPT0gLTEpCisgICAgICAgICAgICBx
dWVzdGlvbm1hcmtJbmRleCA9IHRoaXMuX3VybC5sZW5ndGg7CisKKyAgICAgICAgdmFyIHNsYXNo
SW5kZXggPSB0aGlzLl91cmwuc3Vic3RyaW5nKDAsIHF1ZXN0aW9ubWFya0luZGV4KS5sYXN0SW5k
ZXhPZigiLyIpOworICAgICAgICBzbGFzaEluZGV4Kys7CisKKyAgICAgICAgdmFyIGZpbGVOYW1l
ID0gdGhpcy5fdXJsLnN1YnN0cmluZyhzbGFzaEluZGV4LCBxdWVzdGlvbm1hcmtJbmRleCk7Cisg
ICAgICAgIHZhciBmaWxlQ29udGVudCA9IHRoaXMuX3RleHRFZGl0b3IudGV4dCgpOworCisgICAg
ICAgIFdlYkluc3BlY3Rvci5maWxlTWFuYWdlci5zYXZlKGZpbGVOYW1lLCBmaWxlQ29udGVudCwg
dHJ1ZSk7CisgICAgICAgIFdlYkluc3BlY3Rvci5maWxlTWFuYWdlci5jbG9zZShmaWxlTmFtZSk7
CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0sCisKICAgICBfX3Byb3RvX186IFdlYkluc3Bl
Y3Rvci5WaWV3LnByb3RvdHlwZQogfQogCg==
</data>
<flag name="review"
          id="225399"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="225400"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
      

    </bug>

</bugzilla>