67001 2011-08-25 17:20:03 -0700 Handle key-down events in the updated Cocoa text input model 2011-08-25 17:34:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 457279 0 andersca 2011-08-25 17:20:03 -0700 Handle key-down events in the updated Cocoa text input model 457280 1 105279 andersca 2011-08-25 17:22:15 -0700 Created attachment 105279 Patch 457292 2 andersca 2011-08-25 17:34:15 -0700 Committed r93839: <http://trac.webkit.org/changeset/93839> 105279 2011-08-25 17:22:15 -0700 2011-08-25 17:29:09 -0700 Patch bug-67001-20110825172214.patch text/plain 6029 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzODM4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTEtMDgtMjUgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUga2V5LWRvd24g ZXZlbnRzIGluIHRoZSB1cGRhdGVkIENvY29hIHRleHQgaW5wdXQgbW9kZWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3MDAxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBwZXJmb3JtS2V5RXF1aXZhbGVudDpdKToKKyAg ICAgICAgQ2FsbCBfZGlzYWJsZUNvbXBsZXhUZXh0SW5wdXRJZk5lY2Vzc2FyeSBzbyB0aGF0IHdl J2xsIGluZm9ybSB0aGUgcGx1Zy1pbiB0aGF0IGNvbXBsZXggdGV4dAorICAgICAgICBpbnB1dCBo YXMgYmVlbiBkaXNhYmxlZC4KKworICAgICAgICAoLVtXS1ZpZXcgX2Rpc2FibGVDb21wbGV4VGV4 dElucHV0SWZOZWNlc3NhcnldKToKKyAgICAgICAgSWYgdGhlIHBsdWctaW4gaXMgdXNpbmcgdGhl IHVwZGF0ZWQgQ29jb2EgdGV4dCBpbnB1dCBtb2RlbCBzcGVjaWZpY2F0aW9uLCBkaXNhYmxlIHRl eHQgaW5wdXQKKyAgICAgICAgaWYgdGhlIHRleHQgaW5wdXQgd2luZG93IGhhcyBiZWVuIGRpc21p c3NlZCBmb3Igd2hhdGV2ZXIgcmVhc29uLgorCisgICAgICAgICgtW1dLVmlldyBfdHJ5SGFuZGxl UGx1Z2luQ29tcGxleFRleHRJbnB1dEtleURvd246XSk6CisgICAgICAgIENhbGwgX2Rpc2FibGVD b21wbGV4VGV4dElucHV0SWZOZWNlc3Nhcnkgc28gdGhhdCB3ZSdsbCBpbmZvcm0gdGhlIHBsdWct aW4gdGhhdCBjb21wbGV4IHRleHQKKyAgICAgICAgaW5wdXQgaGFzIGJlZW4gZGlzYWJsZWQuCisg ICAgICAgIAorICAgICAgICAoLVtXS1ZpZXcgX3RyeVBvc3RQcm9jZXNzUGx1Z2luQ29tcGxleFRl eHRJbnB1dEtleURvd246XSk6CisgICAgICAgIElmIHRoZSBwbHVnLWluIGlzIHVzaW5nIHRoZSB1 cGRhdGVkIENvY29hIHRleHQgaW5wdXQgbW9kZWwgc3BlY2lmaWNhdGlvbiwgbGV0IHRoZSBpbnB1 dCBtZXRob2RzCisgICAgICAgIGhhdmUgYSBnbyBhdCB0aGUga2V5Ym9hcmQgZXZlbnQuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1Z2luTWFj Lm1tOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6c2V0Q29tcGxleFRleHRJbnB1 dEVuYWJsZWQpOgorICAgICAgICBBY3R1YWxseSBzZXQgbV9pc0NvbXBsZXhUZXh0SW5wdXRFbmFi bGVkIHRvIHRoZSByaWdodCB2YWx1ZS4KKwogMjAxMS0wOC0yNSAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEZhY3RvciBjb2RlIHRvIHNlbmQgYSBrZXkt ZG93biBldmVudCB0byB0aGUgcGx1Zy1pbiBvdXQgaW50byBhIG5ldyBmdW5jdGlvbgpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gOTM4 MzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtp bmcgY29weSkKQEAgLTExMyw2ICsxMTMsNyBAQCBAaW50ZXJmYWNlIFdLVmlldyAoKQogLSAoZmxv YXQpX2RldmljZVNjYWxlRmFjdG9yOwogLSAodm9pZClfc2V0RHJhd2luZ0FyZWFTaXplOihOU1Np emUpc2l6ZTsKIC0gKHZvaWQpX3NldFBsdWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZTooUGx1Z2lu Q29tcGxleFRleHRJbnB1dFN0YXRlKXBsdWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZTsKKy0gKHZv aWQpX2Rpc2FibGVDb21wbGV4VGV4dElucHV0SWZOZWNlc3Nhcnk7CiBAZW5kCiAKIEBpbnRlcmZh Y2UgV0tWaWV3RGF0YSA6IE5TT2JqZWN0IHsKQEAgLTEyNDAsNiArMTI0MSw5IEBAIC0gKEJPT0wp cGVyZm9ybUtleUVxdWl2YWxlbnQ6KE5TRXZlbnQgKikKICAgICAKICAgICBCT09MIGV2ZW50V2Fz U2VudFRvV2ViQ29yZSA9IChfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50ID09IGV2ZW50 KTsKIAorICAgIGlmICghZXZlbnRXYXNTZW50VG9XZWJDb3JlKQorICAgICAgICBbc2VsZiBfZGlz YWJsZUNvbXBsZXhUZXh0SW5wdXRJZk5lY2Vzc2FyeV07CisKICAgICAvLyBQYXNzIGtleSBjb21i b3MgdGhyb3VnaCBXZWJDb3JlIGlmIHRoZXJlIGlzIGEga2V5IGJpbmRpbmcgYXZhaWxhYmxlIGZv cgogICAgIC8vIHRoaXMgZXZlbnQuIFRoaXMgbGV0cyB3ZWIgcGFnZXMgaGF2ZSBhIGNyYWNrIGF0 IGludGVyY2VwdGluZyBrZXktbW9kaWZpZWQga2V5cHJlc3Nlcy4KICAgICAvLyBCdXQgZG9uJ3Qg ZG8gaXQgaWYgd2UgaGF2ZSBhbHJlYWR5IGhhbmRsZWQgdGhlIGV2ZW50LgpAQCAtMTI1Nyw2ICsx MjYxLDE5IEBAIC0gKHZvaWQpa2V5VXA6KE5TRXZlbnQgKil0aGVFdmVudAogICAgIF9kYXRhLT5f cGFnZS0+aGFuZGxlS2V5Ym9hcmRFdmVudChOYXRpdmVXZWJLZXlib2FyZEV2ZW50KHRoZUV2ZW50 LCBzZWxmKSk7CiB9CiAKKy0gKHZvaWQpX2Rpc2FibGVDb21wbGV4VGV4dElucHV0SWZOZWNlc3Nh cnkKK3sKKyAgICBpZiAoIV9kYXRhLT5fcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIp CisgICAgICAgIHJldHVybjsKKworICAgIGlmIChfZGF0YS0+X3BsdWdpbkNvbXBsZXhUZXh0SW5w dXRTdGF0ZSAhPSBQbHVnaW5Db21wbGV4VGV4dElucHV0RW5hYmxlZCkKKyAgICAgICAgcmV0dXJu OworCisgICAgLy8gQ2hlY2sgaWYgdGhlIHRleHQgaW5wdXQgd2luZG93IGhhcyBiZWVuIGRpc21p c3NlZC4KKyAgICBpZiAoIVtbV0tUZXh0SW5wdXRXaW5kb3dDb250cm9sbGVyIHNoYXJlZFRleHRJ bnB1dFdpbmRvd0NvbnRyb2xsZXJdIGhhc01hcmtlZFRleHRdKQorICAgICAgICBbc2VsZiBfc2V0 UGx1Z2luQ29tcGxleFRleHRJbnB1dFN0YXRlOlBsdWdpbkNvbXBsZXhUZXh0SW5wdXREaXNhYmxl ZF07Cit9CisKIC0gKEJPT0wpX2hhbmRsZVBsdWdpbkNvbXBsZXhUZXh0SW5wdXRLZXlEb3duOihO U0V2ZW50ICopZXZlbnQKIHsKICAgICBBU1NFUlQoX2RhdGEtPl9wbHVnaW5Db21wbGV4VGV4dElu cHV0SWRlbnRpZmllcik7CkBAIC0xMjgyLDYgKzEyOTksMTAgQEAgLSAoQk9PTClfdHJ5SGFuZGxl UGx1Z2luQ29tcGxleFRleHRJbnB1dAogICAgIGlmICghX2RhdGEtPl9wbHVnaW5Db21wbGV4VGV4 dElucHV0SWRlbnRpZmllciB8fCBfZGF0YS0+X3BsdWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZSA9 PSBQbHVnaW5Db21wbGV4VGV4dElucHV0RGlzYWJsZWQpCiAgICAgICAgIHJldHVybiBOTzsKIAor ICAgIC8vIENoZWNrIGlmIHRoZSB0ZXh0IGlucHV0IHdpbmRvdyBoYXMgYmVlbiBkaXNtaXNzZWQg YW5kIGxldCB0aGUgcGx1Zy1pbiBwcm9jZXNzIGtub3cuCisgICAgLy8gVGhpcyBpcyBvbmx5IHZh bGlkIHdpdGggdGhlIHVwZGF0ZWQgQ29jb2EgdGV4dCBpbnB1dCBzcGVjLgorICAgIFtzZWxmIF9k aXNhYmxlQ29tcGxleFRleHRJbnB1dElmTmVjZXNzYXJ5XTsKKwogICAgIC8vIFRyeSBmZWVkaW5n IHRoZSBrZXlib2FyZCBldmVudCBkaXJlY3RseSB0byB0aGUgcGx1Zy1pbi4KICAgICByZXR1cm4g W3NlbGYgX2hhbmRsZVBsdWdpbkNvbXBsZXhUZXh0SW5wdXRLZXlEb3duOmV2ZW50XTsKIH0KQEAg LTIxMTksOCArMjE0MCwxNCBAQCAtICh2b2lkKV9zZXRVc2VySW50ZXJmYWNlSXRlbVN0YXRlOihO U1N0CiAKIC0gKEJPT0wpX3RyeVBvc3RQcm9jZXNzUGx1Z2luQ29tcGxleFRleHRJbnB1dEtleURv d246KE5TRXZlbnQgKilldmVudAogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCi0gICAgcmV0 dXJuIE5POworICAgIGlmICghX2RhdGEtPl9wbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmll ciB8fCBfZGF0YS0+X3BsdWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZSA9PSBQbHVnaW5Db21wbGV4 VGV4dElucHV0RGlzYWJsZWQpCisgICAgICAgIHJldHVybiBOTzsKKworICAgIC8vIEluIHRoZSBs ZWdhY3kgdGV4dCBpbnB1dCBtb2RlbCwgdGhlIGV2ZW50IGhhcyBhbHJlYWR5IGJlZW4gc2VudCB0 byB0aGUgaW5wdXQgbWV0aG9kLgorICAgIGlmIChfZGF0YS0+X3BsdWdpbkNvbXBsZXhUZXh0SW5w dXRTdGF0ZSA9PSBQbHVnaW5Db21wbGV4VGV4dElucHV0RW5hYmxlZExlZ2FjeSkKKyAgICAgICAg cmV0dXJuIE5POworCisgICAgcmV0dXJuIFtzZWxmIF9oYW5kbGVQbHVnaW5Db21wbGV4VGV4dElu cHV0S2V5RG93bjpldmVudF07CiB9CiAKIC0gKHZvaWQpX2RvbmVXaXRoS2V5RXZlbnQ6KE5TRXZl bnQgKilldmVudCBldmVudFdhc0hhbmRsZWQ6KEJPT0wpZXZlbnRXYXNIYW5kbGVkCkBAIC0yMzkw LDcgKzI0MTcsNyBAQCAtICh2b2lkKV9wbHVnaW5Gb2N1c09yV2luZG93Rm9jdXNDaGFuZ2VkCiAg ICAgW05TQXBwIHVwZGF0ZVdpbmRvd3NdOwogfQogCi0tICh2b2lkKV9zZXRQbHVnaW5Db21wbGV4 VGV4dElucHV0U3RhdGU6KFdlYktpdDo6UGx1Z2luQ29tcGxleFRleHRJbnB1dFN0YXRlKXBsdWdp bkNvbXBsZXhUZXh0SW5wdXRTdGF0ZSBwbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmllcjoo dWludDY0X3QpcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIKKy0gKHZvaWQpX3NldFBs dWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZTooUGx1Z2luQ29tcGxleFRleHRJbnB1dFN0YXRlKXBs dWdpbkNvbXBsZXhUZXh0SW5wdXRTdGF0ZSBwbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmll cjoodWludDY0X3QpcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIKIHsKICAgICBpZiAo cGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIgIT0gX2RhdGEtPl9wbHVnaW5Db21wbGV4 VGV4dElucHV0SWRlbnRpZmllcikgewogICAgICAgICAvLyBXZSdyZSBhc2tlZCB0byB1cGRhdGUg dGhlIHN0YXRlIGZvciBhIHBsdWctaW4gdGhhdCBkb2Vzbid0IGhhdmUgZm9jdXMuCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1 Z2luTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OZXRzY2FwZS9tYWMvTmV0c2NhcGVQbHVnaW5NYWMubW0JKHJldmlzaW9uIDkzODM2KQorKysg U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBs dWdpbk1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTAxMCw2ICsxMDEwLDggQEAgdm9pZCBOZXRz Y2FwZVBsdWdpbjo6c2V0Q29tcGxleFRleHRJbnB1dAogICAgIGlmIChtX2lzQ29tcGxleFRleHRJ bnB1dEVuYWJsZWQgPT0gY29tcGxleFRleHRJbnB1dEVuYWJsZWQpCiAgICAgICAgIHJldHVybjsK IAorICAgIG1faXNDb21wbGV4VGV4dElucHV0RW5hYmxlZCA9IGNvbXBsZXhUZXh0SW5wdXRFbmFi bGVkOworCiAgICAgUGx1Z2luQ29tcGxleFRleHRJbnB1dFN0YXRlIGNvbXBsZXhUZXh0SW5wdXRT dGF0ZSA9IFBsdWdpbkNvbXBsZXhUZXh0SW5wdXREaXNhYmxlZDsKICAgICBpZiAobV9pc0NvbXBs ZXhUZXh0SW5wdXRFbmFibGVkKQogICAgICAgICBjb21wbGV4VGV4dElucHV0U3RhdGUgPSBtX3Bs dWdpbldhbnRzTGVnYWN5Q29jb2FUZXh0SW5wdXQgPyBQbHVnaW5Db21wbGV4VGV4dElucHV0RW5h YmxlZExlZ2FjeSA6IFBsdWdpbkNvbXBsZXhUZXh0SW5wdXRFbmFibGVkOwo=