66988 2011-08-25 15:31:01 -0700 Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot 2011-08-26 02:57:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 457183 0 mnaganov 2011-08-25 15:31:01 -0700 From http://code.google.com/p/chromium/issues/detail?id=84659 Chrome Version : 13.0.782.0 OS Version: 6.1 (Windows 7, Windows Server 2008 R2) URLs (if applicable) : Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari 5: Firefox 4.x: IE 7/8/9: What steps will reproduce the problem? 1.Open the inspector and then Go to profiles 2. Take a heap snapshot. 3. Double click on the entry present in either Count or Shallow Size column. What is the expected result? Double clicking on numbers in Count & size columns should toggle between times and percents. What happens instead? Double clicking on numbers in Count & size columns doesn't toggle between times and percents. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.0 Safari/535.1 457190 1 105264 mnaganov 2011-08-25 15:35:53 -0700 Created attachment 105264 Patch 457493 2 mnaganov 2011-08-26 02:57:43 -0700 Manually committed http://trac.webkit.org/changeset/93861 2011-08-26 Mikhail Naganov <mnaganov@chromium.org> Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot. https://bugs.webkit.org/show_bug.cgi?id=66988 Reviewed by Pavel Feldman. * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid): (WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid): 105264 2011-08-25 15:35:53 -0700 2011-08-25 23:47:19 -0700 Patch patch-66988 text/plain 5537 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMjQ4ZTA5Li4wZjVhM2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDgtMjUgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIERvdWJsZSBjbGlja2luZyBvbiBu dW1iZXJzIGluIENvdW50ICYgc2l6ZSBjb2x1bW5zIGRvZXNuJ3QgdG9nZ2xlIGJldHdlZW4gdmFs dWVzIGFuZCBwZXJjZW50cyBpbiB0aGUgSGVhcCBTbmFwc2hvdC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2OTg4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFp bGVkSGVhcHNob3RWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNo b3RWaWV3LnByb3RvdHlwZS5fbW91c2VDbGlja0luQ29udGVudHNHcmlkKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5EZXRhaWxlZEhlYXBzaG90Vmlldy5wcm90b3R5cGUuX21vdXNlRG93bkluQ29u dGVudHNHcmlkKToKKwogMjAxMS0wOC0yNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkzNzcxLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhl YXBzaG90Vmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGV0YWls ZWRIZWFwc2hvdFZpZXcuanMKaW5kZXggODVmMzBmMi4uMTE0NTMzZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RW aWV3LmpzCkBAIC01MzEsMjggKzUzMSwzMSBAQCBXZWJJbnNwZWN0b3IuRGV0YWlsZWRIZWFwc2hv dFZpZXcgPSBmdW5jdGlvbihwYXJlbnQsIHByb2ZpbGUpCiAgICAgdGhpcy5jb250YWlubWVudFZp ZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlZpZXcoKTsKICAgICB0aGlzLmNvbnRhaW5tZW50Vmlldy5l bGVtZW50LmFkZFN0eWxlQ2xhc3MoInZpZXciKTsKICAgICB0aGlzLmNvbnRhaW5tZW50RGF0YUdy aWQgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnRhaW5tZW50RGF0YUdyaWQoKTsK LSAgICB0aGlzLmNvbnRhaW5tZW50RGF0YUdyaWQuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJj bGljayIsIHRoaXMuX21vdXNlQ2xpY2tJbkNvbnRhaW5tZW50R3JpZC5iaW5kKHRoaXMpLCB0cnVl KTsKKyAgICB0aGlzLmNvbnRhaW5tZW50RGF0YUdyaWQuZWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIHRoaXMuX21vdXNlQ2xpY2tJbkNvbnRlbnRzR3JpZC5iaW5kKHRoaXMpLCB0cnVl KTsKKyAgICB0aGlzLmNvbnRhaW5tZW50RGF0YUdyaWQuZWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCJtb3VzZWRvd24iLCB0aGlzLl9tb3VzZURvd25JbkNvbnRlbnRzR3JpZC5iaW5kKHRoaXMpLCB0 cnVlKTsKICAgICB0aGlzLmNvbnRhaW5tZW50Vmlldy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu Y29udGFpbm1lbnREYXRhR3JpZC5lbGVtZW50KTsKICAgICB0aGlzLnZpZXdzQ29udGFpbmVyLmFw cGVuZENoaWxkKHRoaXMuY29udGFpbm1lbnRWaWV3LmVsZW1lbnQpOwogCiAgICAgdGhpcy5jb25z dHJ1Y3RvcnNWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5WaWV3KCk7CiAgICAgdGhpcy5jb25zdHJ1 Y3RvcnNWaWV3LmVsZW1lbnQuYWRkU3R5bGVDbGFzcygidmlldyIpOwogICAgIHRoaXMuY29uc3Ry dWN0b3JzRGF0YUdyaWQgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnN0cnVjdG9y c0RhdGFHcmlkKCk7Ci0gICAgdGhpcy5jb25zdHJ1Y3RvcnNEYXRhR3JpZC5lbGVtZW50LmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fbW91c2VDbGlja0luQ29udGFpbm1lbnRHcmlkLmJp bmQodGhpcyksIHRydWUpOworICAgIHRoaXMuY29uc3RydWN0b3JzRGF0YUdyaWQuZWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX21vdXNlQ2xpY2tJbkNvbnRlbnRzR3JpZC5i aW5kKHRoaXMpLCB0cnVlKTsKKyAgICB0aGlzLmNvbnN0cnVjdG9yc0RhdGFHcmlkLmVsZW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwgdGhpcy5fbW91c2VEb3duSW5Db250ZW50c0dy aWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1lbnQu YXBwZW5kQ2hpbGQodGhpcy5jb25zdHJ1Y3RvcnNEYXRhR3JpZC5lbGVtZW50KTsKICAgICB0aGlz LnZpZXdzQ29udGFpbmVyLmFwcGVuZENoaWxkKHRoaXMuY29uc3RydWN0b3JzVmlldy5lbGVtZW50 KTsKIAogICAgIHRoaXMuZGlmZlZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlZpZXcoKTsKICAgICB0 aGlzLmRpZmZWaWV3LmVsZW1lbnQuYWRkU3R5bGVDbGFzcygidmlldyIpOwogICAgIHRoaXMuZGlm ZkRhdGFHcmlkID0gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3REaWZmRGF0YUdyaWQoKTsK LSAgICB0aGlzLmRpZmZEYXRhR3JpZC5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg dGhpcy5fbW91c2VDbGlja0luQ29udGFpbm1lbnRHcmlkLmJpbmQodGhpcyksIHRydWUpOworICAg IHRoaXMuZGlmZkRhdGFHcmlkLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlz Ll9tb3VzZUNsaWNrSW5Db250ZW50c0dyaWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAgdGhpcy5k aWZmVmlldy5lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuZGlmZkRhdGFHcmlkLmVsZW1lbnQpOwog ICAgIHRoaXMudmlld3NDb250YWluZXIuYXBwZW5kQ2hpbGQodGhpcy5kaWZmVmlldy5lbGVtZW50 KTsKIAogICAgIHRoaXMuZG9taW5hdG9yVmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuVmlldygpOwog ICAgIHRoaXMuZG9taW5hdG9yVmlldy5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoInZpZXciKTsKICAg ICB0aGlzLmRvbWluYXRvckRhdGFHcmlkID0gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RE b21pbmF0b3JzRGF0YUdyaWQoKTsKLSAgICB0aGlzLmRvbWluYXRvckRhdGFHcmlkLmVsZW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9tb3VzZUNsaWNrSW5Db250YWlubWVudEdy aWQuYmluZCh0aGlzKSwgdHJ1ZSk7CisgICAgdGhpcy5kb21pbmF0b3JEYXRhR3JpZC5lbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fbW91c2VDbGlja0luQ29udGVudHNHcmlk LmJpbmQodGhpcyksIHRydWUpOworICAgIHRoaXMuZG9taW5hdG9yRGF0YUdyaWQuZWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9tb3VzZURvd25JbkNvbnRlbnRzR3Jp ZC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlzLmRvbWluYXRvclZpZXcuZWxlbWVudC5hcHBl bmRDaGlsZCh0aGlzLmRvbWluYXRvckRhdGFHcmlkLmVsZW1lbnQpOwogICAgIHRoaXMudmlld3ND b250YWluZXIuYXBwZW5kQ2hpbGQodGhpcy5kb21pbmF0b3JWaWV3LmVsZW1lbnQpOwogCkBAIC05 MDgsMTAgKzkxMSwxMCBAQCBXZWJJbnNwZWN0b3IuRGV0YWlsZWRIZWFwc2hvdFZpZXcucHJvdG90 eXBlID0gewogICAgICAgICBwcm9maWxlLnNpZGViYXJFbGVtZW50LnN1YnRpdGxlID0gTnVtYmVy LmJ5dGVzVG9TdHJpbmcocy50b3RhbFNpemUpOwogICAgIH0sCiAKLSAgICBfbW91c2VDbGlja0lu Q29udGFpbm1lbnRHcmlkOiBmdW5jdGlvbihldmVudCkKKyAgICBfbW91c2VDbGlja0luQ29udGVu dHNHcmlkOiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAgICAgIHZhciBjZWxsID0gZXZlbnQu dGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoTm9kZU5hbWUoInRkIik7Ci0gICAgICAgIGlm ICghY2VsbCB8fCAoIWNlbGwuaGFzU3R5bGVDbGFzcygib2JqZWN0LWNvbHVtbiIpICYmICFjZWxs Lmhhc1N0eWxlQ2xhc3MoInNoYWxsb3dTaXplLWNvbHVtbiIpICYmICFjZWxsLmhhc1N0eWxlQ2xh c3MoInJldGFpbmVkU2l6ZS1jb2x1bW4iKSkpCisgICAgICAgIGlmICghY2VsbCB8fCAoIWNlbGwu aGFzU3R5bGVDbGFzcygib2JqZWN0LWNvbHVtbiIpKSkKICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgdmFyIHJvdyA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVO YW1lKCJ0ciIpOwogICAgICAgICBpZiAoIXJvdykKQEAgLTkyNSw2ICs5MjgsMjcgQEAgV2ViSW5z cGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRo aXMucmV0YWlubWVudERhdGFHcmlkLnJlc2V0KCk7CiAgICAgfSwKIAorICAgIF9tb3VzZURvd25J bkNvbnRlbnRzR3JpZDogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAgICAgICBpZiAoZXZlbnQu ZGV0YWlsIDwgMikKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgY2VsbCA9IGV2 ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lKCJ0ZCIpOworICAgICAg ICBpZiAoIWNlbGwgfHwgKCFjZWxsLmhhc1N0eWxlQ2xhc3MoImNvdW50LWNvbHVtbiIpICYmICFj ZWxsLmhhc1N0eWxlQ2xhc3MoInNoYWxsb3dTaXplLWNvbHVtbiIpICYmICFjZWxsLmhhc1N0eWxl Q2xhc3MoInJldGFpbmVkU2l6ZS1jb2x1bW4iKSkpCisgICAgICAgICAgICByZXR1cm47CisKKyAg ICAgICAgaWYgKGNlbGwuaGFzU3R5bGVDbGFzcygiY291bnQtY29sdW1uIikpCisgICAgICAgICAg ICB0aGlzLnNob3dDb3VudEFzUGVyY2VudCA9ICF0aGlzLnNob3dDb3VudEFzUGVyY2VudDsKKyAg ICAgICAgZWxzZSBpZiAoY2VsbC5oYXNTdHlsZUNsYXNzKCJzaGFsbG93U2l6ZS1jb2x1bW4iKSkK KyAgICAgICAgICAgIHRoaXMuc2hvd1NoYWxsb3dTaXplQXNQZXJjZW50ID0gIXRoaXMuc2hvd1No YWxsb3dTaXplQXNQZXJjZW50OworICAgICAgICBlbHNlIGlmIChjZWxsLmhhc1N0eWxlQ2xhc3Mo InJldGFpbmVkU2l6ZS1jb2x1bW4iKSkKKyAgICAgICAgICAgIHRoaXMuc2hvd1JldGFpbmVkU2l6 ZUFzUGVyY2VudCA9ICF0aGlzLnNob3dSZXRhaW5lZFNpemVBc1BlcmNlbnQ7CisgICAgICAgIHRo aXMucmVmcmVzaFNob3dBc1BlcmNlbnRzKCk7CisKKyAgICAgICAgZXZlbnQucHJldmVudERlZmF1 bHQoKTsKKyAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7CisgICAgfSwKKwogICAgIF9t b3VzZUNsaWNrSW5SZXRhaW5tZW50R3JpZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAg ICB2YXIgY2VsbCA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1l KCJ0ZCIpOwo=