66987 2011-08-25 15:14:54 -0700 Allow failure of tests-known-to-be-broken-by-Skia on all platforms 2011-09-01 07:46:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 67324 P2 Normal --- 0 epoger webkit-unassigned caryclark webkit.review.bot oldest_to_newest 457169 0 epoger 2011-08-25 15:14:54 -0700 There are a bunch of tests that are known to fail when using Skia graphics; these tests were allowed to fail in test_expectations.txt, but only for certain platforms. Allowing them to fail for ALL platforms instead, since Skia can be used on many platforms. 457177 1 105259 epoger 2011-08-25 15:23:36 -0700 Created attachment 105259 Allow failure of tests-known-to-be-broken-by-Skia on all platforms 457179 2 webkit.review.bot 2011-08-25 15:26:25 -0700 Attachment 105259 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/chromium/test_expecta..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:59 Test lacks BUG modifier. animations/animation-api-1.html ERROR: Line:79 Test lacks BUG modifier. fast/dom/HTMLDataGridElement ERROR: Line:84 Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html ERROR: Line:88 Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html ERROR: Line:92 Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html ERROR: Line:97 Test lacks BUG modifier. transforms/3d LayoutTests/platform/chromium/test_expectations.txt:59: Test lacks BUG modifier. animations/animation-api-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:79: Test lacks BUG modifier. fast/dom/HTMLDataGridElement [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:84: Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:88: Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:92: Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:97: Test lacks BUG modifier. transforms/3d [test/expectations] [2] Total errors found: 6 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 457188 3 epoger 2011-08-25 15:33:29 -0700 The check-webkit-style errors were not introduced by my patch. 457514 4 caryclark 2011-08-26 05:03:42 -0700 Looks like this change loses information. Tests which used to be split out to show that only the debug flavor timed out show that all flavors time out. Also, it doesn't permit showing that MAC-CG (however that's specified) succeeds. 457551 5 epoger 2011-08-26 07:43:56 -0700 Given Cary's comment, I am going to rework this patch to only allow test failures when Skia is enabled. I will also try to figure out what change caused the style failures below and pester the guilty party. 457769 6 epoger 2011-08-26 14:08:12 -0700 The check-webkit-style errors have been fixed in http://trac.webkit.org/changeset/93826 Still reworking this patch to only allow test failures when Skia is enabled. 460450 7 105259 epoger 2011-09-01 07:45:57 -0700 Comment on attachment 105259 Allow failure of tests-known-to-be-broken-by-Skia on all platforms Abandoning in favor of new approach in https://bugs.webkit.org/show_bug.cgi?id=67324 460453 8 epoger 2011-09-01 07:46:43 -0700 *** This bug has been marked as a duplicate of bug 67324 *** 105259 2011-08-25 15:23:36 -0700 2011-09-01 07:45:57 -0700 Allow failure of tests-known-to-be-broken-by-Skia on all platforms patch.txt text/plain 5715 epoger SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQJKHJldmlzaW9uIDkzODI0KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xODA1LDkgKzE4 MDUsNiBAQCBCVUdDUjQ0MTUwIExJTlVYIDogZmFzdC9mb3Jtcy9pbnB1dC10ZXh0CiAvLyBUaGUg Zm9sbG93aW5nIHRlc3RzIGZhaWwgb24gYWxsIHBsYXRmb3JtcyBhbmQgbmVlZCBmdXJ0aGVyIGlu dmVzdGlnYXRpb24uCiAvLyBNYW55IG9mIHRoZXNlIGFyZSBza2lwcGVkIG9uIHRoZSBNYWMgcGxh dGZvcm0KIEJVR1dLNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5icm9r ZW4uaHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n cmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgTElOVVggUkVM RUFTRSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUudG9wLmh0 bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIERFQlVHIDogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbCA9IFRJTUVPVVQgVEVYVAogQlVHV0szOTIx MiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmNyZWF0ZTEudHlwZS5odG1sID0g VEVYVAogQlVHV0szOTIxMiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmNyZWF0 ZTIudHlwZS5odG1sID0gVEVYVAogQlVHV0szOTIxMiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu aW1hZ2VEYXRhLmdldC50eXBlLmh0bWwgPSBURVhUCkBAIC0xODU1LDM1ICsxODUyLDM0IEBAIEJV R1dLNTA4NTkgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnRleHQKIEJVR1dLNDU5OTEgOiBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLnRleHQubWVhc3VyZS53aWR0aC5zcGFjZS5odG1sID0gVEVYVAog CiAvLyBUaGVzZSB0ZXN0cyBmYWlsIGV2ZXJ5d2hlcmUgd2UgdXNlIHNraWEgYW5kIGFyZSBtb3N0 IGxpa2VseSBza2lhIGJ1Z3MKLUJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5iZWhpbmQuaHRtbCA9IFRFWFQKLUJVR1dLNDU5 OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29u ZS5iZXNpZGUuaHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5jeWxpbmRlci5odG1sID0gVEVYVAotQlVHV0s0NTk5 MSBMSU5VWCBDUFUgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25l LmN5bGluZGVyLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGls aXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuc2hhcGUyLmh0bWwgPSBURVhUCi1CVUdX SzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFs Lm91dHNpZGUzLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGls aXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLnRvdWNoMS5odG1sID0gVEVYVAotQlVHV0s0NTk5 MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC50b3Vj aDMuaHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgTElOVVggV0lOIENQVSA6IGNhbnZhcy9waGlsaXAv dGVzdHMvMmQubGluZS53aWR0aC5iYXNpYy5odG1sID0gVEVYVAotQlVHV0s0NTk5MSBMSU5VWCBX SU4gQ1BVIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5saW5lLndpZHRoLnRyYW5zZm9ybWVkLmh0 bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu cGF0aC5hcmMuYW5nbGUuMy5odG1sID0gVEVYVAotQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguYXJjLmFuZ2xlLjUuaHRtbCA9IFRFWFQKLUJVR1dLNDU5 OTEgTElOVVggV0lOIENQVSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5zaGFw ZS5jdXJ2ZTEuaHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgTElOVVggV0lOIENQVSA6IGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5zaGFwZS5jdXJ2ZTIuaHRtbCA9IFRFWFQKLUJVR1dL NDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLnBhaW50Lm5v cmVwZWF0LmNvb3JkMy5odG1sID0gVEVYVAotQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMv cGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4ucGFpbnQucmVwZWF0eC5jb29yZDEuaHRtbCA9IFRFWFQK LUJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLnBh aW50LnJlcGVhdHkuY29vcmQxLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiBDUFUg OiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5jYW52YXMuYWxwaGEuaHRtbCA9IFRFWFQK K0JVR1dLNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25l LmJlaGluZC5odG1sID0gVEVYVAorQlVHV0s0NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu Z3JhZGllbnQucmFkaWFsLmNvbmUuYmVzaWRlLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS5jeWxpbmRlci5odG1sID0g VEVYVAorQlVHV0s0NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFs LmNvbmUuc2hhcGUyLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5ncmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbCA9IFRJTUVPVVQgVEVYVAorQlVHV0s0 NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLm91dHNpZGUzLmh0 bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5y YWRpYWwudG91Y2gxLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5ncmFkaWVudC5yYWRpYWwudG91Y2gzLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5saW5lLndpZHRoLmJhc2ljLmh0bWwgPSBURVhUCitCVUdXSzQ1 OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5saW5lLndpZHRoLnRyYW5zZm9ybWVkLmh0bWwg PSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyYy5hbmds ZS4zLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRo LmFyYy5hbmdsZS41Lmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5wYXRoLmFyY1RvLnNoYXBlLmN1cnZlMS5odG1sID0gVEVYVAorQlVHV0s0NTk5MSA6IGNh bnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5zaGFwZS5jdXJ2ZTIuaHRtbCA9IFRFWFQK K0JVR1dLNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4ucGFpbnQubm9yZXBl YXQuY29vcmQzLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXR0ZXJuLnBhaW50LnJlcGVhdHguY29vcmQxLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLnBhaW50LnJlcGVhdHkuY29vcmQxLmh0bWwg PSBURVhUCiAvLyBUaGlzIHRlc3QgdGltZXMgb3V0IGR1ZSB0byBNZXNhIHNsb3duZXNzLgotQlVH V0s0NTk5MSBMSU5VWCBXSU4gR1BVIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuY2Fu dmFzLmFscGhhLmh0bWwgPSBUSU1FT1VUIFRFWFQKLUJVR1dLNDU5OTEgTElOVVggV0lOIDogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuY2FudmFzLmJhc2ljLmh0bWwgPSBURVhUCi1CVUdX SzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmNhbnZhcy50 cmFuc3BhcmVudC4yLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiBDUFUgOiBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5lbmFibGUuYmx1ci5odG1sID0gVEVYVAotQlVHV0s0 NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5pbWFnZS5hbHBo YS5odG1sID0gVEVYVAotQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLnNoYWRvdy5pbWFnZS5iYXNpYy5odG1sID0gVEVYVAotQlVHV0s0NTk5MSBMSU5VWCBXSU4g OiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5pbWFnZS5zY2FsZS5odG1sID0gVEVYVAot QlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5pbWFn ZS50cmFuc3BhcmVudC4yLmh0bWwgPSBURVhUCi1CVUdXSzQ1OTkxIExJTlVYIFdJTiBDUFUgOiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLnRyYW5zZm9ybWF0aW9uLnNldFRyYW5zZm9ybS5za2V3ZWQu aHRtbCA9IFRFWFQKLUJVR1dLNDU5OTEgTElOVVggV0lOIENQVSA6IGNhbnZhcy9waGlsaXAvdGVz dHMvMmQudHJhbnNmb3JtYXRpb24udHJhbnNmb3JtLnNrZXdlZC5odG1sID0gVEVYVAorQlVHV0s0 NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmNhbnZhcy5hbHBoYS5odG1sID0g VElNRU9VVCBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cu Y2FudmFzLmJhc2ljLmh0bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5zaGFkb3cuY2FudmFzLnRyYW5zcGFyZW50LjIuaHRtbCA9IFRFWFQKK0JVR1dLNDU5OTEg OiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnNoYWRvdy5lbmFibGUuYmx1ci5odG1sID0gVEVYVAor QlVHV0s0NTk5MSA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LmltYWdlLmFscGhhLmh0 bWwgPSBURVhUCitCVUdXSzQ1OTkxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuaW1h Z2UuYmFzaWMuaHRtbCA9IFRFWFQKK0JVR1dLNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LnNoYWRvdy5pbWFnZS5zY2FsZS5odG1sID0gVEVYVAorQlVHV0s0NTk5MSA6IGNhbnZhcy9waGls aXAvdGVzdHMvMmQuc2hhZG93LmltYWdlLnRyYW5zcGFyZW50LjIuaHRtbCA9IFRFWFQKK0JVR1dL NDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnRyYW5zZm9ybWF0aW9uLnNldFRyYW5zZm9y bS5za2V3ZWQuaHRtbCA9IFRFWFQKK0JVR1dLNDU5OTEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LnRyYW5zZm9ybWF0aW9uLnRyYW5zZm9ybS5za2V3ZWQuaHRtbCA9IFRFWFQKIAogCiBCVUdDUjYy MzAxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLmNvbmUuZnJv bnQuaHRtbCA9IFRFWFQK