66983 2011-08-25 14:39:28 -0700 Move file internal methods to a class continuation in WKView 2011-08-26 10:03:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca aroben darin oldest_to_newest 457145 0 andersca 2011-08-25 14:39:28 -0700 Move file internal methods to a class continuation in WKView 457148 1 105248 andersca 2011-08-25 14:39:54 -0700 Created attachment 105248 Patch 457182 2 105248 mitz 2011-08-25 15:28:20 -0700 Comment on attachment 105248 Patch r=me but while this is a neat way to do things in the future, changing existing code to use continuations has almost zero benefit and makes it harder to “svn annotate” source code, so perhaps we shouldn’t do it everywhere. 457186 3 andersca 2011-08-25 15:32:46 -0700 (In reply to comment #2) > (From update of attachment 105248 [details]) > r=me but while this is a neat way to do things in the future, changing existing code to use continuations has almost zero benefit and makes it harder to “svn annotate” source code, so perhaps we shouldn’t do it everywhere. I agree. 457187 4 andersca 2011-08-25 15:33:17 -0700 Committed r93825: <http://trac.webkit.org/changeset/93825> 457232 5 darin 2011-08-25 16:19:52 -0700 Do we still get an error or warning if we omit the method definitions? 457252 6 andersca 2011-08-25 16:34:37 -0700 (In reply to comment #5) > Do we still get an error or warning if we omit the method definitions? Yes. 457563 7 aroben 2011-08-26 08:25:24 -0700 What advantages over categories do class extensions provide? 457564 8 aroben 2011-08-26 08:25:56 -0700 I guess maybe it makes it easier to change a method from being internal to public and vice-versa. You won't have to move the method within the file when doing that. 457598 9 darin 2011-08-26 10:03:03 -0700 The second, smaller advantage is that there’s no spurious “category name” that you have to chose. 105248 2011-08-25 14:39:54 -0700 2011-08-25 15:28:20 -0700 Patch bug-66983-20110825143952.patch text/plain 2651 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzODI0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjUgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGZpbGUgaW50ZXJu YWwgbWV0aG9kcyB0byBhIGNsYXNzIGNvbnRpbnVhdGlvbiBpbiBXS1ZpZXcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2OTgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfZGV2aWNlU2NhbGVGYWN0b3JdKToKKyAgICAg ICAgKC1bV0tWaWV3IF9zZXREcmF3aW5nQXJlYVNpemU6XSk6CisKIDIwMTEtMDgtMjUgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3JlIHdvcmsgb24g dGhlIHVwZGF0ZWQgQ29jb2EgdGV4dCBpbnB1dCBzcGVjaWZpY2F0aW9uCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA5Mzc5MSkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5 KQpAQCAtMTA5LDcgKzEwOSw3IEBAIHN0cnVjdCBXS1ZpZXdJbnRlcnByZXRLZXlFdmVudHNQYXJh bWV0ZXIKICAgICBWZWN0b3I8S2V5cHJlc3NDb21tYW5kPiogY29tbWFuZHM7CiB9OwogCi1AaW50 ZXJmYWNlIFdLVmlldyAoV0tGaWxlSW50ZXJuYWwpCitAaW50ZXJmYWNlIFdLVmlldyAoKQogLSAo ZmxvYXQpX2RldmljZVNjYWxlRmFjdG9yOwogLSAodm9pZClfc2V0RHJhd2luZ0FyZWFTaXplOihO U1NpemUpc2l6ZTsKIEBlbmQKQEAgLTIwMTIsNiArMjAxMiwyOSBAQCAtIChOU1ByaW50T3BlcmF0 aW9uICopcHJpbnRPcGVyYXRpb25XaXRoCiAgICAgfQogfQogCistIChmbG9hdClfZGV2aWNlU2Nh bGVGYWN0b3IKK3sKKyAgICBOU1dpbmRvdyAqd2luZG93ID0gW3NlbGYgd2luZG93XTsKKyNpZiAh ZGVmaW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BBUkQpCisgICAgaWYgKHdpbmRvdykKKyAgICAg ICAgcmV0dXJuIFt3aW5kb3cgYmFja2luZ1NjYWxlRmFjdG9yXTsKKyAgICByZXR1cm4gW1tOU1Nj cmVlbiBtYWluU2NyZWVuXSBiYWNraW5nU2NhbGVGYWN0b3JdOworI2Vsc2UKKyAgICBpZiAod2lu ZG93KQorICAgICAgICByZXR1cm4gW3dpbmRvdyB1c2VyU3BhY2VTY2FsZUZhY3Rvcl07CisgICAg cmV0dXJuIFtbTlNTY3JlZW4gbWFpblNjcmVlbl0gdXNlclNwYWNlU2NhbGVGYWN0b3JdOworI2Vu ZGlmCit9CisKKy0gKHZvaWQpX3NldERyYXdpbmdBcmVhU2l6ZTooTlNTaXplKXNpemUKK3sKKyAg ICBpZiAoIV9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgcmV0dXJuOworICAg IAorICAgIF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKS0+c2V0U2l6ZShJbnRTaXplKHNpemUp LCBJbnRTaXplKF9kYXRhLT5fcmVzaXplU2Nyb2xsT2Zmc2V0KSk7CisgICAgX2RhdGEtPl9yZXNp emVTY3JvbGxPZmZzZXQgPSBOU1plcm9TaXplOworfQorCiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlv biBXS1ZpZXcgKEludGVybmFsKQpAQCAtMjYyMiwzMCArMjY0NSwzIEBAIC0gKEJPT0wpdHJ5VG9Q ZXJmb3JtOihTRUwpYWN0aW9uIHdpdGg6KGkKIH0KIAogQGVuZAotCi1AaW1wbGVtZW50YXRpb24g V0tWaWV3IChXS0ZpbGVJbnRlcm5hbCkKLQotLSAoZmxvYXQpX2RldmljZVNjYWxlRmFjdG9yCi17 Ci0gICAgTlNXaW5kb3cgKndpbmRvdyA9IFtzZWxmIHdpbmRvd107Ci0jaWYgIWRlZmluZWQoQlVJ TERJTkdfT05fU05PV19MRU9QQVJEKQotICAgIGlmICh3aW5kb3cpCi0gICAgICAgIHJldHVybiBb d2luZG93IGJhY2tpbmdTY2FsZUZhY3Rvcl07Ci0gICAgcmV0dXJuIFtbTlNTY3JlZW4gbWFpblNj cmVlbl0gYmFja2luZ1NjYWxlRmFjdG9yXTsKLSNlbHNlCi0gICAgaWYgKHdpbmRvdykKLSAgICAg ICAgcmV0dXJuIFt3aW5kb3cgdXNlclNwYWNlU2NhbGVGYWN0b3JdOwotICAgIHJldHVybiBbW05T U2NyZWVuIG1haW5TY3JlZW5dIHVzZXJTcGFjZVNjYWxlRmFjdG9yXTsKLSNlbmRpZgotfQotCi0t ICh2b2lkKV9zZXREcmF3aW5nQXJlYVNpemU6KE5TU2l6ZSlzaXplCi17Ci0gICAgaWYgKCFfZGF0 YS0+X3BhZ2UtPmRyYXdpbmdBcmVhKCkpCi0gICAgICAgIHJldHVybjsKLSAgICAKLSAgICBfZGF0 YS0+X3BhZ2UtPmRyYXdpbmdBcmVhKCktPnNldFNpemUoSW50U2l6ZShzaXplKSwgSW50U2l6ZShf ZGF0YS0+X3Jlc2l6ZVNjcm9sbE9mZnNldCkpOwotICAgIF9kYXRhLT5fcmVzaXplU2Nyb2xsT2Zm c2V0ID0gTlNaZXJvU2l6ZTsKLX0KLQotQGVuZAo=