66980 2011-08-25 14:28:22 -0700 Remove use of magic number -1 in WebCore/editing/visible_units.cpp 2011-08-25 16:19:43 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 0 vanlam webkit-unassigned rniwa vanlam webkit.review.bot xji oldest_to_newest 457136 0 vanlam 2011-08-25 14:28:22 -0700 Currently two functions greatestOffsetUnder and smallestOffsetAbove return -1 to indicate that the correct word boundary to move to is not found. Should be using a constant to make this more clear. 457141 1 105243 vanlam 2011-08-25 14:31:55 -0700 Created attachment 105243 Patch 457229 2 105243 webkit.review.bot 2011-08-25 16:19:39 -0700 Comment on attachment 105243 Patch Clearing flags on attachment: 105243 Committed r93834: <http://trac.webkit.org/changeset/93834> 457230 3 webkit.review.bot 2011-08-25 16:19:43 -0700 All reviewed patches have been landed. Closing bug. 105243 2011-08-25 14:31:55 -0700 2011-08-25 16:19:38 -0700 Patch vanlam-offsetnotfound text/plain 2894 vanlam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzODI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjUgIFZhbiBMYW0g IDx2YW5sYW1AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgdXNlIG9mIG1hZ2ljIG51bWJl ciAtMSBpbiBXZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2OTgwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZWQgdXNlIG9mIG1hZ2ljIG51 bWJlciAtMSB3aXRoIGNvbnN0YW50IG9mZnNldE5vdEZvdW5kLgorCisgICAgICAgICogZWRpdGlu Zy92aXNpYmxlX3VuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdyZWF0ZXN0T2Zmc2V0VW5k ZXIpOgorICAgICAgICAoV2ViQ29yZTo6c21hbGxlc3RPZmZzZXRBYm92ZSk6CisKIDIwMTEtMDgt MjUgIElnb3IgT2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAg ICAgUm9sbG91dCByOTM3OTk6IENhdXNlZCBiYWQgY2xpcHBpbmcgb24gdGhlIGJvdHRvbSBvZiB0 YWxsIGdseXBocyBpbnNpZGUgYSBidXR0b24gbGFiZWwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvdmlzaWJsZV91bml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRp dGluZy92aXNpYmxlX3VuaXRzLmNwcAkocmV2aXNpb24gOTM4MTIpCisrKyBTb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQ0LDYgKzEx NDQsNyBAQCBWaXNpYmxlUG9zaXRpb24gcmlnaHRCb3VuZGFyeU9mTGluZShjb25zCiB9CiAKIHN0 YXRpYyBjb25zdCBpbnQgaW52YWxpZE9mZnNldCA9IC0xOworc3RhdGljIGNvbnN0IGludCBvZmZz ZXROb3RGb3VuZCA9IC0xOwogCiBzdGF0aWMgYm9vbCBpc0JveFZpc3VhbGx5TGFzdEluTGluZShj b25zdCBJbmxpbmVCb3gqIGJveCwgVGV4dERpcmVjdGlvbiBibG9ja0RpcmVjdGlvbikKIHsKQEAg LTE0MzYsMzkgKzE0MzcsMzkgQEAgc3RhdGljIFZpc2libGVQb3NpdGlvbiB2aXN1YWxseUxhc3RX b3JkQgogc3RhdGljIGludCBncmVhdGVzdE9mZnNldFVuZGVyKGludCBvZmZzZXQsIGJvb2wgYm94 QW5kQmxvY2tBcmVJblNhbWVEaXJlY3Rpb24sIGNvbnN0IFdvcmRCb3VuZGFyeVZlY3RvciYgb3Jk ZXJlZFdvcmRCb3VuZGFyaWVzKQogewogICAgIGlmICghb3JkZXJlZFdvcmRCb3VuZGFyaWVzLnNp emUoKSkKLSAgICAgICAgcmV0dXJuIC0xOworICAgICAgICByZXR1cm4gb2Zmc2V0Tm90Rm91bmQ7 CiAgICAgLy8gRklYTUU6IGJpbmFyeSBzZWFyY2guCiAgICAgaWYgKGJveEFuZEJsb2NrQXJlSW5T YW1lRGlyZWN0aW9uKSB7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBvcmRlcmVk V29yZEJvdW5kYXJpZXMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgICAgIGlmIChvcmRlcmVkV29y ZEJvdW5kYXJpZXNbaV0ub2Zmc2V0SW5JbmxpbmVCb3ggPCBvZmZzZXQpCiAgICAgICAgICAgICAg ICAgcmV0dXJuIGk7CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIC0xOworICAgICAgICByZXR1 cm4gb2Zmc2V0Tm90Rm91bmQ7CiAgICAgfQogICAgIGZvciAoaW50IGkgPSBvcmRlcmVkV29yZEJv dW5kYXJpZXMuc2l6ZSgpIC0gMTsgaSA+PSAwOyAtLWkpIHsKICAgICAgICAgaWYgKG9yZGVyZWRX b3JkQm91bmRhcmllc1tpXS5vZmZzZXRJbklubGluZUJveCA8IG9mZnNldCkKICAgICAgICAgICAg IHJldHVybiBpOwogICAgIH0KLSAgICByZXR1cm4gLTE7CisgICAgcmV0dXJuIG9mZnNldE5vdEZv dW5kOwogfQogCiBzdGF0aWMgaW50IHNtYWxsZXN0T2Zmc2V0QWJvdmUoaW50IG9mZnNldCwgYm9v bCBib3hBbmRCbG9ja0FyZUluU2FtZURpcmVjdGlvbiwgY29uc3QgV29yZEJvdW5kYXJ5VmVjdG9y JiBvcmRlcmVkV29yZEJvdW5kYXJpZXMpCiB7CiAgICAgaWYgKCFvcmRlcmVkV29yZEJvdW5kYXJp ZXMuc2l6ZSgpKQotICAgICAgICByZXR1cm4gLTE7CisgICAgICAgIHJldHVybiBvZmZzZXROb3RG b3VuZDsKICAgICAvLyBGSVhNRTogYmluYXJ5IHNlYXJjaC4KICAgICBpZiAoYm94QW5kQmxvY2tB cmVJblNhbWVEaXJlY3Rpb24pIHsKICAgICAgICAgZm9yIChpbnQgaSA9IG9yZGVyZWRXb3JkQm91 bmRhcmllcy5zaXplKCkgLSAxOyBpID49IDA7IC0taSkgewogICAgICAgICAgICAgaWYgKG9yZGVy ZWRXb3JkQm91bmRhcmllc1tpXS5vZmZzZXRJbklubGluZUJveCA+IG9mZnNldCkKICAgICAgICAg ICAgICAgICByZXR1cm4gaTsKICAgICAgICAgfQotICAgICAgICByZXR1cm4gLTE7CisgICAgICAg IHJldHVybiBvZmZzZXROb3RGb3VuZDsKICAgICB9CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsg aSA8IG9yZGVyZWRXb3JkQm91bmRhcmllcy5zaXplKCk7ICsraSkgewogICAgICAgICBpZiAob3Jk ZXJlZFdvcmRCb3VuZGFyaWVzW2ldLm9mZnNldEluSW5saW5lQm94ID4gb2Zmc2V0KQogICAgICAg ICAgICAgcmV0dXJuIGk7CiAgICAgfQotICAgIHJldHVybiAtMTsKKyAgICByZXR1cm4gb2Zmc2V0 Tm90Rm91bmQ7CiB9CiAKIHN0YXRpYyBjb25zdCBSZW5kZXJCbG9jayogYmxvY2tXaXRoUHJldmlv dXNMaW5lQm94KGNvbnN0IFJlbmRlckJsb2NrKiBzdGFydGluZ0Jsb2NrKQo=