66973 2011-08-25 13:14:28 -0700 WebViewImpl::selectionRange should return range in the right order. 2012-09-12 07:01:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96508 0 varunjain webkit-unassigned fishd husky webkit.review.bot oldest_to_newest 457090 0 varunjain 2011-08-25 13:14:28 -0700 WebViewImpl::selectionRange should return range in the right order. 457091 1 105234 varunjain 2011-08-25 13:15:20 -0700 Created attachment 105234 Patch 457600 2 105234 fishd 2011-08-26 10:03:56 -0700 Comment on attachment 105234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105234&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1566 > + WebPoint tmp = start; nit: use std::swap here? 457604 3 105369 varunjain 2011-08-26 10:14:41 -0700 Created attachment 105369 Patch 457656 4 105369 webkit.review.bot 2011-08-26 11:07:52 -0700 Comment on attachment 105369 Patch Clearing flags on attachment: 105369 Committed r93893: <http://trac.webkit.org/changeset/93893> 457657 5 webkit.review.bot 2011-08-26 11:07:56 -0700 All reviewed patches have been landed. Closing bug. 718316 6 husky 2012-09-12 07:00:22 -0700 Hi Varun, I just discovered that this has a bad interaction on Android with my recent change to WebFrameImpl::selectRange. I've filed a new bug to try to resolve the difference: https://bugs.webkit.org/show_bug.cgi?id=96508 105234 2011-08-25 13:15:20 -0700 2011-08-26 10:14:34 -0700 Patch bug-66973-20110825161455.patch text/plain 2140 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3OTMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBmMmVkY2QzZTAxMmI3MTIwODFiMWI1OWY5OTlmNmUwZTc3YWU5Yzk2Li43ZDM5 OTAwNWVkZGQxOTdhM2RlYTA3ODNiZjEzZTc2MGNmMTg1MDIzIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjUgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJWaWV3SW1wbDo6c2VsZWN0 aW9uUmFuZ2Ugc2hvdWxkIHJldHVybiByYW5nZSBpbiB0aGUgcmlnaHQgb3JkZXIuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njk3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oOgorICAgICAgICAqICBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHA6CisKIDIwMTEtMDgtMjQgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIGJ1bXAgR1N0cmVhbWVy IHJlcXVpcmVtZW50IHRvIDAuMTAuMzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi V2lkZ2V0LmgKaW5kZXggZjZlNzNmMWI0NjQyMWQ2YTRjYzAzM2ZlZTg3MmU2ZDgzYzRkMjkxMS4u MWJjMTkxY2MzNWJmNzY5MDA5MGIwODBmOGJhOTY3YWM0YWUzODkzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTE1Miw3ICsxNTIsOCBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBXZWJSZWN0IGNhcmV0T3JTZWxlY3Rpb25Cb3VuZHMoKSB7IHJldHVybiBX ZWJSZWN0KCk7IH0KIAogICAgIC8vIFJldHVybnMgdGhlIHN0YXJ0IGFuZCBlbmQgcG9pbnQgZm9y IHRoZSBjdXJyZW50IHNlbGVjdGlvbiwgYWxpZ25lZCB0byB0aGUKLSAgICAvLyBib3R0b20gb2Yg dGhlIHNlbGVjdGVkIGxpbmUuCisgICAgLy8gYm90dG9tIG9mIHRoZSBzZWxlY3RlZCBsaW5lLiBz dGFydCBhbmQgZW5kIGFyZSB0aGUgbG9naWNhbCBiZWdpbm5pbmcgYW5kCisgICAgLy8gZW5kaW5n IHBvc2l0aW9ucyBvZiB0aGUgc2VsZWN0aW9uLiBWaXN1YWxseSwgc3RhcnQgbWF5IGxpZSBhZnRl ciBlbmQuCiAgICAgdmlydHVhbCBib29sIHNlbGVjdGlvblJhbmdlKFdlYlBvaW50JiBzdGFydCwg V2ViUG9pbnQmIGVuZCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIC8vIEZldGNoIHRo ZSBjdXJyZW50IHNlbGVjdGlvbiByYW5nZSBvZiB0aGlzIFdlYldpZGdldC4gSWYgdGhlcmUgaXMg bm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA1YWNi MTdhODg2ZDliZThkZWQ0ZjljMTdmNzg1ZGE0NDc5OTkwNTA1Li45ZmViYmI5MjU4ZWE3M2ZlN2Rk ZjJjODU4NGU4MzJjOGJjZTdlMDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCkBAIC0xNTYyLDYgKzE1NjIsMTEgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2Vs ZWN0aW9uUmFuZ2UoV2ViUG9pbnQmIHN0YXJ0LCBXZWJQb2ludCYgZW5kKSBjb25zdAogCiAgICAg c3RhcnQgPSBmcmFtZS0+dmlldygpLT5jb250ZW50c1RvV2luZG93KHN0YXJ0KTsKICAgICBlbmQg PSBmcmFtZS0+dmlldygpLT5jb250ZW50c1RvV2luZG93KGVuZCk7CisgICAgaWYgKCFmcmFtZS0+ c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLmlzQmFzZUZpcnN0KCkpIHsKKyAgICAgICAgV2ViUG9p bnQgdG1wID0gc3RhcnQ7CisgICAgICAgIHN0YXJ0ID0gZW5kOworICAgICAgICBlbmQgPSB0bXA7 CisgICAgfQogICAgIHJldHVybiB0cnVlOwogfQogCg== 105369 2011-08-26 10:14:41 -0700 2011-08-26 11:07:52 -0700 Patch bug-66973-20110826131408.patch text/plain 2089 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3OTMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBmMmVkY2QzZTAxMmI3MTIwODFiMWI1OWY5OTlmNmUwZTc3YWU5Yzk2Li4wNmNm NjgwNDE4ODc1OTI4MzRmMDdkYmI3OTI1YWE4NWQ2MzcxYmUxIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjYgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJWaWV3SW1wbDo6c2VsZWN0 aW9uUmFuZ2Ugc2hvdWxkIHJldHVybiByYW5nZSBpbiB0aGUgcmlnaHQgb3JkZXIuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njk3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oOgorICAgICAgICAqICBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHA6CisKIDIwMTEtMDgtMjQgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIGJ1bXAgR1N0cmVhbWVy IHJlcXVpcmVtZW50IHRvIDAuMTAuMzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi V2lkZ2V0LmgKaW5kZXggZjZlNzNmMWI0NjQyMWQ2YTRjYzAzM2ZlZTg3MmU2ZDgzYzRkMjkxMS4u MWJjMTkxY2MzNWJmNzY5MDA5MGIwODBmOGJhOTY3YWM0YWUzODkzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTE1Miw3ICsxNTIsOCBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBXZWJSZWN0IGNhcmV0T3JTZWxlY3Rpb25Cb3VuZHMoKSB7IHJldHVybiBX ZWJSZWN0KCk7IH0KIAogICAgIC8vIFJldHVybnMgdGhlIHN0YXJ0IGFuZCBlbmQgcG9pbnQgZm9y IHRoZSBjdXJyZW50IHNlbGVjdGlvbiwgYWxpZ25lZCB0byB0aGUKLSAgICAvLyBib3R0b20gb2Yg dGhlIHNlbGVjdGVkIGxpbmUuCisgICAgLy8gYm90dG9tIG9mIHRoZSBzZWxlY3RlZCBsaW5lLiBz dGFydCBhbmQgZW5kIGFyZSB0aGUgbG9naWNhbCBiZWdpbm5pbmcgYW5kCisgICAgLy8gZW5kaW5n IHBvc2l0aW9ucyBvZiB0aGUgc2VsZWN0aW9uLiBWaXN1YWxseSwgc3RhcnQgbWF5IGxpZSBhZnRl ciBlbmQuCiAgICAgdmlydHVhbCBib29sIHNlbGVjdGlvblJhbmdlKFdlYlBvaW50JiBzdGFydCwg V2ViUG9pbnQmIGVuZCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIC8vIEZldGNoIHRo ZSBjdXJyZW50IHNlbGVjdGlvbiByYW5nZSBvZiB0aGlzIFdlYldpZGdldC4gSWYgdGhlcmUgaXMg bm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA1YWNi MTdhODg2ZDliZThkZWQ0ZjljMTdmNzg1ZGE0NDc5OTkwNTA1Li5jZTRiM2YxZWVjOTQzZjRiMmJl OTQ3MmM0NDhiZDE0NWU5YWJlYWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCkBAIC0xNTYyLDYgKzE1NjIsOCBAQCBib29sIFdlYlZpZXdJbXBsOjpzZWxl Y3Rpb25SYW5nZShXZWJQb2ludCYgc3RhcnQsIFdlYlBvaW50JiBlbmQpIGNvbnN0CiAKICAgICBz dGFydCA9IGZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3coc3RhcnQpOwogICAgIGVuZCA9 IGZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3coZW5kKTsKKyAgICBpZiAoIWZyYW1lLT5z ZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkuaXNCYXNlRmlyc3QoKSkKKyAgICAgICAgc3RkOjpzd2Fw KHN0YXJ0LCBlbmQpOwogICAgIHJldHVybiB0cnVlOwogfQogCg==