66962 2011-08-25 11:19:03 -0700 WebCore or WTF RunLoop abstraction 2012-07-11 16:51:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified ASSIGNED P2 Normal --- 1 nduca webkit-unassigned andersca ap dimich enne jamesr jbates levin nduca sam skyul oldest_to_newest 457008 0 nduca 2011-08-25 11:19:03 -0700 WK2 and Chromium both have embedder-specific abstractions for a thread that runs tasks, e.g. - WebKit2/platform/RunLoop.h - WebKit/chromium/public/WebThread.h I'm wondering if we should have a generalized version of these abstractions available in WebCore. Two systems that could be refactored to use this: - WebCore/fileapi/FileThread - WebCore/platform/chromium/CCThread Are there other use cases? Should we actually do this? 457633 1 andersca 2011-08-26 10:45:35 -0700 (In reply to comment #0) > WK2 and Chromium both have embedder-specific abstractions for a thread that runs tasks, e.g. > - WebKit2/platform/RunLoop.h > - WebKit/chromium/public/WebThread.h > > I'm wondering if we should have a generalized version of these abstractions available in WebCore. > > Two systems that could be refactored to use this: > - WebCore/fileapi/FileThread > - WebCore/platform/chromium/CCThread > > Are there other use cases? Should we actually do this? FWIW, the WebKit2 RunLoop class is just a platform abstraction for a system run loop. We also have a WorkQueue class which is a light-weight thread (on OS X it's actually a libdispatch queue) that can run tasks. It would definitely be worth moving them down to either WebCore or even WTF. 457636 2 sam 2011-08-26 10:51:16 -0700 > It would definitely be worth moving them down to either WebCore or even WTF. The tentative plan is to move them to WTF. 457639 3 nduca 2011-08-26 10:52:33 -0700 (In reply to comment #2) > > It would definitely be worth moving them down to either WebCore or even WTF. > > The tentative plan is to move them to WTF. Cool. To ask a dumb question, can you have run loops for things != the main thread in the Wk2 abstraction? 457642 4 andersca 2011-08-26 10:53:35 -0700 (In reply to comment #3) > (In reply to comment #2) > > > It would definitely be worth moving them down to either WebCore or even WTF. > > > > The tentative plan is to move them to WTF. > > > Cool. To ask a dumb question, can you have run loops for things != the main thread in the Wk2 abstraction? Yes, the run loop objects are allocated in thread-specific storage. 457644 5 nduca 2011-08-26 10:55:34 -0700 Awesome. That sounds like a great building block... is there a bug for that that I should merge this into?