66956 2011-08-25 10:37:44 -0700 REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot 2011-08-25 16:08:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 66571 1 ossy webkit-unassigned ggaren j.mont loki oliver ossy webkit.review.bot zherczeg oldest_to_newest 456965 0 ossy 2011-08-25 10:37:44 -0700 Check the results for details: http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Qt%20Release%20%28Test%29/builds/3203 456980 1 oliver 2011-08-25 10:45:24 -0700 Could you include sample failures + stacktraces in these bugs? It's much more useful than a slow loading link, and the given link doesn't include any stacktraces at all thus making it completely useless. I suspect that the cause of these failures would be obvious to any Qt engineer who looked at them 456982 2 ossy 2011-08-25 10:45:52 -0700 Zoltan (our ARM expert) said that he'll check this bug tomorrow morning. 456985 3 oliver 2011-08-25 10:48:44 -0700 (In reply to comment #2) > Zoltan (our ARM expert) said that he'll check this bug tomorrow morning. This should be trivial -- the problem is that the Qt bot isn't providing console output. The problem is almost certainly going to be that the size of one of the getById insn sequences has changed and the constant just needs to be updated appropriately, the assertions for these branches even tell you what the new size should be. 457049 4 105230 loki 2011-08-25 12:12:25 -0700 Created attachment 105230 Rebaseline constants for patching GetByIdSlowCaseCall on ARM A quick fix for r93755 457084 5 105230 oliver 2011-08-25 13:12:11 -0700 Comment on attachment 105230 Rebaseline constants for patching GetByIdSlowCaseCall on ARM r=me! 457214 6 105230 webkit.review.bot 2011-08-25 16:08:26 -0700 Comment on attachment 105230 Rebaseline constants for patching GetByIdSlowCaseCall on ARM Clearing flags on attachment: 105230 Committed r93832: <http://trac.webkit.org/changeset/93832> 457215 7 webkit.review.bot 2011-08-25 16:08:30 -0700 All reviewed patches have been landed. Closing bug. 105230 2011-08-25 12:12:25 -0700 2011-08-25 16:08:26 -0700 Rebaseline constants for patching GetByIdSlowCaseCall on ARM 0001-2011-08-25-Gabor-Loki-loki-webkit.org.patch text/plain 2287 loki RnJvbSA3YThmMzAzNDUwMjBhZTkwNWJlMWQ0M2Y3ZGM4NTVhMGIwNjAzM2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQHdlYmtpdC5vcmc+CkRhdGU6IFRo dSwgMjUgQXVnIDIwMTEgMjE6MDc6NTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDExLTA4LTI1 ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgoKICAgICAgICBSRUdSRVNTSU9OKHI5Mzc1 NSk6IEl0IG1hZGUgMTQganNjIHRlc3QgYW5kIH41MDAgbGF5b3V0IHRlc3QgZmFpbCBvbiBRdC1B Uk0gYm90CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2 OTU2CgogICAgICAgIFJlYmFzZWxpbmUgY29uc3RhbnRzIGZvciBwYXRjaGluZyBHZXRCeUlkU2xv d0Nhc2VDYWxsIG9uIEFSTS4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgICogaml0L0pJVC5oOgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg fCAgIDExICsrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oIHwgICAg NCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMjliZmNkOC4uNGVkZDRhZSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjUgIEdhYm9yIExva2kg IDxsb2tpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTM3NTUpOiBJdCBtYWRl IDE0IGpzYyB0ZXN0IGFuZCB+NTAwIGxheW91dCB0ZXN0IGZhaWwgb24gUXQtQVJNIGJvdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY5NTYKKworICAg ICAgICBSZWJhc2VsaW5lIGNvbnN0YW50cyBmb3IgcGF0Y2hpbmcgR2V0QnlJZFNsb3dDYXNlQ2Fs bCBvbiBBUk0uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBqaXQvSklULmg6CisKIDIwMTEtMDgtMjQgIEp1YW4gQy4gTW9udGVtYXlvciAgPGptb250 QGFwcGxlLmNvbT4KIAogICAgICAgICBLZWVwIHRyYWNrIG9mIHRvcENhbGxGcmFtZSBmb3IgU3Rh Y2sgdHJhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaAppbmRleCA1NGZiZjA2Li4zNDY3YTc5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklULmgKQEAgLTM5MSw3ICszOTEsNyBAQCBuYW1lc3BhY2UgSlND IHsKICNpZiBFTkFCTEUoT1BDT0RFX1NBTVBMSU5HKQogICAgICAgICAjZXJyb3IgIk9QQ09ERV9T QU1QTElORyBpcyBub3QgeWV0IHN1cHBvcnRlZCIKICNlbHNlCi0gICAgICAgIHN0YXRpYyBjb25z dCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xvd0Nhc2VDYWxsID0gMzI7CisgICAgICAgIHN0YXRp YyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xvd0Nhc2VDYWxsID0gNDA7CiAjZW5kaWYK ICAgICAgICAgc3RhdGljIGNvbnN0IGludCBwYXRjaE9mZnNldE9wQ2FsbENvbXBhcmVUb0p1bXAg PSAxMjsKIApAQCAtNDEwLDcgKzQxMCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBzdGF0 aWMgY29uc3QgaW50IHNlcXVlbmNlR2V0QnlJZEhvdFBhdGhDb25zdGFudFNwYWNlID0gNDsKICAg ICAgICAgLy8gc2VxdWVuY2VHZXRCeUlkU2xvd0Nhc2UKICAgICAgICAgc3RhdGljIGNvbnN0IGlu dCBzZXF1ZW5jZUdldEJ5SWRTbG93Q2FzZUluc3RydWN0aW9uU3BhY2UgPSA1NjsKLSAgICAgICAg c3RhdGljIGNvbnN0IGludCBzZXF1ZW5jZUdldEJ5SWRTbG93Q2FzZUNvbnN0YW50U3BhY2UgPSAy OworICAgICAgICBzdGF0aWMgY29uc3QgaW50IHNlcXVlbmNlR2V0QnlJZFNsb3dDYXNlQ29uc3Rh bnRTcGFjZSA9IDM7CiAgICAgICAgIC8vIHNlcXVlbmNlUHV0QnlJZAogICAgICAgICBzdGF0aWMg Y29uc3QgaW50IHNlcXVlbmNlUHV0QnlJZEluc3RydWN0aW9uU3BhY2UgPSAzNjsKICAgICAgICAg c3RhdGljIGNvbnN0IGludCBzZXF1ZW5jZVB1dEJ5SWRDb25zdGFudFNwYWNlID0gNDsKLS0gCjEu Ny40LjEKCg==