66951 2011-08-25 09:45:54 -0700 [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch 2011-08-25 16:07:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P4 Normal --- 1 ostap73 webkit-unassigned webkit.review.bot oldest_to_newest 456920 0 ostap73 2011-08-25 09:45:54 -0700 BrowserView::resizeEvent set width and height one by one. m_item->setWidth in BrowserView::resizeEvent() cause QTouchWebView::geometryChanged() which calls QTouchWebViewPrivate::updateViewportConstraints() and computeViewportAttributes while height is still 0 . 456931 1 105203 ostap73 2011-08-25 09:56:55 -0700 Created attachment 105203 Replace setWidth/setHeight with setSize. 457211 2 105203 webkit.review.bot 2011-08-25 16:06:59 -0700 Comment on attachment 105203 Replace setWidth/setHeight with setSize. Clearing flags on attachment: 105203 Committed r93831: <http://trac.webkit.org/changeset/93831> 457212 3 webkit.review.bot 2011-08-25 16:07:03 -0700 All reviewed patches have been landed. Closing bug. 105203 2011-08-25 09:56:55 -0700 2011-08-25 16:06:59 -0700 Replace setWidth/setHeight with setSize. minibrowser_setsize_fix_01.diff text/plain 1324 ostap73 ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNWNm MTY5Li40Nzc2OTYyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjUgIFZpYXRjaGVzbGF2IE9zdGFwZW5r byAgPG9zdGFwZW5rby52aWF0Y2hlc2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0sy XSBBc3NlcnQgaW4gY29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlcyB3aGVuIE1pbmlCcm93c2VyIHN0 YXJ0ZWQgd2l0aCAtdG91Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY2OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRnVuY3Rpb24gY29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlcygpIGdldHMgY2FsbGVk IHdoZW4gaGVpZ2h0IGlzIHN0aWxsIDAgYmVjYXVzZSBNaW5pQnJvd3NlciBzZXRzCisgICAgICAg IHdpZHRoIGFuZCBoZWlnaHQgb25lIGJ5IG9uZSBhbmQgc2V0V2lkdGggY2F1c2UgZ2VvbWV0cnlD aGFuZ2UgZXZlbnQgaW4gUVRvdWNoV2ViVmlldy4gCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9x dC9Ccm93c2VyVmlldy5jcHA6CisgICAgICAgIChCcm93c2VyVmlldzo6cmVzaXplRXZlbnQpOgor CiAyMDExLTA4LTI1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTM3NjcuCmRpZmYgLS1naXQgYS9U b29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyVmlldy5jcHAKaW5kZXggODA4NTA2Mi4uOTMxM2VjOCAxMDA2NDQKLS0tIGEvVG9v bHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2Vy L3F0L0Jyb3dzZXJWaWV3LmNwcApAQCAtNTcsOCArNTcsNyBAQCB2b2lkIEJyb3dzZXJWaWV3Ojpy ZXNpemVFdmVudChRUmVzaXplRXZlbnQqIGV2ZW50KQogICAgIFFTR0NhbnZhczo6cmVzaXplRXZl bnQoZXZlbnQpOwogICAgIG1faXRlbS0+c2V0WCgwKTsKICAgICBtX2l0ZW0tPnNldFkoMCk7Ci0g ICAgbV9pdGVtLT5zZXRXaWR0aChldmVudC0+c2l6ZSgpLndpZHRoKCkpOwotICAgIG1faXRlbS0+ c2V0SGVpZ2h0KGV2ZW50LT5zaXplKCkuaGVpZ2h0KCkpOworICAgIG1faXRlbS0+c2V0U2l6ZShl dmVudC0+c2l6ZSgpKTsKIH0KIAogdm9pZCBCcm93c2VyVmlldzo6bG9hZChjb25zdCBRU3RyaW5n JiB1cmxTdHJpbmcpCg==