66942 2011-08-25 07:48:44 -0700 [SKIA] Move forward decl of skia type outside namespace Webkit 2011-08-25 09:14:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon senorblanco webkit.review.bot oldest_to_newest 456854 0 bsalomon 2011-08-25 07:48:44 -0700 [SKIA] Move forward decl of skia type outside namespace Webkit 456855 1 105191 bsalomon 2011-08-25 07:49:32 -0700 Created attachment 105191 Patch 456856 2 bsalomon 2011-08-25 07:54:28 -0700 D'oh! I didn't notice that I was adding the forward decl inside of a namespace in my original patch. 456857 3 105191 senorblanco 2011-08-25 07:57:19 -0700 Comment on attachment 105191 Patch Looks good. r=me Did this cause a build failure? Or just that it would have in the future? 456858 4 bsalomon 2011-08-25 08:01:48 -0700 There was no build failure. If left as is it would have caused the subclass implementations of grGLInterface() to have to cast from GrGLInterface* to the bogus WebKit::GrGLInterface* type. 456900 5 105191 webkit.review.bot 2011-08-25 09:14:34 -0700 Comment on attachment 105191 Patch Clearing flags on attachment: 105191 Committed r93791: <http://trac.webkit.org/changeset/93791> 456901 6 webkit.review.bot 2011-08-25 09:14:37 -0700 All reviewed patches have been landed. Closing bug. 105191 2011-08-25 07:49:32 -0700 2011-08-25 09:14:33 -0700 Patch bug-66942-20110825104931.patch text/plain 1412 bsalomon SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5Mzc4MikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDgtMjUgIEJyaWFuIFNhbG9tb24gIDxic2Fsb21vbkBnb29nbGUuY29tPgorCisg ICAgICAgIFtTS0lBXSBNb3ZlIGZvcndhcmQgZGVjbCBvZiBza2lhIHR5cGUgb3V0c2lkZSBuYW1l c3BhY2UgV2Via2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02Njk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDgtMjUgIE1pa2hh aWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaHJvbWl1bTog ZXhwb3NlIE1lbW9yeUNhY2hlOjpwcnVuZSBhbmQgRm9udENhY2hlOjpwdXJnZUluYWN0aXZlRm9u dERhdGEuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0Nv bnRleHQzRC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkdyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDkzNzgxKQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAt MzcsNiArMzcsMTAgQEAKIAogI2RlZmluZSBVU0VfV0dDM0RfVFlQRVMKIAorI2lmIFdFQktJVF9V U0lOR19TS0lBCitzdHJ1Y3QgR3JHTEludGVyZmFjZTsKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2Vi S2l0IHsKIAogLy8gV0dDM0QgdHlwZXMgbWF0Y2ggdGhlIGNvcnJlc3BvbmRpbmcgR0wgdHlwZXMg YXMgZGVmaW5lZCBpbiBPcGVuR0wgRVMgMi4wCkBAIC02MCwxMCArNjQsNiBAQCB0eXBlZGVmIHNp Z25lZCBsb25nIGludCBXR0MzRHNpemVpcHRyOwogLy8gVHlwZWRlZiBmb3Igc2VydmVyLXNpZGUg b2JqZWN0cyBsaWtlIE9wZW5HTCB0ZXh0dXJlcyBhbmQgcHJvZ3JhbSBvYmplY3RzLgogdHlwZWRl ZiBXR0MzRHVpbnQgV2ViR0xJZDsKIAotI2lmIFdFQktJVF9VU0lOR19TS0lBCi1zdHJ1Y3QgR3JH TEludGVyZmFjZTsKLSNlbmRpZgotCiBjbGFzcyBXZWJWaWV3OwogCiAvLyBUaGlzIGludGVyZmFj ZSBhYnN0cmFjdHMgdGhlIG9wZXJhdGlvbnMgcGVyZm9ybWVkIGJ5IHRoZQo=