66927 2011-08-25 03:05:41 -0700 [EFL] Add missing API documentation. 2011-08-29 18:29:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco tkent webkit.review.bot oldest_to_newest 456735 0 g.czajkowski 2011-08-25 03:05:41 -0700 Adds missing documentation for ewk_context_menu_item_checked_get/set. Moves API documentation from cpp to the headers. Adds brief and file commands for ewk_js.h. 456737 1 105154 g.czajkowski 2011-08-25 03:06:51 -0700 Created attachment 105154 proposed patch 456739 2 gyuyoung.kim 2011-08-25 03:07:44 -0700 LGTM. 456805 3 rakuco 2011-08-25 06:14:27 -0700 Informal r+. 458151 4 gyuyoung.kim 2011-08-29 03:03:58 -0700 CC'ing kent, could you please review this patch? 458603 5 105154 tkent 2011-08-29 17:49:19 -0700 Comment on attachment 105154 proposed patch rubber stamped. 458625 6 105154 webkit.review.bot 2011-08-29 18:29:04 -0700 Comment on attachment 105154 proposed patch Clearing flags on attachment: 105154 Committed r94034: <http://trac.webkit.org/changeset/94034> 458626 7 webkit.review.bot 2011-08-29 18:29:09 -0700 All reviewed patches have been landed. Closing bug. 105154 2011-08-25 03:06:51 -0700 2011-08-29 18:29:04 -0700 proposed patch missing_doc.patch text/plain 6070 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4OThhMjQ0Li4wMjlkMWU1IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMjQgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIG1pc3NpbmcgQVBJIGRvY3Vt ZW50YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NjkyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgbWlzc2luZyBkb2N1bWVudGF0aW9uIGZvciBld2tfY29udGV4dF9tZW51X2l0ZW1fY2hl Y2tlZF9nZXQvc2V0LgorICAgICAgICBNb3ZlcyBBUEkgZG9jdW1lbnRhdGlvbiBmcm9tIGNwcCB0 byB0aGUgaGVhZGVycy4KKyAgICAgICAgQWRkcyBicmllZiBhbmQgZmlsZSBjb21tYW5kcyBmb3Ig ZXdrX2pzLmguCisKKyAgICAgICAgKiBld2svZXdrX2NvbnRleHRtZW51Lmg6CisgICAgICAgICog ZXdrL2V3a19jb29raWVzLmNwcDoKKyAgICAgICAgKiBld2svZXdrX2Nvb2tpZXMuaDoKKyAgICAg ICAgKiBld2svZXdrX2ZyYW1lLmNwcDoKKyAgICAgICAgKiBld2svZXdrX2ZyYW1lLmg6CisgICAg ICAgICogZXdrL2V3a19qcy5oOgorCiAyMDExLTA4LTIzICBLd2FuZ0h5dWsgS2ltICA8aHl1a2ku a2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIENoYW5nZSBwYXJhbWV0ZXIgdHlwZSBm b3Igc29tZSBBUElzIGluIGV3a190aWxlX21hdHJpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf Y29udGV4dG1lbnUuaAppbmRleCBjZjBlOWI3Li4wZjc2YWE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19jb250ZXh0bWVudS5oCkBAIC0xOTIsNyArMTkyLDcgQEAgRUFQSSBjb25zdCBFaW5h X0xpc3QgICAgICAgICAgICAqZXdrX2NvbnRleHRfbWVudV9pdGVtX2xpc3RfZ2V0KEV3a19Db250 ZXh0X01lbnUKICAqIEBwYXJhbSBhY3Rpb24gc3BlY2lmaWVzIGEgYWN0aW9uIG9mIHRoZSBpdGVt CiAgKiBAcGFyYW0gc3VibWVudSBzcGVjaWZpZXMgYSBzdWJtZW51IG9mIHRoZSBpdGVtCiAgKiBA cGFyYW0gdGl0bGUgc3BlY2lmaWVzIGEgdGl0bGUgb2YgdGhlIGl0ZW0KLSAqIEBwYXJhbSBjaGVj a2VkCisgKiBAcGFyYW0gY2hlY2tlZCBAYyBFSU5BX1RSVUUgaWYgdGhlIGl0ZW0gc2hvdWxkIGJl IHRvZ2dsZWQgb3IgQGMgRUlOQV9GQUxTRSBpZiBub3QKICAqIEBwYXJhbSBlbmFibGVkIEBjIEVJ TkFfVFJVRSB0byBlbmFibGUgdGhlIGl0ZW0gb3IgQGMgRUlOQV9GQUxTRSB0byBkaXNhYmxlCiAg KiBAcmV0dXJuIHRoZSBwb2ludGVyIHRvIHRoZSBuZXcgaXRlbSBvbiBzdWNjZXNzIG9yIEBjIDAg b24gZmFpbHVyZQogICoKQEAgLTI4Miw3ICsyODIsMjEgQEAgRUFQSSBjb25zdCBjaGFyICAgICAg ICAgICAgICAgICAqZXdrX2NvbnRleHRfbWVudV9pdGVtX3RpdGxlX2dldChFd2tfQ29udGV4dF9N ZW4KICAqLwogRUFQSSBjb25zdCBjaGFyICAgICAgICAgICAgICAgICAqZXdrX2NvbnRleHRfbWVu dV9pdGVtX3RpdGxlX3NldChFd2tfQ29udGV4dF9NZW51X0l0ZW0gKm8sIGNvbnN0IGNoYXIgKnRp dGxlKTsKIAorLyoqCisgKiBRdWVyaWVzIGlmIHRoZSBpdGVtIGlzIHRvZ2dsZWQuCisgKgorICog QHBhcmFtIG8gdGhlIGl0ZW0gdG8gcXVlcnkgaWYgdGhlIGl0ZW0gaXMgdG9nZ2xlZAorICogQHJl dHVybiBAYyBFSU5BX1RSVUUgaWYgdGhlIGl0ZW0gaXMgdG9nZ2xlZCBvciBAYyBFSU5BX0ZBTFNF IGlmIG5vdCBvciBvbiBmYWlsdXJlCisgKi8KIEVBUEkgRWluYV9Cb29sICAgICAgICAgICAgICAg ICAgIGV3a19jb250ZXh0X21lbnVfaXRlbV9jaGVja2VkX2dldChFd2tfQ29udGV4dF9NZW51X0l0 ZW0gKm8pOworCisvKioKKyAqIFNldHMgaWYgdGhlIGl0ZW0gc2hvdWxkIGJlIHRvZ2dsZWQuCisg KgorICogQHBhcmFtIG8gdGhlIGl0ZW0gdG8gYmUgdG9nZ2xlZAorICogQHBhcmFtIGNoZWNrZWQg QGMgRUlOQV9UUlVFIGlmIHRoZSBpdGVtIHNob3VsZCBiZSB0b2dnbGVkIG9yIEBjIEVJTkFfRkFM U0UgaWYgbm90CisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzIG9yIEBjIEVJTkFf RkFMU0Ugb24gZmFpbHVyZQorICovCiBFQVBJIEVpbmFfQm9vbCAgICAgICAgICAgICAgICAgICBl d2tfY29udGV4dF9tZW51X2l0ZW1fY2hlY2tlZF9zZXQoRXdrX0NvbnRleHRfTWVudV9JdGVtICpv LCBFaW5hX0Jvb2wgY2hlY2tlZCk7CiAKIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19jb29raWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29va2ll cy5jcHAKaW5kZXggZWU0NDhhOC4uNzlkNTUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19jb29raWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nv b2tpZXMuY3BwCkBAIC0xNjUsMTIgKzE2NSw2IEBAIHZvaWQgZXdrX2Nvb2tpZXNfcG9saWN5X3Nl dChFd2tfQ29va2llX1BvbGljeSBwKQogI2VuZGlmCiB9CiAKLS8qKgotICogR2V0cyB0aGUgYWNj ZXB0YW5jZSBwb2xpY3kgdXNlZCBpbiB0aGUgY3VycmVudCBjb29raWUgamFyLgotICoKLSAqIEBy ZXR1cm4gdGhlIGN1cnJlbnQgYWNjZXB0YW5jZSBwb2xpY3kKLSAqIEBzZWUgRXdrX0Nvb2tpZV9Q b2xpY3kKLSAqLwogRXdrX0Nvb2tpZV9Qb2xpY3kgZXdrX2Nvb2tpZXNfcG9saWN5X2dldCh2b2lk KQogewogICAgIEV3a19Db29raWVfUG9saWN5IGV3a19wb2xpY3kgPSBFV0tfQ09PS0lFX0pBUl9B Q0NFUFRfQUxXQVlTOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb29r aWVzLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuaAppbmRleCAyODc1ZTBl Li5hY2QxNTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuaApAQCAtMTIyLDYgKzEy MiwxMyBAQCBFQVBJIHZvaWQgICAgICAgICAgICAgICBld2tfY29va2llc19jb29raWVfZnJlZShF d2tfQ29va2llICpjb29raWUpOwogICogQHNlZSBFd2tfQ29va2llX1BvbGljeQogICovCiBFQVBJ IHZvaWQgICAgICAgICAgICAgICBld2tfY29va2llc19wb2xpY3lfc2V0KEV3a19Db29raWVfUG9s aWN5IHApOworCisvKioKKyAqIEdldHMgdGhlIGFjY2VwdGFuY2UgcG9saWN5IHVzZWQgaW4gdGhl IGN1cnJlbnQgY29va2llIGphci4KKyAqCisgKiBAcmV0dXJuIHRoZSBjdXJyZW50IGFjY2VwdGFu Y2UgcG9saWN5CisgKiBAc2VlIEV3a19Db29raWVfUG9saWN5CisgKi8KIEVBUEkgRXdrX0Nvb2tp ZV9Qb2xpY3kgIGV3a19jb29raWVzX3BvbGljeV9nZXQodm9pZCk7CiAKICNpZmRlZiBfX2NwbHVz cGx1cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAppbmRleCA5MWYyMjM3Li5iYmEwY2Y5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcApAQCAtNDk0LDE0ICs0OTQsNiBAQCBF aW5hX0Jvb2wgZXdrX2ZyYW1lX3RleHRfbWF0Y2hlc191bm1hcmtfYWxsKEV2YXNfT2JqZWN0ICpv KQogICAgIHJldHVybiBFSU5BX1RSVUU7CiB9CiAKLS8qKgotICogU2V0cyB3aGV0aGVyIG1hdGNo ZXMgbWFya2VkIHdpdGggZXdrX2ZyYW1lX3RleHRfbWF0Y2hlc19tYXJrKCkgc2hvdWxkIGJlIGhp Z2hsaWdodGVkLgotICoKLSAqIEBwYXJhbSBvIGZyYW1lIG9iamVjdCB3aGVyZSB0byBzZXQgaWYg bWF0Y2hlcyBhcmUgaGlnaGxpZ2h0ZWQgb3Igbm90Ci0gKiBAcGFyYW0gaGlnaGxpZ2h0IEBjIEVJ TkFfVFJVRSBpZiBtYXRjaGVzIGFyZSBoaWdobGlnaHRlZCwgQGMgRUlOQV9GQUxTRSBpZiBub3QK LSAqCi0gKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzLCBAYyBFSU5BX0ZBTFNFIG9u IGZhaWx1cmUKLSAqLwogRWluYV9Cb29sIGV3a19mcmFtZV90ZXh0X21hdGNoZXNfaGlnaGxpZ2h0 X3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb29sIGhpZ2hsaWdodCkKIHsKICAgICBFV0tfRlJB TUVfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X2ZyYW1lLmgKaW5kZXggYTM1Njc3Yi4uMmQ5YWU1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a19mcmFtZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJh bWUuaApAQCAtMzgxLDcgKzM4MSw2IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a19mcmFtZV90ZXh0 X3NlYXJjaChjb25zdCBFdmFzX09iamVjdCAqbywgY29uc3QgY2hhciAqc3RyaW5nCiAgKiBAcmV0 dXJuIG51bWJlciBvZiBtYXRjaGVkIEBhIHN0cmluZwogICovCiBFQVBJIHVuc2lnbmVkIGludCBl d2tfZnJhbWVfdGV4dF9tYXRjaGVzX21hcmsoRXZhc19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKnN0 cmluZywgRWluYV9Cb29sIGNhc2Vfc2Vuc2l0aXZlLCBFaW5hX0Jvb2wgaGlnaGxpZ2h0LCB1bnNp Z25lZCBpbnQgbGltaXQpOwotRUFQSSBFaW5hX0Jvb2wgICAgZXdrX2ZyYW1lX3RleHRfbWF0Y2hl c191bm1hcmtfYWxsKEV2YXNfT2JqZWN0ICpvKTsKIAogLyoqCiAgKiBVbm1hcmtzIGFsbCBtYXJr ZWQgbWF0Y2hlcyBpbiBhIGRvY3VtZW50LgpAQCAtMzkxLDYgKzM5MCwxNiBAQCBFQVBJIEVpbmFf Qm9vbCAgICBld2tfZnJhbWVfdGV4dF9tYXRjaGVzX3VubWFya19hbGwoRXZhc19PYmplY3QgKm8p OwogICoKICAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIG9uIHN1Y2Nlc3MsIEBjIEVJTkFfRkFMU0Ug b24gZmFpbHVyZQogICovCitFQVBJIEVpbmFfQm9vbCAgICBld2tfZnJhbWVfdGV4dF9tYXRjaGVz X3VubWFya19hbGwoRXZhc19PYmplY3QgKm8pOworCisvKioKKyAqIFNldHMgd2hldGhlciBtYXRj aGVzIG1hcmtlZCB3aXRoIGV3a19mcmFtZV90ZXh0X21hdGNoZXNfbWFyaygpIHNob3VsZCBiZSBo aWdobGlnaHRlZC4KKyAqCisgKiBAcGFyYW0gbyBmcmFtZSBvYmplY3Qgd2hlcmUgdG8gc2V0IGlm IG1hdGNoZXMgYXJlIGhpZ2hsaWdodGVkIG9yIG5vdAorICogQHBhcmFtIGhpZ2hsaWdodCBAYyBF SU5BX1RSVUUgaWYgbWF0Y2hlcyBhcmUgaGlnaGxpZ2h0ZWQsIEBjIEVJTkFfRkFMU0UgaWYgbm90 CisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2VzcywgQGMgRUlOQV9GQUxTRSBv biBmYWlsdXJlCisgKi8KIEVBUEkgRWluYV9Cb29sICAgIGV3a19mcmFtZV90ZXh0X21hdGNoZXNf aGlnaGxpZ2h0X3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb29sIGhpZ2hsaWdodCk7CiAKIC8q KgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19qcy5oIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19qcy5oCmluZGV4IGMwZWEwMTguLjczMzFkYTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfanMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX2pzLmgKQEAgLTE3LDYgKzE3LDExIEBACiAgICAgQm9zdG9uLCBNQSAwMjExMC0xMzAx LCBVU0EuCiAqLwogCisvKioKKyAqIEBmaWxlICAgIGV3a19qcy5oCisgKiBAYnJpZWYgICBBbGxv d3MgdG8gZXhwb3J0IG9iamVjdHMgdG8gSmF2YVNjcmlwdCBBUEkuCisgKi8KKwogI2lmbmRlZiBl d2tfanNfaAogI2RlZmluZSBld2tfanNfaAogCg==