66917 2011-08-24 18:23:50 -0700 [chromium] TextureManager overestimates the size of non-RGBA texture formats 2011-09-01 16:03:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne dglazkov enne jamesr nduca vangelis webkit.review.bot oldest_to_newest 456590 0 enne 2011-08-24 18:23:50 -0700 Currently, the TextureManager estimates everything as being 4bpp. (See the FIXME in memoryUseBytes in TextureManager.cpp.) This should consider the format when calculating the size. 460024 1 105851 enne 2011-08-31 16:11:51 -0700 Created attachment 105851 Patch 460131 2 105851 webkit.review.bot 2011-08-31 18:15:29 -0700 Comment on attachment 105851 Patch Attachment 105851 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9578161 New failing tests: http/tests/loading/empty-urls.html 460219 3 105851 vangelis 2011-08-31 22:28:20 -0700 Comment on attachment 105851 Patch This looks good. I'm curious though, what textures that the texture manager deals with are not 4bpp ? 460519 4 enne 2011-09-01 09:35:12 -0700 (In reply to comment #3) > (From update of attachment 105851 [details]) > This looks good. I'm curious though, what textures that the texture manager deals with are not 4bpp ? I recently changed VideoLayerChromium to reserve textures via the texture manager, and that can use luminance textures. 460527 5 105851 jamesr 2011-09-01 09:47:22 -0700 Comment on attachment 105851 Patch R=me 460873 6 enne 2011-09-01 16:03:01 -0700 Committed r94356: <http://trac.webkit.org/changeset/94356> 105851 2011-08-31 16:11:51 -0700 2011-09-01 09:47:22 -0700 Patch bug-66917-20110831161150.patch text/plain 4283 enne U3VidmVyc2lvbiBSZXZpc2lvbjogOTQyNDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NjVhY2VkMDE0OTlhMGQ0 N2RhYjMzNzdmZmU2NzlhOTU5MmNmN2MxLi5lZTY2NzNiZGM5M2MzMTRhYzQ4NGRiM2QyMDNmMGYw NDM5NTBhNWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMzEgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFRleHR1 cmVNYW5hZ2VyIG92ZXJlc3RpbWF0ZXMgdGhlIHNpemUgb2Ygbm9uLVJHQkEgdGV4dHVyZSBmb3Jt YXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njkx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBH cmFwaGljc0NvbnRleHQzRCB0byBkZXRlcm1pbmUgdGhlIHNpemUgb2YgYSBnaXZlbiB0ZXh0dXJl IGZvcm1hdC4KKyAgICAgICAgQWxzbywgbWFrZSBUZXh0dXJlTWFuYWdlciB1c2UgbW9yZSBHcmFw aGljc0NvbnRleHQzRCB0eXBlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzQ29udGV4dDNELmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4 dHVyZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bWVtb3J5VXNlQnl0ZXMpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmg6CisKIDIw MTEtMDgtMzEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NDExNi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IDQ2YjVh NmJiODNhZTQwYjY5OTQ2YmUzNzc4M2RjNTEzYTkyNGEwZmMuLjFiM2ViNzk2NjU2MmYzNGZmYjk4 ZWNkNDY4MzBjOWEwZmRiZWIyYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtNTIxLDEwICs1MjEsMTAgQEAgcHVi bGljOgogICAgIC8vIENvbXB1dGVzIHRoZSBjb21wb25lbnRzIHBlciBwaXhlbCBhbmQgYnl0ZXMg cGVyIGNvbXBvbmVudAogICAgIC8vIGZvciB0aGUgZ2l2ZW4gZm9ybWF0IGFuZCB0eXBlIGNvbWJp bmF0aW9uLiBSZXR1cm5zIGZhbHNlIGlmCiAgICAgLy8gZWl0aGVyIHdhcyBhbiBpbnZhbGlkIGVu dW0uCi0gICAgYm9vbCBjb21wdXRlRm9ybWF0QW5kVHlwZVBhcmFtZXRlcnMoR0MzRGVudW0gZm9y bWF0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDM0RlbnVtIHR5 cGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50 KiBjb21wb25lbnRzUGVyUGl4ZWwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgaW50KiBieXRlc1BlckNvbXBvbmVudCk7CisgICAgc3RhdGljIGJvb2wg Y29tcHV0ZUZvcm1hdEFuZFR5cGVQYXJhbWV0ZXJzKEdDM0RlbnVtIGZvcm1hdCwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0MzRGVudW0gdHlwZSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50 KiBjb21wb25lbnRzUGVyUGl4ZWwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCogYnl0ZXNQZXJDb21wb25lbnQpOwogCiAgICAgLy8g Q29tcHV0ZXMgdGhlIGltYWdlIHNpemUgaW4gYnl0ZXMuIElmIHBhZGRpbmdJbkJ5dGVzIGlzIG5v dCBudWxsLCBwYWRkaW5nCiAgICAgLy8gaXMgYWxzbyBjYWxjdWxhdGVkIGluIHJldHVybi4gUmV0 dXJucyBOT19FUlJPUiBpZiBzdWNjZWVkLCBvdGhlcndpc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmNw cAppbmRleCAwYjM5ZjQ0NTBmNmU4MjdjZWU1NmI4MjZhYjE2Yzk1ZTIwNGU3YjM4Li44ZmEwNjUx Yjk4NWU5ZjljNDlkZmIzNTU2MDgxN2M2MjkzYTZjMzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIu Y3BwCkBAIC0zMiwxMCArMzIsMTYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0aWMg c2l6ZV90IG1lbW9yeVVzZUJ5dGVzKEludFNpemUgc2l6ZSwgdW5zaWduZWQgdGV4dHVyZUZvcm1h dCkKK3N0YXRpYyBzaXplX3QgbWVtb3J5VXNlQnl0ZXMoSW50U2l6ZSBzaXplLCBHQzNEZW51bSB0 ZXh0dXJlRm9ybWF0KQogewotICAgIC8vIEZJWE1FOiBUaGlzIGFzc3VtZXMgYWxsIHRleHR1cmVz IGFyZSA0IGJ5dGVzL3BpeGVsLCBsaWtlIFJHQkEuCi0gICAgcmV0dXJuIHNpemUud2lkdGgoKSAq IHNpemUuaGVpZ2h0KCkgKiA0OworICAgIC8vIEZJWE1FOiBUaGlzIGFzc3VtZXMgYWxsIHRleHR1 cmVzIGFyZSAxIGJ5dGUvY29tcG9uZW50LgorICAgIGNvbnN0IEdDM0RlbnVtIHR5cGUgPSBHcmFw aGljc0NvbnRleHQzRDo6VU5TSUdORURfQllURTsKKyAgICB1bnNpZ25lZCBpbnQgY29tcG9uZW50 c1BlclBpeGVsID0gNDsKKyAgICB1bnNpZ25lZCBpbnQgYnl0ZXNQZXJDb21wb25lbnQgPSAxOwor ICAgIGlmICghR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXB1dGVGb3JtYXRBbmRUeXBlUGFyYW1ldGVy cyh0ZXh0dXJlRm9ybWF0LCB0eXBlLCAmY29tcG9uZW50c1BlclBpeGVsLCAmYnl0ZXNQZXJDb21w b25lbnQpKQorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKworICAgIHJldHVybiBzaXpl LndpZHRoKCkgKiBzaXplLmhlaWdodCgpICogY29tcG9uZW50c1BlclBpeGVsICogYnl0ZXNQZXJD b21wb25lbnQ7CiB9CiAKIFRleHR1cmVNYW5hZ2VyOjpUZXh0dXJlTWFuYWdlcihzaXplX3QgbWVt b3J5TGltaXRCeXRlcywgaW50IG1heFRleHR1cmVTaXplKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RleHR1cmVNYW5hZ2VyLmgKaW5k ZXggOTJmMzA4Y2E5ZDVlNzdmM2U4Yjk5ZDQ1NzEyYzhiZTU0MTI0NGQ5NC4uMTJhZDIwODAwYjZj ZGM2YTJjZTdhMDQ0Zjk2ZDBhZjA1NTIwMDkwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGV4dHVyZU1hbmFnZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0dXJlTWFuYWdlci5oCkBAIC01 MSw3ICs1MSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlbGVhc2VUb2tlbihUZXh0dXJlVG9rZW4p OwogICAgIGJvb2wgaGFzVGV4dHVyZShUZXh0dXJlVG9rZW4pOwogCi0gICAgYm9vbCByZXF1ZXN0 VGV4dHVyZShUZXh0dXJlVG9rZW4sIEludFNpemUsIHVuc2lnbmVkIHRleHR1cmVGb3JtYXQpOwor ICAgIGJvb2wgcmVxdWVzdFRleHR1cmUoVGV4dHVyZVRva2VuLCBJbnRTaXplLCBHQzNEZW51bSB0 ZXh0dXJlRm9ybWF0KTsKIAogICAgIHZvaWQgcHJvdGVjdFRleHR1cmUoVGV4dHVyZVRva2VuKTsK ICAgICB2b2lkIHVucHJvdGVjdFRleHR1cmUoVGV4dHVyZVRva2VuKTsKQEAgLTc0LDcgKzc0LDcg QEAgcHJpdmF0ZToKIAogICAgIHN0cnVjdCBUZXh0dXJlSW5mbyB7CiAgICAgICAgIEludFNpemUg c2l6ZTsKLSAgICAgICAgdW5zaWduZWQgZm9ybWF0OworICAgICAgICBHQzNEZW51bSBmb3JtYXQ7 CiAgICAgICAgIHVuc2lnbmVkIHRleHR1cmVJZDsKICAgICAgICAgYm9vbCBpc1Byb3RlY3RlZDsK ICAgICB9Owo=