66913 2011-08-24 17:56:48 -0700 Some layerTreeAsText compositing tests are flaky 2011-08-24 22:50:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne kbr simon.fraser vangelis webkit.review.bot oldest_to_newest 456565 0 jamesr 2011-08-24 17:56:48 -0700 [chromium] Some layerTreeAsText compositing tests are flaky 456566 1 105108 jamesr 2011-08-24 17:57:32 -0700 Created attachment 105108 Patch 456568 2 jamesr 2011-08-24 17:58:28 -0700 Since the parallelization changes for webkit_gpu_tests a few tests have been flaky with the failure mode being that the dumped GraphicsLayer tree sometimes doesn't show up in the layer tree. This patch seems to fix the flake, but I'm not completely sure what is going on here. 456610 3 105121 jamesr 2011-08-24 19:15:14 -0700 Created attachment 105121 Patch 456612 4 jamesr 2011-08-24 19:16:39 -0700 I don't actually think this is limited to chromium, the cross-platform code seems a bit unreliable too. Simon: We've been seeing some layerTreeAsText tests flake out, occasionally the GraphicsLayer tree is not up to date when layoutTestController.layerTreeAsText() is called. This seems like the right fix and only impacts test code. I suspect that a similar thing is happening on the mac port. 456635 5 105121 simon.fraser 2011-08-24 20:52:04 -0700 Comment on attachment 105121 Patch I wonder if this fixes the tiled layer flakiness. 456651 6 105121 webkit.review.bot 2011-08-24 22:50:14 -0700 Comment on attachment 105121 Patch Clearing flags on attachment: 105121 Committed r93760: <http://trac.webkit.org/changeset/93760> 456652 7 webkit.review.bot 2011-08-24 22:50:18 -0700 All reviewed patches have been landed. Closing bug. 105108 2011-08-24 17:57:32 -0700 2011-08-24 19:15:11 -0700 Patch bug-66913-20110824175731.patch text/plain 1443 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3NDgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZGRlMTRkNDlmZTk5MWMyMzQwOWRkOWFjNWJiOWJiYTAz NDhlOTE3Li40NTEzNTgzMTgxN2JjMjMzNWYyNjNlOWRlZDg4ODZiNzRkODBmYTdkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDgtMjQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbY2hyb21pdW1dIFNvbWUgbGF5ZXJUcmVlQXNUZXh0IGNvbXBvc2l0aW5nIHRlc3Rz IGFyZSBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjY5MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEbyBhbiBleHBsaWNpdCBsYXlvdXQoKSBiZWZvcmUgcXVlcnlpbmcgbGF5ZXJUcmVlQXNUZXh0 IHRvIGVuc3VyZSB0aGF0IHRoZSBHcmFwaGljc0xheWVyIHRyZWUgaXMgdXAgdG8gZGF0ZS4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpsYXllclRyZWVBc1RleHQpOgorCiAy MDExLTA4LTI0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVt b3ZlIGVtcHR5IGRpcmVjdG9yeS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAppbmRleCBhZDIzYWFiMjk2OTdmYWFlMmFh NzI3NTZhMjZjZDEzNDY5MTY1ZDcyLi4zNzhkYzg5NjQzMmE4NTExZmY2MDExYjZkODU0YTdkNzU2 ZjI3OGIwIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRU ZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5 b3V0VGVzdENvbnRyb2xsZXIuY3BwCkBAIC0xNzE5LDYgKzE3MTksNyBAQCB2b2lkIExheW91dFRl c3RDb250cm9sbGVyOjphZGRNb2NrU3BlZWNoSW5wdXRSZXN1bHQoY29uc3QgQ3BwQXJndW1lbnRM aXN0JiBhcmd1bQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpsYXllclRyZWVBc1RleHQo Y29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmdzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7CisgICAg bV9zaGVsbC0+d2ViVmlldygpLT5sYXlvdXQoKTsKICAgICByZXN1bHQtPnNldChtX3NoZWxsLT53 ZWJWaWV3KCktPm1haW5GcmFtZSgpLT5sYXllclRyZWVBc1RleHQobV9zaG93RGVidWdMYXllclRy ZWUpLnV0ZjgoKSk7CiB9CiAK 105121 2011-08-24 19:15:14 -0700 2011-08-24 22:50:14 -0700 Patch bug-66913-20110824191513.patch text/plain 2909 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhYjFlYTgzNzNlM2Y2Y2I2 MjYzN2NlYTA3ZjQxYmE5NzEyOGFkMjQ5Li4xMmIxZTY4OTU5ZWU1ODkzYjc5YzZiOGNjYTU4MGQ2 MzZjY2NjZmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMjQgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBTb21lIGxheWVyVHJl ZUFzVGV4dCBjb21wb3NpdGluZyB0ZXN0cyBhcmUgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2OTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGNvbXBvc2l0aW5nTGF5ZXJVcGRhdGVQ ZW5kaW5nKCkgYW5kIHVuY29uZGl0aW9uYWxseSB1cGRhdGUgY29tcG9zaXRpbmcgbGF5ZXJzIHdo ZW4KKyAgICAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpsYXllclRyZWVBc1RleHQoKS4gIGNv bXBvc2l0aW5nTGF5ZXJVcGRhdGVQZW5kaW5nKCkgd2FzIG9ubHkgdXNlZCBieSB0ZXN0IGNvZGUg YW5kIGlzCisgICAgICAgIHVucmVsaWFibGUuCisKKyAgICAgICAgQ292ZXJlZCBieSBjb21wb3Np dGluZy8gbGF5ZXJUcmVlQXNUZXh0IHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBv c2l0b3I6OmxheWVyVHJlZUFzVGV4dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVy Q29tcG9zaXRvci5oOgorCiAyMDExLTA4LTI0ICBFcmljIFVocmhhbmUgIDxlcmljdUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggMWUxYmNl M2Y2YTJjZTllNTU0NDdhNTc0ZWYxODExODI4ODc5OWM2ZC4uYWM4NDE1NjNmZTFlNWJmYzQwZTA4 ZTJmNDM2NmNkODRkN2JlOWRlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTIzNiwxMSArMjM2LDYgQEAgdm9pZCBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OnNjaGVkdWxlQ29tcG9zaXRpbmdMYXllclVwZGF0ZSgpCiAgICAg ICAgIG1fdXBkYXRlQ29tcG9zaXRpbmdMYXllcnNUaW1lci5zdGFydE9uZVNob3QoMCk7CiB9CiAK LWJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpjb21wb3NpdGluZ0xheWVyVXBkYXRlUGVuZGlu ZygpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1fdXBkYXRlQ29tcG9zaXRpbmdMYXllcnNUaW1lci5p c0FjdGl2ZSgpOwotfQotCiB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQ29tcG9z aXRpbmdMYXllcnNUaW1lckZpcmVkKFRpbWVyPFJlbmRlckxheWVyQ29tcG9zaXRvcj4qKQogewog ICAgIHVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKCk7CkBAIC05NzIsOCArOTY3LDcgQEAgdm9pZCBS ZW5kZXJMYXllckNvbXBvc2l0b3I6OmZyYW1lVmlld0RpZFNjcm9sbChjb25zdCBMYXlvdXRQb2lu dCYgc2Nyb2xsUG9zaXRpb24KIAogU3RyaW5nIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6bGF5ZXJU cmVlQXNUZXh0KGJvb2wgc2hvd0RlYnVnSW5mbykKIHsKLSAgICBpZiAoY29tcG9zaXRpbmdMYXll clVwZGF0ZVBlbmRpbmcoKSkKLSAgICAgICAgdXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoKTsKKyAg ICB1cGRhdGVDb21wb3NpdGluZ0xheWVycygpOwogCiAgICAgaWYgKCFtX3Jvb3RDb250ZW50TGF5 ZXIpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAppbmRleCA5MzRmY2NmYjg3ODk1ZGYyM2U0MWRk NWE0ZjVmZmZiOGFmODJhYjk3Li5hZDAwODE0ZTU2Y2IwZDE4YWZjNTA2MDY4ZDU0NjU0YWU2MDEx MTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5oCkBAIC0xMDEsNyArMTAxLDYgQEAgcHVibGljOgogICAgIC8vIFRoaXMgaXMgb25seSB1 c2VkIHdoZW4gc3RhdGUgY2hhbmdlcyBhbmQgd2UgZG8gbm90IGV4ZXBlY3QgYSBzdHlsZSB1cGRh dGUgb3IgbGF5b3V0IHRvIGhhcHBlbiBzb29uIChlLmcuIHdoZW4KICAgICAvLyB3ZSBkaXNjb3Zl ciB0aGF0IGFuIGlmcmFtZSBpcyBvdmVybGFwcGVkIGR1cmluZyBwYWludGluZykuCiAgICAgdm9p ZCBzY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJVcGRhdGUoKTsKLSAgICBib29sIGNvbXBvc2l0aW5n TGF5ZXJVcGRhdGVQZW5kaW5nKCkgY29uc3Q7CiAgICAgCiAgICAgLy8gVXBkYXRlIHRoZSBjb21w b3NpdGluZyBzdGF0ZSBvZiB0aGUgZ2l2ZW4gbGF5ZXIuIFJldHVybnMgdHJ1ZSBpZiB0aGF0IHN0 YXRlIGNoYW5nZWQuCiAgICAgZW51bSBDb21wb3NpdGluZ0NoYW5nZVJlcGFpbnQgeyBDb21wb3Np dGluZ0NoYW5nZVJlcGFpbnROb3csIENvbXBvc2l0aW5nQ2hhbmdlV2lsbFJlcGFpbnRMYXRlciB9 Owo=