66912 2011-08-24 17:55:37 -0700 Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464 2011-08-24 18:23:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 456563 0 msaboff 2011-08-24 17:55:37 -0700 The comment added in <http://trac.webkit.org/changeset/93546> from https://bugs.webkit.org/show_bug.cgi?id=66464 for ArgumentEncoder::grow is not totally correct. The proposed new comment is: // Use system malloc / realloc instead of fastMalloc due to // fastMalloc using MADV_FREE_REUSABLE which doesn't work with // mach messages with OOL message and MACH_MSG_VIRTUAL_COPY. // System malloc also calls madvise(MADV_FREE_REUSABLE) but after first // checking via madvise(CAN_REUSE) that it will succeed. Should this // behavior change we'll need to revisit this. 456576 1 105109 msaboff 2011-08-24 18:02:43 -0700 Created attachment 105109 proposed patch 456589 2 msaboff 2011-08-24 18:23:49 -0700 Committed r93754: <http://trac.webkit.org/changeset/93754> 105109 2011-08-24 18:02:43 -0700 2011-08-24 18:04:10 -0700 proposed patch 66912.patch text/plain 1982 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNzQ5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjQgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm9wZXIgY29tbWVudCBp biBDb3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHAgZnJvbSA2NjQ2NAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY5MTIKKworICAgICAgICBVcGRhdGVk IHRoZSBjb21tZW50IGluIEFyZ3VtZW50RW5jb2Rlcjo6Z3JvdyB0byByZWZsZWN0IHRoYXQgc3lz dGVtIG1hbGxvYworICAgICAgICBjdXJyZW50bHkgY2hlY2tzIHRvIHNlZSBpZiBhIE1BRFZfRlJF RV9SRVVTQUJMRSB3aWxsIGZhaWwgYmVmb3JlIGNhbGxpbmcgaXQuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3Vt ZW50RW5jb2Rlci5jcHA6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVudEVuY29kZXI6Omdyb3cp OgorCiAyMDExLTA4LTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVuYW1lIC1bV0tUZXh0SW5wdXRXaW5kb3dDb250cm9sbGVyIGtleWJvYXJkSW5w dXRTb3VyY2VDaGFuZ2VkXSB0byB1bm1hcmtUZXh0IHRvIGluZGljYXRlIHdoYXQgdGhlIG1ldGhv ZCBkb2VzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5j b2Rlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9B cmd1bWVudEVuY29kZXIuY3BwCShyZXZpc2lvbiA5Mzc0OCkKKysrIFNvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzEs OCArNzEsMTEgQEAgdWludDhfdCogQXJndW1lbnRFbmNvZGVyOjpncm93KHVuc2lnbmVkIAogICAg IGlmIChhbGlnbmVkU2l6ZSArIHNpemUgPiBtX2J1ZmZlckNhcGFjaXR5KSB7CiAgICAgICAgIHNp emVfdCBuZXdDYXBhY2l0eSA9IHN0ZDo6bWF4KGFsaWduZWRTaXplICsgc2l6ZSwgc3RkOjptYXgo c3RhdGljX2Nhc3Q8c2l6ZV90PigzMiksIG1fYnVmZmVyQ2FwYWNpdHkgKyBtX2J1ZmZlckNhcGFj aXR5IC8gNCArIDEpKTsKICAgICAgICAgLy8gVXNlIHN5c3RlbSBtYWxsb2MgLyByZWFsbG9jIGlu c3RlYWQgb2YgZmFzdE1hbGxvYyBkdWUgdG8gCi0gICAgICAgIC8vIGZhc3RNYWxsb2MgdXNpbmcg TUFEVl9GUkVFX1JFVVNBQkxFIGRvZXNuJ3Qgd29yayB3aXRoCisgICAgICAgIC8vIGZhc3RNYWxs b2MgdXNpbmcgTUFEVl9GUkVFX1JFVVNBQkxFIHdoaWNoIGRvZXNuJ3Qgd29yayB3aXRoCiAgICAg ICAgIC8vIG1hY2ggbWVzc2FnZXMgd2l0aCBPT0wgbWVzc2FnZSBhbmQgTUFDSF9NU0dfVklSVFVB TF9DT1BZLgorICAgICAgICAvLyBTeXN0ZW0gbWFsbG9jIGFsc28gY2FsbHMgbWFkdmlzZShNQURW X0ZSRUVfUkVVU0FCTEUpIGJ1dCBhZnRlciBmaXJzdAorICAgICAgICAvLyBjaGVja2luZyB2aWEg bWFkdmlzZShDQU5fUkVVU0UpIHRoYXQgaXQgd2lsbCBzdWNjZWVkLiBTaG91bGQgdGhpcworICAg ICAgICAvLyBiZWhhdmlvciBjaGFuZ2Ugd2UnbGwgbmVlZCB0byByZXZpc2l0IHRoaXMuCiAgICAg ICAgIGlmICghbV9idWZmZXIpCiAgICAgICAgICAgICBtX2J1ZmZlciA9IHN0YXRpY19jYXN0PHVp bnQ4X3QqPihtYWxsb2MobmV3Q2FwYWNpdHkpKTsKICAgICAgICAgZWxzZQo=