66896 2011-08-24 14:48:29 -0700 Remove LayoutStateDisabler instances from RenderLayer 2011-09-08 11:53:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 jchaffraix jchaffraix simon.fraser webkit.review.bot oldest_to_newest 456426 0 jchaffraix 2011-08-24 14:48:29 -0700 RenderLayer::scrollTo does not call updateLayerPositions anymore so they can be safely removed. 456448 1 105080 jchaffraix 2011-08-24 15:03:01 -0700 Created attachment 105080 Remove 2 instances of LayoutStateDisabler that are not needed anymore. 456463 2 105082 jchaffraix 2011-08-24 15:25:00 -0700 Created attachment 105082 Version 2: Remove a bad wording (layers' are not sparse or at least this is not guaranteed). 463640 3 105082 simon.fraser 2011-09-07 14:11:07 -0700 Comment on attachment 105082 Version 2: Remove a bad wording (layers' are not sparse or at least this is not guaranteed). View in context: https://bugs.webkit.org/attachment.cgi?id=105082&action=review > Source/WebCore/ChangeLog:16 > + that was not acurate anymore. Also explained what is wrong with accurate 463673 4 106647 jchaffraix 2011-09-07 14:51:35 -0700 Created attachment 106647 Patch for landing 464222 5 106647 webkit.review.bot 2011-09-08 11:53:40 -0700 Comment on attachment 106647 Patch for landing Clearing flags on attachment: 106647 Committed r94777: <http://trac.webkit.org/changeset/94777> 464223 6 webkit.review.bot 2011-09-08 11:53:44 -0700 All reviewed patches have been landed. Closing bug. 105080 2011-08-24 15:03:01 -0700 2011-08-24 15:24:57 -0700 Remove 2 instances of LayoutStateDisabler that are not needed anymore. bug-66896-20110824150259.patch text/plain 3901 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZDlkYzg0ODQxYmNmODE3 ZmQwZDNjNjNhZTJkZTBkNjhkMDlmNjg2Li41ODI4NGI0ZjIxNWY3NTI5NjQxZTc3YzFmZmZhM2Mx MzhiNDZlZjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDgtMjQgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIExh eW91dFN0YXRlRGlzYWJsZXIgaW5zdGFuY2VzIGZyb20gUmVuZGVyTGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgcGFydCBvZiByOTM2MTQsIHNj cm9sbFRvIGRvZXMgbm90IGNhbGwgdXBkYXRlTGF5ZXJQb3NpdGlvbnMgYW55bW9yZS4KKyAgICAg ICAgVGhpcyBtZWFucyB0aGF0IHdlIGRvbid0IG5lZWQgdG8gZGlzYWJsZSBMYXlvdXRTdGF0ZSBm cm9tIHRoZSBzY3JvbGxpbmcgY29kZQorICAgICAgICBpbiBSZW5kZXJMYXllci4KKworICAgICAg ICBUaGlzIGNoYW5nZSBpcyBjb3ZlcmVkIGJ5IHRoZSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnMpOiBVcGRhdGVkIHRoZSBjb21tZW50CisgICAgICAg IHRoYXQgd2FzIG5vdCBhY3VyYXRlIGFueW1vcmUuIEFsc28gZXhwbGFpbmVkIHdoYXQgaXMgd3Jv bmcgd2l0aAorICAgICAgICBMYXlvdXRTdGF0ZSB2cyBSZW5kZXJMYXllciBub3cuIE5vdGUgdGhh dCB0aGUgQVNTRVJUIGlzIHN0aWxsCisgICAgICAgIHZhbGlkIGFuZCB3aWxsIG5vdCB0cmlnZ2Vy IGFzIHRoZSByZW1haW5pbmcgY2FsbHMgdG8gdXBkYXRlTGF5ZXJQb3NpdGlvbnMKKyAgICAgICAg YXJlIGRvbmUgKm91dHNpZGUqIGxheW91dCgpIHdoZXJlIExheW91dFN0YXRlIGlzIG5vdCBzZXQg KHRodXMgZGlzYWJsZWQpLgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRl U2Nyb2xsSW5mb0FmdGVyTGF5b3V0KTogUmVtb3ZlZAorICAgICAgICAyIExheW91dFN0YXRlRGlz YWJsZXIgc3Vycm91bmRpbmcgc2Nyb2xsVG9PZmZzZXQuCisKIDIwMTEtMDgtMjQgIEFsb2sgUHJp eWFkYXJzaGkgIDxhbG9rcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSb290 IGxheWVyIGlzIG5vdCB1cGRhdGVkIHdoZW4gb25seSBhIHBvcnRpb24gb2YgdGlsZSBpcyB1cGRh dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA1YzBhMTkw ZDZjYjZmMDUzNGFkN2UzMjQ5NGJmYjk0MTZhYTRhMWRmLi40Y2Q2NWE4MTRhYmU5OGUzN2RhMTcx NzgxNzljZTA4Y2UwNjlhNTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAKQEAgLTMwNCw4ICszMDQsOSBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVMYXllclBv c2l0aW9ucyhVcGRhdGVMYXllclBvc2l0aW9uc0ZsYWdzIGZsYWdzLCBMYXlvdXRQbwogICAgIGlm IChtX2hhc1Zpc2libGVDb250ZW50KSB7CiAgICAgICAgIFJlbmRlclZpZXcqIHZpZXcgPSByZW5k ZXJlcigpLT52aWV3KCk7CiAgICAgICAgIEFTU0VSVCh2aWV3KTsKLSAgICAgICAgLy8gRklYTUU6 IE9wdGltaXplIHVzaW5nIExheW91dFN0YXRlIGFuZCByZW1vdmUgTGF5b3V0U3RhdGVEaXNhYmxl ciBpbnN0YW50aWF0aW9uCi0gICAgICAgIC8vIGZyb20gdXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5 b3V0KCkuCisgICAgICAgIC8vIEZJWE1FOiBMYXlvdXRTdGF0ZSBkb2VzIG5vdCB3b3JrIHdpdGgg UmVuZGVyTGF5ZXJzIGFzIHRoZXkgYXJlIHNwYXJzZQorICAgICAgICAvLyBpbiB0aGUgUmVuZGVy VHJlZS4gSXQgd291bGQgbmVhdCB0byBlbmFibGUgTGF5b3V0U3RhdGUgb3V0c2lkZSB0aGUgbGF5 b3V0KCkKKyAgICAgICAgLy8gcGhhc2UgYW5kIHVzZSBpdCBoZXJlLgogICAgICAgICBBU1NFUlQo IXZpZXctPmxheW91dFN0YXRlRW5hYmxlZCgpKTsKIAogICAgICAgICBSZW5kZXJCb3hNb2RlbE9i amVjdCogcmVwYWludENvbnRhaW5lciA9IHJlbmRlcmVyKCktPmNvbnRhaW5lckZvclJlcGFpbnQo KTsKQEAgLTIxOTYsMTUgKzIxOTcsOCBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxJ bmZvQWZ0ZXJMYXlvdXQoKQogICAgICAgICAvLyB0byBwdWxsIG91ciBzY3JvbGwgb2Zmc2V0cyBi YWNrIHRvIHRoZSBtYXggKG9yIHB1c2ggdGhlbSB1cCB0byB0aGUgbWluKS4KICAgICAgICAgTGF5 b3V0VW5pdCBuZXdYID0gbWF4PExheW91dFVuaXQ+KDAsIG1pbihzY3JvbGxYT2Zmc2V0KCksIHNj cm9sbFdpZHRoKCkgLSBib3gtPmNsaWVudFdpZHRoKCkpKTsKICAgICAgICAgTGF5b3V0VW5pdCBu ZXdZID0gbWF4PExheW91dFVuaXQ+KDAsIG1pbihzY3JvbGxZT2Zmc2V0KCksIHNjcm9sbEhlaWdo dCgpIC0gYm94LT5jbGllbnRIZWlnaHQoKSkpOwotICAgICAgICBpZiAobmV3WCAhPSBzY3JvbGxY T2Zmc2V0KCkgfHwgbmV3WSAhPSBzY3JvbGxZT2Zmc2V0KCkpIHsKLSAgICAgICAgICAgIFJlbmRl clZpZXcqIHZpZXcgPSByZW5kZXJlcigpLT52aWV3KCk7Ci0gICAgICAgICAgICBBU1NFUlQodmll dyk7Ci0gICAgICAgICAgICAvLyBzY3JvbGxUb09mZnNldCgpIG1heSBjYWxsIHVwZGF0ZUxheWVy UG9zaXRpb25zKCksIHdoaWNoIGRvZXNuJ3Qgd29yawotICAgICAgICAgICAgLy8gd2l0aCBMYXlv dXRTdGF0ZS4KLSAgICAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhlIExheW91dFN0YXRlRGlz YWJsZXIgaW5zdGFudGlhdGlvbiBpZiB0aGUgYWJvdmUgY2hhbmdlcy4KLSAgICAgICAgICAgIExh eW91dFN0YXRlRGlzYWJsZXIgbGF5b3V0U3RhdGVEaXNhYmxlcih2aWV3KTsKKyAgICAgICAgaWYg KG5ld1ggIT0gc2Nyb2xsWE9mZnNldCgpIHx8IG5ld1kgIT0gc2Nyb2xsWU9mZnNldCgpKQogICAg ICAgICAgICAgc2Nyb2xsVG9PZmZzZXQobmV3WCwgbmV3WSk7Ci0gICAgICAgIH0KICAgICB9CiAK ICAgICBib29sIGhhdmVIb3Jpem9udGFsQmFyID0gbV9oQmFyOwpAQCAtMjI3NywxMSArMjI3MSw3 IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dCgpCiAgICAg ICAgIG1fdkJhci0+c2V0UHJvcG9ydGlvbihjbGllbnRIZWlnaHQsIG1fc2Nyb2xsU2l6ZS5oZWln aHQoKSk7CiAgICAgfQogIAotICAgIFJlbmRlclZpZXcqIHZpZXcgPSByZW5kZXJlcigpLT52aWV3 KCk7Ci0gICAgewotICAgICAgICBMYXlvdXRTdGF0ZURpc2FibGVyIGxheW91dFN0YXRlRGlzYWJs ZXIodmlldyk7Ci0gICAgICAgIHNjcm9sbFRvT2Zmc2V0KHNjcm9sbFhPZmZzZXQoKSwgc2Nyb2xs WU9mZnNldCgpKTsKLSAgICB9CisgICAgc2Nyb2xsVG9PZmZzZXQoc2Nyb2xsWE9mZnNldCgpLCBz Y3JvbGxZT2Zmc2V0KCkpOwogCiAgICAgaWYgKHJlbmRlcmVyKCktPm5vZGUoKSAmJiByZW5kZXJl cigpLT5kb2N1bWVudCgpLT5oYXNMaXN0ZW5lclR5cGUoRG9jdW1lbnQ6Ok9WRVJGTE9XQ0hBTkdF RF9MSVNURU5FUikpCiAgICAgICAgIHVwZGF0ZU92ZXJmbG93U3RhdHVzKGhvcml6b250YWxPdmVy ZmxvdywgdmVydGljYWxPdmVyZmxvdyk7Cg== 105082 2011-08-24 15:25:00 -0700 2011-09-07 14:51:32 -0700 Version 2: Remove a bad wording (layers' are not sparse or at least this is not guaranteed). bug-66896-20110824152459.patch text/plain 3935 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZDlkYzg0ODQxYmNmODE3 ZmQwZDNjNjNhZTJkZTBkNjhkMDlmNjg2Li41ODI4NGI0ZjIxNWY3NTI5NjQxZTc3YzFmZmZhM2Mx MzhiNDZlZjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDgtMjQgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIExh eW91dFN0YXRlRGlzYWJsZXIgaW5zdGFuY2VzIGZyb20gUmVuZGVyTGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgcGFydCBvZiByOTM2MTQsIHNj cm9sbFRvIGRvZXMgbm90IGNhbGwgdXBkYXRlTGF5ZXJQb3NpdGlvbnMgYW55bW9yZS4KKyAgICAg ICAgVGhpcyBtZWFucyB0aGF0IHdlIGRvbid0IG5lZWQgdG8gZGlzYWJsZSBMYXlvdXRTdGF0ZSBm cm9tIHRoZSBzY3JvbGxpbmcgY29kZQorICAgICAgICBpbiBSZW5kZXJMYXllci4KKworICAgICAg ICBUaGlzIGNoYW5nZSBpcyBjb3ZlcmVkIGJ5IHRoZSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnMpOiBVcGRhdGVkIHRoZSBjb21tZW50CisgICAgICAg IHRoYXQgd2FzIG5vdCBhY3VyYXRlIGFueW1vcmUuIEFsc28gZXhwbGFpbmVkIHdoYXQgaXMgd3Jv bmcgd2l0aAorICAgICAgICBMYXlvdXRTdGF0ZSB2cyBSZW5kZXJMYXllciBub3cuIE5vdGUgdGhh dCB0aGUgQVNTRVJUIGlzIHN0aWxsCisgICAgICAgIHZhbGlkIGFuZCB3aWxsIG5vdCB0cmlnZ2Vy IGFzIHRoZSByZW1haW5pbmcgY2FsbHMgdG8gdXBkYXRlTGF5ZXJQb3NpdGlvbnMKKyAgICAgICAg YXJlIGRvbmUgKm91dHNpZGUqIGxheW91dCgpIHdoZXJlIExheW91dFN0YXRlIGlzIG5vdCBzZXQg KHRodXMgZGlzYWJsZWQpLgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRl U2Nyb2xsSW5mb0FmdGVyTGF5b3V0KTogUmVtb3ZlZAorICAgICAgICAyIExheW91dFN0YXRlRGlz YWJsZXIgc3Vycm91bmRpbmcgc2Nyb2xsVG9PZmZzZXQuCisKIDIwMTEtMDgtMjQgIEFsb2sgUHJp eWFkYXJzaGkgIDxhbG9rcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSb290 IGxheWVyIGlzIG5vdCB1cGRhdGVkIHdoZW4gb25seSBhIHBvcnRpb24gb2YgdGlsZSBpcyB1cGRh dGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA1YzBhMTkw ZDZjYjZmMDUzNGFkN2UzMjQ5NGJmYjk0MTZhYTRhMWRmLi4xOWNiMjI3YTRlODJjY2ZiNTM4NjU0 YjVmYzk5MzVlMWYwZmVkNTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAKQEAgLTMwNCw4ICszMDQsOSBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVMYXllclBv c2l0aW9ucyhVcGRhdGVMYXllclBvc2l0aW9uc0ZsYWdzIGZsYWdzLCBMYXlvdXRQbwogICAgIGlm IChtX2hhc1Zpc2libGVDb250ZW50KSB7CiAgICAgICAgIFJlbmRlclZpZXcqIHZpZXcgPSByZW5k ZXJlcigpLT52aWV3KCk7CiAgICAgICAgIEFTU0VSVCh2aWV3KTsKLSAgICAgICAgLy8gRklYTUU6 IE9wdGltaXplIHVzaW5nIExheW91dFN0YXRlIGFuZCByZW1vdmUgTGF5b3V0U3RhdGVEaXNhYmxl ciBpbnN0YW50aWF0aW9uCi0gICAgICAgIC8vIGZyb20gdXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5 b3V0KCkuCisgICAgICAgIC8vIEZJWE1FOiBMYXlvdXRTdGF0ZSBkb2VzIG5vdCB3b3JrIHdpdGgg UmVuZGVyTGF5ZXJzIGFzIHRoZXJlIGlzIG5vdCBhIDEtdG8tMQorICAgICAgICAvLyBtYXBwaW5n IGJldHdlZW4gdGhlbSBhbmQgdGhlIFJlbmRlck9iamVjdHMuIEl0IHdvdWxkIGJlIG5lYXQgdG8g ZW5hYmxlCisgICAgICAgIC8vIExheW91dFN0YXRlIG91dHNpZGUgdGhlIGxheW91dCgpIHBoYXNl IGFuZCB1c2UgaXQgaGVyZS4KICAgICAgICAgQVNTRVJUKCF2aWV3LT5sYXlvdXRTdGF0ZUVuYWJs ZWQoKSk7CiAKICAgICAgICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIg PSByZW5kZXJlcigpLT5jb250YWluZXJGb3JSZXBhaW50KCk7CkBAIC0yMTk2LDE1ICsyMTk3LDgg QEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5b3V0KCkKICAgICAg ICAgLy8gdG8gcHVsbCBvdXIgc2Nyb2xsIG9mZnNldHMgYmFjayB0byB0aGUgbWF4IChvciBwdXNo IHRoZW0gdXAgdG8gdGhlIG1pbikuCiAgICAgICAgIExheW91dFVuaXQgbmV3WCA9IG1heDxMYXlv dXRVbml0PigwLCBtaW4oc2Nyb2xsWE9mZnNldCgpLCBzY3JvbGxXaWR0aCgpIC0gYm94LT5jbGll bnRXaWR0aCgpKSk7CiAgICAgICAgIExheW91dFVuaXQgbmV3WSA9IG1heDxMYXlvdXRVbml0Pigw LCBtaW4oc2Nyb2xsWU9mZnNldCgpLCBzY3JvbGxIZWlnaHQoKSAtIGJveC0+Y2xpZW50SGVpZ2h0 KCkpKTsKLSAgICAgICAgaWYgKG5ld1ggIT0gc2Nyb2xsWE9mZnNldCgpIHx8IG5ld1kgIT0gc2Ny b2xsWU9mZnNldCgpKSB7Ci0gICAgICAgICAgICBSZW5kZXJWaWV3KiB2aWV3ID0gcmVuZGVyZXIo KS0+dmlldygpOwotICAgICAgICAgICAgQVNTRVJUKHZpZXcpOwotICAgICAgICAgICAgLy8gc2Ny b2xsVG9PZmZzZXQoKSBtYXkgY2FsbCB1cGRhdGVMYXllclBvc2l0aW9ucygpLCB3aGljaCBkb2Vz bid0IHdvcmsKLSAgICAgICAgICAgIC8vIHdpdGggTGF5b3V0U3RhdGUuCi0gICAgICAgICAgICAv LyBGSVhNRTogUmVtb3ZlIHRoZSBMYXlvdXRTdGF0ZURpc2FibGVyIGluc3RhbnRpYXRpb24gaWYg dGhlIGFib3ZlIGNoYW5nZXMuCi0gICAgICAgICAgICBMYXlvdXRTdGF0ZURpc2FibGVyIGxheW91 dFN0YXRlRGlzYWJsZXIodmlldyk7CisgICAgICAgIGlmIChuZXdYICE9IHNjcm9sbFhPZmZzZXQo KSB8fCBuZXdZICE9IHNjcm9sbFlPZmZzZXQoKSkKICAgICAgICAgICAgIHNjcm9sbFRvT2Zmc2V0 KG5ld1gsIG5ld1kpOwotICAgICAgICB9CiAgICAgfQogCiAgICAgYm9vbCBoYXZlSG9yaXpvbnRh bEJhciA9IG1faEJhcjsKQEAgLTIyNzcsMTEgKzIyNzEsNyBAQCB2b2lkIFJlbmRlckxheWVyOjp1 cGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXQoKQogICAgICAgICBtX3ZCYXItPnNldFByb3BvcnRp b24oY2xpZW50SGVpZ2h0LCBtX3Njcm9sbFNpemUuaGVpZ2h0KCkpOwogICAgIH0KICAKLSAgICBS ZW5kZXJWaWV3KiB2aWV3ID0gcmVuZGVyZXIoKS0+dmlldygpOwotICAgIHsKLSAgICAgICAgTGF5 b3V0U3RhdGVEaXNhYmxlciBsYXlvdXRTdGF0ZURpc2FibGVyKHZpZXcpOwotICAgICAgICBzY3Jv bGxUb09mZnNldChzY3JvbGxYT2Zmc2V0KCksIHNjcm9sbFlPZmZzZXQoKSk7Ci0gICAgfQorICAg IHNjcm9sbFRvT2Zmc2V0KHNjcm9sbFhPZmZzZXQoKSwgc2Nyb2xsWU9mZnNldCgpKTsKIAogICAg IGlmIChyZW5kZXJlcigpLT5ub2RlKCkgJiYgcmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+aGFzTGlz dGVuZXJUeXBlKERvY3VtZW50OjpPVkVSRkxPV0NIQU5HRURfTElTVEVORVIpKQogICAgICAgICB1 cGRhdGVPdmVyZmxvd1N0YXR1cyhob3Jpem9udGFsT3ZlcmZsb3csIHZlcnRpY2FsT3ZlcmZsb3cp Owo= 106647 2011-09-07 14:51:35 -0700 2011-09-08 11:53:39 -0700 Patch for landing bug-66896-20110907145134.patch text/plain 3957 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkODVmNzI2OTFjNzYwYWI2 NmI4MmI2OTdjMjkwYWY3NWIyNmI5OWY1Li44NzI2YzY3MWVjNDI5MWU3ZDFmYTk5NzVlN2JiYjcw YzFiOGRkNTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDktMDcgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIExh eW91dFN0YXRlRGlzYWJsZXIgaW5zdGFuY2VzIGZyb20gUmVuZGVyTGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIEFzIHBhcnQgb2YgcjkzNjE0LCBzY3Jv bGxUbyBkb2VzIG5vdCBjYWxsIHVwZGF0ZUxheWVyUG9zaXRpb25zIGFueW1vcmUuCisgICAgICAg IFRoaXMgbWVhbnMgdGhhdCB3ZSBkb24ndCBuZWVkIHRvIGRpc2FibGUgTGF5b3V0U3RhdGUgZnJv bSB0aGUgc2Nyb2xsaW5nIGNvZGUKKyAgICAgICAgaW4gUmVuZGVyTGF5ZXIuCisKKyAgICAgICAg VGhpcyBjaGFuZ2UgaXMgY292ZXJlZCBieSB0aGUgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5 ZXI6OnVwZGF0ZUxheWVyUG9zaXRpb25zKTogVXBkYXRlZCB0aGUgY29tbWVudAorICAgICAgICB0 aGF0IHdhcyBub3QgYWNjdXJhdGUgYW55bW9yZS4gQWxzbyBleHBsYWluZWQgd2hhdCBpcyB3cm9u ZyB3aXRoCisgICAgICAgIExheW91dFN0YXRlIHZzIFJlbmRlckxheWVyIG5vdy4gTm90ZSB0aGF0 IHRoZSBBU1NFUlQgaXMgc3RpbGwKKyAgICAgICAgdmFsaWQgYW5kIHdpbGwgbm90IHRyaWdnZXIg YXMgdGhlIHJlbWFpbmluZyBjYWxscyB0byB1cGRhdGVMYXllclBvc2l0aW9ucworICAgICAgICBh cmUgZG9uZSAqb3V0c2lkZSogbGF5b3V0KCkgd2hlcmUgTGF5b3V0U3RhdGUgaXMgbm90IHNldCAo dGh1cyBkaXNhYmxlZCkuCisKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVT Y3JvbGxJbmZvQWZ0ZXJMYXlvdXQpOiBSZW1vdmVkCisgICAgICAgIDIgTGF5b3V0U3RhdGVEaXNh YmxlciBzdXJyb3VuZGluZyBzY3JvbGxUb09mZnNldC4KKwogMjAxMS0wOS0wNyAgVGltIEhvcnRv biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBUZXh0IHJlbmRlcmVkIHdp dGggYSBzaW1wbGUgKGkuZS4gMHB4IGJsdXIpIHNoYWRvdyBpbnNpZGUgYSB0cmFuc3BhcmVuY3kg bGF5ZXIgaGFzIGEgZG91YmxlIHNoYWRvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAKaW5kZXggOWUwNDE0NjkwYTk0ZGNhYWQwNmNkZmE3NzIxY2Y4MDUxMGY4YzY1ZC4u YzNlMmJmNmYzY2FmZDY1ZGMyYWYzZmMzNjFhM2M4ZGJhZTQ5MTEwYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zMzQsOCArMzM0LDkgQEAgdm9pZCBSZW5k ZXJMYXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnMoTGF5b3V0UG9pbnQqIG9mZnNldEZyb21Sb290 LCBVcGRhdGVMYXllclAKICAgICBpZiAobV9oYXNWaXNpYmxlQ29udGVudCkgewogICAgICAgICBS ZW5kZXJWaWV3KiB2aWV3ID0gcmVuZGVyZXIoKS0+dmlldygpOwogICAgICAgICBBU1NFUlQodmll dyk7Ci0gICAgICAgIC8vIEZJWE1FOiBPcHRpbWl6ZSB1c2luZyBMYXlvdXRTdGF0ZSBhbmQgcmVt b3ZlIExheW91dFN0YXRlRGlzYWJsZXIgaW5zdGFudGlhdGlvbgotICAgICAgICAvLyBmcm9tIHVw ZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dCgpLgorICAgICAgICAvLyBGSVhNRTogTGF5b3V0U3Rh dGUgZG9lcyBub3Qgd29yayB3aXRoIFJlbmRlckxheWVycyBhcyB0aGVyZSBpcyBub3QgYSAxLXRv LTEKKyAgICAgICAgLy8gbWFwcGluZyBiZXR3ZWVuIHRoZW0gYW5kIHRoZSBSZW5kZXJPYmplY3Rz LiBJdCB3b3VsZCBiZSBuZWF0IHRvIGVuYWJsZQorICAgICAgICAvLyBMYXlvdXRTdGF0ZSBvdXRz aWRlIHRoZSBsYXlvdXQoKSBwaGFzZSBhbmQgdXNlIGl0IGhlcmUuCiAgICAgICAgIEFTU0VSVCgh dmlldy0+bGF5b3V0U3RhdGVFbmFibGVkKCkpOwogCiAgICAgICAgIFJlbmRlckJveE1vZGVsT2Jq ZWN0KiByZXBhaW50Q29udGFpbmVyID0gcmVuZGVyZXIoKS0+Y29udGFpbmVyRm9yUmVwYWludCgp OwpAQCAtMjI0NywxNSArMjI0OCw4IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbElu Zm9BZnRlckxheW91dCgpCiAgICAgICAgIC8vIHRvIHB1bGwgb3VyIHNjcm9sbCBvZmZzZXRzIGJh Y2sgdG8gdGhlIG1heCAob3IgcHVzaCB0aGVtIHVwIHRvIHRoZSBtaW4pLgogICAgICAgICBMYXlv dXRVbml0IG5ld1ggPSBtYXg8TGF5b3V0VW5pdD4oMCwgbWluKHNjcm9sbFhPZmZzZXQoKSwgc2Ny b2xsV2lkdGgoKSAtIGJveC0+Y2xpZW50V2lkdGgoKSkpOwogICAgICAgICBMYXlvdXRVbml0IG5l d1kgPSBtYXg8TGF5b3V0VW5pdD4oMCwgbWluKHNjcm9sbFlPZmZzZXQoKSwgc2Nyb2xsSGVpZ2h0 KCkgLSBib3gtPmNsaWVudEhlaWdodCgpKSk7Ci0gICAgICAgIGlmIChuZXdYICE9IHNjcm9sbFhP ZmZzZXQoKSB8fCBuZXdZICE9IHNjcm9sbFlPZmZzZXQoKSkgewotICAgICAgICAgICAgUmVuZGVy VmlldyogdmlldyA9IHJlbmRlcmVyKCktPnZpZXcoKTsKLSAgICAgICAgICAgIEFTU0VSVCh2aWV3 KTsKLSAgICAgICAgICAgIC8vIHNjcm9sbFRvT2Zmc2V0KCkgbWF5IGNhbGwgdXBkYXRlTGF5ZXJQ b3NpdGlvbnMoKSwgd2hpY2ggZG9lc24ndCB3b3JrCi0gICAgICAgICAgICAvLyB3aXRoIExheW91 dFN0YXRlLgotICAgICAgICAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgTGF5b3V0U3RhdGVEaXNh YmxlciBpbnN0YW50aWF0aW9uIGlmIHRoZSBhYm92ZSBjaGFuZ2VzLgotICAgICAgICAgICAgTGF5 b3V0U3RhdGVEaXNhYmxlciBsYXlvdXRTdGF0ZURpc2FibGVyKHZpZXcpOworICAgICAgICBpZiAo bmV3WCAhPSBzY3JvbGxYT2Zmc2V0KCkgfHwgbmV3WSAhPSBzY3JvbGxZT2Zmc2V0KCkpCiAgICAg ICAgICAgICBzY3JvbGxUb09mZnNldChuZXdYLCBuZXdZKTsKLSAgICAgICAgfQogICAgIH0KIAog ICAgIGJvb2wgaGF2ZUhvcml6b250YWxCYXIgPSBtX2hCYXI7CkBAIC0yMzI4LDExICsyMzIyLDcg QEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5b3V0KCkKICAgICAg ICAgbV92QmFyLT5zZXRQcm9wb3J0aW9uKGNsaWVudEhlaWdodCwgbV9zY3JvbGxTaXplLmhlaWdo dCgpKTsKICAgICB9CiAgCi0gICAgUmVuZGVyVmlldyogdmlldyA9IHJlbmRlcmVyKCktPnZpZXco KTsKLSAgICB7Ci0gICAgICAgIExheW91dFN0YXRlRGlzYWJsZXIgbGF5b3V0U3RhdGVEaXNhYmxl cih2aWV3KTsKLSAgICAgICAgc2Nyb2xsVG9PZmZzZXQoc2Nyb2xsWE9mZnNldCgpLCBzY3JvbGxZ T2Zmc2V0KCkpOwotICAgIH0KKyAgICBzY3JvbGxUb09mZnNldChzY3JvbGxYT2Zmc2V0KCksIHNj cm9sbFlPZmZzZXQoKSk7CiAKICAgICBpZiAocmVuZGVyZXIoKS0+bm9kZSgpICYmIHJlbmRlcmVy KCktPmRvY3VtZW50KCktPmhhc0xpc3RlbmVyVHlwZShEb2N1bWVudDo6T1ZFUkZMT1dDSEFOR0VE X0xJU1RFTkVSKSkKICAgICAgICAgdXBkYXRlT3ZlcmZsb3dTdGF0dXMoaG9yaXpvbnRhbE92ZXJm bG93LCB2ZXJ0aWNhbE92ZXJmbG93KTsK