66880 2011-08-24 12:34:17 -0700 [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM. 2011-08-25 06:48:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco leandro paroga oldest_to_newest 456312 0 rakuco 2011-08-24 12:34:17 -0700 [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM. 456314 1 105045 rakuco 2011-08-24 12:38:08 -0700 Created attachment 105045 Patch 456315 2 rakuco 2011-08-24 12:38:57 -0700 CC'ing Patrick as this patch changes a global CMakeLists.txt. 456321 3 105045 paroga 2011-08-24 12:45:56 -0700 Comment on attachment 105045 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105045&action=review > Source/WebCore/CMakeLists.txt:1552 > + fileapi/FileException.idl Why do you add them twice? Wouldn't it be cooler if you add an addition if (ENABLE_BLOB OR ENABLE_FILE_SYSTEM) section? 456331 4 rakuco 2011-08-24 12:52:42 -0700 Stupid me, didn't notice that before. Will work on a new version in a minute. 456336 5 105050 rakuco 2011-08-24 12:56:18 -0700 Created attachment 105050 Patch 456339 6 105050 paroga 2011-08-24 12:58:29 -0700 Comment on attachment 105050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105050&action=review > Source/WebCore/CMakeLists.txt:1558 > + fileapi/OperationNotAllowedException.idl and what about OperationNotAllowedException.idl? ;-) 456342 7 rakuco 2011-08-24 13:01:36 -0700 I can't even think of a proper excuse now ;) 456345 8 105052 rakuco 2011-08-24 13:03:28 -0700 Created attachment 105052 Third time is a charm 456469 9 paroga 2011-08-24 15:29:18 -0700 Committed r93744: <http://trac.webkit.org/changeset/93744> 456818 10 105052 rakuco 2011-08-25 06:48:03 -0700 Comment on attachment 105052 Third time is a charm Cleaning flags, patch committed. 105045 2011-08-24 12:38:08 -0700 2011-08-24 12:56:11 -0700 Patch bug-66880-20110824164140.patch text/plain 2027 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzlmNTlh Y2JiMTMwNTkwNjBlMGViYzYwN2I4ODVjNDgwNGY2ODNmMS4uODczNGM0OWE0ZjRiNzFhZjg3MDEz ODc2NDIxZjc0NTllNzA1NGY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEzODYsMTAgKzEz ODYsMTcgQEAgSUYgKEVOQUJMRV9CTE9CKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwogICAgICAgICBmaWxlYXBpL0ZpbGVSZWFkZXIuY3BwCiAgICAgICAgIGZpbGVhcGkvRmlsZVJl YWRlckxvYWRlci5jcHAKKyAgICAgICAgZmlsZWFwaS9GaWxlUmVhZGVyU3luYy5jcHAKICAgICAg ICAgZmlsZWFwaS9GaWxlVGhyZWFkLmNwcAogICAgICAgICBmaWxlYXBpL0ZpbGVTdHJlYW1Qcm94 eS5jcHAKICAgICAgICAgcGxhdGZvcm0vRmlsZVN0cmVhbS5jcHAKICAgICApCisKKyAgICBMSVNU KEFQUEVORCBXZWJDb3JlX0lETF9GSUxFUworICAgICAgIGZpbGVhcGkvRmlsZUV4Y2VwdGlvbi5p ZGwKKyAgICAgICBmaWxlYXBpL0ZpbGVSZWFkZXJTeW5jLmlkbAorICAgICAgIGZpbGVhcGkvT3Bl cmF0aW9uTm90QWxsb3dlZEV4Y2VwdGlvbi5pZGwKKyAgICApCiBFTkRJRiAoKQogCiBJRiAoRU5B QkxFX0RBVEFCQVNFKQpAQCAtMTU0Miw2ICsxNTQ5LDcgQEAgaWYgKEVOQUJMRV9GSUxFX1NZU1RF TSkKICAgICAgICAgZmlsZWFwaS9GaWxlQ2FsbGJhY2suaWRsCiAgICAgICAgIGZpbGVhcGkvRmls ZUVudHJ5LmlkbAogICAgICAgICBmaWxlYXBpL0ZpbGVFbnRyeVN5bmMuaWRsCisgICAgICAgIGZp bGVhcGkvRmlsZUV4Y2VwdGlvbi5pZGwKICAgICAgICAgZmlsZWFwaS9GaWxlU3lzdGVtQ2FsbGJh Y2suaWRsCiAgICAgICAgIGZpbGVhcGkvRmlsZVdyaXRlckNhbGxiYWNrLmlkbAogICAgICAgICBm aWxlYXBpL0ZpbGVXcml0ZXIuaWRsCkBAIC0xNTQ5LDYgKzE1NTcsNyBAQCBpZiAoRU5BQkxFX0ZJ TEVfU1lTVEVNKQogICAgICAgICBmaWxlYXBpL1dlYktpdEZsYWdzLmlkbAogICAgICAgICBmaWxl YXBpL01ldGFkYXRhLmlkbAogICAgICAgICBmaWxlYXBpL01ldGFkYXRhQ2FsbGJhY2suaWRsCisg ICAgICAgIGZpbGVhcGkvT3BlcmF0aW9uTm90QWxsb3dlZEV4Y2VwdGlvbi5pZGwKICAgICApCiBF TkRJRiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EzMzhlNWI2NzJkMTc2MWYxNmE5NWE2ZTY1N2Q0MzRk YWMwOWYxZS4uNjEwN2I0ZGY4YmY3ZjhjNWVmMDI5MDViYWFhMGJmZDQ1OGVmNjYzNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA4LTI0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEg IDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFtDTWFrZV0gRml4IGJ1aWxkIHdpdGgg RU5BQkxFX0JMT0Igb3IgRU5BQkxFX0ZJTEVfU1lTVEVNLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY4ODAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZW5lcmF0ZSBhbmQgYnVpbGQgc29tZSBhZGRpdGlv bmFsIGZpbGVzIHJlcXVpcmVkIGJ5IHRoZXNlIG9wdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBhcyB0aGlzIGlzIGEgYnVpbGQgZml4IGZvciBzb21lIGJ1aWxkIG9wdGlvbnMuCisKKyAg ICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMS0wOC0yNCAgVGF0aWFuYSBNZXNoa292YSAg PHRhdGlhbmEubWVzaGtvdmFAbm9raWEuY29tPgogCiAgICAgICAgIFBhaW50IFNsaWRlclRyYWNr IGFuZCBTbGlkZXJUaHVtYiBpbmRlcGVuZGVudGx5Lgo= 105050 2011-08-24 12:56:18 -0700 2011-08-24 13:03:22 -0700 Patch bug-66880-20110824165950.patch text/plain 1913 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzlmNTlh Y2JiMTMwNTkwNjBlMGViYzYwN2I4ODVjNDgwNGY2ODNmMS4uZTVjM2I3ZGU4MTYwNTAyNjk1OWJi ZWQyOTA2MmVmYmZmYjExMDdlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEzODYsMTAgKzEz ODYsMTYgQEAgSUYgKEVOQUJMRV9CTE9CKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwogICAgICAgICBmaWxlYXBpL0ZpbGVSZWFkZXIuY3BwCiAgICAgICAgIGZpbGVhcGkvRmlsZVJl YWRlckxvYWRlci5jcHAKKyAgICAgICAgZmlsZWFwaS9GaWxlUmVhZGVyU3luYy5jcHAKICAgICAg ICAgZmlsZWFwaS9GaWxlVGhyZWFkLmNwcAogICAgICAgICBmaWxlYXBpL0ZpbGVTdHJlYW1Qcm94 eS5jcHAKICAgICAgICAgcGxhdGZvcm0vRmlsZVN0cmVhbS5jcHAKICAgICApCisKKyAgICBMSVNU KEFQUEVORCBXZWJDb3JlX0lETF9GSUxFUworICAgICAgIGZpbGVhcGkvRmlsZVJlYWRlclN5bmMu aWRsCisgICAgICAgZmlsZWFwaS9PcGVyYXRpb25Ob3RBbGxvd2VkRXhjZXB0aW9uLmlkbAorICAg ICkKIEVORElGICgpCiAKIElGIChFTkFCTEVfREFUQUJBU0UpCkBAIC0xNTQ5LDkgKzE1NTUsMTYg QEAgaWYgKEVOQUJMRV9GSUxFX1NZU1RFTSkKICAgICAgICAgZmlsZWFwaS9XZWJLaXRGbGFncy5p ZGwKICAgICAgICAgZmlsZWFwaS9NZXRhZGF0YS5pZGwKICAgICAgICAgZmlsZWFwaS9NZXRhZGF0 YUNhbGxiYWNrLmlkbAorICAgICAgICBmaWxlYXBpL09wZXJhdGlvbk5vdEFsbG93ZWRFeGNlcHRp b24uaWRsCiAgICAgKQogRU5ESUYgKCkKIAorSUYgKEVOQUJMRV9CTE9CIE9SIEVOQUJMRV9GSUxF X1NZU1RFTSkKKyAgIExJU1QoQVBQRU5EIFdlYkNvcmVfSURMX0ZJTEVTCisgICAgICAgZmlsZWFw aS9GaWxlRXhjZXB0aW9uLmlkbAorICAgKQorRU5ESUYgKCkKKwogSUYgKEVOQUJMRV9YUEFUSCkK ICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX0lETF9GSUxFUwogICAgICAgICB4bWwvWFBhdGhFdmFs dWF0b3IuaWRsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EzMzhlNWI2NzJkMTc2MWYxNmE5NWE2ZTY1N2Q0MzRk YWMwOWYxZS4uNjEwN2I0ZGY4YmY3ZjhjNWVmMDI5MDViYWFhMGJmZDQ1OGVmNjYzNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA4LTI0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEg IDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFtDTWFrZV0gRml4IGJ1aWxkIHdpdGgg RU5BQkxFX0JMT0Igb3IgRU5BQkxFX0ZJTEVfU1lTVEVNLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY4ODAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZW5lcmF0ZSBhbmQgYnVpbGQgc29tZSBhZGRpdGlv bmFsIGZpbGVzIHJlcXVpcmVkIGJ5IHRoZXNlIG9wdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBhcyB0aGlzIGlzIGEgYnVpbGQgZml4IGZvciBzb21lIGJ1aWxkIG9wdGlvbnMuCisKKyAg ICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMS0wOC0yNCAgVGF0aWFuYSBNZXNoa292YSAg PHRhdGlhbmEubWVzaGtvdmFAbm9raWEuY29tPgogCiAgICAgICAgIFBhaW50IFNsaWRlclRyYWNr IGFuZCBTbGlkZXJUaHVtYiBpbmRlcGVuZGVudGx5Lgo= 105052 2011-08-24 13:03:28 -0700 2011-08-25 06:48:03 -0700 Third time is a charm bug-66880-20110824170700.patch text/plain 1762 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzlmNTlh Y2JiMTMwNTkwNjBlMGViYzYwN2I4ODVjNDgwNGY2ODNmMS4uNWE5ODIwZTJjNzJkYjYzZTk0OWEz ZTI1MjQ4MDgyODk1ODgzZGVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEzODYsMTAgKzEz ODYsMTUgQEAgSUYgKEVOQUJMRV9CTE9CKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwogICAgICAgICBmaWxlYXBpL0ZpbGVSZWFkZXIuY3BwCiAgICAgICAgIGZpbGVhcGkvRmlsZVJl YWRlckxvYWRlci5jcHAKKyAgICAgICAgZmlsZWFwaS9GaWxlUmVhZGVyU3luYy5jcHAKICAgICAg ICAgZmlsZWFwaS9GaWxlVGhyZWFkLmNwcAogICAgICAgICBmaWxlYXBpL0ZpbGVTdHJlYW1Qcm94 eS5jcHAKICAgICAgICAgcGxhdGZvcm0vRmlsZVN0cmVhbS5jcHAKICAgICApCisKKyAgICBMSVNU KEFQUEVORCBXZWJDb3JlX0lETF9GSUxFUworICAgICAgIGZpbGVhcGkvRmlsZVJlYWRlclN5bmMu aWRsCisgICAgKQogRU5ESUYgKCkKIAogSUYgKEVOQUJMRV9EQVRBQkFTRSkKQEAgLTE1NTIsNiAr MTU1NywxMyBAQCBpZiAoRU5BQkxFX0ZJTEVfU1lTVEVNKQogICAgICkKIEVORElGICgpCiAKK0lG IChFTkFCTEVfQkxPQiBPUiBFTkFCTEVfRklMRV9TWVNURU0pCisgICBMSVNUKEFQUEVORCBXZWJD b3JlX0lETF9GSUxFUworICAgICAgIGZpbGVhcGkvRmlsZUV4Y2VwdGlvbi5pZGwKKyAgICAgICBm aWxlYXBpL09wZXJhdGlvbk5vdEFsbG93ZWRFeGNlcHRpb24uaWRsCisgICApCitFTkRJRiAoKQor CiBJRiAoRU5BQkxFX1hQQVRIKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfSURMX0ZJTEVTCiAg ICAgICAgIHhtbC9YUGF0aEV2YWx1YXRvci5pZGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYTMzOGU1YjY3MmQx NzYxZjE2YTk1YTZlNjU3ZDQzNGRhYzA5ZjFlLi42MTA3YjRkZjhiZjdmOGM1ZWYwMjkwNWJhYWEw YmZkNDU4ZWY2NjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjQgIFJh cGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0NN YWtlXSBGaXggYnVpbGQgd2l0aCBFTkFCTEVfQkxPQiBvciBFTkFCTEVfRklMRV9TWVNURU0uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njg4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdlbmVyYXRlIGFu ZCBidWlsZCBzb21lIGFkZGl0aW9uYWwgZmlsZXMgcmVxdWlyZWQgYnkgdGhlc2Ugb3B0aW9ucy4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIHRoaXMgaXMgYSBidWlsZCBmaXggZm9yIHNvbWUg YnVpbGQgb3B0aW9ucy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDExLTA4LTI0 ICBUYXRpYW5hIE1lc2hrb3ZhICA8dGF0aWFuYS5tZXNoa292YUBub2tpYS5jb20+CiAKICAgICAg ICAgUGFpbnQgU2xpZGVyVHJhY2sgYW5kIFNsaWRlclRodW1iIGluZGVwZW5kZW50bHkuCg==