66875 2011-08-24 11:59:52 -0700 Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac 2011-08-24 23:26:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 1 avi jamesr webkit.review.bot oldest_to_newest 456280 0 avi 2011-08-24 11:59:52 -0700 Cr bug: http://code.google.com/p/chromium/issues/detail?id=93830 There's a crashing layout test on mac in the gpu config, tested with chromium r97735 + WebKit r93540. Avi says it's related to a known issue. To reproduce this crash build DumpRenderTree (the target is in third_party/WebKit/Source/WebKit/chromium/WebKit.xcodeproj) and run it with the following flags: --test-shell --pixel-tests=/usr/local/home/jamesr/chrome/src/webkit/Debug/layout-test-results/png_result0.png --enable-accelerated-2d-canvas --enable-accelerated-compositing then pass the following two lines to stdin (separate lines): $CHROME_REPOSITORY_ROOT/src/third_party/WebKit/LayoutTests/compositing/animation/busy-indicator.html $CHROME_REPOSITORY_ROOT/src/third_party/WebKit/LayoutTests/compositing/iframes/iframe-size-to-zero.html The crashing stack is: #0 0x9069cf8b in objc_msgSend () #1 0x0032a5e0 in ?? () #2 0x0e1a1f17 in WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb (this=0x11f6d16c, canvas=0x1c4a8620, state=WebKit::WebThemeEngine::StateActive, size=WebKit::WebThemeEngine::SizeRegular, rect=@0xbfffbb28, scrollbarInfo=@0xbfffbb10) at /usr/local/home/jamesr/chrome/src/third_party/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:195 #3 0x0e1a1ab1 in WebThemeEngineDRTMac::paintScrollbarThumb (this=0x11f6d16c, canvas=0x1c4a8620, state=WebKit::WebThemeEngine::StateActive, size=WebKit::WebThemeEngine::SizeRegular, rect=@0xbfffbb28, scrollbarInfo=@0xbfffbb10) at /usr/local/home/jamesr/chrome/src/third_party/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:106 456289 1 105037 avi 2011-08-24 12:06:09 -0700 Created attachment 105037 Patch 456322 2 105037 jamesr 2011-08-24 12:46:59 -0700 Comment on attachment 105037 Patch Hurray! Thanks for fixing this. 456347 3 105037 webkit.review.bot 2011-08-24 13:04:58 -0700 Comment on attachment 105037 Patch Clearing flags on attachment: 105037 Committed r93724: <http://trac.webkit.org/changeset/93724> 456348 4 webkit.review.bot 2011-08-24 13:05:02 -0700 All reviewed patches have been landed. Closing bug. 105037 2011-08-24 12:06:09 -0700 2011-08-24 13:04:57 -0700 Patch bug-66875-20110824150608.patch text/plain 2500 avi SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkzNzE3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDgtMjQgIEF2aSBEcmlzc21hbiAgPGF2aUBnb29nbGUuY29tPgorCisg ICAgICAgIENyYXNoIHdoZW4gcmVzdG9yaW5nIE5TR3JhcGhpY3NDb250ZXh0IHdoZW4gcnVubmlu ZyB0aGUgQ2hyb21pdW0gR1BVIGxheW91dCB0ZXN0cyBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9X ZWJUaGVtZUVuZ2luZURSVE1hYy5tbToKKyAgICAgICAgKFdlYlRoZW1lRW5naW5lRFJUTWFjOjpw YWludE5TU2Nyb2xsZXJTY3JvbGxiYXJUaHVtYik6CisKIDIwMTEtMDgtMjMgIERpbWl0cmkgR2xh emtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYWtlIG5vdGlmaWNhdGlv bnMgYXBwZWFyIGluIHRpbWUgb3JkZXIgYWdhaW4uCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5tbQkocmV2aXNpb24g OTM3MTUpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURS VE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTYwLDYgKzE2MCw3IEBAIHZvaWQgV2ViVGhlbWVF bmdpbmVEUlRNYWM6OnBhaW50TlNTY3JvbGwKICAgICBjb25zdCBXZWJSZWN0JiByZWN0LAogICAg IGNvbnN0IFdlYlRoZW1lRW5naW5lOjpTY3JvbGxiYXJJbmZvJiBzY3JvbGxiYXJJbmZvKQogewor ICAgIFtOU0dyYXBoaWNzQ29udGV4dCBzYXZlR3JhcGhpY3NTdGF0ZV07CiAgICAgTlNTY3JvbGxl ciogc2Nyb2xsZXIgPSBbW05TU2Nyb2xsZXIgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVj dChyZWN0LngsIHJlY3QueSwgcmVjdC53aWR0aCwgcmVjdC5oZWlnaHQpXTsKICAgICBbc2Nyb2xs ZXIgc2V0RW5hYmxlZDpzdGF0ZSAhPSBXZWJUaGVtZUVuZ2luZTo6U3RhdGVEaXNhYmxlZF07CiAg ICAgaWYgKHN0YXRlID09IFdlYlRoZW1lRW5naW5lOjpTdGF0ZUluYWN0aXZlKQpAQCAtMTc1LDcg KzE3Niw2IEBAIHZvaWQgV2ViVGhlbWVFbmdpbmVEUlRNYWM6OnBhaW50TlNTY3JvbGwKICAgICBm bG9hdCBrbm9iUHJvcG9ydGlvbiA9IGZsb2F0KHNjcm9sbGJhckluZm8udmlzaWJsZVNpemUpIC8g ZmxvYXQoc2Nyb2xsYmFySW5mby50b3RhbFNpemUpOwogICAgIFtzY3JvbGxlciBzZXRLbm9iUHJv cG9ydGlvbjoga25vYlByb3BvcnRpb25dOwogCi0gICAgTlNHcmFwaGljc0NvbnRleHQqIHByZXZp b3VzR3JhcGhpY3NDb250ZXh0ID0gW05TR3JhcGhpY3NDb250ZXh0IGN1cnJlbnRDb250ZXh0XTsK ICNpZiBXRUJLSVRfVVNJTkdfU0tJQQogICAgIGdmeDo6U2tpYUJpdExvY2tlciBiaXRMb2NrZXIo Y2FudmFzKTsKICAgICBDR0NvbnRleHRSZWYgY2dDb250ZXh0ID0gYml0TG9ja2VyLmNnQ29udGV4 dCgpOwpAQCAtMTg4LDE1ICsxODgsMTUgQEAgdm9pZCBXZWJUaGVtZUVuZ2luZURSVE1hYzo6cGFp bnROU1Njcm9sbAogICAgIC8vIERlc3BpdGUgcGFzc2luZyBpbiBmcmFtZVJlY3QoKSB0byB0aGUg c2Nyb2xsZXIsIGl0IGFsd2F5cyBkcmF3cyBhdCAoMCwgMCkuCiAgICAgLy8gRm9yY2UgaXQgdG8g ZHJhdyBpbiB0aGUgcmlnaHQgbG9jYXRpb24gYnkgdHJhbnNsYXRpbmcgdGhlIHdob2xlIGdyYXBo aWNzCiAgICAgLy8gY29udGV4dC4KLSAgICBbbnNHcmFwaGljc0NvbnRleHQgc2F2ZUdyYXBoaWNz U3RhdGVdOworICAgIENHQ29udGV4dFNhdmVHU3RhdGUoY2dDb250ZXh0KTsKICAgICBOU0FmZmlu ZVRyYW5zZm9ybSAqdHJhbnNmb3JtID0gW05TQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybV07CiAg ICAgW3RyYW5zZm9ybSB0cmFuc2xhdGVYQnk6cmVjdC54IHlCeTpyZWN0LnldOwogICAgIFt0cmFu c2Zvcm0gY29uY2F0XTsKIAogICAgIFtzY3JvbGxlciBkcmF3S25vYl07CisgICAgQ0dDb250ZXh0 UmVzdG9yZUdTdGF0ZShjZ0NvbnRleHQpOwogCiAgICAgW3Njcm9sbGVyIHJlbGVhc2VdOwogCi0g ICAgW25zR3JhcGhpY3NDb250ZXh0IHJlc3RvcmVHcmFwaGljc1N0YXRlXTsKLSAgICBbTlNHcmFw aGljc0NvbnRleHQgc2V0Q3VycmVudENvbnRleHQ6cHJldmlvdXNHcmFwaGljc0NvbnRleHRdOwor ICAgIFtOU0dyYXBoaWNzQ29udGV4dCByZXN0b3JlR3JhcGhpY3NTdGF0ZV07CiB9Cg==