66866 2011-08-24 10:56:59 -0700 [EFL] Add API to call Frame::scalePage. 2011-09-28 18:57:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 rakuco rakuco leandro ryuan.choi oldest_to_newest 456202 0 rakuco 2011-08-24 10:56:59 -0700 [EFL] Add API to call Frame::scalePage. 456203 1 105020 rakuco 2011-08-24 10:59:11 -0700 Created attachment 105020 Patch 456479 2 ryuan.choi 2011-08-24 15:39:43 -0700 I'm not sure. IMO, we have too many zoom related apis. Please see Bug 62842 . Now we are testing this to replace cairo scaling, local patch. 456599 3 rakuco 2011-08-24 18:56:35 -0700 Some parts of both patches do overlap. I have a few questions/concerns about dropping this one altogether in favor of the other patch: a) I did not understand what you mean with "Now we are testing this to replace cairo scaling, local patch". Do you mean you will upload a new patch to bug 62842? b) Is the behaviour of that code going to be the same as the one here? _ewk_view_smart_zoom_set does more than this internal function. c) The parameter types are different in this function and ewk_view_zoom_set. 456658 4 ryuan.choi 2011-08-24 23:05:00 -0700 (In reply to comment #3) > Some parts of both patches do overlap. I have a few questions/concerns about dropping this one altogether in favor of the other patch: > > a) I did not understand what you mean with "Now we are testing this to replace cairo scaling, local patch". Do you mean you will upload a new patch to bug 62842? Sorry for the confusion. I means that we are refactoring local patches(cairo scaling) to it. > b) Is the behaviour of that code going to be the same as the one here? _ewk_view_smart_zoom_set does more than this internal function. > c) The parameter types are different in this function and ewk_view_zoom_set. OK. after more thinking, Bug 62842 can change to use this. I'll check zoom related APIs more and make new patch for Bug 62842. So, this patch is fine to me. 465894 5 105020 kenneth 2011-09-12 15:58:49 -0700 Comment on attachment 105020 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105020&action=review > Source/WebKit/efl/ChangeLog:10 > + This bit of API is required by DRT's EventSender, as it is used by > + tests which call zoom-related code, such as > + fast/dom/Element/scale-page-client-rects.html. For DRT add in something like DumpRenderTreeSupport class, if really needed at all. 466992 6 rakuco 2011-09-14 06:33:19 -0700 Right, I'm closing this one and will put it in a separate report with DumpRenderTreeSupportEfl. 475180 7 105020 rakuco 2011-09-28 18:57:52 -0700 Comment on attachment 105020 Patch Removing the cq? flag. 105020 2011-08-24 10:59:11 -0700 2011-09-28 18:57:52 -0700 Patch bug-66866-20110824150243.patch text/plain 2324 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBiMDVkNDcwMjU1 OTVmYWEzMDBhNWQ2MTVlMmJmZjVmODdiMDcwYjUyLi4yNTMwYThmYWM5MWVjMzMzNGQ1ZjczNGE2 NDRiYzBlNTE5MmI3MjYyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEt MDgtMjQgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gQWRkIEFQSSB0byBjYWxsIEZyYW1lOjpzY2FsZVBhZ2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njg2NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYml0IG9mIEFQSSBpcyBy ZXF1aXJlZCBieSBEUlQncyBFdmVudFNlbmRlciwgYXMgaXQgaXMgdXNlZCBieQorICAgICAgICB0 ZXN0cyB3aGljaCBjYWxsIHpvb20tcmVsYXRlZCBjb2RlLCBzdWNoIGFzCisgICAgICAgIGZhc3Qv ZG9tL0VsZW1lbnQvc2NhbGUtcGFnZS1jbGllbnQtcmVjdHMuaHRtbC4KKworICAgICAgICAqIGV3 ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChl d2tfdmlld19wYWdlX3NjYWxlKToKKwogMjAxMS0wOC0yNCAgSmFlaHVuIExpbSAgPGxqYWVodW4u bGltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBkdW1teSBJY29uRGF0YWJhc2VD bGllbnRFZmwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCmluZGV4IDNkNjIyODQ3NjM2 YTg0YmViMDYzODE3ODg0ODUzMmMzZjM1NDM4ZWUuLjcxZTNhYzNlNTM0ZWI5Mjc3MDZhMGU0M2Rm MTg1OGU0NzBhZjI1OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJp dmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCkBAIC0xMzgs NiArMTM4LDggQEAgdm9pZCBld2tfdmlld19kb3dubG9hZF9yZXF1ZXN0KEV2YXNfT2JqZWN0ICpv LCBFd2tfRG93bmxvYWQgKmRvd25sb2FkKTsKIHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9j b250ZW50c19jaGFuZ2VkKEV2YXNfT2JqZWN0ICpvKTsKIHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2Ns aWVudF9zZWxlY3Rpb25fY2hhbmdlZChFdmFzX09iamVjdCAqbyk7CiAKK3ZvaWQgZXdrX3ZpZXdf cGFnZV9zY2FsZShjb25zdCBFdmFzX09iamVjdCAqbywgZmxvYXQgc2NhbGVGYWN0b3IsIGZsb2F0 IHgsIGZsb2F0IHkpOworCiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiB2b2lkIGV3 a192aWV3X2pzX3dpbmRvd19vYmplY3RfY2xlYXIoRXZhc19PYmplY3QgKm8sIEV2YXNfT2JqZWN0 ICpmcmFtZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDE5NTlk NDY4NzgyYWI4ZTZlMmM2NDk5YTNmMmVmZGFjNGRlNDRjYTIuLmQ4ZTgwOGE3ODc4MmZmNTVhODAy OTQ3MGMwMGNjZjQwZmY2Yjc1ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAt MzcyNywzICszNzI3LDE1IEBAIHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9jb250ZW50c19j aGFuZ2VkKEV2YXNfT2JqZWN0ICpvKQogewogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNr X2NhbGwobywgImVkaXRvcmNsaWVudCxjb250ZW50cyxjaGFuZ2VkIiwgMCk7CiB9CisKKy8qKgor ICogQGludGVybmFsCisgKiBTY2FsZXMgdGhlIGdpdmVuIHBhZ2UgYXJvdW5kIHBvaW50cyBAcCB4 IGFuZCBAcCB5IGJ5IHRoZSBnaXZlbiBAcCBzY2FsZUZhY3Rvci4KKyAqLwordm9pZCBld2tfdmll d19wYWdlX3NjYWxlKGNvbnN0IEV2YXNfT2JqZWN0ICpvLCBmbG9hdCBzY2FsZUZhY3RvciwgZmxv YXQgeCwgZmxvYXQgeSkKK3sKKyAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOworICAgIEVXS19W SUVXX1BSSVZfR0VUKHNkLCBwcml2KTsKKworICAgIHByaXYtPm1haW5fZnJhbWUtPnNjYWxlUGFn ZShzY2FsZUZhY3RvciwgV2ViQ29yZTo6SW50UG9pbnQoeCwgeSkpOworfQo=