66864 2011-08-24 10:28:31 -0700 JSHTMLImageElement (and associated Node) is abandoned when image load is canceled 2011-08-24 11:28:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam oldest_to_newest 456171 0 sam 2011-08-24 10:28:31 -0700 JSHTMLImageElement (and associated Node) is abandoned when image load is canceled 456179 1 sam 2011-08-24 10:34:07 -0700 In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements. In the case that an image load is canceled, the haveFiredLoadEvent never true, so the JSHTMLImageElement is kept alive forever (and since it references the global object, it keeps the entire graph alive as well). 456181 2 105015 sam 2011-08-24 10:35:48 -0700 Created attachment 105015 Patch 456184 3 sam 2011-08-24 10:37:38 -0700 <rdar://problem/9925630> 456250 4 sam 2011-08-24 11:28:16 -0700 Committed r93717: <http://trac.webkit.org/changeset/93717> 105015 2011-08-24 10:35:48 -0700 2011-08-24 10:37:17 -0700 Patch bug-66864-20110824103546.patch text/plain 1717 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNzA3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMjQgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBKU0hUTUxJbWFnZUVsZW1lbnQgKGFuZCBh c3NvY2lhdGVkIE5vZGUpIGlzIGFiYW5kb25lZCB3aGVuIGltYWdlIGxvYWQgaXMgY2FuY2VsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODY0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIEpT QyBiaW5kaW5ncywgd2UgdXNlIEhUTUxJbWFnZUVsZW1lbnQ6Omhhc1BlbmRpbmdBY3Rpdml0eSgp ICh3aGljaCBpbiB0dXJuIGNhbGxzCisgICAgICAgIEhUTUxJbWFnZUxvYWRlcjo6aGF2ZUZpcmVk TG9hZEV2ZW50KCkpIHRvIHJlYXNvbiBhYm91dCB0aGUgbGl2ZW5lc3Mgb2YgSlNIVE1MSW1hZ2VF bGVtZW50cy4KKyAgICAgICAgSW4gdGhlIGNhc2UgdGhhdCBhbiBpbWFnZSBsb2FkIGlzIGNhbmNl bGVkLCB0aGUgaGF2ZUZpcmVkTG9hZEV2ZW50IG5ldmVyIHRydWUsIHNvIHRoZQorICAgICAgICBK U0hUTUxJbWFnZUVsZW1lbnQgaXMga2VwdCBhbGl2ZSBmb3JldmVyIChhbmQgc2luY2UgaXQgcmVm ZXJlbmNlcyB0aGUgZ2xvYmFsIG9iamVjdCwgaXQKKyAgICAgICAga2VlcHMgdGhlIGVudGlyZSBn cmFwaCBhbGl2ZSBhcyB3ZWxsKS4KKworICAgICAgICAqIGxvYWRlci9JbWFnZUxvYWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUxvYWRlcjo6bm90aWZ5RmluaXNoZWQpOgorICAgICAg ICBTZXQgbV9maXJlZExvYWQgdG8gdHJ1ZSBpbiB0aGUgY2FzZSBvZiBhIGNhbmNlbGVkIGxvYWQs IHRvIHJlc2V0IHRoZSBzdGF0ZSBiYWNrIHRvCisgICAgICAgIGl0cyBpbml0aWFsIHZhbHVlcy4K KwogMjAxMS0wOC0yNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQWRkIDkgbW9yZSBqYXZhc2NyaXB0IGZpbGVzIHRvIHRoZSBj b21waWxhdGlvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9JbWFnZUxvYWRlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ltYWdlTG9hZGVyLmNwcAkocmV2 aXNpb24gOTM1MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSW1hZ2VMb2FkZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMzQsOCArMjM0LDEwIEBAIHZvaWQgSW1hZ2VMb2FkZXI6Om5vdGlm eUZpbmlzaGVkKENhY2hlZFIKICAgICBpZiAobV9maXJlZExvYWQpCiAgICAgICAgIHJldHVybjsK IAotICAgIGlmIChyZXNvdXJjZS0+d2FzQ2FuY2VsZWQoKSkKKyAgICBpZiAocmVzb3VyY2UtPndh c0NhbmNlbGVkKCkpIHsKKyAgICAgICAgbV9maXJlZExvYWQgPSB0cnVlOwogICAgICAgICByZXR1 cm47CisgICAgfQogCiAgICAgbG9hZEV2ZW50U2VuZGVyKCkuZGlzcGF0Y2hFdmVudFNvb24odGhp cyk7CiB9Cg==