66856 2011-08-24 06:56:37 -0700 [EFL] Do not always return the cached frame name. 2011-09-13 10:53:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco kenneth leandro webkit.review.bot oldest_to_newest 456080 0 rakuco 2011-08-24 06:56:37 -0700 [EFL] Do not always return the cached frame name. 456082 1 104993 rakuco 2011-08-24 06:57:43 -0700 Created attachment 104993 Patch 456499 2 104993 ryuan.choi 2011-08-24 15:59:10 -0700 Comment on attachment 104993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:358 > + const WTF::String s = sd->frame->tree()->uniqueName(); > + const WTF::CString cs = s.utf8(); Informal r+. But, how do you think about making above as one line and giving better name? 456962 3 rakuco 2011-08-25 10:27:02 -0700 It is possible, but I would rather not do that in this patch, as it is not strictly related to this change. 465874 4 104993 kenneth 2011-09-12 15:48:15 -0700 Comment on attachment 104993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:361 > + if ((sd->name) && (!strcmp(sd->name, cs.data()))) > + return sd->name; WebKit's string classes can do comparison. Please avoid using pure C methods such as strcmp. 466319 5 107181 rakuco 2011-09-13 08:53:24 -0700 Created attachment 107181 Use operator== instead of strcmp 466344 6 107181 tonikitoo 2011-09-13 09:46:14 -0700 Comment on attachment 107181 Use operator== instead of strcmp View in context: https://bugs.webkit.org/attachment.cgi?id=107181&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:357 > + const WTF::String frameName = sd->frame->tree()->uniqueName(); nit: const here seem unusual. > Source/WebKit/efl/ewk/ewk_frame.cpp:359 > + if ((sd->name) && (sd->name == frameName)) nit: extra ()'s 466390 7 107181 webkit.review.bot 2011-09-13 10:53:20 -0700 Comment on attachment 107181 Use operator== instead of strcmp Clearing flags on attachment: 107181 Committed r95033: <http://trac.webkit.org/changeset/95033> 466391 8 webkit.review.bot 2011-09-13 10:53:25 -0700 All reviewed patches have been landed. Closing bug. 104993 2011-08-24 06:57:43 -0700 2011-09-13 08:53:17 -0700 Patch bug-66856-20110824110115.patch text/plain 1947 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBiMDVkNDcwMjU1 OTVmYWEzMDBhNWQ2MTVlMmJmZjVmODdiMDcwYjUyLi44MGVjYzU0N2FjNDJhNzYxNjAzOWMwOTM1 ZTQ4MjAwMDVmMmE5NTIxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDgtMjQgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gRG8gbm90IGFsd2F5cyByZXR1cm4gdGhlIGNhY2hlZCBmcmFtZSBuYW1lLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY4NTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgZnJh bWUgaGFzIGl0cyBwYXJlbnQgY2hhbmdlZCAodmlhIGFkb3B0Tm9kZSBhbmQgYXBwZW5kQ2hpbGQs CisgICAgICAgIGZvciBleGFtcGxlKSwgdGhlIGZyYW1lIG5hbWUgd2lsbCBjaGFuZ2UsIHNvIHdl IG5lZWQgdG8gYWNjb3VudCBmb3IKKyAgICAgICAgdGhhdCBjYXNlIGFuZCBjaGFuZ2UgdGhlIGNh Y2hlZCBuYW1lIHdoZW4gbmVlZGVkLgorCisgICAgICAgIFRoaXMgc2hvdWxkIG1ha2UgZmFzdC9m cmFtZXMvaWZyYW1lLXJlcGFyZW50aW5nLXVuaXF1ZS1uYW1lLmh0bWwgcGFzcy4KKworICAgICAg ICAqIGV3ay9ld2tfZnJhbWUuY3BwOgorICAgICAgICAoZXdrX2ZyYW1lX25hbWVfZ2V0KToKKwog MjAxMS0wOC0yNCAgSmFlaHVuIExpbSAgPGxqYWVodW4ubGltQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtFRkxdIEFkZCBkdW1teSBJY29uRGF0YWJhc2VDbGllbnRFZmwuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfZnJhbWUuY3BwCmluZGV4IDkxZjIyMzc5MTRiNmRhNDQ3NzI3YmE4YzNlMGM2MjRiZWY3 NmMzYzcuLmNhNjM5NTJkMjg4M2E0ZTQ1ZDRiYTU3MGFjMDU5NjNhOGZlNjE5ODcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC0zNDksMTcgKzM0OSwxOSBAQCBjb25zdCBjaGFy ICpld2tfZnJhbWVfbmFtZV9nZXQoY29uc3QgRXZhc19PYmplY3QgKm8pCiB7CiAgICAgRVdLX0ZS QU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIDApOwogCi0gICAgaWYgKHNkLT5uYW1lKQotICAg ICAgICByZXR1cm4gc2QtPm5hbWU7Ci0KICAgICBpZiAoIXNkLT5mcmFtZSkgewogICAgICAgICBF UlIoImNvdWxkIG5vdCBnZXQgbmFtZSBvZiB1bmluaXRpYWxpemVkIGZyYW1lLiIpOwogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBXVEY6OlN0cmluZyBzID0gc2QtPmZyYW1lLT50cmVl KCktPnVuaXF1ZU5hbWUoKTsKLSAgICBXVEY6OkNTdHJpbmcgY3MgPSBzLnV0ZjgoKTsKLSAgICBz ZC0+bmFtZSA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkX2xlbmd0aChjcy5kYXRhKCksIGNzLmxlbmd0 aCgpKTsKKyAgICBjb25zdCBXVEY6OlN0cmluZyBzID0gc2QtPmZyYW1lLT50cmVlKCktPnVuaXF1 ZU5hbWUoKTsKKyAgICBjb25zdCBXVEY6OkNTdHJpbmcgY3MgPSBzLnV0ZjgoKTsKKworICAgIGlm ICgoc2QtPm5hbWUpICYmICghc3RyY21wKHNkLT5uYW1lLCBjcy5kYXRhKCkpKSkKKyAgICAgICAg cmV0dXJuIHNkLT5uYW1lOworCisgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlX2xlbmd0aCgm KHNkLT5uYW1lKSwgY3MuZGF0YSgpLCBjcy5sZW5ndGgoKSk7CisKICAgICByZXR1cm4gc2QtPm5h bWU7CiB9CiAK 107181 2011-09-13 08:53:24 -0700 2011-09-13 10:53:20 -0700 Use operator== instead of strcmp bug-66856-20110913125703.patch text/plain 1928 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTUwMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA1OGQ0Yjg0YjAz ZDNkZmY4ZmQ4MWNmYmE5NWUxODE2MzlhODY5MDFiLi5lMjg5NjMyZTNlMWNjNzY1ZjU0ZjIzYzdh ODllYzZkYjM2YTgyNmQ3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDktMTMgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gRG8gbm90IGFsd2F5cyByZXR1cm4gdGhlIGNhY2hlZCBmcmFtZSBuYW1lLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY4NTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgZnJh bWUgaGFzIGl0cyBwYXJlbnQgY2hhbmdlZCAodmlhIGFkb3B0Tm9kZSBhbmQgYXBwZW5kQ2hpbGQs CisgICAgICAgIGZvciBleGFtcGxlKSwgdGhlIGZyYW1lIG5hbWUgd2lsbCBjaGFuZ2UsIHNvIHdl IG5lZWQgdG8gYWNjb3VudCBmb3IKKyAgICAgICAgdGhhdCBjYXNlIGFuZCBjaGFuZ2UgdGhlIGNh Y2hlZCBuYW1lIHdoZW4gbmVlZGVkLgorCisgICAgICAgIFRoaXMgc2hvdWxkIG1ha2UgZmFzdC9m cmFtZXMvaWZyYW1lLXJlcGFyZW50aW5nLXVuaXF1ZS1uYW1lLmh0bWwgcGFzcy4KKworICAgICAg ICAqIGV3ay9ld2tfZnJhbWUuY3BwOgorICAgICAgICAoZXdrX2ZyYW1lX25hbWVfZ2V0KToKKwog MjAxMS0wOS0xMiAgRmxhdmlvIENlb2xpbiAgPGZsYXZpby5jZW9saW5AcHJvZnVzaW9uLm1vYmk+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX2ZyYW1lLmNwcAppbmRleCBlNjdmZTQxOWE1NzZhNzMwZjg2MWY0YzkwMjVjNzY1NmM2Y2I0 ZTJlLi5kYTQzNDQwZWFiYzQ3NDQxZmNkZDk3ZTZiNzk5ZTVmYjRiMzM5ZmFhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX2ZyYW1lLmNwcApAQCAtMzQ5LDE3ICszNDksMTggQEAgY29uc3QgY2hhciAq ZXdrX2ZyYW1lX25hbWVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKQogewogICAgIEVXS19GUkFN RV9TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCAwKTsKIAotICAgIGlmIChzZC0+bmFtZSkKLSAgICAg ICAgcmV0dXJuIHNkLT5uYW1lOwotCiAgICAgaWYgKCFzZC0+ZnJhbWUpIHsKICAgICAgICAgRVJS KCJjb3VsZCBub3QgZ2V0IG5hbWUgb2YgdW5pbml0aWFsaXplZCBmcmFtZS4iKTsKICAgICAgICAg cmV0dXJuIDA7CiAgICAgfQogCi0gICAgV1RGOjpTdHJpbmcgcyA9IHNkLT5mcmFtZS0+dHJlZSgp LT51bmlxdWVOYW1lKCk7Ci0gICAgV1RGOjpDU3RyaW5nIGNzID0gcy51dGY4KCk7Ci0gICAgc2Qt Pm5hbWUgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZF9sZW5ndGgoY3MuZGF0YSgpLCBjcy5sZW5ndGgo KSk7CisgICAgY29uc3QgV1RGOjpTdHJpbmcgZnJhbWVOYW1lID0gc2QtPmZyYW1lLT50cmVlKCkt PnVuaXF1ZU5hbWUoKTsKKworICAgIGlmICgoc2QtPm5hbWUpICYmIChzZC0+bmFtZSA9PSBmcmFt ZU5hbWUpKQorICAgICAgICByZXR1cm4gc2QtPm5hbWU7CisKKyAgICBlaW5hX3N0cmluZ3NoYXJl X3JlcGxhY2VfbGVuZ3RoKCYoc2QtPm5hbWUpLCBmcmFtZU5hbWUudXRmOCgpLmRhdGEoKSwgZnJh bWVOYW1lLmxlbmd0aCgpKTsKKwogICAgIHJldHVybiBzZC0+bmFtZTsKIH0KIAo=