66843 2011-08-24 01:55:51 -0700 Color chooser closes on "open new tab" 2011-09-06 15:42:03 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 keishi keishi oldest_to_newest 456018 0 keishi 2011-08-24 01:55:51 -0700 Color chooser closes on "open new tab" and "open Web Inspector". I caused this bug while solving the layer violation in Bug 62619. 456043 1 104978 keishi 2011-08-24 03:43:59 -0700 Created attachment 104978 patch 456147 2 104978 darin 2011-08-24 09:48:50 -0700 Comment on attachment 104978 patch Not a comment about this patch, but about the original code. This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there. On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away. 456786 3 keishi 2011-08-25 05:40:55 -0700 > On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away. You are absolutely right. I will abandon this idea to close the color panel when the element disappears for OS X. > This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there. I knew it was wrong but transitionToCommitted was the only place I could find. I will remove these lines immediately in an upcoming patch. I will close this bug as it is no longer relavent. Thanks for taking a look! 462940 4 104978 eric 2011-09-06 15:42:03 -0700 Comment on attachment 104978 patch Cleared review? from attachment 104978 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 104978 2011-08-24 03:43:59 -0700 2011-09-06 15:42:03 -0700 patch bug-66843-20110824194357.patch text/plain 3597 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogOTM2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMDliMTUyNWRkNWVkYmU5 YTBmNzRjODNiMjJmNDU0YTA2ZDJmOTA4Li40MDhjMDliMmU4N2U2NWQ3MDViM2E2ZGExMjdmMTVh NDgyZDUyNjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMjQgIEtlaXNo aSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29sb3IgY2hvb3NlciBj bG9zZXMgb24gJ29wZW4gbmV3IHRhYicKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY2ODQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNvbG9ySW5wdXRUeXBlOjpjbG9zZUNvbG9yQ2hvb3NlcklmQ3VycmVudENsaWVudEFuZElu RG9jdW1lbnQpOiBBZGRlZC4gQ2hlY2sgaWYgdGhlCisgICAgICAgIGRvY3VtZW50IG1hdGNoZXMg dGhlIGVsZW1lbnQncyBkb2N1bWVudC4KKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmg6 CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lTG9hZGVyOjp0cmFuc2l0aW9uVG9Db21taXR0ZWQpOiBDYWxsIGNsb3NlQ29sb3JDaG9vc2Vy SWZDdXJyZW50Q2xpZW50QW5kSW5Eb2N1bWVudAorICAgICAgICBpbnN0ZWFkIG9mIGNsb3NlQ29s b3JDaG9vc2VySWZDdXJyZW50Q2xpZW50CisKIDIwMTEtMDgtMjMgIE1hcmsgSGFobmVuYmVyZyAg PG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY2hlY2tzIHRvIGVuc3VyZSBh bGxvY2F0aW9uIGRvZXMgbm90IHRha2UgcGxhY2UgZHVyaW5nIGluaXRpYWxpemF0aW9uIG9mIEdD LW1hbmFnZWQgb2JqZWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklu cHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcAppbmRl eCA4ZGFkMmMzNDMwMTkyOTE4MDUyNjcwZjk1ZTU5NjQyMDk2NjMyYjFlLi41Y2ZlNjU4MjQyYWRj NDliY2E3NTk3OGVlODk3MmMxMTFlYWIzYzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0NvbG9ySW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5w dXRUeXBlLmNwcApAQCAtMjAyLDYgKzIwMiwxMyBAQCB2b2lkIENvbG9ySW5wdXRUeXBlOjpjbG9z ZUNvbG9yQ2hvb3NlcklmQ3VycmVudENsaWVudCgpIGNvbnN0CiAgICAgICAgIGNocm9tZS0+Y2xv c2VDb2xvckNob29zZXIoKTsKIH0KIAordm9pZCBDb2xvcklucHV0VHlwZTo6Y2xvc2VDb2xvckNo b29zZXJJZkN1cnJlbnRDbGllbnRBbmRJbkRvY3VtZW50KERvY3VtZW50KiBkb2N1bWVudCkgY29u c3QKK3sKKyAgICBpZiAoZWxlbWVudCgpLT5kb2N1bWVudCgpICE9IGRvY3VtZW50KQorICAgICAg ICByZXR1cm47CisgICAgY2xvc2VDb2xvckNob29zZXJJZkN1cnJlbnRDbGllbnQoKTsgICAgCit9 CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShJTlBVVF9DT0xP UikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuaAppbmRleCA5MjhlZjg2OGYxYjdiMzhl OTFlMzkyMTM3OTI5OWU0ZTUwMDU0ZGY2Li4xYzdiZjJiN2E0YzliYjk1OTM3YjFiYjNmOGMxMjI4 Mzg4MmY3ZTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5oCkBAIC0zOCwxMiAr MzgsMTQgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBEb2N1bWVudDsKKwogY2xh c3MgQ29sb3JJbnB1dFR5cGUgOiBwdWJsaWMgSW5wdXRUeXBlLCBwdWJsaWMgQ29sb3JDaG9vc2Vy Q2xpZW50IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc093blB0cjxJbnB1dFR5cGU+IGNyZWF0 ZShIVE1MSW5wdXRFbGVtZW50Kik7CiAgICAgdmlydHVhbCB+Q29sb3JJbnB1dFR5cGUoKTsKIAot ICAgIHZvaWQgY2xvc2VDb2xvckNob29zZXJJZkN1cnJlbnRDbGllbnQoKSBjb25zdDsKKyAgICB2 b2lkIGNsb3NlQ29sb3JDaG9vc2VySWZDdXJyZW50Q2xpZW50QW5kSW5Eb2N1bWVudChEb2N1bWVu dCopIGNvbnN0OwogCiBwcml2YXRlOgogICAgIENvbG9ySW5wdXRUeXBlKEhUTUxJbnB1dEVsZW1l bnQqIGVsZW1lbnQpIDogSW5wdXRUeXBlKGVsZW1lbnQpIHsgfQpAQCAtNjMsNiArNjUsNyBAQCBw cml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBjb2xvclNlbGVjdGVkKGNvbnN0IENvbG9yJik7CiAg ICAgdmlydHVhbCBib29sIGlzQ29sb3JJbnB1dFR5cGUoKSBjb25zdDsKIAorICAgIHZvaWQgY2xv c2VDb2xvckNob29zZXJJZkN1cnJlbnRDbGllbnQoKSBjb25zdDsKICAgICB2b2lkIHVwZGF0ZUNv bG9yU3dhdGNoKCk7CiAgICAgSFRNTEVsZW1lbnQqIHNoYWRvd0NvbG9yU3dhdGNoKCkgY29uc3Q7 CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNGYwZjFmMzU2ZWE3 YTI4N2FiYWNkYWVmNDg2ODQzY2Y5NTM4Nzg2ZS4uZWY4YjllMzQ3MWYxYjM2ZjUxZjhmZGEwZmZj YzcyMTRkZTg0NmM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0x ODU2LDggKzE4NTYsOCBAQCB2b2lkIEZyYW1lTG9hZGVyOjp0cmFuc2l0aW9uVG9Db21taXR0ZWQo UGFzc1JlZlB0cjxDYWNoZWRQYWdlPiBjYWNoZWRQYWdlKQogCiAjaWYgRU5BQkxFKElOUFVUX0NP TE9SKQogICAgIENvbG9yQ2hvb3NlckNsaWVudCogY29sb3JDaG9vc2VyQ2xpZW50ID0gQ29sb3JD aG9vc2VyOjpjaG9vc2VyKCktPmNsaWVudCgpOwotICAgIGlmIChjb2xvckNob29zZXJDbGllbnQg JiYgY29sb3JDaG9vc2VyQ2xpZW50LT5pc0NvbG9ySW5wdXRUeXBlKCkpCi0gICAgICAgIHN0YXRp Y19jYXN0PENvbG9ySW5wdXRUeXBlKj4oY29sb3JDaG9vc2VyQ2xpZW50KS0+Y2xvc2VDb2xvckNo b29zZXJJZkN1cnJlbnRDbGllbnQoKTsKKyAgICBpZiAoY29sb3JDaG9vc2VyQ2xpZW50ICYmIGNv bG9yQ2hvb3NlckNsaWVudC0+aXNDb2xvcklucHV0VHlwZSgpICYmIG1fZnJhbWUtPmRvY3VtZW50 KCkpCisgICAgICAgIHN0YXRpY19jYXN0PENvbG9ySW5wdXRUeXBlKj4oY29sb3JDaG9vc2VyQ2xp ZW50KS0+Y2xvc2VDb2xvckNob29zZXJJZkN1cnJlbnRDbGllbnRBbmRJbkRvY3VtZW50KG1fZnJh bWUtPmRvY3VtZW50KCkpOwogI2VuZGlmCiAKICAgICBtX2NsaWVudC0+c2V0Q29waWVzT25TY3Jv bGwoKTsK