66831 2011-08-23 18:01:04 -0700 WebSearchableFormData crashes when given a detached HTMLFormElement 2011-08-23 21:33:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov webkit.review.bot oldest_to_newest 455892 0 abarth 2011-08-23 18:01:04 -0700 WebSearchableFormData crashes when given a detached HTMLFormElement 455894 1 104948 abarth 2011-08-23 18:02:09 -0700 Created attachment 104948 Patch 455896 2 104948 webkit.review.bot 2011-08-23 18:05:08 -0700 Comment on attachment 104948 Patch Attachment 104948 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9480721 455902 3 104952 abarth 2011-08-23 18:16:44 -0700 Created attachment 104952 Patch 455947 4 104952 dglazkov 2011-08-23 20:33:51 -0700 Comment on attachment 104952 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review > Source/WebKit/chromium/tests/data/form.html:1 > +<form action="about:blank" method="POST"></form> This test is too simple! 455948 5 abarth 2011-08-23 20:35:20 -0700 (In reply to comment #4) > (From update of attachment 104952 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review > > > Source/WebKit/chromium/tests/data/form.html:1 > > +<form action="about:blank" method="POST"></form> > > This test is too simple! I could take the "method" attribute away. :) 455957 6 104952 webkit.review.bot 2011-08-23 21:32:56 -0700 Comment on attachment 104952 Patch Clearing flags on attachment: 104952 Committed r93692: <http://trac.webkit.org/changeset/93692> 455958 7 webkit.review.bot 2011-08-23 21:33:00 -0700 All reviewed patches have been landed. Closing bug. 104948 2011-08-23 18:02:09 -0700 2011-08-23 18:16:40 -0700 Patch bug-66831-20110823180208.patch text/plain 3128 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MzY3NikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBXZWJTZWFyY2hhYmxlRm9ybURhdGEgY3Jhc2hlcyB3aGVuIGdpdmVuIGEgZGV0YWNoZWQgSFRN TEZvcm1FbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIG5lZWQgdG8gbnVsbC1jaGVjayB0aGUgRnJhbWUuCisKKyAgICAgICAgKiBzcmMvV2Vi U2VhcmNoYWJsZUZvcm1EYXRhLmNwcDoKKyAgICAgICAgKEhUTUxOYW1lczo6R2V0Rm9ybUVuY29k aW5nKToKKyAgICAgICAgKiB0ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0 OjpURVNUX0YpOgorICAgICAgICAqIHRlc3RzL2RhdGEvZm9ybS5odG1sOiBBZGRlZC4KKwogMjAx MS0wOC0yMyAgRG1pdHJ5IExvbW92ICA8RG1pdHJ5IExvbW92IChkc2xvbW92QGdvb2dsZS5jb20p PgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njc1 MSAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlYXJjaGFibGVGb3JtRGF0 YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VhcmNo YWJsZUZvcm1EYXRhLmNwcAkocmV2aXNpb24gOTM2NDMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJTZWFyY2hhYmxlRm9ybURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2 ICs2NCw4IEBAIHZvaWQgR2V0Rm9ybUVuY29kaW5nKGNvbnN0IEhUTUxGb3JtRWxlbWUKICAgICAg ICAgaWYgKGVuY29kaW5nLT5pc1ZhbGlkKCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQor ICAgIGlmICghZm9ybS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkKKyAgICAgICAgIHJldHVybjsKICAg ICAqZW5jb2RpbmcgPSBUZXh0RW5jb2RpbmcoZm9ybS0+ZG9jdW1lbnQoKS0+bG9hZGVyKCktPndy aXRlcigpLT5lbmNvZGluZygpKTsKIH0KIApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAkocmV2aXNpb24gOTM2NDMpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMw LDExICszMCwxMSBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKLSNpbmNsdWRlIDxnb29nbGV1 cmwvc3JjL2d1cmwuaD4KLSNpbmNsdWRlIDxndGVzdC9ndGVzdC5oPgotI2luY2x1ZGUgPHdlYmtp dC9zdXBwb3J0L3dlYmtpdF9zdXBwb3J0Lmg+CisjaW5jbHVkZSAiV2ViRG9jdW1lbnQuaCIKKyNp bmNsdWRlICJXZWJGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVk ZSAiV2ViRnJhbWVDbGllbnQuaCIKKyNpbmNsdWRlICJXZWJTZWFyY2hhYmxlRm9ybURhdGEuaCIK ICNpbmNsdWRlICJXZWJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogI2luY2x1 ZGUgIldlYlVSTC5oIgpAQCAtNDIsNiArNDIsOSBAQAogI2luY2x1ZGUgIldlYlVSTFJlc3BvbnNl LmgiCiAjaW5jbHVkZSAiV2ViVmlldy5oIgogI2luY2x1ZGUgInY4LmgiCisjaW5jbHVkZSA8Z29v Z2xldXJsL3NyYy9ndXJsLmg+CisjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KKyNpbmNsdWRlIDx3 ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViS2l0 OwogCkBAIC0xNDUsNCArMTQ4LDI1IEBAIFRFU1RfRihXZWJGcmFtZVRlc3QsIEZyYW1lRm9yRW50 ZXJlZENvbnQKICAgICB3ZWJWaWV3LT5jbG9zZSgpOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0 LCBGb3JtV2l0aE51bGxGcmFtZSkKK3sKKyAgICByZWdpc3Rlck1vY2tlZFVSTExvYWQoImZvcm0u aHRtbCIpOworCisgICAgVGVzdFdlYkZyYW1lQ2xpZW50IHdlYkZyYW1lQ2xpZW50OworICAgIFdl YlZpZXcqIHdlYlZpZXcgPSBXZWJWaWV3OjpjcmVhdGUoMCk7CisgICAgd2ViVmlldy0+aW5pdGlh bGl6ZU1haW5GcmFtZSgmd2ViRnJhbWVDbGllbnQpOworCisgICAgbG9hZEZyYW1lKHdlYlZpZXct Pm1haW5GcmFtZSgpLCAiZm9ybS5odG1sIik7CisgICAgc2VydmVSZXF1ZXN0cygpOworCisgICAg V2ViVmVjdG9yPFdlYkZvcm1FbGVtZW50PiBmb3JtczsKKyAgICB3ZWJWaWV3LT5tYWluRnJhbWUo KS0+ZG9jdW1lbnQoKS5mb3Jtcyhmb3Jtcyk7CisgICAgd2ViVmlldy0+Y2xvc2UoKTsKKworICAg IEVYUEVDVF9FUShmb3Jtcy5zaXplKCksIDEpOworCisgICAgLy8gVGhpcyB0ZXN0IHBhc3NlcyBp ZiB0aGlzIGRvZXNuJ3QgY3Jhc2guCisgICAgV2ViU2VhcmNoYWJsZUZvcm1EYXRhIHNlYXJjaGFi bGVEYXRhRm9ybShmb3Jtc1swXSk7Cit9CisKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvZGF0YS9mb3JtLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9kYXRhL2Zvcm0uaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvZGF0YS9mb3JtLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAK Kzxmb3JtIGFjdGlvbj0iYWJvdXQ6YmxhbmsiIG1ldGhvZD0iUE9TVCI+PC9mb3JtPgo= 104952 2011-08-23 18:16:44 -0700 2011-08-23 21:32:56 -0700 Patch bug-66831-20110823181643.patch text/plain 3129 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MzY3NikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBXZWJTZWFyY2hhYmxlRm9ybURhdGEgY3Jhc2hlcyB3aGVuIGdpdmVuIGEgZGV0YWNoZWQgSFRN TEZvcm1FbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIG5lZWQgdG8gbnVsbC1jaGVjayB0aGUgRnJhbWUuCisKKyAgICAgICAgKiBzcmMvV2Vi U2VhcmNoYWJsZUZvcm1EYXRhLmNwcDoKKyAgICAgICAgKEhUTUxOYW1lczo6R2V0Rm9ybUVuY29k aW5nKToKKyAgICAgICAgKiB0ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0 OjpURVNUX0YpOgorICAgICAgICAqIHRlc3RzL2RhdGEvZm9ybS5odG1sOiBBZGRlZC4KKwogMjAx MS0wOC0yMyAgRG1pdHJ5IExvbW92ICA8RG1pdHJ5IExvbW92IChkc2xvbW92QGdvb2dsZS5jb20p PgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njc1 MSAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlYXJjaGFibGVGb3JtRGF0 YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VhcmNo YWJsZUZvcm1EYXRhLmNwcAkocmV2aXNpb24gOTM2NDMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJTZWFyY2hhYmxlRm9ybURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2 ICs2NCw4IEBAIHZvaWQgR2V0Rm9ybUVuY29kaW5nKGNvbnN0IEhUTUxGb3JtRWxlbWUKICAgICAg ICAgaWYgKGVuY29kaW5nLT5pc1ZhbGlkKCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQor ICAgIGlmICghZm9ybS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkKKyAgICAgICAgIHJldHVybjsKICAg ICAqZW5jb2RpbmcgPSBUZXh0RW5jb2RpbmcoZm9ybS0+ZG9jdW1lbnQoKS0+bG9hZGVyKCktPndy aXRlcigpLT5lbmNvZGluZygpKTsKIH0KIApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAkocmV2aXNpb24gOTM2NDMpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMw LDExICszMCwxMSBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKLSNpbmNsdWRlIDxnb29nbGV1 cmwvc3JjL2d1cmwuaD4KLSNpbmNsdWRlIDxndGVzdC9ndGVzdC5oPgotI2luY2x1ZGUgPHdlYmtp dC9zdXBwb3J0L3dlYmtpdF9zdXBwb3J0Lmg+CisjaW5jbHVkZSAiV2ViRG9jdW1lbnQuaCIKKyNp bmNsdWRlICJXZWJGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVk ZSAiV2ViRnJhbWVDbGllbnQuaCIKKyNpbmNsdWRlICJXZWJTZWFyY2hhYmxlRm9ybURhdGEuaCIK ICNpbmNsdWRlICJXZWJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogI2luY2x1 ZGUgIldlYlVSTC5oIgpAQCAtNDIsNiArNDIsOSBAQAogI2luY2x1ZGUgIldlYlVSTFJlc3BvbnNl LmgiCiAjaW5jbHVkZSAiV2ViVmlldy5oIgogI2luY2x1ZGUgInY4LmgiCisjaW5jbHVkZSA8Z29v Z2xldXJsL3NyYy9ndXJsLmg+CisjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KKyNpbmNsdWRlIDx3 ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViS2l0 OwogCkBAIC0xNDUsNCArMTQ4LDI1IEBAIFRFU1RfRihXZWJGcmFtZVRlc3QsIEZyYW1lRm9yRW50 ZXJlZENvbnQKICAgICB3ZWJWaWV3LT5jbG9zZSgpOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0 LCBGb3JtV2l0aE51bGxGcmFtZSkKK3sKKyAgICByZWdpc3Rlck1vY2tlZFVSTExvYWQoImZvcm0u aHRtbCIpOworCisgICAgVGVzdFdlYkZyYW1lQ2xpZW50IHdlYkZyYW1lQ2xpZW50OworICAgIFdl YlZpZXcqIHdlYlZpZXcgPSBXZWJWaWV3OjpjcmVhdGUoMCk7CisgICAgd2ViVmlldy0+aW5pdGlh bGl6ZU1haW5GcmFtZSgmd2ViRnJhbWVDbGllbnQpOworCisgICAgbG9hZEZyYW1lKHdlYlZpZXct Pm1haW5GcmFtZSgpLCAiZm9ybS5odG1sIik7CisgICAgc2VydmVSZXF1ZXN0cygpOworCisgICAg V2ViVmVjdG9yPFdlYkZvcm1FbGVtZW50PiBmb3JtczsKKyAgICB3ZWJWaWV3LT5tYWluRnJhbWUo KS0+ZG9jdW1lbnQoKS5mb3Jtcyhmb3Jtcyk7CisgICAgd2ViVmlldy0+Y2xvc2UoKTsKKworICAg IEVYUEVDVF9FUShmb3Jtcy5zaXplKCksIDFVKTsKKworICAgIC8vIFRoaXMgdGVzdCBwYXNzZXMg aWYgdGhpcyBkb2Vzbid0IGNyYXNoLgorICAgIFdlYlNlYXJjaGFibGVGb3JtRGF0YSBzZWFyY2hh YmxlRGF0YUZvcm0oZm9ybXNbMF0pOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL2RhdGEvZm9ybS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vdGVzdHMvZGF0YS9mb3JtLmh0bWwJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL2RhdGEvZm9ybS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBA Cis8Zm9ybSBhY3Rpb249ImFib3V0OmJsYW5rIiBtZXRob2Q9IlBPU1QiPjwvZm9ybT4K