66821 2011-08-23 16:33:52 -0700 [skia] Outlines for inline elements have small gaps 2013-04-09 13:05:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 72062 1 benwells webkit-unassigned jamesr kbr mikelawther reed schenney senorblanco oldest_to_newest 455810 0 104928 benwells 2011-08-23 16:33:52 -0700 Created attachment 104928 Test case When inline elements which span multiple lines have outlines, the outlines have gaps in them. 487993 1 benwells 2011-10-20 16:45:01 -0700 This appears to be due to skia drawing polygons differently to CG when anti-aliasing is not used. This only happens now via drawConvexPolygon, when called with anti-aliasing false, which doesn't happen much. Skia draws slightly less pixels than CG. Something like: any pixels which aren't fully on or off (i.e. they are on an edge which isn't straight up/down or left/right) are drawn on in CG. In skia they are drawn on if the fill is on the left of the edge and off if the fill is on the right. Maybe this makes drawing adjacent polygons (like when triangulating larger shapes) easier in skia and is deliberate. I have 'fixed' this minor issue by changing skias path filling code at a deep level but that is pretty heavy and would probably break a million other really important things. This difference shows up in other edge cases in border / outline rendering, e.g. webkit bug 70741. Right now its not much of a problem and is perhaps not worth fixing. 500316 2 benwells 2011-11-10 14:51:46 -0800 Related border bug is webkit bug 70471 (not 70741). 104928 2011-08-23 16:33:52 -0700 2011-08-23 16:33:52 -0700 Test case InlineOutlines.html text/html 1574 benwells CjwhRE9DVFlQRSBodG1sPgo8c3R5bGU+CiAgZGl2IHsKICAgIG1hcmdpbjogMjBweDsKICAgIGRp c3BsYXk6IGlubGluZS1ibG9jazsKICAgIHdpZHRoOiAxMDBweDsKICB9CgogIHNwYW4gewogICAg b3V0bGluZS13aWR0aDogMjBweDsKICAgIG91dGxpbmUtY29sb3I6IHJnYigwLCAwLCAyNTUpOwog IH0KCiAgc3Bhbi5zb2xpZCB7CiAgICBvdXRsaW5lLXN0eWxlOiBzb2xpZDsKICB9CgogIHNwYW4u YXV0byB7CiAgICBvdXRsaW5lLXN0eWxlOiBhdXRvOwogIH0KCiAgc3Bhbi5kb3R0ZWQgewogICAg b3V0bGluZS1zdHlsZTogZG90dGVkOwogIH0KCiAgc3Bhbi5kYXNoZWQgewogICAgb3V0bGluZS1z dHlsZTogZGFzaGVkOwogIH0KCiAgc3Bhbi5kb3VibGUgewogICAgb3V0bGluZS1zdHlsZTogZG91 YmxlOwogIH0KCiAgc3Bhbi5yaWRnZSB7CiAgICBvdXRsaW5lLXN0eWxlOiByaWRnZTsKICB9Cgog IHNwYW4uZ3Jvb3ZlIHsKICAgIG91dGxpbmUtc3R5bGU6IGdyb292ZTsKICB9CgogIHNwYW4uaW5z ZXQgewogICAgb3V0bGluZS1zdHlsZTogaW5zZXQ7CiAgfQoKICBzcGFuLm91dHNldCB7CiAgICBv dXRsaW5lLXN0eWxlOiBvdXRzZXQ7CiAgfQo8L3N0eWxlPgoKVGhlIG91dGxpbmVzIHNob3VsZCBi ZSBhIGNvbnNpc3RlbnQgY29sb3IgYWxsIHRoZSB3YXkgYXJvdW5kIHRoZSBvdXRsaW5lLiBUaGVy ZSBzaG91bGQgYmUgbm8gZGFyayBwaXhlbHMgb3IgYmxvY2tzIGF0IGNvcm5lcnMgb3IgYmV0d2Vl biBsaW5lcy48YnI+PGJyPgoKPGRpdj4KICAgIDxzcGFuIGNsYXNzPSJzb2xpZCI+VGV4dCBzcGFu bmluZyBtb3JlIHRoYW4gb25lIGxpbmUuPC9zcGFuPgo8L2Rpdj4Kc29saWQKCjxkaXY+CiAgICA8 c3BhbiBjbGFzcz0iZG91YmxlIj5UZXh0IHNwYW5uaW5nIG1vcmUgdGhhbiBvbmUgbGluZS48L3Nw YW4+CjwvZGl2Pgpkb3VibGU8YnI+PGJyPgoKPGRpdj4KICAgIDxzcGFuIGNsYXNzPSJkb3R0ZWQi PlRleHQgc3Bhbm5pbmcgbW9yZSB0aGFuIG9uZSBsaW5lLjwvc3Bhbj4KPC9kaXY+CmRvdHRlZAoK PGRpdj4KICAgIDxzcGFuIGNsYXNzPSJkYXNoZWQiPlRleHQgc3Bhbm5pbmcgbW9yZSB0aGFuIG9u ZSBsaW5lLjwvc3Bhbj4KPC9kaXY+CmRhc2hlZDxicj48YnI+Cgo8ZGl2PgogICAgPHNwYW4gY2xh c3M9InJpZGdlIj5UZXh0IHNwYW5uaW5nIG1vcmUgdGhhbiBvbmUgbGluZS48L3NwYW4+CjwvZGl2 PgpyaWRnZQoKPGRpdj4KICAgIDxzcGFuIGNsYXNzPSJncm9vdmUiPlRleHQgc3Bhbm5pbmcgbW9y ZSB0aGFuIG9uZSBsaW5lLjwvc3Bhbj4KPC9kaXY+Cmdyb292ZTxicj48YnI+Cgo8ZGl2PgogICAg PHNwYW4gY2xhc3M9Imluc2V0Ij5UZXh0IHNwYW5uaW5nIG1vcmUgdGhhbiBvbmUgbGluZS48L3Nw YW4+CjwvZGl2PgppbnNldAoKPGRpdj4KICAgIDxzcGFuIGNsYXNzPSJvdXRzZXQiPlRleHQgc3Bh bm5pbmcgbW9yZSB0aGFuIG9uZSBsaW5lLjwvc3Bhbj4KPC9kaXY+Cm91dHNldAoKPHNjcmlwdD4K ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQodHJ1ZSk7Cjwvc2NyaXB0Pgo=