6682 2006-01-19 23:02:21 -0800 Call to checkWebCoreSVGSupport() broken in build-drawtest and run-drawtest 2006-01-21 14:36:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 ddkilzer ddkilzer eric oldest_to_newest 28955 0 ddkilzer 2006-01-19 23:02:21 -0800 Calls to checkWebCoreSVGSupport(), which is defined in WebKitTools/Scripts/webkitdirs.pm, are broken in build-drawtest and run-drawtest: $ ./WebKitTools/Scripts/build-drawtest Bareword "true" not allowed while "strict subs" in use at ./build-drawtest line 44. Execution of ./WebKitTools/Scripts/build-drawtest aborted due to compilation errors. $ ./WebKitTools/Scripts/run-drawtest Bareword "true" not allowed while "strict subs" in use at ./run-drawtest line 41. Execution of ./WebKitTools/Scripts/run-drawtest aborted due to compilation errors. 28956 1 5794 ddkilzer 2006-01-19 23:30:37 -0800 Created attachment 5794 Patch v1 Patch v1 to fix Perl errors. Taking bug. 28957 2 5794 eric 2006-01-19 23:36:41 -0800 Comment on attachment 5794 Patch v1 Looks great. 29284 3 ddkilzer 2006-01-21 14:36:22 -0800 Verified build-drawtest and run-drawtest compile with "perl -c". 5794 2006-01-19 23:30:37 -0800 2006-01-19 23:36:41 -0800 Patch v1 bug-6682-v1.diff text/plain 1748 ddkilzer SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHJhd3Rlc3QKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC1kcmF3dGVzdAkocmV2aXNpb24gMTIyNTEpCisrKyBX ZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLWRyYXd0ZXN0CSh3b3JraW5nIGNvcHkpCkBAIC00MSw3 ICs0MSw3IEBAIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25zKCk7CiAKICMgQ2hlY2sgdG8gc2Vl IHRoYXQgYWxsIHRoZSBmcmFtZXdvcmtzIGFyZSBidWlsdCAody8gU1ZHIHN1cHBvcnQpLgogY2hl Y2tGcmFtZXdvcmtzKCk7Ci1jaGVja1dlYkNvcmVTVkdTdXBwb3J0KHRydWUpOworY2hlY2tXZWJD b3JlU1ZHU3VwcG9ydCgxKTsKIAogIyBCdWlsZAogY2hkaXIgIldlYktpdFRvb2xzL0RyYXdUZXN0 IiBvciBkaWU7CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1kcmF3dGVzdAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1kcmF3dGVzdAkocmV2aXNpb24gMTIyNTEp CisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1kcmF3dGVzdAkod29ya2luZyBjb3B5KQpAQCAt MzgsNyArMzgsNyBAQCBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKIAogIyBDaGVjayB0 byBzZWUgdGhhdCBhbGwgdGhlIGZyYW1ld29ya3MgYXJlIGJ1aWx0ICh3LyBTVkcgc3VwcG9ydCku CiBjaGVja0ZyYW1ld29ya3MoKTsKLWNoZWNrV2ViQ29yZVNWR1N1cHBvcnQodHJ1ZSk7CitjaGVj a1dlYkNvcmVTVkdTdXBwb3J0KDEpOwogCiAjIFNldCB1cCBEWUxEX0ZSQU1FV09SS19QQVRIIHRv IHBvaW50IHRvIHRoZSBwcm9kdWN0IGRpcmVjdG9yeS4KIHByaW50ICJTdGFydCBEcmF3VGVzdCB3 aXRoIERZTERfRlJBTUVXT1JLX1BBVEggc2V0IHRvIHBvaW50IHRvIGJ1aWx0IFdlYktpdCBpbiAk cHJvZHVjdERpci5cbiI7CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjI1NCkKKysrIFdlYktpdFRvb2xz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA2LTAxLTIwICBE YXZpZCBLaWx6ZXIgIDxzZXQgRU1BSUxfQUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBmb3Ig aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02NjgyCisgICAg ICAgIENhbGwgdG8gY2hlY2tXZWJDb3JlU1ZHU3VwcG9ydCgpIGJyb2tlbiBpbiBidWlsZC1kcmF3 dGVzdCBhbmQgcnVuLWRyYXd0ZXN0CisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLWRyYXd0ZXN0 OiBDaGFuZ2VkIGJhcmV3b3JkICd0cnVlJyB0byAxLgorICAgICAgICAqIFNjcmlwdHMvcnVuLWRy YXd0ZXN0OiBDaGFuZ2VkIGJhcmV3b3JkICd0cnVlJyB0byAxLgorCiAyMDA2LTAxLTE5ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICAqIFNjcmlwdHMvcmVwb3J0LWlu Y2x1ZGUtc3RhdGlzdGljczogQWRkZWQgYSBuZXcgc2NyaXB0Lgo=