66810 2011-08-23 14:17:30 -0700 platform/graphics/skia should stay in float space when possible to avoid inaccurate rendering 2011-08-24 13:09:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbates reed jamesr kbr pkasting reed webkit.review.bot oldest_to_newest 455702 0 jbates 2011-08-23 14:17:30 -0700 This depends on skia adding float support to some functions: http://code.google.com/p/skia/issues/detail?id=345 Once that is implemented, we can remove the int conversion in platform/graphics/skia/SkiaUtils.cpp IntersectRectAndRegion. 455705 1 jbates 2011-08-23 14:19:48 -0700 See https://bugs.webkit.org/show_bug.cgi?id=66798 for discussion of the rendering results. 456075 2 104990 reed 2011-08-24 06:45:57 -0700 Created attachment 104990 Patch 456079 3 104992 reed 2011-08-24 06:55:50 -0700 Created attachment 104992 Patch 456081 4 reed 2011-08-24 06:56:43 -0700 Change ClipRectToCanvas to call existing method to get the clip bounds in local (float) coordinates. 456140 5 jbates 2011-08-24 09:36:16 -0700 lol, nicely done. Need a webkit committer to give the r+ (Peter?). 456178 6 pkasting 2011-08-24 10:32:10 -0700 (In reply to comment #5) > lol, nicely done. Need a webkit committer to give the r+ (Peter?). Sorry, you need a WebKit reviewer, and I'm only a committer. I can't r+. 456290 7 104992 kbr 2011-08-24 12:07:36 -0700 Comment on attachment 104992 Patch Looks good. I'm assuming no layout tests need updates for this change. 456350 8 104992 webkit.review.bot 2011-08-24 13:09:05 -0700 Comment on attachment 104992 Patch Clearing flags on attachment: 104992 Committed r93725: <http://trac.webkit.org/changeset/93725> 456351 9 webkit.review.bot 2011-08-24 13:09:09 -0700 All reviewed patches have been landed. Closing bug. 104990 2011-08-24 06:45:57 -0700 2011-08-24 06:55:45 -0700 Patch bug-66810-20110824094555.patch text/plain 2893 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNzA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjQgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBDaGFuZ2UgY2xpcCByb3V0aW5lIHRvIHBy b21vdGUgdGhlIGNsaXBib3VuZHMgdXAgdG8gKGxvY2FsKSBmbG9hdHMgYW5kIHRoZW4gcGVyZm9y bSB0aGUgaW50ZXJzZWN0aW9uLAorICAgICAgICByYXRoZXIgdGhhbiByb3VuZGluZyB0aGUgc3Jj UmVjdCBkb3duIHRvIGludGVnZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjY4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEV4aXN0aW5nIHRlc3RzIHRoYXQgcmVzaXplIGlt YWdlcyB3aWxsIGV4ZXJjaXNlIHRoaXMgY29kZSBwYXRoCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9za2lhL1NraWFVdGlscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwUmVjdFRv Q2FudmFzKToKKwogMjAxMS0wOC0yNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIDkgbW9yZSBqYXZhc2NyaXB0IGZpbGVz IHRvIHRoZSBjb21waWxhdGlvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvU2tpYVV0aWxzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1NraWFVdGlscy5jcHAJKHJldmlzaW9uIDkzNzA0KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhVXRpbHMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDYsNDQgKzEwNiwxMCBAQCBDb2xvciBTa1BNQ29sb3JUb1dlYkNvcmVDb2xv cihTa1BNQ29sb3IgCiAgICAgcmV0dXJuIFNrUE1Db2xvclRvQ29sb3IocG0pOwogfQogCi12b2lk IEludGVyc2VjdFJlY3RBbmRSZWdpb24oY29uc3QgU2tSZWdpb24mIHJlZ2lvbiwgY29uc3QgU2tS ZWN0JiBzcmNSZWN0LCBTa1JlY3QqIGRlc3RSZWN0KSB7Ci0gICAgLy8gVGhlIGNsaXBlcmF0b3Ig cmVxdWlyZXMgYW4gaW50IHJlY3QsIHNvIHdlIHJvdW5kIG91dC4KLSAgICBTa0lSZWN0IHNyY1Jl Y3RSb3VuZGVkOwotICAgIHNyY1JlY3Qucm91bmRPdXQoJnNyY1JlY3RSb3VuZGVkKTsKLQotICAg IC8vIFRoZSBDbGlwZXJhdG9yIHdpbGwgaXRlcmF0ZSBvdmVyIGEgYnVuY2ggb2YgcmVjdHMgd2hl cmUgb3VyIHRyYW5zZm9ybWVkCi0gICAgLy8gcmVjdCBhbmQgdGhlIGNsaXBwaW5nIHJlZ2lvbiAo d2hpY2ggbWF5IGJlIG5vbi1zcXVhcmUpIG92ZXJsYXAuCi0gICAgU2tSZWdpb246OkNsaXBlcmF0 b3IgY2xpcGVyYXRvcihyZWdpb24sIHNyY1JlY3RSb3VuZGVkKTsKLSAgICBpZiAoY2xpcGVyYXRv ci5kb25lKCkpIHsKLSAgICAgICAgZGVzdFJlY3QtPnNldEVtcHR5KCk7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9Ci0KLSAgICAvLyBHZXQgdGhlIHVuaW9uIG9mIGFsbCB2aXNpYmxlIHJlY3RzIGlu IHRoZSBjbGlwIHRoYXQgb3ZlcmxhcCBvdXIgYml0bWFwLgotICAgIFNrSVJlY3QgY3VycmVudFZp c2libGVSZWN0ID0gY2xpcGVyYXRvci5yZWN0KCk7Ci0gICAgY2xpcGVyYXRvci5uZXh0KCk7Ci0g ICAgd2hpbGUgKCFjbGlwZXJhdG9yLmRvbmUoKSkgewotICAgICAgICBjdXJyZW50VmlzaWJsZVJl Y3Quam9pbihjbGlwZXJhdG9yLnJlY3QoKSk7Ci0gICAgICAgIGNsaXBlcmF0b3IubmV4dCgpOwot ICAgIH0KLQotICAgIGRlc3RSZWN0LT5zZXQoY3VycmVudFZpc2libGVSZWN0KTsKLX0KLQogdm9p ZCBDbGlwUmVjdFRvQ2FudmFzKGNvbnN0IFNrQ2FudmFzJiBjYW52YXMsIGNvbnN0IFNrUmVjdCYg c3JjUmVjdCwgU2tSZWN0KiBkZXN0UmVjdCkgewotICAgIC8vIFRyYW5zbGF0ZSBpbnRvIHRoZSBj YW52YXMnIGNvb3JkaW5hdGUgc3BhY2UuIFRoaXMgaXMgd2hlcmUgdGhlIGNsaXBwaW5nCi0gICAg Ly8gcmVnaW9uIGFwcGxpZXMuCi0gICAgU2tSZWN0IHRyYW5zZm9ybWVkU3JjOwotICAgIGNhbnZh cy5nZXRUb3RhbE1hdHJpeCgpLm1hcFJlY3QoJnRyYW5zZm9ybWVkU3JjLCBzcmNSZWN0KTsKLQot ICAgIC8vIERvIHRoZSBpbnRlcnNlY3Rpb24uCi0gICAgU2tSZWN0IHRyYW5zZm9ybWVkRGVzdDsK LSAgICBJbnRlcnNlY3RSZWN0QW5kUmVnaW9uKGNhbnZhcy5nZXRUb3RhbENsaXAoKSwgdHJhbnNm b3JtZWRTcmMsICZ0cmFuc2Zvcm1lZERlc3QpOwotCi0gICAgLy8gTm93IHRyYW5zZm9ybSBpdCBi YWNrIGludG8gd29ybGQgc3BhY2UuCi0gICAgU2tNYXRyaXggaW52ZXJzZVRyYW5zZm9ybTsKLSAg ICBjYW52YXMuZ2V0VG90YWxNYXRyaXgoKS5pbnZlcnQoJmludmVyc2VUcmFuc2Zvcm0pOwotICAg IGludmVyc2VUcmFuc2Zvcm0ubWFwUmVjdChkZXN0UmVjdCwgdHJhbnNmb3JtZWREZXN0KTsKKyAg ICBTa1JlY3QgcjsKKyAgICBpZiAoIWNhbnZhcy5nZXRDbGlwQm91bmRzKCZyKSB8fCAhZGVzdFJl Y3QtPmludGVyc2VjdChyLCBzcmNSZWN0KSkKKyAgICAgICAgZGVzdFJlY3QtPnNldEVtcHR5KCk7 CiB9CiAKIGJvb2wgU2tQYXRoQ29udGFpbnNQb2ludChTa1BhdGgqIG9yaWdpbmFsUGF0aCwgY29u c3QgRmxvYXRQb2ludCYgcG9pbnQsIFNrUGF0aDo6RmlsbFR5cGUgZnQpCg== 104992 2011-08-24 06:55:50 -0700 2011-08-24 13:09:05 -0700 Patch bug-66810-20110824095548.patch text/plain 2941 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNzA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjQgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBDaGFuZ2UgY2xpcCByb3V0aW5lIHRvIHBy b21vdGUgdGhlIGNsaXBib3VuZHMgdXAgdG8gKGxvY2FsKSBmbG9hdHMgYW5kIHRoZW4gcGVyZm9y bSB0aGUgaW50ZXJzZWN0aW9uLAorICAgICAgICByYXRoZXIgdGhhbiByb3VuZGluZyB0aGUgc3Jj UmVjdCBkb3duIHRvIGludGVnZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjY4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEV4aXN0aW5nIHRlc3RzIHRoYXQgcmVzaXplIGlt YWdlcyB3aWxsIGV4ZXJjaXNlIHRoaXMgY29kZSBwYXRoCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9za2lhL1NraWFVdGlscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwUmVjdFRv Q2FudmFzKToKKwogMjAxMS0wOC0yNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIDkgbW9yZSBqYXZhc2NyaXB0IGZpbGVz IHRvIHRoZSBjb21waWxhdGlvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvU2tpYVV0aWxzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1NraWFVdGlscy5jcHAJKHJldmlzaW9uIDkzNzA0KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhVXRpbHMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDYsNDQgKzEwNiwxMCBAQCBDb2xvciBTa1BNQ29sb3JUb1dlYkNvcmVDb2xv cihTa1BNQ29sb3IgCiAgICAgcmV0dXJuIFNrUE1Db2xvclRvQ29sb3IocG0pOwogfQogCi12b2lk IEludGVyc2VjdFJlY3RBbmRSZWdpb24oY29uc3QgU2tSZWdpb24mIHJlZ2lvbiwgY29uc3QgU2tS ZWN0JiBzcmNSZWN0LCBTa1JlY3QqIGRlc3RSZWN0KSB7Ci0gICAgLy8gVGhlIGNsaXBlcmF0b3Ig cmVxdWlyZXMgYW4gaW50IHJlY3QsIHNvIHdlIHJvdW5kIG91dC4KLSAgICBTa0lSZWN0IHNyY1Jl Y3RSb3VuZGVkOwotICAgIHNyY1JlY3Qucm91bmRPdXQoJnNyY1JlY3RSb3VuZGVkKTsKLQotICAg IC8vIFRoZSBDbGlwZXJhdG9yIHdpbGwgaXRlcmF0ZSBvdmVyIGEgYnVuY2ggb2YgcmVjdHMgd2hl cmUgb3VyIHRyYW5zZm9ybWVkCi0gICAgLy8gcmVjdCBhbmQgdGhlIGNsaXBwaW5nIHJlZ2lvbiAo d2hpY2ggbWF5IGJlIG5vbi1zcXVhcmUpIG92ZXJsYXAuCi0gICAgU2tSZWdpb246OkNsaXBlcmF0 b3IgY2xpcGVyYXRvcihyZWdpb24sIHNyY1JlY3RSb3VuZGVkKTsKLSAgICBpZiAoY2xpcGVyYXRv ci5kb25lKCkpIHsKK3ZvaWQgQ2xpcFJlY3RUb0NhbnZhcyhjb25zdCBTa0NhbnZhcyYgY2FudmFz LCBjb25zdCBTa1JlY3QmIHNyY1JlY3QsIFNrUmVjdCogZGVzdFJlY3QpCit7CisgICAgaWYgKCFj YW52YXMuZ2V0Q2xpcEJvdW5kcyhkZXN0UmVjdCkgfHwgIWRlc3RSZWN0LT5pbnRlcnNlY3Qoc3Jj UmVjdCkpCiAgICAgICAgIGRlc3RSZWN0LT5zZXRFbXB0eSgpOwotICAgICAgICByZXR1cm47Ci0g ICAgfQotCi0gICAgLy8gR2V0IHRoZSB1bmlvbiBvZiBhbGwgdmlzaWJsZSByZWN0cyBpbiB0aGUg Y2xpcCB0aGF0IG92ZXJsYXAgb3VyIGJpdG1hcC4KLSAgICBTa0lSZWN0IGN1cnJlbnRWaXNpYmxl UmVjdCA9IGNsaXBlcmF0b3IucmVjdCgpOwotICAgIGNsaXBlcmF0b3IubmV4dCgpOwotICAgIHdo aWxlICghY2xpcGVyYXRvci5kb25lKCkpIHsKLSAgICAgICAgY3VycmVudFZpc2libGVSZWN0Lmpv aW4oY2xpcGVyYXRvci5yZWN0KCkpOwotICAgICAgICBjbGlwZXJhdG9yLm5leHQoKTsKLSAgICB9 Ci0KLSAgICBkZXN0UmVjdC0+c2V0KGN1cnJlbnRWaXNpYmxlUmVjdCk7Ci19Ci0KLXZvaWQgQ2xp cFJlY3RUb0NhbnZhcyhjb25zdCBTa0NhbnZhcyYgY2FudmFzLCBjb25zdCBTa1JlY3QmIHNyY1Jl Y3QsIFNrUmVjdCogZGVzdFJlY3QpIHsKLSAgICAvLyBUcmFuc2xhdGUgaW50byB0aGUgY2FudmFz JyBjb29yZGluYXRlIHNwYWNlLiBUaGlzIGlzIHdoZXJlIHRoZSBjbGlwcGluZwotICAgIC8vIHJl Z2lvbiBhcHBsaWVzLgotICAgIFNrUmVjdCB0cmFuc2Zvcm1lZFNyYzsKLSAgICBjYW52YXMuZ2V0 VG90YWxNYXRyaXgoKS5tYXBSZWN0KCZ0cmFuc2Zvcm1lZFNyYywgc3JjUmVjdCk7Ci0KLSAgICAv LyBEbyB0aGUgaW50ZXJzZWN0aW9uLgotICAgIFNrUmVjdCB0cmFuc2Zvcm1lZERlc3Q7Ci0gICAg SW50ZXJzZWN0UmVjdEFuZFJlZ2lvbihjYW52YXMuZ2V0VG90YWxDbGlwKCksIHRyYW5zZm9ybWVk U3JjLCAmdHJhbnNmb3JtZWREZXN0KTsKLQotICAgIC8vIE5vdyB0cmFuc2Zvcm0gaXQgYmFjayBp bnRvIHdvcmxkIHNwYWNlLgotICAgIFNrTWF0cml4IGludmVyc2VUcmFuc2Zvcm07Ci0gICAgY2Fu dmFzLmdldFRvdGFsTWF0cml4KCkuaW52ZXJ0KCZpbnZlcnNlVHJhbnNmb3JtKTsKLSAgICBpbnZl cnNlVHJhbnNmb3JtLm1hcFJlY3QoZGVzdFJlY3QsIHRyYW5zZm9ybWVkRGVzdCk7CiB9CiAKIGJv b2wgU2tQYXRoQ29udGFpbnNQb2ludChTa1BhdGgqIG9yaWdpbmFsUGF0aCwgY29uc3QgRmxvYXRQ b2ludCYgcG9pbnQsIFNrUGF0aDo6RmlsbFR5cGUgZnQpCg==