66809 2011-08-23 14:08:00 -0700 [SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface 2011-08-24 08:04:48 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon senorblanco twiz webkit.review.bot oldest_to_newest 455695 0 bsalomon 2011-08-23 14:08:00 -0700 [SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface 455696 1 104912 bsalomon 2011-08-23 14:09:09 -0700 Created attachment 104912 Patch 455698 2 bsalomon 2011-08-23 14:11:50 -0700 A follow on Chromium change will override grGLInterface in WGC3D subclasses. Passing NULL to GrContext::Create means use the default GrGLInterface. So this change by itself causes no change in behavior. 455725 3 104912 twiz 2011-08-23 14:50:30 -0700 Comment on attachment 104912 Patch This change LGTM. I wonder, should we use the platform-agnostic GrPlatform3DContext type for the WebGraphicsContext3D interface, instead of the OpenGL specific GrGLInterface? That would save on the need for a reinterpret cast. 455944 4 bsalomon 2011-08-23 20:00:25 -0700 Hmm.. There are three subclasses of WGC3D in Chromium that'd have to cast to GrPlatform3DContext in their overrides. I think having the GrGLInterface type in the virtual's signature makes it a little bit more clear what is expected of the override. If the subclass is going to give a agnostic GrPlatform3DContext then it seems to me that it should also provide the GrEngine enum as well since they have to be consistent. Maybe that's not a bad way to go but we aren't expecting a WGC3D subclass that is backed by anything but GL anytime soon. 456084 5 104912 senorblanco 2011-08-24 07:03:54 -0700 Comment on attachment 104912 Patch That makes sense. Since Jeff gave unofficial LG, I'm r+'ing as-is. 456103 6 104912 webkit.review.bot 2011-08-24 08:04:45 -0700 Comment on attachment 104912 Patch Clearing flags on attachment: 104912 Committed r93707: <http://trac.webkit.org/changeset/93707> 456104 7 webkit.review.bot 2011-08-24 08:04:48 -0700 All reviewed patches have been landed. Closing bug. 104912 2011-08-23 14:09:09 -0700 2011-08-24 08:04:44 -0700 Patch bug-66809-20110823170908.patch text/plain 2542 bsalomon SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5MzYzNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDgtMjMgIEJyaWFuIFNhbG9tb24gIDxic2Fsb21vbkBnb29nbGUuY29tPgorCisg ICAgICAgIFtTS0lBXSBBbGxvdyBXZWJLaXRHcmFwaGljc0NvbnRleHQzRCBpbXBsZW1lbnRhdGlv biB0byBwcm92aWRlIGEgY29tcGF0aWJsZSBHckdMSW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjgwOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4 dDNELmg6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpnckdMSW50ZXJm YWNlKToKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpnckNvbnRleHQpOgorCiAy MDExLTA4LTIzICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gUmVtb3ZlIGEgZmV3IEZJWE1FICNkZWZpbmVzIGluIEFQSSBoZWFkZXJzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29u dGV4dDNELmgJKHJldmlzaW9uIDkzNjM3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNiArNjAsMTAg QEAgdHlwZWRlZiBzaWduZWQgbG9uZyBpbnQgV0dDM0RzaXplaXB0cjsKIC8vIFR5cGVkZWYgZm9y IHNlcnZlci1zaWRlIG9iamVjdHMgbGlrZSBPcGVuR0wgdGV4dHVyZXMgYW5kIHByb2dyYW0gb2Jq ZWN0cy4KIHR5cGVkZWYgV0dDM0R1aW50IFdlYkdMSWQ7CiAKKyNpZiBXRUJLSVRfVVNJTkdfU0tJ QQorc3RydWN0IEdyR0xJbnRlcmZhY2U7CisjZW5kaWYKKwogY2xhc3MgV2ViVmlldzsKIAogLy8g VGhpcyBpbnRlcmZhY2UgYWJzdHJhY3RzIHRoZSBvcGVyYXRpb25zIHBlcmZvcm1lZCBieSB0aGUK QEAgLTM1NSw2ICszNTksMTAgQEAgcHVibGljOgogICAgIC8vIHRoZSBHTF9BUkJfcm9idXN0bmVz cyBleHRlbnNpb247IHNwZWNpZmljYWxseSwgdGhlIGxvc3QgY29udGV4dAogICAgIC8vIHN0YXRl IGlzIHN0aWNreSwgcmF0aGVyIHRoYW4gcmVwb3J0ZWQgb25seSBvbmNlLgogICAgIHZpcnR1YWwg V0dDM0RlbnVtIGdldEdyYXBoaWNzUmVzZXRTdGF0dXNBUkIoKSB7IHJldHVybiAwOyAvKiBHTF9O T19FUlJPUiAqLyB9CisKKyNpZiBXRUJLSVRfVVNJTkdfU0tJQQorICAgIHZpcnR1YWwgR3JHTElu dGVyZmFjZSogZ3JHTEludGVyZmFjZSgpIHsgcmV0dXJuIDA7IH0KKyNlbmRpZgogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFw aGljc0NvbnRleHQzRENocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAkocmV2aXNpb24gOTM2Mzcp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVt LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY0LDcgKzE2NCw4IEBAIEdyQ29udGV4dCogR3JhcGhp Y3NDb250ZXh0M0RJbnRlcm5hbDo6Z3IKICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IG1heFRleHR1 cmVDYWNoZUJ5dGVzID0gNTAgKiAxMDI0ICogMTAyNDsKIAogICAgIGlmICghbV9nckNvbnRleHQp IHsKLSAgICAgICAgbV9nckNvbnRleHQgPSBHckNvbnRleHQ6OkNyZWF0ZUdMU2hhZGVyQ29udGV4 dCgpOworICAgICAgICBHclBsYXRmb3JtM0RDb250ZXh0IGdsaW50ZXJmYWNlID0gcmVpbnRlcnBy ZXRfY2FzdDxHclBsYXRmb3JtM0RDb250ZXh0PihtX2ltcGwtPmdyR0xJbnRlcmZhY2UoKSk7Cisg ICAgICAgIG1fZ3JDb250ZXh0ID0gR3JDb250ZXh0OjpDcmVhdGUoa09wZW5HTF9TaGFkZXJzX0dy RW5naW5lLCBnbGludGVyZmFjZSk7CiAgICAgICAgIGlmIChtX2dyQ29udGV4dCkKICAgICAgICAg ICAgIG1fZ3JDb250ZXh0LT5zZXRUZXh0dXJlQ2FjaGVMaW1pdHMobWF4VGV4dHVyZUNhY2hlQ291 bnQsIG1heFRleHR1cmVDYWNoZUJ5dGVzKTsKICAgICB9Cg==