66803 2011-08-23 13:10:27 -0700 Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac) 2011-08-23 16:18:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark jamesr webkit.review.bot oldest_to_newest 455647 0 caryclark 2011-08-23 13:10:27 -0700 Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac) 455650 1 104903 caryclark 2011-08-23 13:13:41 -0700 Created attachment 104903 Patch 455653 2 104904 caryclark 2011-08-23 13:20:05 -0700 Created attachment 104904 Patch 455659 3 104904 jamesr 2011-08-23 13:28:54 -0700 Comment on attachment 104904 Patch Looks sane. I guess we'll have to audit all of the uses of WebCanvas anywhere, right? 455662 4 caryclark 2011-08-23 13:36:55 -0700 I did search everywhere for graphicsContextWithGraphicsPort, since it takes a void*, to see if there were any other possible mismatches, but all other uses look fine. I don't know if there are other common Apple framework calls that take void* to check. 455796 5 104904 webkit.review.bot 2011-08-23 16:18:49 -0700 Comment on attachment 104904 Patch Clearing flags on attachment: 104904 Committed r93653: <http://trac.webkit.org/changeset/93653> 455797 6 webkit.review.bot 2011-08-23 16:18:53 -0700 All reviewed patches have been landed. Closing bug. 104903 2011-08-23 13:13:41 -0700 2011-08-23 13:20:00 -0700 Patch bug-66803-20110823161340.patch text/plain 1905 caryclark SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkzNjMwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDgtMjMgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4K KworICAgICAgICBUdXJuIFdlYkNhbnZhcyBpbnRvIENHQ29udGV4dCBiZWZvcmUgZHJhd2luZyBz Y3JvbGxiYXIgKERSVCB1c2luZyBTa2lhIG9uIE1hYykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVt ZUVuZ2luZURSVE1hYy5tbToKKyAgICAgICAgKFdlYlRoZW1lRW5naW5lRFJUTWFjOjpwYWludE5T U2Nyb2xsZXJTY3JvbGxiYXJUaHVtYik6CisgICAgICAgIFRoZSBOU0dyYXBoaWNzQ29udGV4dCBj YWxsIGdyYXBoaWNzQ29udGV4dFdpdGhHcmFwaGljc1BvcnQgdGFrZXMgYSB2b2lkKgorICAgICAg ICBwYXJhbWV0ZXIsIHNvIGl0IHRvb2sgYSBXZWJDYW52YXMqIChtYXBwZWQgdG8gU2tDYW52YXMq IGluIFNraWEtbGFuZCkKKyAgICAgICAgYW5kIHRyZWF0ZWQgaXQgYXMgaWYgaXQgd2VyZSBhIENH Q29udGV4dFJlZi4KKwogMjAxMS0wOC0yMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBBZGQgbWlzc2luZyBxdW90ZXMgYXJvdW5kIGZpbGVuYW1lcyBp biBtZXJnZUNoYW5nZUxvZ3MKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dl YlRoZW1lRW5naW5lRFJUTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUTWFjLm1tCShyZXZpc2lvbiA5MzYyOSkKKysrIFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUTWFjLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzYsNyArMTc2LDEzIEBAIHZvaWQgV2ViVGhlbWVFbmdpbmVEUlRNYWM6 OnBhaW50TlNTY3JvbGwKICAgICBbc2Nyb2xsZXIgc2V0S25vYlByb3BvcnRpb246IGtub2JQcm9w b3J0aW9uXTsKIAogICAgIE5TR3JhcGhpY3NDb250ZXh0KiBwcmV2aW91c0dyYXBoaWNzQ29udGV4 dCA9IFtOU0dyYXBoaWNzQ29udGV4dCBjdXJyZW50Q29udGV4dF07Ci0gICAgTlNHcmFwaGljc0Nv bnRleHQqIG5zR3JhcGhpY3NDb250ZXh0ID0gW05TR3JhcGhpY3NDb250ZXh0IGdyYXBoaWNzQ29u dGV4dFdpdGhHcmFwaGljc1BvcnQ6Y2FudmFzIGZsaXBwZWQ6WUVTXTsKKyNpZiBXRUJLSVRfVVNJ TkdfU0tJQQorICAgIGdmeDo6U2tpYUJpdExvY2tlciBiaXRMb2NrZXIoY2FudmFzKTsKKyAgICBD R0NvbnRleHRSZWYgY2dDb250ZXh0ID0gYml0TG9ja2VyLmNnQ29udGV4dCgpOworI2Vsc2UKKyAg ICBDR0NvbnRleHRSZWYgY2dDb250ZXh0ID0gY2FudmFzOworI2VuZGlmCisgICAgTlNHcmFwaGlj c0NvbnRleHQqIG5zR3JhcGhpY3NDb250ZXh0ID0gW05TR3JhcGhpY3NDb250ZXh0IGdyYXBoaWNz Q29udGV4dFdpdGhHcmFwaGljc1BvcnQ6Y2dDb250ZXh0IGZsaXBwZWQ6WUVTXTsKICAgICBbTlNH cmFwaGljc0NvbnRleHQgc2V0Q3VycmVudENvbnRleHQ6bnNHcmFwaGljc0NvbnRleHRdOwogCiAg ICAgLy8gRGVzcGl0ZSBwYXNzaW5nIGluIGZyYW1lUmVjdCgpIHRvIHRoZSBzY3JvbGxlciwgaXQg YWx3YXlzIGRyYXdzIGF0ICgwLCAwKS4K 104904 2011-08-23 13:20:05 -0700 2011-08-23 16:18:49 -0700 Patch bug-66803-20110823162003.patch text/plain 2026 caryclark SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkzNjMwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDgtMjMgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4K KworICAgICAgICBUdXJuIFdlYkNhbnZhcyBpbnRvIENHQ29udGV4dCBiZWZvcmUgZHJhd2luZyBz Y3JvbGxiYXIgKERSVCB1c2luZyBTa2lhIG9uIE1hYykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2ODAzCisKKyAgICAgICAgVGhpcyBmaXhlcyB0aGUg V2ViS2l0IENhbmFyaWVzLCBpbiBwYXJ0aWN1bGFyIGF2b2lkcyBhIGNyYXNoIG9uIHRlc3RzCisg ICAgICAgIGxpa2UgY3NzMS9iYXNpYy9jb21tZW50cy5odG1sLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v V2ViVGhlbWVFbmdpbmVEUlRNYWMubW06CisgICAgICAgIChXZWJUaGVtZUVuZ2luZURSVE1hYzo6 cGFpbnROU1Njcm9sbGVyU2Nyb2xsYmFyVGh1bWIpOgorICAgICAgICBUaGUgTlNHcmFwaGljc0Nv bnRleHQgY2FsbCBncmFwaGljc0NvbnRleHRXaXRoR3JhcGhpY3NQb3J0IHRha2VzIGEgdm9pZCoK KyAgICAgICAgcGFyYW1ldGVyLCBzbyBpdCB0b29rIGEgV2ViQ2FudmFzKiAobWFwcGVkIHRvIFNr Q2FudmFzKiBpbiBTa2lhLWxhbmQpCisgICAgICAgIGFuZCB0cmVhdGVkIGl0IGFzIGlmIGl0IHdl cmUgYSBDR0NvbnRleHRSZWYuCisKIDIwMTEtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFy b2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIG1pc3NpbmcgcXVvdGVzIGFyb3VuZCBmaWxl bmFtZXMgaW4gbWVyZ2VDaGFuZ2VMb2dzCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5tbQkocmV2aXNpb24gOTM2Mjkp CisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMTc2LDcgKzE3NiwxMyBAQCB2b2lkIFdlYlRoZW1lRW5naW5l RFJUTWFjOjpwYWludE5TU2Nyb2xsCiAgICAgW3Njcm9sbGVyIHNldEtub2JQcm9wb3J0aW9uOiBr bm9iUHJvcG9ydGlvbl07CiAKICAgICBOU0dyYXBoaWNzQ29udGV4dCogcHJldmlvdXNHcmFwaGlj c0NvbnRleHQgPSBbTlNHcmFwaGljc0NvbnRleHQgY3VycmVudENvbnRleHRdOwotICAgIE5TR3Jh cGhpY3NDb250ZXh0KiBuc0dyYXBoaWNzQ29udGV4dCA9IFtOU0dyYXBoaWNzQ29udGV4dCBncmFw aGljc0NvbnRleHRXaXRoR3JhcGhpY3NQb3J0OmNhbnZhcyBmbGlwcGVkOllFU107CisjaWYgV0VC S0lUX1VTSU5HX1NLSUEKKyAgICBnZng6OlNraWFCaXRMb2NrZXIgYml0TG9ja2VyKGNhbnZhcyk7 CisgICAgQ0dDb250ZXh0UmVmIGNnQ29udGV4dCA9IGJpdExvY2tlci5jZ0NvbnRleHQoKTsKKyNl bHNlCisgICAgQ0dDb250ZXh0UmVmIGNnQ29udGV4dCA9IGNhbnZhczsKKyNlbmRpZgorICAgIE5T R3JhcGhpY3NDb250ZXh0KiBuc0dyYXBoaWNzQ29udGV4dCA9IFtOU0dyYXBoaWNzQ29udGV4dCBn cmFwaGljc0NvbnRleHRXaXRoR3JhcGhpY3NQb3J0OmNnQ29udGV4dCBmbGlwcGVkOllFU107CiAg ICAgW05TR3JhcGhpY3NDb250ZXh0IHNldEN1cnJlbnRDb250ZXh0Om5zR3JhcGhpY3NDb250ZXh0 XTsKIAogICAgIC8vIERlc3BpdGUgcGFzc2luZyBpbiBmcmFtZVJlY3QoKSB0byB0aGUgc2Nyb2xs ZXIsIGl0IGFsd2F5cyBkcmF3cyBhdCAoMCwgMCkuCg==