<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66797</bug_id>
          
          <creation_ts>2011-08-23 12:03:51 -0700</creation_ts>
          <short_desc>Fix mergeChangeLogs test on native windows</short_desc>
          <delta_ts>2011-08-23 16:07:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Patrick R. Gansterer">paroga</assigned_to>
          <cc>aroben</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>455572</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-08-23 12:03:51 -0700</bug_when>
    <thetext>Fix mergeChangeLogs test on native windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>455580</commentid>
    <comment_count>1</comment_count>
      <attachid>104884</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-08-23 12:09:24 -0700</bug_when>
    <thetext>Created attachment 104884
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>455583</commentid>
    <comment_count>2</comment_count>
      <attachid>104884</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-08-23 12:12:32 -0700</bug_when>
    <thetext>Comment on attachment 104884
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104884&amp;action=review

&gt; Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:53
&gt; -        DIR =&gt; ($ENV{&apos;TMPDIR&apos;} || &quot;/tmp&quot;),
&gt; +        DIR =&gt; ($ENV{&apos;TMPDIR&apos;} || $ENV{&apos;TEMP&apos;} || &quot;/tmp&quot;),

It would be even better to use File::Spec-&gt;tmpdir().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>455779</commentid>
    <comment_count>3</comment_count>
      <attachid>104884</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-23 16:07:34 -0700</bug_when>
    <thetext>Comment on attachment 104884
Patch

Clearing flags on attachment: 104884

Committed r93649: &lt;http://trac.webkit.org/changeset/93649&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>455780</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-23 16:07:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>104884</attachid>
            <date>2011-08-23 12:09:24 -0700</date>
            <delta_ts>2011-08-23 16:07:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-66797-20110823210922.patch</filename>
            <type>text/plain</type>
            <size>1512</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTM2MjAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1YTczODZkNDI0OGUyZTRkNGZkNGUzYjE3NDUxMTViYmZi
ZTAzMzIxLi5kMTYxNTdlYjU5ZjQ0YjZkZmZjNmFhNjQxNTdmY2Y0Zjk1Yjk2ZDE5IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg
QEAKKzIwMTEtMDgtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK
KyAgICAgICAgRml4IG1lcmdlQ2hhbmdlTG9ncyB0ZXN0IG9uIG5hdGl2ZSB3aW5kb3dzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Njc5NworCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpbmRvd3MgaGFzIG5v
IC90bXAvIGRpcmVjdG9yeSBhbmQgdGhlICJUTVBESVIiIGVudmlyb25tZW50IHZhcmlhYmxlIGlz
bid0IHNldCBpbiB0aGUgZGVmYXVsdCBzZXR1cC4KKyAgICAgICAgQWRkIHRoZSAiVEVNUCIgZW52
aXJvbm1lbnQgdmFyaWFibGUgYXMgYWRkaXRpb25hbCBzb3VyY2UgZm9yIHRoZSB0ZW1wb3Jhcnkg
ZGlyZWN0b3J5IHVzZWQgaW4gd3JpdGVUZW1wRmlsZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi
a2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC9tZXJnZUNoYW5nZUxvZ3MucGw6CisgICAgICAgICh3
cml0ZVRlbXBGaWxlKToKKwogMjAxMS0wOC0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu
b3JnPgogCiAgICAgICAgIGdhcmRlbi1vLW1hdGljIHN1bW1hcnkgc2hvdWxkIGJlIGFibGUgdG8g
ZXhhbWluZSBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZD
U1V0aWxzX3VuaXR0ZXN0L21lcmdlQ2hhbmdlTG9ncy5wbCBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cGVybC9WQ1NVdGlsc191bml0dGVzdC9tZXJnZUNoYW5nZUxvZ3MucGwKaW5kZXggYTIyNmU0M2Zj
OTE4YjcyOWM2MDY5M2NiNTRhYzE0ZWNhNDcxMjNjZC4uMGM4Yzg5YzdhNmI3NDczZTYxNGExZGMw
YTYxY2Y4ZTA1ZTJjZDEzZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZD
U1V0aWxzX3VuaXR0ZXN0L21lcmdlQ2hhbmdlTG9ncy5wbAorKysgYi9Ub29scy9TY3JpcHRzL3dl
YmtpdHBlcmwvVkNTVXRpbHNfdW5pdHRlc3QvbWVyZ2VDaGFuZ2VMb2dzLnBsCkBAIC01MCw3ICs1
MCw3IEBAIHN1YiB3cml0ZVRlbXBGaWxlKCQkJCkKIAogICAgIG15ICgkRkgsICRmaWxlTmFtZSkg
PSB0ZW1wZmlsZSgKICAgICAgICAgJG5hbWUgLiAiLVhYWFhYWFhYIiwKLSAgICAgICAgRElSID0+
ICgkRU5WeydUTVBESVInfSB8fCAiL3RtcCIpLAorICAgICAgICBESVIgPT4gKCRFTlZ7J1RNUERJ
Uid9IHx8ICRFTlZ7J1RFTVAnfSB8fCAiL3RtcCIpLAogICAgICAgICBVTkxJTksgPT4gMCwKICAg
ICApOwogICAgIHByaW50ICRGSCAkY29udGVudDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>