6679 2006-01-19 17:18:43 -0800 evalAfterBackForwardNavigation causes hang when page can't be cached 2007-10-18 00:56:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 NEW P4 Normal --- 1 eric webkit-unassigned oldest_to_newest 28936 0 eric 2006-01-19 17:18:43 -0800 evalAfterBackForwardNavigation causes hang when page can't be cached I was trying to write a test case for back/forward navigation where cacheing the page should be disallowed. This hangs DRT because evalAfterBackForwardNavigation keeps getting called by my onload every time the first page is reload. We need some sort of loop check for evalAfterBackForwardNavigation. 28937 1 5789 eric 2006-01-19 17:19:32 -0800 Created attachment 5789 test case 30355 2 ggaren 2006-01-27 15:41:29 -0800 I didn't consider a page not making it into the cache when I wrote the NavigationController class. The simple solution here is to have evalAfterBackForwardNavigation execute only once per page. In the future, if someone wants to use it more than once on a page, they can dream up a more interesting hashing solution. 30357 3 ggaren 2006-01-27 15:47:10 -0800 We could also use something like if (!navigationController.didNavigate) {...} or navigationController.setState(true) if (!navigationController.getState()) to make things arbitrarily extensible. valueForUndefinedKey would be helpful here, but it doesn't work yet. 5789 2006-01-19 17:19:32 -0800 2006-01-19 17:19:32 -0800 test case embed-after-back-forward.tgz application/x-gzip 510 eric H4sIAJI60EMAA+2VzXKbMBDHuZanUDnhgw0YYw5VmEnb6bGXJg8goyVRiyUPEnE9mbx7JeHEnYzt dPLhHLq/ixBaaZfdPytYLoCPWWOgGy9Y/WvcqG7NOj65Nss2eB1Sy3w2s2OWFenMz7Np6kf3mJVF kKX5fJbmeZrmQZoV5TQPSPpK/o/Sa8M6QgLQIDgc/mTGl0KeIqDTQl2dq5BeA+NV+IEaYVqo1OIn 1CYBJw5NrCSuwJBaSQPSaOLVQpxakq1aaDLsC6muO7EyVdj0sjZCSb9LyB4uQJtzt/E7uxFXzK3F o/A2JBbWQmfiiCsJ0eiTfyUaEq+F5Go9adlG9cbt/2LP6lRrrUfeyLFvdSKVEc3mqz0vtufdhbtw jDV88PuUE3J73A3vl6tzfQG/TbwN+6DpmglzaTPR3gflLO8eRyEfcrPvU/etTuCGtT6vn209vg3l +CvF0dH8Rz47NLmvGk0GHThvdKH4hijZKsbPoiFvkZWIW/LCILqrz6IOtOq7GvSglkOtJEqcuhJ3 pnfjVffe4keCXfnezodr8mVRHOr/jm3/z8r5vLT9f5oX04AUbxfSjv+8///j7/siH0/c/3ZSPqp/ WRYZ3v+ngK6qH31t668/0mRVvXc4CIIgCIIgCIIgCIIgCIIgCIIgCIIgyDP5A/iO/e4AKAAA