66787 2011-08-23 10:49:46 -0700 SelectElementData: Reorder members to reduce memory usage. 2011-08-24 02:52:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling oldest_to_newest 455501 0 kling 2011-08-23 10:49:46 -0700 There is some potential here. 455502 1 104866 kling 2011-08-23 10:51:25 -0700 Created attachment 104866 Proposed patch 455507 2 104866 darin 2011-08-23 11:00:11 -0700 Comment on attachment 104866 Proposed patch While this does make the class smaller, I am concerned that it might also make the class a bit harder to understand. Also, I think it might be easy to make the class even smaller since a UChar could share storage with some of the bools. Or the bools could be made bitfields. 456036 3 kling 2011-08-24 02:52:53 -0700 Committed r93699: <http://trac.webkit.org/changeset/93699> 104866 2011-08-23 10:51:25 -0700 2011-08-23 11:00:10 -0700 Proposed patch bug-66787.diff text/plain 2816 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjY5ZWJmLi4wNTJjZjJiIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMDgtMjMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNlbGVjdEVsZW1lbnREYXRhOiBSZW9yZGVyIG1lbWJlcnMgdG8gcmVkdWNlIG1lbW9yeSB1 c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2 Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVk dWNlZCB0aGUgc2l6ZSBvZiBTZWxlY3RFbGVtZW50RGF0YSBieSAyNCBieXRlcyBvbiA2NC1iaXQg YnkgcmVhcnJhbmdpbmcKKyAgICAgICAgaXRzIGRhdGEgbWVtYmVycy4KKworICAgICAgICBBbHNv IGFkZGVkIG1pc3NpbmcgaW5pdGlhbGl6YXRpb24gb2YgbV91c2VyRHJpdmVuQ2hhbmdlLgorCisg ICAgICAgICogZG9tL1NlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0 RWxlbWVudERhdGE6OlNlbGVjdEVsZW1lbnREYXRhKToKKyAgICAgICAgKiBkb20vU2VsZWN0RWxl bWVudC5oOgorCisyMDExLTA4LTIzICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4K KwogICAgICAgICBIVE1MSW1hZ2VFbGVtZW50OiBSZW9yZGVyIG1lbWJlcnMgdG8gcmVkdWNlIG1l bW9yeSB1c2FnZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2Nzg0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAppbmRleCAwYTgzNTQz Li5jZmQ2OWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCkBAIC0xMDUwLDE1 ICsxMDUwLDE2IEBAIHVuc2lnbmVkIFNlbGVjdEVsZW1lbnQ6Om9wdGlvbkNvdW50KGNvbnN0IFNl bGVjdEVsZW1lbnREYXRhJiBkYXRhLCBjb25zdCBFbGVtZW50CiAKIC8vIFNlbGVjdEVsZW1lbnRE YXRhCiBTZWxlY3RFbGVtZW50RGF0YTo6U2VsZWN0RWxlbWVudERhdGEoKQotICAgIDogbV9tdWx0 aXBsZShmYWxzZSkgCisgICAgOiBtX2xhc3RDaGFyVGltZSgwKQorICAgICwgbV9yZXBlYXRpbmdD aGFyKDApCiAgICAgLCBtX3NpemUoMCkKICAgICAsIG1fbGFzdE9uQ2hhbmdlSW5kZXgoLTEpCi0g ICAgLCBtX2FjdGl2ZVNlbGVjdGlvblN0YXRlKGZhbHNlKQogICAgICwgbV9hY3RpdmVTZWxlY3Rp b25BbmNob3JJbmRleCgtMSkKICAgICAsIG1fYWN0aXZlU2VsZWN0aW9uRW5kSW5kZXgoLTEpCisg ICAgLCBtX3VzZXJEcml2ZW5DaGFuZ2UoZmFsc2UpCisgICAgLCBtX211bHRpcGxlKGZhbHNlKQor ICAgICwgbV9hY3RpdmVTZWxlY3Rpb25TdGF0ZShmYWxzZSkKICAgICAsIG1fcmVjYWxjTGlzdEl0 ZW1zKGZhbHNlKQotICAgICwgbV9yZXBlYXRpbmdDaGFyKDApCi0gICAgLCBtX2xhc3RDaGFyVGlt ZSgwKQogewogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuaAppbmRleCA3YTI2Y2MwLi44 NDc5MzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmgKQEAgLTE3MSwyNSArMTcxLDI0 IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgdm9pZCBjaGVja0xpc3RJdGVtcyhjb25zdCBFbGVt ZW50KikgY29uc3Q7CiAKLSAgICBib29sIG1fbXVsdGlwbGU7Ci0gICAgaW50IG1fc2l6ZTsKLQot ICAgIGludCBtX2xhc3RPbkNoYW5nZUluZGV4OworICAgIFZlY3RvcjxFbGVtZW50Kj4gbV9saXN0 SXRlbXM7CiAgICAgVmVjdG9yPGJvb2w+IG1fbGFzdE9uQ2hhbmdlU2VsZWN0aW9uOwotICAgIGJv b2wgbV91c2VyRHJpdmVuQ2hhbmdlOwotCi0gICAgYm9vbCBtX2FjdGl2ZVNlbGVjdGlvblN0YXRl OwotICAgIGludCBtX2FjdGl2ZVNlbGVjdGlvbkFuY2hvckluZGV4OwotICAgIGludCBtX2FjdGl2 ZVNlbGVjdGlvbkVuZEluZGV4OwogICAgIFZlY3Rvcjxib29sPiBtX2NhY2hlZFN0YXRlRm9yQWN0 aXZlU2VsZWN0aW9uOwogCi0gICAgYm9vbCBtX3JlY2FsY0xpc3RJdGVtczsKLSAgICBWZWN0b3I8 RWxlbWVudCo+IG1fbGlzdEl0ZW1zOwotCiAgICAgLy8gSW5zdGFuY2UgdmFyaWFibGVzIGZvciB0 eXBlLWFoZWFkIGZpbmQKLSAgICBVQ2hhciBtX3JlcGVhdGluZ0NoYXI7CiAgICAgRE9NVGltZVN0 YW1wIG1fbGFzdENoYXJUaW1lOwogICAgIFN0cmluZyBtX3R5cGVkU3RyaW5nOworICAgIFVDaGFy IG1fcmVwZWF0aW5nQ2hhcjsKKworICAgIGludCBtX3NpemU7CisgICAgaW50IG1fbGFzdE9uQ2hh bmdlSW5kZXg7CisgICAgaW50IG1fYWN0aXZlU2VsZWN0aW9uQW5jaG9ySW5kZXg7CisgICAgaW50 IG1fYWN0aXZlU2VsZWN0aW9uRW5kSW5kZXg7CisKKyAgICBib29sIG1fdXNlckRyaXZlbkNoYW5n ZTsKKyAgICBib29sIG1fbXVsdGlwbGU7CisgICAgYm9vbCBtX2FjdGl2ZVNlbGVjdGlvblN0YXRl OworICAgIGJvb2wgbV9yZWNhbGNMaXN0SXRlbXM7CiB9OwogCiBTZWxlY3RFbGVtZW50KiB0b1Nl bGVjdEVsZW1lbnQoRWxlbWVudCopOwo=