66783 2011-08-23 10:13:39 -0700 fast/loader/document-destruction-within-unload.html causes an assertion failure in the next test (currently, document-with-fragment-url-1.html) 2012-09-04 09:47:05 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 64741 1 ap japhet abarth japhet kbalazs ossy webkit-bug-importer webkit.review.bot oldest_to_newest 455465 0 ap 2011-08-23 10:13:39 -0700 run-webkit-tests fast/loader/document-destruction-within-unload.html --repeat 2 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x00000001036707a8 -[WebHTMLView setDataSource:] + 88 (WebHTMLView.mm:3774) 1 com.apple.WebKit 0x000000010363243d WebFrameLoaderClient::transitionToCommittedForNewPage() + 1917 (WebFrameLoaderClient.mm:1301) 2 com.apple.WebCore 0x0000000104318d86 WebCore::FrameLoader::transitionToCommitted(WTF::PassRefPtr<WebCore::CachedPage>) + 1142 (FrameLoader.cpp:1928) 3 com.apple.WebCore 0x0000000104317e29 WebCore::FrameLoader::commitProvisionalLoad() + 1625 (FrameLoader.cpp:1780) 4 com.apple.WebCore 0x000000010408cf7d WebCore::DocumentLoader::commitIfReady() + 77 (DocumentLoader.cpp:281) 5 com.apple.WebCore 0x000000010408d054 WebCore::DocumentLoader::commitLoad(char const*, int) + 84 (DocumentLoader.cpp:300) 6 com.apple.WebCore 0x000000010408d42a WebCore::DocumentLoader::receivedData(char const*, int) + 90 (DocumentLoader.cpp:335) 7 com.apple.WebCore 0x0000000104c09007 WebCore::MainResourceLoader::addData(char const*, int, bool) + 87 (MainResourceLoader.cpp:169) 8 com.apple.WebCore 0x0000000104fccc5d WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 269 (ResourceLoader.cpp:304) 9 com.apple.WebCore 0x0000000104c0b1fc WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 1052 (MainResourceLoader.cpp:464) 10 com.apple.WebCore 0x0000000104fcd7dd WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) + 157 (ResourceLoader.cpp:463) 11 com.apple.WebCore 0x0000000104fc94e2 -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] + 306 (ResourceHandleMac.mm:854) 455492 1 japhet 2011-08-23 10:36:36 -0700 Sigh. I saw a similar assertion failure while testing my patch, but I thought I had fixed those issues. I'll look at it this afternoon if no one beats me to it. 455774 2 japhet 2011-08-23 16:03:05 -0700 (In reply to comment #1) > Sigh. I saw a similar assertion failure while testing my patch, but I thought I had fixed those issues. > > I'll look at it this afternoon if no one beats me to it. It appears my too-clever-for-its-own-good crash fix doesn't properly retain WebDocumentLoaderMac's m_dataSource, which is getting detached too early in the new test. Need to do some more digging to see if there's a sane way to handle this. 459041 3 ap 2011-08-30 11:31:17 -0700 This is still failing on bots. How bad is this assertion - should the test be disabled, or should the whole patch be reverted? 459043 4 japhet 2011-08-30 11:33:54 -0700 (In reply to comment #3) > This is still failing on bots. How bad is this assertion - should the test be disabled, or should the whole patch be reverted? It's an assertion fail in debug (and null deref in release), in a place where we were use-after-freeing. I'd propose that we mark the test failing and leave this issue open (and assign it to me). 459122 5 ap 2011-08-30 13:10:02 -0700 Skipped the test on Mac in <http://trac.webkit.org/changeset/94099>. It cannot be marked as failing, because it breaks the next test. 503033 6 ddkilzer 2011-11-15 10:32:13 -0800 <rdar://problem/10448886> 659346 7 kbalazs 2012-06-28 02:04:54 -0700 I believe I am facing with the same issue on WebKit2 (with Qt port but I think it is a general bug): bug 89467. 687109 8 ap 2012-08-03 13:47:36 -0700 Nate, do you think that you'll have a chance to look into this? 687111 9 japhet 2012-08-03 13:52:20 -0700 (In reply to comment #8) > Nate, do you think that you'll have a chance to look into this? Probably not for at least a few weeks, but I can add it to my list of things I need to do sooner rather than later. 709147 10 161584 japhet 2012-08-30 16:42:44 -0700 Created attachment 161584 patch 709849 11 161584 darin 2012-08-31 11:50:10 -0700 Comment on attachment 161584 patch View in context: https://bugs.webkit.org/attachment.cgi?id=161584&action=review > Source/WebCore/ChangeLog:3 > + fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt. Is there a way to make a test that more directly targets this problem rather than having the symptom be assertion failures in the next test that happen on only certain platforms? > Source/WebCore/loader/FrameLoader.cpp:1619 > + // detachChildren() can trigger this frame's unload event, and can therefore > + // do terrible, terrible things. For example, an unload event that calls Whenever possible, I prefer more precise terminology than “can do terrible things”. I want our comments to help people understand better, rather than creating fear. So I’d be tempted to say something more like “therefore script code from the webpage can run and do almost anything” or something like that. > LayoutTests/ChangeLog:9 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Can’t land a patch with this in it. 710028 12 japhet 2012-08-31 15:17:30 -0700 (In reply to comment #11) > (From update of attachment 161584 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161584&action=review > > > Source/WebCore/ChangeLog:3 > > + fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt. > > Is there a way to make a test that more directly targets this problem rather than having the symptom be assertion failures in the next test that happen on only certain platforms? If there is, I haven't figured it out. It's unfortunate that assertions during detach and cleanup show up as failures in the next test (or are swallowed if the test is run by itself). > > > Source/WebCore/loader/FrameLoader.cpp:1619 > > + // detachChildren() can trigger this frame's unload event, and can therefore > > + // do terrible, terrible things. For example, an unload event that calls > > Whenever possible, I prefer more precise terminology than “can do terrible things”. I want our comments to help people understand better, rather than creating fear. So I’d be tempted to say something more like “therefore script code from the webpage can run and do almost anything” or something like that. Yeah, sorry about that. FrameLoader brings out my snarky, fear-mongering side. 710029 13 161785 japhet 2012-08-31 15:21:30 -0700 Created attachment 161785 Patch for landing 710114 14 161785 webkit.review.bot 2012-08-31 18:08:39 -0700 Comment on attachment 161785 Patch for landing Clearing flags on attachment: 161785 Committed r127347: <http://trac.webkit.org/changeset/127347> 710115 15 webkit.review.bot 2012-08-31 18:08:43 -0700 All reviewed patches have been landed. Closing bug. 710992 16 kbalazs 2012-09-04 05:03:55 -0700 *** Bug 89467 has been marked as a duplicate of this bug. *** 711190 17 japhet 2012-09-04 09:47:05 -0700 *** Bug 95441 has been marked as a duplicate of this bug. *** 161584 2012-08-30 16:42:44 -0700 2012-08-31 15:21:27 -0700 patch unload.txt text/plain 5211 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzIwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTMwICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZmFzdC9sb2FkZXIvZG9jdW1l bnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sIGNhdXNlcyBhc3NlcnRpb24gZmFpbHVy ZXMgb24gbWFjIGFuZCBxdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY2NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyB3YXMgYSBub3QtcXVpdGUtcmVncmVzc2lvbiBmcm9tIHRyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvOTM1MjEsIGluIHRoYXQgd2UgaGl0IGFzc2VydHMKKyAgICAgICAgaW4g YSBjYXNlIHdoZXJlIHdlIHByZXZpb3VzbHkgd2VyZSB1c2UtYWZ0ZXItZnJlZWluZy4gVHdlYWsg aG93IHdlIGhhbmRsZSBjYXNlcyB3aGVyZSBhIERvY3VtZW50CisgICAgICAgIGlzIGNsZWFyZWQg ZnJvbSB3aXRoaW4gYW4gdW5sb2FkIGhhbmRsZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChP T1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OnNldERvY3VtZW50TG9hZGVyKTogSW5zdGVhZCBvZiB0cnlpbmcg dG8gcmVhdHRhY2ggYSBwYXJ0aWFsbHkgcmVtb3ZlZAorICAgICAgICAgICAgRG9jdW1lbnRMb2Fk ZXIgaWYgaXQgaXMgZGV0YWNoZWQgYmVmb3JlIGJlaW5nIGZ1bGx5IGFkZGVkLCBsZWF2ZSB0aGUg b2xkIG9uZSBpbiBwbGFjZSwgY29tcGxldGVkLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2Fk ZXI6OnRyYW5zaXRpb25Ub0NvbW1pdHRlZCk6CisKIDIwMTItMDgtMzAgIEp1bGllbiBDaGFmZnJh aXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ3Jhc2ggaW4gUmVuZGVyVGFi bGU6OmNhbGNCb3JkZXJFbmQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAkocmV2aXNpb24gMTI3MjA3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYxNCwyNCArMTYxNCwyMSBAQAogCiAgICAgbV9jbGll bnQtPnByZXBhcmVGb3JEYXRhU291cmNlUmVwbGFjZW1lbnQoKTsKICAgICBkZXRhY2hDaGlsZHJl bigpOworCisgICAgLy8gZGV0YWNoQ2hpbGRyZW4oKSBjYW4gdHJpZ2dlciB0aGlzIGZyYW1lJ3Mg dW5sb2FkIGV2ZW50LCBhbmQgY2FuIHRoZXJlZm9yZQorICAgIC8vIGRvIHRlcnJpYmxlLCB0ZXJy aWJsZSB0aGluZ3MuIEZvciBleGFtcGxlLCBhbiB1bmxvYWQgZXZlbnQgdGhhdCBjYWxscworICAg IC8vIGRvY3VtZW50LndyaXRlKCIiKSBvbiBpdHMgcGFyZW50IGZyYW1lIHdpbGwgbGVhZCB0byBh IHJlY3Vyc2l2ZSBkZXRhY2hDaGlsZHJlbigpCisgICAgLy8gc3BpcmFsIG9mIGRvb20uIEluIHRo YXQgY2FzZSwgd2UgY2FuIGVuZCB1cCBhdCB0aGlzIHBvaW50IHdpdGggYW4gYWxpdmUKKyAgICAv LyBsb2FkZXIgdGhhdCBoYXMgYmVlbiBkZXRhY2hlZCBmcm9tIGl0cyBmcmFtZS4gU3VjaCBhIERv Y3VtZW50TG9hZGVyIGhhcworICAgIC8vIGJlZW4gc3VmZmljaWVudGx5IGRldGFjaGVkIHRoYXQg d2UnbGwgZW5kIHVwIGluIGFuIGluY29uc2lzdGVudCBzdGF0ZSBpZgorICAgIC8vIHdlIHRyeSB0 byB1c2UgaXQuCisgICAgaWYgKGxvYWRlciAmJiAhbG9hZGVyLT5mcmFtZSgpKQorICAgICAgICBy ZXR1cm47CisKICAgICBpZiAobV9kb2N1bWVudExvYWRlcikKICAgICAgICAgbV9kb2N1bWVudExv YWRlci0+ZGV0YWNoRnJvbUZyYW1lKCk7CiAKICAgICBtX2RvY3VtZW50TG9hZGVyID0gbG9hZGVy OwotCi0gICAgLy8gVGhlIGZvbGxvd2luZyBhYm9taW5hdGlvbiBpcyBicm91Z2h0IHRvIHlvdSBi eSB0aGUgdW5sb2FkIGV2ZW50LgotICAgIC8vIFRoZSBkZXRhY2hDaGlsZHJlbigpIGNhbGwgYWJv dmUgbWF5IHRyaWdnZXIgYSBjaGlsZCBmcmFtZSdzIHVubG9hZCBldmVudCwKLSAgICAvLyB3aGlj aCBjb3VsZCBkbyBzb21ldGhpbmcgb2Jub3hpb3VzIGxpa2UgY2FsbCBkb2N1bWVudC53cml0ZSgi Iikgb24KLSAgICAvLyB0aGUgbWFpbiBmcmFtZSwgd2hpY2ggcmVzdWx0cyBpbiBkZXRhY2hpbmcg Y2hpbGRyZW4gd2hpbGUgZGV0YWNoaW5nIGNoaWxkcmVuLgotICAgIC8vIFRoaXMgY2FuIGNhdXNl IHRoZSBuZXcgbV9kb2N1bWVudExvYWRlciB0byBiZSBkZXRhY2hlZCBmcm9tIGl0cyBGcmFtZSos IGJ1dCBzdGlsbAotICAgIC8vIGJlIGFsaXZlLiBUbyBtYWtlIG1hdHRlcnMgd29yc2UsIERvY3Vt ZW50TG9hZGVycyB3aXRoIGEgbnVsbCBGcmFtZSogYXJlbid0IHN1cHBvc2VkCi0gICAgLy8gdG8g aGFwcGVuIHdoZW4gdGhleSdyZSBzdGlsbCBhbGl2ZSAoYW5kIG1hbnkgcGxhY2VzIGJlbG93IHVz IG9uIHRoZSBzdGFjayB0aGluayB0aGUKLSAgICAvLyBEb2N1bWVudExvYWRlciBpcyBzdGlsbCB1 c2FibGUpLiBFcmdvLCB3ZSByZWF0dGFjaCBsb2FkZXIgdG8gaXRzIEZyYW1lLCBhbmQgcHJldGVu ZAotICAgIC8vIGxpa2Ugbm90aGluZyBldmVyIGhhcHBlbmVkLgotICAgIGlmIChtX2RvY3VtZW50 TG9hZGVyICYmICFtX2RvY3VtZW50TG9hZGVyLT5mcmFtZSgpKSB7Ci0gICAgICAgIEFTU0VSVCgh bV9kb2N1bWVudExvYWRlci0+aXNMb2FkaW5nKCkpOwotICAgICAgICBtX2RvY3VtZW50TG9hZGVy LT5zZXRGcmFtZShtX2ZyYW1lKTsKLSAgICB9CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXI6OnNldFBv bGljeURvY3VtZW50TG9hZGVyKERvY3VtZW50TG9hZGVyKiBsb2FkZXIpCkBAIC0xODA1LDYgKzE4 MDIsMTIgQEAKIAogICAgIHNldERvY3VtZW50TG9hZGVyKG1fcHJvdmlzaW9uYWxEb2N1bWVudExv YWRlci5nZXQoKSk7CiAgICAgc2V0UHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcigwKTsKKworICAg IGlmIChwZGwgIT0gbV9kb2N1bWVudExvYWRlcikgeworICAgICAgICBBU1NFUlQobV9zdGF0ZSA9 PSBGcmFtZVN0YXRlQ29tcGxldGUpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgc2V0 U3RhdGUoRnJhbWVTdGF0ZUNvbW1pdHRlZFBhZ2UpOwogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5U UykKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gMTI3MjA3KQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMjc3Miw1ICsy NzcyLDMgQEAKICMgW1F0XVtHVEtdIE5ldyBzdmcvY3VzdG9tL2NsYW1wZWQtbWFza2luZy1jbGlw cGluZy5zdmcgZmFpbHMKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1NDMyCiBzdmcvY3VzdG9tL2NsYW1wZWQtbWFza2luZy1jbGlwcGluZy5zdmcKLQotZmFzdC9s b2FkZXIvZG9jdW1lbnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sCkluZGV4OiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvU2tpcHBlZAkocmV2aXNpb24gMTI3MjA3KQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTUxNywxMCArNTE3LDYgQEAKICMg VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYSBtaXNtYXRjaCByZWZ0ZXN0IHdpbGwgZmFpbCBhcyBp bnRlbmRlZCBpZiBib3RoIHJlc3VsdHMgYXJlIHNhbWUuCiBmYXN0L2hhcm5lc3Mvc2FtcGxlLWZh aWwtbWlzbWF0Y2gtcmVmdGVzdC5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY2NzgzCi0jIE1ha2VzIHN1YnNlcXVlbnQgdGVzdCBjcmFzaAotZmFzdC9s b2FkZXIvZG9jdW1lbnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sCi0KICMgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NzE2CiBtZWRpYS9tZWRpYS1jb250 cm9scy1pbnZhbGlkLXVybC5odG1sCiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzIwOSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA4LTMwICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVW5z a2lwIGZhc3QvbG9hZGVyL2RvY3VtZW50LWRlc3RydWN0aW9uLXdpdGhpbi11bmxvYWQuaHRtbAor ICAgICAgICBvbiBtYWMgYW5kIHF0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjY3ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBh cyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlv bnMgYmVsb3cgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lwcGVkOgorICAg ICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTItMDgtMzAgIEplc3NpZSBCZXJsaW4g IDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBDU1MgMi4xIGZhaWx1cmU6IG1hcmdpbi1j b2xsYXBzZS1jbGVhci0wMTIgZmFpbHMK 161785 2012-08-31 15:21:30 -0700 2012-08-31 18:08:39 -0700 Patch for landing bug-66783-20120831152117.patch text/plain 5741 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzMxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTMwICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZmFzdC9sb2FkZXIvZG9jdW1l bnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sIGNhdXNlcyBhc3NlcnRpb24gZmFpbHVy ZXMgb24gbWFjIGFuZCBxdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY2NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAg ICAgICAgVGhpcyB3YXMgYSBub3QtcXVpdGUtcmVncmVzc2lvbiBmcm9tIHRyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvOTM1MjEsIGluIHRoYXQgd2UgaGl0IGFzc2VydHMKKyAgICAgICAgaW4gYSBj YXNlIHdoZXJlIHdlIHByZXZpb3VzbHkgd2VyZSB1c2UtYWZ0ZXItZnJlZWluZy4gVHdlYWsgaG93 IHdlIGhhbmRsZSBjYXNlcyB3aGVyZSBhIERvY3VtZW50CisgICAgICAgIGlzIGNsZWFyZWQgZnJv bSB3aXRoaW4gYW4gdW5sb2FkIGhhbmRsZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBmaXhp bmcgZmFzdC9sb2FkZXIvZG9jdW1lbnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sIG9u IG1hYyBhbmQgcXQuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnNldERvY3VtZW50TG9hZGVyKTogSW5zdGVhZCBvZiB0 cnlpbmcgdG8gcmVhdHRhY2ggYSBwYXJ0aWFsbHkgcmVtb3ZlZAorICAgICAgICAgICAgRG9jdW1l bnRMb2FkZXIgaWYgaXQgaXMgZGV0YWNoZWQgYmVmb3JlIGJlaW5nIGZ1bGx5IGFkZGVkLCBsZWF2 ZSB0aGUgb2xkIG9uZSBpbiBwbGFjZSwgY29tcGxldGVkLgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVMb2FkZXI6OnRyYW5zaXRpb25Ub0NvbW1pdHRlZCk6CisKIDIwMTItMDgtMzAgIEphbWVzIFJv Ymluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFB1dCBj b21wb3NpdG9yIGNsaWVudCBpbnRlcmZhY2VzIGluIHNlcGFyYXRlIGhlYWRlcnMsIG5vcm1hbGl6 ZSBuYW1pbmcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNp b24gMTI3MzE2KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTYxNCwyNCArMTYxNCwyMSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpzZXRE b2N1bWVudExvYWRlcihEb2N1CiAKICAgICBtX2NsaWVudC0+cHJlcGFyZUZvckRhdGFTb3VyY2VS ZXBsYWNlbWVudCgpOwogICAgIGRldGFjaENoaWxkcmVuKCk7CisKKyAgICAvLyBkZXRhY2hDaGls ZHJlbigpIGNhbiB0cmlnZ2VyIHRoaXMgZnJhbWUncyB1bmxvYWQgZXZlbnQsIGFuZCB0aGVyZWZv cmUKKyAgICAvLyBzY3JpcHQgY2FuIHJ1biBhbmQgZG8ganVzdCBhYm91dCBhbnl0aGluZy4gRm9y IGV4YW1wbGUsIGFuIHVubG9hZCBldmVudCB0aGF0IGNhbGxzCisgICAgLy8gZG9jdW1lbnQud3Jp dGUoIiIpIG9uIGl0cyBwYXJlbnQgZnJhbWUgY2FuIGxlYWQgdG8gYSByZWN1cnNpdmUgZGV0YWNo Q2hpbGRyZW4oKQorICAgIC8vIGludm9jYXRpb24gZm9yIHRoaXMgZnJhbWUuIEluIHRoYXQgY2Fz ZSwgd2UgY2FuIGVuZCB1cCBhdCB0aGlzIHBvaW50IHdpdGggYQorICAgIC8vIGxvYWRlciB0aGF0 IGhhc24ndCBiZWVuIGRlbGV0ZWQgYnV0IGhhcyBiZWVuIGRldGFjaGVkIGZyb20gaXRzIGZyYW1l LiBTdWNoIGEKKyAgICAvLyBEb2N1bWVudExvYWRlciBoYXMgYmVlbiBzdWZmaWNpZW50bHkgZGV0 YWNoZWQgdGhhdCB3ZSdsbCBlbmQgdXAgaW4gYW4gaW5jb25zaXN0ZW50CisgICAgLy8gc3RhdGUg aWYgd2UgdHJ5IHRvIHVzZSBpdC4KKyAgICBpZiAobG9hZGVyICYmICFsb2FkZXItPmZyYW1lKCkp CisgICAgICAgIHJldHVybjsKKwogICAgIGlmIChtX2RvY3VtZW50TG9hZGVyKQogICAgICAgICBt X2RvY3VtZW50TG9hZGVyLT5kZXRhY2hGcm9tRnJhbWUoKTsKIAogICAgIG1fZG9jdW1lbnRMb2Fk ZXIgPSBsb2FkZXI7Ci0KLSAgICAvLyBUaGUgZm9sbG93aW5nIGFib21pbmF0aW9uIGlzIGJyb3Vn aHQgdG8geW91IGJ5IHRoZSB1bmxvYWQgZXZlbnQuCi0gICAgLy8gVGhlIGRldGFjaENoaWxkcmVu KCkgY2FsbCBhYm92ZSBtYXkgdHJpZ2dlciBhIGNoaWxkIGZyYW1lJ3MgdW5sb2FkIGV2ZW50LAot ICAgIC8vIHdoaWNoIGNvdWxkIGRvIHNvbWV0aGluZyBvYm5veGlvdXMgbGlrZSBjYWxsIGRvY3Vt ZW50LndyaXRlKCIiKSBvbgotICAgIC8vIHRoZSBtYWluIGZyYW1lLCB3aGljaCByZXN1bHRzIGlu IGRldGFjaGluZyBjaGlsZHJlbiB3aGlsZSBkZXRhY2hpbmcgY2hpbGRyZW4uCi0gICAgLy8gVGhp cyBjYW4gY2F1c2UgdGhlIG5ldyBtX2RvY3VtZW50TG9hZGVyIHRvIGJlIGRldGFjaGVkIGZyb20g aXRzIEZyYW1lKiwgYnV0IHN0aWxsCi0gICAgLy8gYmUgYWxpdmUuIFRvIG1ha2UgbWF0dGVycyB3 b3JzZSwgRG9jdW1lbnRMb2FkZXJzIHdpdGggYSBudWxsIEZyYW1lKiBhcmVuJ3Qgc3VwcG9zZWQK LSAgICAvLyB0byBoYXBwZW4gd2hlbiB0aGV5J3JlIHN0aWxsIGFsaXZlIChhbmQgbWFueSBwbGFj ZXMgYmVsb3cgdXMgb24gdGhlIHN0YWNrIHRoaW5rIHRoZQotICAgIC8vIERvY3VtZW50TG9hZGVy IGlzIHN0aWxsIHVzYWJsZSkuIEVyZ28sIHdlIHJlYXR0YWNoIGxvYWRlciB0byBpdHMgRnJhbWUs IGFuZCBwcmV0ZW5kCi0gICAgLy8gbGlrZSBub3RoaW5nIGV2ZXIgaGFwcGVuZWQuCi0gICAgaWYg KG1fZG9jdW1lbnRMb2FkZXIgJiYgIW1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCkpIHsKLSAgICAg ICAgQVNTRVJUKCFtX2RvY3VtZW50TG9hZGVyLT5pc0xvYWRpbmcoKSk7Ci0gICAgICAgIG1fZG9j dW1lbnRMb2FkZXItPnNldEZyYW1lKG1fZnJhbWUpOwotICAgIH0KIH0KIAogdm9pZCBGcmFtZUxv YWRlcjo6c2V0UG9saWN5RG9jdW1lbnRMb2FkZXIoRG9jdW1lbnRMb2FkZXIqIGxvYWRlcikKQEAg LTE4MDUsNiArMTgwMiwxMiBAQCB2b2lkIEZyYW1lTG9hZGVyOjp0cmFuc2l0aW9uVG9Db21taXR0 ZWQoCiAKICAgICBzZXREb2N1bWVudExvYWRlcihtX3Byb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIu Z2V0KCkpOwogICAgIHNldFByb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIoMCk7CisKKyAgICBpZiAo cGRsICE9IG1fZG9jdW1lbnRMb2FkZXIpIHsKKyAgICAgICAgQVNTRVJUKG1fc3RhdGUgPT0gRnJh bWVTdGF0ZUNvbXBsZXRlKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIHNldFN0YXRl KEZyYW1lU3RhdGVDb21taXR0ZWRQYWdlKTsKIAogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjczMTYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOC0zMCAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVuc2tpcCBmYXN0L2xvYWRlci9kb2N1bWVudC1k ZXN0cnVjdGlvbi13aXRoaW4tdW5sb2FkLmh0bWwKKyAgICAgICAgb24gbWFjIGFuZCBxdC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NzgzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv U2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEyLTA4LTMxICBQ aGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCB1cGRh dGUgb2YgZmFzdC9qcy9mdW5jdGlvbi1hcHBseS1hbGlhc2VkLmh0bWwgZXhwZWN0YXRpb25zLgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQJKHJldmlzaW9uIDEyNzMxNikKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01MTcsMTAgKzUx Nyw2IEBAIGNzczMvZm9udC1mZWF0dXJlLXNldHRpbmdzLXJlbmRlcmluZy5odG0KICMgVGhpcyB0 ZXN0IHZlcmlmaWVzIHRoYXQgYSBtaXNtYXRjaCByZWZ0ZXN0IHdpbGwgZmFpbCBhcyBpbnRlbmRl ZCBpZiBib3RoIHJlc3VsdHMgYXJlIHNhbWUuCiBmYXN0L2hhcm5lc3Mvc2FtcGxlLWZhaWwtbWlz bWF0Y2gtcmVmdGVzdC5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2NzgzCi0jIE1ha2VzIHN1YnNlcXVlbnQgdGVzdCBjcmFzaAotZmFzdC9sb2FkZXIv ZG9jdW1lbnQtZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sCi0KICMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NzE2CiBtZWRpYS9tZWRpYS1jb250cm9scy1p bnZhbGlkLXVybC5odG1sCiAKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24g MTI3MzE2KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5 KQpAQCAtMjc4MiwxMCArMjc4Miw2IEBAIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2NzcC1pbmxpbmUt d2FybmluZy0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NDMy CiBzdmcvY3VzdG9tL2NsYW1wZWQtbWFza2luZy1jbGlwcGluZy5zdmcKIAotIyBbUXRdIFJFR1JF U1NJT04ocjEyMjE3NSk6IGZhc3QvbG9hZGVyL2RvY3VtZW50LWRlc3RydWN0aW9uLXdpdGhpbi11 bmxvYWQuaHRtbCBtYWtlcyB0aGUgZm9sbG93aW5nIHRlc3QgYXNzZXJ0Ci0jIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTQ0MQotZmFzdC9sb2FkZXIvZG9jdW1lbnQt ZGVzdHJ1Y3Rpb24td2l0aGluLXVubG9hZC5odG1sCi0KICMgUkVHUkVTU0lPTiAocjEyNzIwMik6 IGh0dHAvdGVzdHMvc2VjdXJpdHkvaW5hY3RpdmUtZG9jdW1lbnQtd2l0aC1lbXB0eS1zZWN1cml0 eS1vcmlnaW4uaHRtbCBmYWlsaW5nIG9uIEpTQyBwb3J0cwogIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU1MzAKIGh0dHAvdGVzdHMvc2VjdXJpdHkvaW5hY3RpdmUt ZG9jdW1lbnQtd2l0aC1lbXB0eS1zZWN1cml0eS1vcmlnaW4uaHRtbAo=