66773 2011-08-23 06:17:45 -0700 Implement dumpProgressFinishedCallback() for Win layoutTestController 2015-06-09 20:35:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 28851 1 cmarcelo hyungwook.lee bfulgham commit-queue gyuyoung.kim hyungwook.lee oldest_to_newest 455365 0 cmarcelo 2011-08-23 06:17:45 -0700 This feature allows us to test the order of progress finished and frame load. See bug 28851 for details. 1100565 1 254542 hyungwook.lee 2015-06-08 20:54:02 -0700 Created attachment 254542 Patch 1100896 2 254542 gyuyoung.kim 2015-06-09 19:33:24 -0700 Comment on attachment 254542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review > Source/WebKit/win/WebView.cpp:5260 > + if (wasObserver) One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. > Source/WebKit/win/WebView.cpp:5266 > + if (isObserver) ditto. 1100897 3 254542 hyungwook.lee 2015-06-09 19:41:17 -0700 Comment on attachment 254542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review >> Source/WebKit/win/WebView.cpp:5260 >> + if (wasObserver) > > One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. We can get valid value when we implement COM QueryInterface() in FrameLoadDelegete. Now we are implement IID_IWebNotificationObserver COM QueryInterface() only for DumpRenderTree. 1100898 4 gyuyoung.kim 2015-06-09 19:47:34 -0700 (In reply to comment #3) > Comment on attachment 254542 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254542&action=review > > >> Source/WebKit/win/WebView.cpp:5260 > >> + if (wasObserver) > > > > One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. > > We can get valid value when we implement COM QueryInterface() in > FrameLoadDelegete. > Now we are implement IID_IWebNotificationObserver COM QueryInterface() only > for DumpRenderTree. If we don't implement COM QueryInterface(), I understand wasObserver and isObserver can be null. Ok, I see. Thanks. 1100904 5 254542 commit-queue 2015-06-09 20:34:57 -0700 Comment on attachment 254542 Patch Clearing flags on attachment: 254542 Committed r185400: <http://trac.webkit.org/changeset/185400> 1100905 6 commit-queue 2015-06-09 20:35:01 -0700 All reviewed patches have been landed. Closing bug. 254542 2015-06-08 20:54:02 -0700 2015-06-09 20:34:57 -0700 Patch Patch text/plain 6474 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTM1MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA2LTA4 ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAg IEltcGxlbWVudCBkdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkgZm9yIFdpbiBsYXlvdXRU ZXN0Q29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2NzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OnNldEZyYW1lTG9hZERlbGVn YXRlUHJpdmF0ZSk6CisKIDIwMTUtMDYtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBBY2Nlc3MgR0NDb250cm9sbGVyIGluc3RhbmNlIHZpYSBHQ0NvbnRyb2xs ZXI6OnNpbmdsZXRvbigpIGluc3RlYWQgb2YgYSBmcmVlIGZ1bmN0aW9uCkluZGV4OiBTb3VyY2Uv V2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9X ZWJWaWV3LmNwcAkocmV2aXNpb24gMTg1MzE0KQorKysgU291cmNlL1dlYktpdC93aW4vV2ViVmll dy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyNDksNyArNTI0OSwyMyBAQCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIFdlYlZpZXc6OmZvcm1ECiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdl YlZpZXc6OnNldEZyYW1lTG9hZERlbGVnYXRlUHJpdmF0ZSggCiAgICAgLyogW2luXSAqLyBJV2Vi RnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlKiBkKQogeworICAgIGlmIChtX2ZyYW1lTG9hZERlbGVn YXRlUHJpdmF0ZSA9PSBkKQorICAgICAgICByZXR1cm4gU19PSzsKKworICAgIHN0YXRpYyBCU1RS IHdlYlZpZXdQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uTmFtZSA9IFN5c0FsbG9jU3RyaW5n KFdlYlZpZXdQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uKTsKKworICAgIElXZWJOb3RpZmlj YXRpb25DZW50ZXIqIG5vdGlmeUNlbnRlciA9IFdlYk5vdGlmaWNhdGlvbkNlbnRlcjo6ZGVmYXVs dENlbnRlckludGVybmFsKCk7CisKKyAgICBDT01QdHI8SVdlYk5vdGlmaWNhdGlvbk9ic2VydmVy PiB3YXNPYnNlcnZlcihRdWVyeSwgbV9mcmFtZUxvYWREZWxlZ2F0ZVByaXZhdGUpOworICAgIGlm ICh3YXNPYnNlcnZlcikKKyAgICAgICAgbm90aWZ5Q2VudGVyLT5yZW1vdmVPYnNlcnZlcih3YXNP YnNlcnZlci5nZXQoKSwgd2ViVmlld1Byb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb25OYW1lLCBu dWxscHRyKTsKKwogICAgIG1fZnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlID0gZDsKKworICAgIENP TVB0cjxJV2ViTm90aWZpY2F0aW9uT2JzZXJ2ZXI+IGlzT2JzZXJ2ZXIoUXVlcnksIG1fZnJhbWVM b2FkRGVsZWdhdGVQcml2YXRlKTsKKyAgICBpZiAoaXNPYnNlcnZlcikKKyAgICAgICAgbm90aWZ5 Q2VudGVyLT5hZGRPYnNlcnZlcihpc09ic2VydmVyLmdldCgpLCB3ZWJWaWV3UHJvZ3Jlc3NGaW5p c2hlZE5vdGlmaWNhdGlvbk5hbWUsIG51bGxwdHIpOworCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAK SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTM1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA2LTA4ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIEltcGxlbWVudCBkdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxi YWNrKCkgZm9yIFdpbiBsYXlvdXRUZXN0Q29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRnJhbWVMb2Fk RGVsZWdhdGUuY3BwOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9GcmFtZUxvYWREZWxl Z2F0ZS5oOgorCiAyMDE1LTA2LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIFlldCBhbm90aGVyIHVucmV2aWV3ZWQgYnVpbGQgZml4IDooCkluZGV4OiBUb29s cy9EdW1wUmVuZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9GcmFtZUxvYWREZWxlZ2F0ZS5jcHAJKHJldmlzaW9u IDE4NTMxNCkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9GcmFtZUxvYWREZWxlZ2F0ZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDYgKzk2LDggQEAgSFJFU1VMVCBGcmFtZUxvYWREZWxl Z2F0ZTo6UXVlcnlJbnRlcmZhYwogICAgICAgICAqcHB2T2JqZWN0ID0gc3RhdGljX2Nhc3Q8SVdl YkZyYW1lTG9hZERlbGVnYXRlUHJpdmF0ZSo+KHRoaXMpOwogICAgIGVsc2UgaWYgKElzRXF1YWxH VUlEKHJpaWQsIElJRF9JV2ViRnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlMikpCiAgICAgICAgICpw cHZPYmplY3QgPSBzdGF0aWNfY2FzdDxJV2ViRnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlMio+KHRo aXMpOworICAgIGVsc2UgaWYgKElzRXF1YWxHVUlEKHJpaWQsIElJRF9JV2ViTm90aWZpY2F0aW9u T2JzZXJ2ZXIpKQorICAgICAgICAqcHB2T2JqZWN0ID0gc3RhdGljX2Nhc3Q8SVdlYk5vdGlmaWNh dGlvbk9ic2VydmVyKj4odGhpcyk7CiAgICAgZWxzZQogICAgICAgICByZXR1cm4gRV9OT0lOVEVS RkFDRTsKIApAQCAtNDI0LDMgKzQyNiwyNCBAQCBIUkVTVUxUIEZyYW1lTG9hZERlbGVnYXRlOjpk aWRSdW5JbnNlY3VyCiAKICAgICByZXR1cm4gU19PSzsKIH0KKworSFJFU1VMVCBGcmFtZUxvYWRE ZWxlZ2F0ZTo6b25Ob3RpZnkoSVdlYk5vdGlmaWNhdGlvbiogbm90aWZpY2F0aW9uKQoreworICAg IF9ic3RyX3Qgbm90aWZpY2F0aW9uTmFtZTsKKyAgICBIUkVTVUxUIGhyID0gbm90aWZpY2F0aW9u LT5uYW1lKCZub3RpZmljYXRpb25OYW1lLkdldEJTVFIoKSk7CisgICAgaWYgKEZBSUxFRChocikp CisgICAgICAgIHJldHVybiBocjsKKworICAgIHN0YXRpYyBfYnN0cl90IHdlYlZpZXdQcm9ncmVz c0ZpbmlzaGVkTm90aWZpY2F0aW9uTmFtZShXZWJWaWV3UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNh dGlvbik7CisKKyAgICBpZiAoIXdjc2NtcChub3RpZmljYXRpb25OYW1lLCB3ZWJWaWV3UHJvZ3Jl c3NGaW5pc2hlZE5vdGlmaWNhdGlvbk5hbWUpKQorICAgICAgICB3ZWJWaWV3UHJvZ3Jlc3NGaW5p c2hlZE5vdGlmaWNhdGlvbigpOworCisgICAgcmV0dXJuIFNfT0s7Cit9CisKK3ZvaWQgRnJhbWVM b2FkRGVsZWdhdGU6OndlYlZpZXdQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uKCkKK3sKKyAg ICBpZiAoIWRvbmUgJiYgZ1Rlc3RSdW5uZXItPmR1bXBQcm9ncmVzc0ZpbmlzaGVkQ2FsbGJhY2so KSkKKyAgICAgICAgcHJpbnRmKCJwb3N0UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlvblxuIik7 Cit9CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUu aAkocmV2aXNpb24gMTg1MzE0KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0ZyYW1lTG9h ZERlbGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDcgQEAgY2xhc3MgQWNjZXNz aWJpbGl0eUNvbnRyb2xsZXI7CiBjbGFzcyBUZXh0SW5wdXRDb250cm9sbGVyOwogY2xhc3MgR0ND b250cm9sbGVyOwogCi1jbGFzcyBGcmFtZUxvYWREZWxlZ2F0ZSA6IHB1YmxpYyBJV2ViRnJhbWVM b2FkRGVsZWdhdGUsIHB1YmxpYyBJV2ViRnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlMiB7CitjbGFz cyBGcmFtZUxvYWREZWxlZ2F0ZSA6IHB1YmxpYyBJV2ViRnJhbWVMb2FkRGVsZWdhdGUsIHB1Ymxp YyBJV2ViRnJhbWVMb2FkRGVsZWdhdGVQcml2YXRlMiwgcHVibGljIElXZWJOb3RpZmljYXRpb25P YnNlcnZlciB7CiBwdWJsaWM6CiAgICAgRnJhbWVMb2FkRGVsZWdhdGUoKTsKICAgICB2aXJ0dWFs IH5GcmFtZUxvYWREZWxlZ2F0ZSgpOwpAQCAtMTUwLDExICsxNTAsMTUgQEAgSlNDb250ZXh0UmVm LCBKU09iamVjdFJlZiB3aW5kb3dPYmplY3QpOwogICAgICAgICAvKiBbaW5dICovIElXZWJWaWV3 ICpzZW5kZXIsCiAgICAgICAgIC8qIFtpbl0gKi8gSVdlYkZyYW1lICpmcmFtZSkgeyByZXR1cm4g RV9OT1RJTVBMOyB9IAogCisgICAgLy8gSVdlYk5vdGlmaWNhdGlvbk9ic2VydmVyCisgICAgdmly dHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIG9uTm90aWZ5KElXZWJOb3RpZmljYXRpb24q KTsKKwogcHJpdmF0ZToKICAgICB2b2lkIGRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWVJbklz b2xhdGVkV29ybGQoSVdlYkZyYW1lKiwgSVdlYlNjcmlwdFdvcmxkKik7CiAgICAgdm9pZCBkaWRD bGVhcldpbmRvd09iamVjdEZvckZyYW1lSW5TdGFuZGFyZFdvcmxkKElXZWJGcmFtZSopOwogCiAg ICAgdm9pZCBsb2NhdGlvbkNoYW5nZURvbmUoSVdlYkVycm9yKiwgSVdlYkZyYW1lKik7CisgICAg dm9pZCB3ZWJWaWV3UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlvbigpOwogCiAgICAgVUxPTkcg bV9yZWZDb3VudDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8R0NDb250cm9sbGVyPiBtX2djQ29udHJv bGxlcjsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTM1MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTA4ICBIeXVuZ3dvb2sg TGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEltcGxlbWVudCBk dW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkgZm9yIFdpbiBsYXlvdXRUZXN0Q29udHJvbGxl ci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Nzcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wNi0wOCAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1YnBpeGVsIHJlbmRlcmluZzogQ2xpcC1wYXRo IGRvZXMgbm90IHdvcmsgcHJvcGVybHkgb24gc3VicGl4ZWwgcG9zaXRpb25zLgpJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE4NTMxNCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNv cHkpCkBAIC00NTMsOSArNDUzLDYgQEAgZmFzdC9jc3MvZHJhZ2dhYmxlLXJlZ2lvbi1wYXJzZXIu aHRtbCBbCiAjIEZvbnQgZmVhdHVyZSBzZXR0aW5ncyBpcyBub3QgaW1wbGVtZW50ZWQuCiBjc3Mz L2ZvbnQtZmVhdHVyZS1zZXR0aW5ncy1yZW5kZXJpbmcuaHRtbCBbIFNraXAgXQogCi0jIFRPRE8g SW1wbGVtZW50IGR1bXBQcm9ncmVzc0ZpbmlzaGVkQ2FsbGJhY2sKLXdlYmtpdC5vcmcvYi82Njc3 MyBodHRwL3Rlc3RzL2xvYWRpbmcvcHJvZ3Jlc3MtZmluaXNoZWQtY2FsbGJhY2suaHRtbAotCiAj IFRPRE8gSGlEUEkgdGVzdHMgcmVxdWlyZSB0ZXN0IGluZnJhc3RydWN0dXJlIGVuaGFuY2VtZW50 cyAoZS5nLiB0ZXN0UnVubmVyLnNldEJhY2tpbmdTY2FsZUZhY3RvcikKICMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTE5CiB3ZWJraXQub3JnL2IvODc5MTkgY29t cG9zaXRpbmcvdGlsZWQtbGF5ZXJzLWhpZHBpLmh0bWwK