66753 2011-08-23 03:36:49 -0700 Web Inspector: [Chromium] Fix handling of aggregate names in profiler 2011-08-23 05:21:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 455286 0 mnaganov 2011-08-23 03:36:49 -0700 Currently in _buildAggregates we check for existing aggregate names using the "in" operator, and it looks up in the prototype chain, so e.g. "'toString' in {} === true". That is, having an aggregate named "toString" will cause a problem. 455287 1 104808 mnaganov 2011-08-23 03:38:49 -0700 Created attachment 104808 Patch 455330 2 mnaganov 2011-08-23 05:21:40 -0700 Manually committed http://trac.webkit.org/changeset/93591 Web Inspector: [Chromium] Fix handling of aggregate names in profiler. https://bugs.webkit.org/show_bug.cgi?id=66753 Reviewed by Pavel Feldman. * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype._buildAggregates): 104808 2011-08-23 03:38:49 -0700 2011-08-23 05:02:09 -0700 Patch patch-66753 text/plain 1753 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNjllY2E4Li5jMDYwZjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDgtMjMgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIEZpeCBoYW5kbGluZyBvZiBhZ2dy ZWdhdGUgbmFtZXMgaW4gcHJvZmlsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02Njc1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZS5fYnVpbGRBZ2dyZWdh dGVzKToKKwogMjAxMS0wOC0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJlbW92ZSBXZWJDb3JlL3BsYXRmb3JtL2FuZHJvaWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKaW5kZXggNTIyMWM3MS4u NmNiMjMzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9I ZWFwU25hcHNob3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9I ZWFwU25hcHNob3QuanMKQEAgLTgzMiwxMSArODMyLDExIEBAIFdlYkluc3BlY3Rvci5IZWFwU25h cHNob3QucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9hZ2dyZWdhdGVzID0ge307CiAgICAg ICAgIGZvciAodmFyIGl0ZXIgPSB0aGlzLl9hbGxOb2RlczsgaXRlci5oYXNOZXh0KCk7IGl0ZXIu bmV4dCgpKSB7CiAgICAgICAgICAgICB2YXIgbm9kZSA9IGl0ZXIubm9kZTsKLSAgICAgICAgICAg IHZhciBjbGFzc05hbWUgPSBub2RlLmNsYXNzTmFtZTsKLSAgICAgICAgICAgIHZhciBuYW1lTWF0 dGVycyA9IG5vZGUudHlwZSA9PT0gIm9iamVjdCIgfHwgbm9kZS50eXBlID09PSAibmF0aXZlIjsK ICAgICAgICAgICAgIGlmIChub2RlLnR5cGUgIT09ICJuYXRpdmUiICYmIG5vZGUuc2VsZlNpemUg PT09IDApCiAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICBpZiAoIShjbGFz c05hbWUgaW4gdGhpcy5fYWdncmVnYXRlcykpCisgICAgICAgICAgICB2YXIgbmFtZU1hdHRlcnMg PSBub2RlLnR5cGUgPT09ICJvYmplY3QiIHx8IG5vZGUudHlwZSA9PT0gIm5hdGl2ZSI7CisgICAg ICAgICAgICB2YXIgY2xhc3NOYW1lID0gbm9kZS5jbGFzc05hbWU7CisgICAgICAgICAgICBpZiAo IXRoaXMuX2FnZ3JlZ2F0ZXMuaGFzT3duUHJvcGVydHkoY2xhc3NOYW1lKSkKICAgICAgICAgICAg ICAgICB0aGlzLl9hZ2dyZWdhdGVzW2NsYXNzTmFtZV0gPSB7IGNvdW50OiAwLCBzZWxmOiAwLCBt YXhSZXQ6IDAsIHR5cGU6IG5vZGUudHlwZSwgbmFtZTogbmFtZU1hdHRlcnMgPyBub2RlLm5hbWUg OiBudWxsLCBpZHhzOiBbXSB9OwogICAgICAgICAgICAgdmFyIGNsc3MgPSB0aGlzLl9hZ2dyZWdh dGVzW2NsYXNzTmFtZV07CiAgICAgICAgICAgICArK2Nsc3MuY291bnQ7Cg==