66746 2011-08-22 23:12:11 -0700 Expose setFullscreen method on WebPluginContainer 2011-08-24 11:09:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jeremya webkit-unassigned dglazkov eric fishd webkit.review.bot oldest_to_newest 455203 0 jeremya 2011-08-22 23:12:11 -0700 Expose setFullscreen method on WebPluginContainer 455204 1 104791 jeremya 2011-08-22 23:14:05 -0700 Created attachment 104791 Patch 455207 2 104791 webkit.review.bot 2011-08-22 23:18:48 -0700 Comment on attachment 104791 Patch Attachment 104791 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9482076 455215 3 104792 jeremya 2011-08-22 23:41:51 -0700 Created attachment 104792 Patch 455564 4 eric 2011-08-23 11:57:57 -0700 API changes sound like a fishd review. 455576 5 104792 eric 2011-08-23 12:06:19 -0700 Comment on attachment 104792 Patch I thought the new fullscreen goodness allowed you to make any element fullscreen? 455744 6 jeremya 2011-08-23 15:25:17 -0700 (In reply to comment #5) > (From update of attachment 104792 [details]) > I thought the new fullscreen goodness allowed you to make any element fullscreen? They do. The reason I put the code in WebPluginContainer instead of WebElement is that WebPluginContainer has a direct reference to a WebCore::HTMLPlugInElement, and it seemed silly to wrap it in WebElement only to unwrap it and call a method on it immediately afterwards. I think if I moved the function to WebElement, I would mirror the WebKit API, and have: webelement->requestFullScreen(flags); and webelement->document()->cancelFullScreen(); which would necessitate adding 3 methods: - void WebElement::requestFullScreen(flags) - WebDocument WebElement::document() - void WebDocument::cancelFullScreen() If that seems cleaner/better to someone with a clearer understanding of the WebFoo wrapper APIs than me, I'm happy to reimplement it that way :) 455801 7 104792 fishd 2011-08-23 16:24:38 -0700 Comment on attachment 104792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104792&action=review > Source/WebKit/chromium/public/WebPluginContainer.h:93 > + virtual void setFullscreen(bool) = 0; Since this is implemented as webkitRequestFullScreen, it could fail. In other words, this method should probably have a name indicative of the fact that this could fail. Another idea here, is that we could just expose a requestFullScreen function on WebElement. WebPluginContainer provides a way to get the WebElement containing the plugin. We could also add a cancelFullScreen method on WebElement. This might be the better way to expose this functionality to the embedder of WebKit. 455804 8 fishd 2011-08-23 16:27:00 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 104792 [details] [details]) > > I thought the new fullscreen goodness allowed you to make any element fullscreen? > > They do. The reason I put the code in WebPluginContainer instead of WebElement is that WebPluginContainer has a direct reference to a WebCore::HTMLPlugInElement, and it seemed silly to wrap it in WebElement only to unwrap it and call a method on it immediately afterwards. > > I think if I moved the function to WebElement, I would mirror the WebKit API, and have: > > webelement->requestFullScreen(flags); > > and > > webelement->document()->cancelFullScreen(); > > which would necessitate adding 3 methods: > - void WebElement::requestFullScreen(flags) > - WebDocument WebElement::document() > - void WebDocument::cancelFullScreen() > > > If that seems cleaner/better to someone with a clearer understanding of the WebFoo wrapper APIs than me, I'm happy to reimplement it that way :) Heh, sorry... I only looked at the patch before commenting. I think it is better to add the more generic APIs. We've found that to be the better way in the past. I have to note though that if this is for Pepper, we may have a bit of an issue to worry about. Assuming we want to require a user gesture before accepting a request to make an element fullscreen, we might have trouble here. You see with pepper, events are dispatched asynchronously. This means that when the plugin sees the event, webkit has already cleared its user gesture flag. 455906 9 104953 jeremya 2011-08-23 18:19:10 -0700 Created attachment 104953 Patch 455909 10 jeremya 2011-08-23 18:20:51 -0700 (In reply to comment #7) > (From update of attachment 104792 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104792&action=review > > > Source/WebKit/chromium/public/WebPluginContainer.h:93 > > + virtual void setFullscreen(bool) = 0; > > Since this is implemented as webkitRequestFullScreen, it could fail. In other > words, this method should probably have a name indicative of the fact that this > could fail. > > Another idea here, is that we could just expose a requestFullScreen function on > WebElement. WebPluginContainer provides a way to get the WebElement containing > the plugin. We could also add a cancelFullScreen method on WebElement. This > might be the better way to expose this functionality to the embedder of WebKit. I've rearranged this to reflect the arrangement of the underlying WebKit implementation. 456215 11 104953 webkit.review.bot 2011-08-24 11:09:21 -0700 Comment on attachment 104953 Patch Clearing flags on attachment: 104953 Committed r93714: <http://trac.webkit.org/changeset/93714> 456216 12 webkit.review.bot 2011-08-24 11:09:26 -0700 All reviewed patches have been landed. Closing bug. 104791 2011-08-22 23:14:05 -0700 2011-08-22 23:41:41 -0700 Patch bug-66746-20110823161403.patch text/plain 3169 jeremya U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDU5Y2JkOGYxMjY3Y2VhZWRiNGVhOTljODZhMTA0MDgzNTBhZGQ3OC4uY2MxMDBmMzY5N2FiMThi MThhNTFmMWI4NjI0NzlmZGFjZGViZjUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0yMiAgSmVyZW15IEFwdGhvcnAgIDxqZXJlbXlhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRXhwb3NlIHNldEZ1bGxzY3JlZW4gbWV0aG9kIG9uIFdlYlBsdWdp bkNvbnRhaW5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjY3NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2lu Q29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lcklt cGw6OnNldEZ1bGxzY3JlZW4pOgorICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBs Lmg6CisKIDIwMTEtMDgtMTkgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRXh0ZW5zaW9ucyBBUEldW2Nocm9taXVtXSB3ZWJJ bnNwZWN0b3IucmVzb3VyY2VzIGRlcHJlY2F0aW9uIHdhcm5pbmcgaXMgZ2l2ZW4gZXZlbiBmb3Ig ZXh0ZW5zaW9ucyB0aGF0IGRvbid0IHVzZSB3ZWJJbnNwZWN0b3IucmVzb3VyY2VzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCmluZGV4 IDAyNjAyOGJjOWYyMzg2OWRkZWJiMDlmZjVmMDgyZjhmNWUxZTUwNGUuLjdiOGZlMzM2MTA2OTMx ZjVlODdkYTFhMjkwZDI1MzZjODNmNDUyYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCkBAIC04OSw2ICs4OSw5IEBAIHB1Ymxp YzoKICAgICAvLyBOb3RpZmllcyB0aGF0IHRoZSB6b29tIGxldmVsIGhhcyBjaGFuZ2VkLgogICAg IHZpcnR1YWwgdm9pZCB6b29tTGV2ZWxDaGFuZ2VkKGRvdWJsZSB6b29tTGV2ZWwpID0gMDsKIAor ICAgIC8vIFRyYW5zaXRpb24gdG8gb3IgZnJvbSBmdWxsc2NyZWVuIGZvciB0aGlzIHBsdWdpbi4K KyAgICB2aXJ0dWFsIHZvaWQgc2V0RnVsbHNjcmVlbihib29sKSA9IDA7CisKICAgICB2aXJ0dWFs IFdlYlBsdWdpbiogcGx1Z2luKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRQbHVnaW4oV2Vi UGx1Z2luKikgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDZjMzE5NzUyOWZiNzcyNzY0NTljMDA1OWZk MGJmZGRhYmJjM2VhOWUuLjJiYjhhZTUxNjI3ZWQ5ZjM5ZWUzYWM5MTQ0MzAyYjY2ZTMyNmM2YTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRh aW5lckltcGwuY3BwCkBAIC00MDYsNiArNDA2LDE0IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVy SW1wbDo6em9vbUxldmVsQ2hhbmdlZChkb3VibGUgem9vbUxldmVsKQogICAgIHZpZXctPmZ1bGxG cmFtZVBsdWdpblpvb21MZXZlbENoYW5nZWQoem9vbUxldmVsKTsKIH0KIAordm9pZCBXZWJQbHVn aW5Db250YWluZXJJbXBsOjpzZXRGdWxsc2NyZWVuKGJvb2wgZnVsbHNjcmVlbikKK3sKKyAgICBp ZiAoZnVsbHNjcmVlbikKKyAgICAgICAgbV9lbGVtZW50LT53ZWJraXRSZXF1ZXN0RnVsbFNjcmVl bihFbGVtZW50OjpBTExPV19LRVlCT0FSRF9JTlBVVCk7CisgICAgZWxzZQorICAgICAgICBtX2Vs ZW1lbnQtPmRvY3VtZW50KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKK30KKwogdm9pZCBX ZWJQbHVnaW5Db250YWluZXJJbXBsOjpkaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VS ZXNwb25zZSYgcmVzcG9uc2UpCiB7CiAgICAgLy8gTWFrZSBzdXJlIHRoYXQgdGhlIHBsdWdpbiBy ZWNlaXZlcyB3aW5kb3cgZ2VvbWV0cnkgYmVmb3JlIGRhdGEsIG9yIGVsc2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAppbmRleCA3 NGU0OTI3NWUyMmQ5MjRmZWYzMDE5Nzk0YTJkM2NiMjgwODU5MGU2Li5hY2NkNmM3NjJhNTRhZmFi MTcwMzUyMDMyODMwYTMwMWMxNjEzYjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oCkBAIC05Myw2ICs5Myw3IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBleGVjdXRlU2NyaXB0VVJMKGNvbnN0IFdlYlVSTCYs IGJvb2wgcG9wdXBzQWxsb3dlZCk7CiAgICAgdmlydHVhbCB2b2lkIGxvYWRGcmFtZVJlcXVlc3Qo Y29uc3QgV2ViVVJMUmVxdWVzdCYsIGNvbnN0IFdlYlN0cmluZyYgdGFyZ2V0LCBib29sIG5vdGlm eU5lZWRlZCwgdm9pZCogbm90aWZ5RGF0YSk7CiAgICAgdmlydHVhbCB2b2lkIHpvb21MZXZlbENo YW5nZWQoZG91YmxlIHpvb21MZXZlbCk7ICAgIAorICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxsc2Ny ZWVuKGJvb2wpOwogCiAgICAgLy8gVGhpcyBjYW5ub3QgYmUgbnVsbC4KICAgICBXZWJQbHVnaW4q IHBsdWdpbigpIHsgcmV0dXJuIG1fd2ViUGx1Z2luOyB9Cg== 104792 2011-08-22 23:41:51 -0700 2011-08-23 18:18:59 -0700 Patch bug-66746-20110823164149.patch text/plain 3205 jeremya U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDU5Y2JkOGYxMjY3Y2VhZWRiNGVhOTljODZhMTA0MDgzNTBhZGQ3OC4uY2MxMDBmMzY5N2FiMThi MThhNTFmMWI4NjI0NzlmZGFjZGViZjUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0yMiAgSmVyZW15IEFwdGhvcnAgIDxqZXJlbXlhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRXhwb3NlIHNldEZ1bGxzY3JlZW4gbWV0aG9kIG9uIFdlYlBsdWdp bkNvbnRhaW5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjY3NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaDoKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2lu Q29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lcklt cGw6OnNldEZ1bGxzY3JlZW4pOgorICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBs Lmg6CisKIDIwMTEtMDgtMTkgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRXh0ZW5zaW9ucyBBUEldW2Nocm9taXVtXSB3ZWJJ bnNwZWN0b3IucmVzb3VyY2VzIGRlcHJlY2F0aW9uIHdhcm5pbmcgaXMgZ2l2ZW4gZXZlbiBmb3Ig ZXh0ZW5zaW9ucyB0aGF0IGRvbid0IHVzZSB3ZWJJbnNwZWN0b3IucmVzb3VyY2VzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCmluZGV4 IDAyNjAyOGJjOWYyMzg2OWRkZWJiMDlmZjVmMDgyZjhmNWUxZTUwNGUuLjdiOGZlMzM2MTA2OTMx ZjVlODdkYTFhMjkwZDI1MzZjODNmNDUyYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5lci5oCkBAIC04OSw2ICs4OSw5IEBAIHB1Ymxp YzoKICAgICAvLyBOb3RpZmllcyB0aGF0IHRoZSB6b29tIGxldmVsIGhhcyBjaGFuZ2VkLgogICAg IHZpcnR1YWwgdm9pZCB6b29tTGV2ZWxDaGFuZ2VkKGRvdWJsZSB6b29tTGV2ZWwpID0gMDsKIAor ICAgIC8vIFRyYW5zaXRpb24gdG8gb3IgZnJvbSBmdWxsc2NyZWVuIGZvciB0aGlzIHBsdWdpbi4K KyAgICB2aXJ0dWFsIHZvaWQgc2V0RnVsbHNjcmVlbihib29sKSA9IDA7CisKICAgICB2aXJ0dWFs IFdlYlBsdWdpbiogcGx1Z2luKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRQbHVnaW4oV2Vi UGx1Z2luKikgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDZjMzE5NzUyOWZiNzcyNzY0NTljMDA1OWZk MGJmZGRhYmJjM2VhOWUuLmE4ZWQwNDQ1NDNlOTBlNDE0MTZmYzMwMWM2YTliMTQwYTM5ZjViZjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRh aW5lckltcGwuY3BwCkBAIC00MDYsNiArNDA2LDE2IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVy SW1wbDo6em9vbUxldmVsQ2hhbmdlZChkb3VibGUgem9vbUxldmVsKQogICAgIHZpZXctPmZ1bGxG cmFtZVBsdWdpblpvb21MZXZlbENoYW5nZWQoem9vbUxldmVsKTsKIH0KIAordm9pZCBXZWJQbHVn aW5Db250YWluZXJJbXBsOjpzZXRGdWxsc2NyZWVuKGJvb2wgZnVsbHNjcmVlbikKK3sKKyNpZiBF TkFCTEUoRlVMTFNDUkVFTl9BUEkpCisgICAgaWYgKGZ1bGxzY3JlZW4pCisgICAgICAgIG1fZWxl bWVudC0+d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oRWxlbWVudDo6QUxMT1dfS0VZQk9BUkRfSU5Q VVQpOworICAgIGVsc2UKKyAgICAgICAgbV9lbGVtZW50LT5kb2N1bWVudCgpLT53ZWJraXRDYW5j ZWxGdWxsU2NyZWVuKCk7CisjZW5kaWYKK30KKwogdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBs OjpkaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7 CiAgICAgLy8gTWFrZSBzdXJlIHRoYXQgdGhlIHBsdWdpbiByZWNlaXZlcyB3aW5kb3cgZ2VvbWV0 cnkgYmVmb3JlIGRhdGEsIG9yIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAppbmRleCA3NGU0OTI3NWUyMmQ5MjRmZWYzMDE5 Nzk0YTJkM2NiMjgwODU5MGU2Li5hY2NkNmM3NjJhNTRhZmFiMTcwMzUyMDMyODMwYTMwMWMxNjEz YjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250 YWluZXJJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29u dGFpbmVySW1wbC5oCkBAIC05Myw2ICs5Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYlN0 cmluZyBleGVjdXRlU2NyaXB0VVJMKGNvbnN0IFdlYlVSTCYsIGJvb2wgcG9wdXBzQWxsb3dlZCk7 CiAgICAgdmlydHVhbCB2b2lkIGxvYWRGcmFtZVJlcXVlc3QoY29uc3QgV2ViVVJMUmVxdWVzdCYs IGNvbnN0IFdlYlN0cmluZyYgdGFyZ2V0LCBib29sIG5vdGlmeU5lZWRlZCwgdm9pZCogbm90aWZ5 RGF0YSk7CiAgICAgdmlydHVhbCB2b2lkIHpvb21MZXZlbENoYW5nZWQoZG91YmxlIHpvb21MZXZl bCk7ICAgIAorICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxsc2NyZWVuKGJvb2wpOwogCiAgICAgLy8g VGhpcyBjYW5ub3QgYmUgbnVsbC4KICAgICBXZWJQbHVnaW4qIHBsdWdpbigpIHsgcmV0dXJuIG1f d2ViUGx1Z2luOyB9Cg== 104953 2011-08-23 18:19:10 -0700 2011-08-24 11:09:21 -0700 Patch bug-66746-20110824111908.patch text/plain 4005 jeremya U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDU5Y2JkOGYxMjY3Y2VhZWRiNGVhOTljODZhMTA0MDgzNTBhZGQ3OC4uMDZkNTQwZjM4NDg5MmZh NzgzNGQyYmM4MWJlOTA2MjY3MjBjNTk0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0yMiAgSmVyZW15IEFwdGhvcnAgIDxqZXJlbXlhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRXhwb3NlIGZ1bGxzY3JlZW4gQVBJIG9uIFdlYkVsZW1lbnQvV2Vi RG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2NzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwdWJsaWMvV2ViUGx1Z2luQ29udGFpbmVyLmg6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNv bnRhaW5lckltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBs OjpzZXRGdWxsc2NyZWVuKToKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5o OgorCiAyMDExLTA4LTE5ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogW0V4dGVuc2lvbnMgQVBJXVtjaHJvbWl1bV0gd2ViSW5z cGVjdG9yLnJlc291cmNlcyBkZXByZWNhdGlvbiB3YXJuaW5nIGlzIGdpdmVuIGV2ZW4gZm9yIGV4 dGVuc2lvbnMgdGhhdCBkb24ndCB1c2Ugd2ViSW5zcGVjdG9yLnJlc291cmNlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKaW5kZXggNGM5ZGQzMDRmYTQ4ZGI0 ZmU3MDFmNzM5OTBkMWU3ZmE1ZTJhZmJiYi4uMGMxNDkzOWY4YmIyMTkzNDQ5MjAzODkwZGIxNTgx NjQ1YTAwZWM3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi RG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVu dC5oCkBAIC05OSw2ICs5OSw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JUIFdlYk5vZGUg Zm9jdXNlZE5vZGUoKSBjb25zdDsKICAgICBXRUJLSVRfRVhQT1JUIFdlYkRvY3VtZW50VHlwZSBk b2N0eXBlKCkgY29uc3Q7CiAgICAgV0VCS0lUX0VYUE9SVCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0 IGFjY2Vzc2liaWxpdHlPYmplY3QoKSBjb25zdDsKKyAgICBXRUJLSVRfRVhQT1JUIHZvaWQgY2Fu Y2VsRnVsbFNjcmVlbigpOwogCiAgICAgLy8gSW5zZXJ0cyB0aGUgZ2l2ZW4gQ1NTIHNvdXJjZSBj b2RlIGFzIGEgdXNlciBzdHlsZXNoZWV0IGluIHRoZSBkb2N1bWVudC4KICAgICAvLyBNZWFudCBm b3IgcHJvZ3JhbWF0aWMvb25lLW9mZiBpbmplY3Rpb24sIGFzIG9wcG9zZWQgdG8KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkVsZW1lbnQuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkVsZW1lbnQuaAppbmRleCAzMjBjNzMyZjUwZGM4ODkx NWVjNGJmZWNhYjRhMDRlYThmYzQxYWE4Li45MjNjMTgyYzJlOGVmOTE3NDAwNGZhOTQ3YTU2ZjE2 YTM0ZjAwZmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJF bGVtZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRWxlbWVudC5o CkBAIC01OCw2ICs1OCw4IEBAIGNsYXNzIFdlYk5hbWVkTm9kZU1hcDsKICAgICAgICAgV0VCS0lU X0VYUE9SVCBib29sIHNldEF0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdl YlN0cmluZyYgdmFsdWUpOwogICAgICAgICBXRUJLSVRfRVhQT1JUIFdlYk5hbWVkTm9kZU1hcCBh dHRyaWJ1dGVzKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGlubmVy VGV4dCgpOworICAgICAgICBXRUJLSVRfRVhQT1JUIFdlYkRvY3VtZW50IGRvY3VtZW50KCkgY29u c3Q7CisgICAgICAgIFdFQktJVF9FWFBPUlQgdm9pZCByZXF1ZXN0RnVsbFNjcmVlbigpOwogCiAg ICAgICAgIC8vIFJldHVybnMgdGhlIGxhbmd1YWdlIGNvZGUgc3BlY2lmaWVkIGZvciB0aGlzIGVs ZW1lbnQuICBUaGlzIGF0dHJpYnV0ZQogICAgICAgICAvLyBpcyBpbmhlcml0ZWQsIHNvIHRoZSBy ZXR1cm5lZCB2YWx1ZSBpcyBkcmF3biBmcm9tIHRoZSBjbG9zZXN0IHBhcmVudApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCmluZGV4IGRhNDczMGJmYzc2MGRmMjQ5 MTlkNWQ2MmZiMmZlZjNjNzIyZThkZjguLmFiMDU4YTYwNDM0NDVhZmNhYTlkOTkxODg5ZDExZjQy MGExYTViYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRvY3Vt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHAK QEAgLTE4OSw2ICsxODksMTMgQEAgdm9pZCBXZWJEb2N1bWVudDo6aW5zZXJ0VXNlclN0eWxlU2hl ZXQoY29uc3QgV2ViU3RyaW5nJiBzb3VyY2VDb2RlLCBVc2VyU3R5bGVMZXYKICAgICBkb2N1bWVu dC0+YWRkVXNlclNoZWV0KHBhcnNlZFNoZWV0LnJlbGVhc2UoKSk7CiB9CiAKK3ZvaWQgV2ViRG9j dW1lbnQ6OmNhbmNlbEZ1bGxTY3JlZW4oKQoreworI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK KyAgICB1bndyYXA8RG9jdW1lbnQ+KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyNlbmRp ZgorfQorCiBXZWJEb2N1bWVudDo6V2ViRG9jdW1lbnQoY29uc3QgUGFzc1JlZlB0cjxEb2N1bWVu dD4mIGVsZW0pCiAgICAgOiBXZWJOb2RlKGVsZW0pCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYkVsZW1lbnQuY3BwCmluZGV4IDI3YzBiMWYyYTI2YzU4ZGRkNDI0MzcyOGFjNTVhNDU3 OWQyY2JiMzkuLmI2NTA5MDBkYTBmNDJiMzY0YjkxNjRjYjdmODk5ZjVkOGQ1MjZhNTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkVsZW1lbnQuY3BwCkBAIC0zMCw2ICszMCw3IEBA CiAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJFbGVtZW50LmgiCisjaW5jbHVk ZSAiV2ViRG9jdW1lbnQuaCIKIAogI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRlICJSZW5k ZXJCb3hNb2RlbE9iamVjdC5oIgpAQCAtOTUsNiArOTYsMTggQEAgV2ViU3RyaW5nIFdlYkVsZW1l bnQ6OmNvbXB1dGVJbmhlcml0ZWRMYW5ndWFnZSgpIGNvbnN0CiAgICAgcmV0dXJuIFdlYlN0cmlu Zyhjb25zdFVud3JhcDxFbGVtZW50PigpLT5jb21wdXRlSW5oZXJpdGVkTGFuZ3VhZ2UoKSk7CiB9 CiAKK3ZvaWQgV2ViRWxlbWVudDo6cmVxdWVzdEZ1bGxTY3JlZW4oKQoreworI2lmIEVOQUJMRShG VUxMU0NSRUVOX0FQSSkKKyAgICB1bndyYXA8RWxlbWVudD4oKS0+d2Via2l0UmVxdWVzdEZ1bGxT Y3JlZW4oRWxlbWVudDo6QUxMT1dfS0VZQk9BUkRfSU5QVVQpOworI2VuZGlmCit9CisKK1dlYkRv Y3VtZW50IFdlYkVsZW1lbnQ6OmRvY3VtZW50KCkgY29uc3QKK3sKKyAgICByZXR1cm4gV2ViRG9j dW1lbnQoY29uc3RVbndyYXA8RWxlbWVudD4oKS0+ZG9jdW1lbnQoKSk7Cit9CisKIFdlYkVsZW1l bnQ6OldlYkVsZW1lbnQoY29uc3QgUGFzc1JlZlB0cjxFbGVtZW50PiYgZWxlbSkKICAgICA6IFdl Yk5vZGUoZWxlbSkKIHsK