<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66742</bug_id>
          
          <creation_ts>2011-08-22 18:07:45 -0700</creation_ts>
          <short_desc>Write regression test for WebGL rate limiting</short_desc>
          <delta_ts>2024-01-17 01:23:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="John Bates">jbates</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>darin</cc>
    
    <cc>kbr</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>nduca</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>455126</commentid>
    <comment_count>0</comment_count>
    <who name="John Bates">jbates</who>
    <bug_when>2011-08-22 18:07:45 -0700</bug_when>
    <thetext>Write regression test for bug fix: https://bugs.webkit.org/show_bug.cgi?id=66445.

This would test whether the WebGL rate limiting is properly executing. We would want to test both RAF and non-RAF use cases. In non-RAF cases, test that rate limiting kicks in only when it is supposed to.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>455143</commentid>
    <comment_count>1</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2011-08-22 18:46:37 -0700</bug_when>
    <thetext>I&apos;ve changed the component to WebGL so that it shows up easily on searches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>459815</commentid>
    <comment_count>2</comment_count>
    <who name="Nat Duca">nduca</who>
    <bug_when>2011-08-31 12:06:48 -0700</bug_when>
    <thetext>There really are two things to veirfy here: that WebGLLayerChromium behaves correctly when dirtied outside of RAF, and that WebGLGraphicsContexts call setLayerUpdated.

At least for the latter case, mock testing might be a more appropriate vehicle for testing.

Mock could be: instantiate a compositor tree with a WebGLLayerChromium. Fire commands onto the webglcontext outside of the render task and assert that the ratelimiting task gets called on that context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>481893</commentid>
    <comment_count>3</comment_count>
    <who name="Nat Duca">nduca</who>
    <bug_when>2011-10-11 14:02:44 -0700</bug_when>
    <thetext>Might be good use case of frame rate tests on chromium-side.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>