66732 2011-08-22 16:56:11 -0700 [Qt] RenderThemeQt::adjustSliderThumbSize() doesn't differentiate vertical case 2011-08-23 15:58:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 50453 0 tanya.meshkova webkit-unassigned benjamin webkit.review.bot oldest_to_newest 455066 0 tanya.meshkova 2011-08-22 16:56:11 -0700 We should swap length and thickness for vertical orientation. This bug blocks bug #50453 455069 1 tanya.meshkova 2011-08-22 16:58:33 -0700 thumbslider-no-parent-slider.html expectations are wrong also. There should be: RenderBody {BODY} at (8,8) size 784x584 RenderBlock {SPAN} at (0,0) size 11x16 RenderBR {BR} at (11,16) size 0x0 - RenderBlock {SPAN} at (0,16) size 11x16 + RenderBlock {SPAN} at (0,16) size 16x11 RenderText {#text} at (0,0) size 0x0 455105 2 104776 tanya.meshkova 2011-08-22 17:40:35 -0700 Created attachment 104776 Patch 455540 3 104776 webkit.review.bot 2011-08-23 11:29:04 -0700 Comment on attachment 104776 Patch Rejecting attachment 104776 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: g file LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt Hunk #1 FAILED at 5. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/qt/RenderThemeQt.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1 Full output: http://queues.webkit.org/results/9480440 455574 4 104882 tanya.meshkova 2011-08-23 12:05:14 -0700 Created attachment 104882 Patch 455577 5 104882 tanya.meshkova 2011-08-23 12:06:52 -0700 Comment on attachment 104882 Patch rebased 455713 6 104882 kenneth 2011-08-23 14:26:16 -0700 Comment on attachment 104882 Patch When it was already reviewed, no need to set the r? flag 455761 7 104882 webkit.review.bot 2011-08-23 15:58:02 -0700 Comment on attachment 104882 Patch Clearing flags on attachment: 104882 Committed r93644: <http://trac.webkit.org/changeset/93644> 455762 8 webkit.review.bot 2011-08-23 15:58:06 -0700 All reviewed patches have been landed. Closing bug. 104776 2011-08-22 17:40:35 -0700 2011-08-23 12:04:59 -0700 Patch bug-66732-20110822173655.patch text/plain 3346 tanya.meshkova U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1NTgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwMzc1MTQwOTFkZDcwOGJhYzBjNDg0 ZGY1ZTNhMDJlMzg1NjM0ZTA2Li5iNWY2MmRkNGQyMDExMGViYjEwZWMyYWRhNjIzNTMzNGVmY2U2 ZjVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMjIgIFRhdGlhbmEgTWVzaGtvdmEg IDx0YXRpYW5hLm1lc2hrb3ZhQG5va2lhLmNvbT4KKworICAgICAgICBTd2FwIHdpZHRoIGFuZCBo ZWlnaHQgZm9yIHNsaWRlcnRodW1iLXZlcnRpY2FsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZm9ybXMvdGh1bWJzbGlk ZXItbm8tcGFyZW50LXNsaWRlci1leHBlY3RlZC50eHQ6CisKIDIwMTEtMDgtMjIgIFBldGVyIEth c3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI5MzUzOC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3Qv Zm9ybXMvdGh1bWJzbGlkZXItbm8tcGFyZW50LXNsaWRlci1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Zvcm1zL3RodW1ic2xpZGVyLW5vLXBhcmVudC1zbGlkZXIt ZXhwZWN0ZWQudHh0CmluZGV4IDY1YmFlNmY1MTViZjE3NGNkNThlOTRmYzU1ZGQzMjcyOTc0YjBi ZGEuLjQwYWZlZjI5ODAxNWJhYmQ0NDkxOGVlOGY4NzUyMGJkZTdiYTcwNDQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZm9ybXMvdGh1bWJzbGlkZXItbm8tcGFyZW50 LXNsaWRlci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9m b3Jtcy90aHVtYnNsaWRlci1uby1wYXJlbnQtc2xpZGVyLWV4cGVjdGVkLnR4dApAQCAtNSw1ICs1 LDUgQEAgbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAgICAgUmVuZGVyQm9keSB7Qk9EWX0g YXQgKDgsOCkgc2l6ZSA3ODR4NTg0CiAgICAgICBSZW5kZXJCbG9jayB7U1BBTn0gYXQgKDAsMCkg c2l6ZSAxMXgxNgogICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMTEsMTYpIHNpemUgMHgwCi0gICAg ICBSZW5kZXJCbG9jayB7U1BBTn0gYXQgKDAsMTYpIHNpemUgMTF4MTYKKyAgICAgIFJlbmRlckJs b2NrIHtTUEFOfSBhdCAoMCwxNikgc2l6ZSAxNngxMQogICAgICAgUmVuZGVyVGV4dCB7I3RleHR9 IGF0ICgwLDApIHNpemUgMHgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU1NWY3MGU4NmMzYmYxOGZjMjUwMGYz NTc3MDY5OWYxMTI1NTYzMS4uNDZjZGZiYmJkNDE0NGQ4ZWNlYmE4ZWY4MDkyODFlNTI4Y2MzOTVl YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA4LTIyICBUYXRpYW5hIE1lc2hr b3ZhICA8dGF0aWFuYS5tZXNoa292YUBub2tpYS5jb20+CisKKyAgICAgICAgUHJlcGFyZSB0byBw YWludCBzbGlkZXIgdGh1bWIgc2VwYXJhdGVseS4KKyAgICAgICAgUHJvdmlkZSBwcm9wZXIgc2l6 ZSB2YWx1ZXMgZm9yIHZlcnRpY2FsIFNsaWRlclRodW1iLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVRdDo6YWRqdXN0U2xpZGVyVGh1bWJTaXpl KToKKyAgICAgICAgU3dhcCBsZW5ndGggYW5kIHRoaWNrbmVzcyBmb3Igc2xpZGVydGh1bWItdmVy dGljYWwuCisKIDIwMTEtMDgtMjIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEZpeCB1c2FnZSBvZiBQYXNzUmVmUHRyIGluIHBvc3RNZXNzYWdlIGFuZCBzdHJ1 Y3R1cmVkIGNsb25lIGNvZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9x dC9SZW5kZXJUaGVtZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRo ZW1lUXQuY3BwCmluZGV4IGRhNWYxZDI1YTM0MGQ5ODU1ZmExZmNlNDExZWM5ZmZhNWEwNGEyMjIu LmIyZjBmMTg0MWZkZmYwNmNiYmFiMDc1NTg1NmRkMTA5ODliOGFlZmMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC0xNDkxLDEwICsxNDkxLDE1 IEBAIHZvaWQgUmVuZGVyVGhlbWVRdDo6YWRqdXN0U2xpZGVyVGh1bWJTaXplKFJlbmRlclN0eWxl KiBzdHlsZSkgY29uc3QKIAogICAgICAgICBRU3R5bGUqIHFzdHlsZSA9IHFTdHlsZSgpOwogCi0g ICAgICAgIGludCB3aWR0aCA9IHFzdHlsZS0+cGl4ZWxNZXRyaWMoUVN0eWxlOjpQTV9TbGlkZXJM ZW5ndGgsICZvcHRpb24pOwotICAgICAgICBpbnQgaGVpZ2h0ID0gcXN0eWxlLT5waXhlbE1ldHJp YyhRU3R5bGU6OlBNX1NsaWRlclRoaWNrbmVzcywgJm9wdGlvbik7Ci0gICAgICAgIHN0eWxlLT5z ZXRXaWR0aChMZW5ndGgod2lkdGgsIEZpeGVkKSk7Ci0gICAgICAgIHN0eWxlLT5zZXRIZWlnaHQo TGVuZ3RoKGhlaWdodCwgRml4ZWQpKTsKKyAgICAgICAgaW50IGxlbmd0aCA9IHFzdHlsZS0+cGl4 ZWxNZXRyaWMoUVN0eWxlOjpQTV9TbGlkZXJMZW5ndGgsICZvcHRpb24pOworICAgICAgICBpbnQg dGhpY2tuZXNzID0gcXN0eWxlLT5waXhlbE1ldHJpYyhRU3R5bGU6OlBNX1NsaWRlclRoaWNrbmVz cywgJm9wdGlvbik7CisgICAgICAgIGlmIChvcHRpb24ub3JpZW50YXRpb24gPT0gUXQ6OlZlcnRp Y2FsKSB7CisgICAgICAgICAgICBzdHlsZS0+c2V0V2lkdGgoTGVuZ3RoKHRoaWNrbmVzcywgRml4 ZWQpKTsKKyAgICAgICAgICAgIHN0eWxlLT5zZXRIZWlnaHQoTGVuZ3RoKGxlbmd0aCwgRml4ZWQp KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHN0eWxlLT5zZXRXaWR0aChMZW5ndGgo bGVuZ3RoLCBGaXhlZCkpOworICAgICAgICAgICAgc3R5bGUtPnNldEhlaWdodChMZW5ndGgodGhp Y2tuZXNzLCBGaXhlZCkpOworICAgICAgICB9CiAgICAgfQogfQogCg== 104882 2011-08-23 12:05:14 -0700 2011-08-23 15:58:02 -0700 Patch bug-66732-20110823120131.patch text/plain 3373 tanya.meshkova U3VidmVyc2lvbiBSZXZpc2lvbjogOTM2MTgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNmJkNjQ3MDdmMjNhYmM0ZTc0OTM0 NDFkNWQyMGRiYjkyOWE0MDE4Li5kMWMxODU0ZWVkNTgwMmI3ZDNiNjhjN2VhZmViNTY1ZjA3YWZk NDZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMjMgIFRhdGlhbmEgTWVzaGtvdmEg IDx0YXRpYW5hLm1lc2hrb3ZhQG5va2lhLmNvbT4KKworICAgICAgICBTd2FwIHdpZHRoIGFuZCBo ZWlnaHQgZm9yIHNsaWRlcnRodW1iLXZlcnRpY2FsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZm9y bXMvcmFuZ2UvdGh1bWJzbGlkZXItbm8tcGFyZW50LXNsaWRlci1leHBlY3RlZC50eHQ6CisKIDIw MTEtMDctMjUgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIGRp diBhbGlnbj0iY2VudGVyIiByZW5kZXJpbmcgcHJvYmxlbQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvZmFzdC9mb3Jtcy9yYW5nZS90aHVtYnNsaWRlci1uby1wYXJlbnQtc2xp ZGVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZm9ybXMvcmFu Z2UvdGh1bWJzbGlkZXItbm8tcGFyZW50LXNsaWRlci1leHBlY3RlZC50eHQKaW5kZXggNjViYWU2 ZjUxNWJmMTc0Y2Q1OGU5NGZjNTVkZDMyNzI5NzRiMGJkYS4uNDBhZmVmMjk4MDE1YmFiZDQ0OTE4 ZWU4Zjg3NTIwYmRlN2JhNzA0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv ZmFzdC9mb3Jtcy9yYW5nZS90aHVtYnNsaWRlci1uby1wYXJlbnQtc2xpZGVyLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Zvcm1zL3JhbmdlL3RodW1ic2xp ZGVyLW5vLXBhcmVudC1zbGlkZXItZXhwZWN0ZWQudHh0CkBAIC01LDUgKzUsNSBAQCBsYXllciBh dCAoMCwwKSBzaXplIDgwMHg2MDAKICAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXpl IDc4NHg1ODQKICAgICAgIFJlbmRlckJsb2NrIHtTUEFOfSBhdCAoMCwwKSBzaXplIDExeDE2CiAg ICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgxMSwxNikgc2l6ZSAweDAKLSAgICAgIFJlbmRlckJsb2Nr IHtTUEFOfSBhdCAoMCwxNikgc2l6ZSAxMXgxNgorICAgICAgUmVuZGVyQmxvY2sge1NQQU59IGF0 ICgwLDE2KSBzaXplIDE2eDExCiAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6 ZSAweDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA1ZTNhM2ZiNjgxMjk2N2UwMmM2MDQ1Y2U3OTY4Mzg1ODkwZjRl MjlmLi5hYTdlN2I2NjYwNWJhNjBmYzlhZGRiOGNiZmQ2MGZmMGY0YWIzY2RlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMjMgIFRhdGlhbmEgTWVzaGtvdmEgIDx0YXRpYW5h Lm1lc2hrb3ZhQG5va2lhLmNvbT4KKworICAgICAgICBQcmVwYXJlIHRvIHBhaW50IHNsaWRlciB0 aHVtYiBzZXBhcmF0ZWx5LgorICAgICAgICBQcm92aWRlIHByb3BlciBzaXplIHZhbHVlcyBmb3Ig dmVydGljYWwgU2xpZGVyVGh1bWIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NjczMgorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVF0OjphZGp1c3RTbGlkZXJUaHVtYlNpemUp OgorICAgICAgICBTd2FwIGxlbmd0aCBhbmQgdGhpY2tuZXNzIGZvciBzbGlkZXJ0aHVtYi12ZXJ0 aWNhbC4KKwogMjAxMS0wNy0yNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgZGl2IGFsaWduPSJjZW50ZXIiIHJlbmRlcmluZyBwcm9ibGVtCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCmluZGV4IGRhNWYxZDI1YTM0MGQ5 ODU1ZmExZmNlNDExZWM5ZmZhNWEwNGEyMjIuLmIyZjBmMTg0MWZkZmYwNmNiYmFiMDc1NTg1NmRk MTA5ODliOGFlZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRl clRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1l UXQuY3BwCkBAIC0xNDkxLDEwICsxNDkxLDE1IEBAIHZvaWQgUmVuZGVyVGhlbWVRdDo6YWRqdXN0 U2xpZGVyVGh1bWJTaXplKFJlbmRlclN0eWxlKiBzdHlsZSkgY29uc3QKIAogICAgICAgICBRU3R5 bGUqIHFzdHlsZSA9IHFTdHlsZSgpOwogCi0gICAgICAgIGludCB3aWR0aCA9IHFzdHlsZS0+cGl4 ZWxNZXRyaWMoUVN0eWxlOjpQTV9TbGlkZXJMZW5ndGgsICZvcHRpb24pOwotICAgICAgICBpbnQg aGVpZ2h0ID0gcXN0eWxlLT5waXhlbE1ldHJpYyhRU3R5bGU6OlBNX1NsaWRlclRoaWNrbmVzcywg Jm9wdGlvbik7Ci0gICAgICAgIHN0eWxlLT5zZXRXaWR0aChMZW5ndGgod2lkdGgsIEZpeGVkKSk7 Ci0gICAgICAgIHN0eWxlLT5zZXRIZWlnaHQoTGVuZ3RoKGhlaWdodCwgRml4ZWQpKTsKKyAgICAg ICAgaW50IGxlbmd0aCA9IHFzdHlsZS0+cGl4ZWxNZXRyaWMoUVN0eWxlOjpQTV9TbGlkZXJMZW5n dGgsICZvcHRpb24pOworICAgICAgICBpbnQgdGhpY2tuZXNzID0gcXN0eWxlLT5waXhlbE1ldHJp YyhRU3R5bGU6OlBNX1NsaWRlclRoaWNrbmVzcywgJm9wdGlvbik7CisgICAgICAgIGlmIChvcHRp b24ub3JpZW50YXRpb24gPT0gUXQ6OlZlcnRpY2FsKSB7CisgICAgICAgICAgICBzdHlsZS0+c2V0 V2lkdGgoTGVuZ3RoKHRoaWNrbmVzcywgRml4ZWQpKTsKKyAgICAgICAgICAgIHN0eWxlLT5zZXRI ZWlnaHQoTGVuZ3RoKGxlbmd0aCwgRml4ZWQpKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgIHN0eWxlLT5zZXRXaWR0aChMZW5ndGgobGVuZ3RoLCBGaXhlZCkpOworICAgICAgICAgICAg c3R5bGUtPnNldEhlaWdodChMZW5ndGgodGhpY2tuZXNzLCBGaXhlZCkpOworICAgICAgICB9CiAg ICAgfQogfQogCg==