66730 2011-08-22 16:41:48 -0700 WebSocket layout tests are flaky on Chromium Win 2011-10-19 21:02:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting toyoshim ap mihaip toyoshim webkit.review.bot yutak oldest_to_newest 455054 0 pkasting 2011-08-22 16:41:48 -0700 The following layout test is flaky on Chromium Win, for the release bot on the WebKit builder (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showExpectations=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhixie76%2Fhandshake-fail-by-no-connection-header.html ) and the bots on the downstream builder (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40DEPS%20-%20chromium.org&showExpectations=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhixie76%2Fhandshake-fail-by-no-connection-header.html ). http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html I don't know why sometimes the handshake doesn't fail; maybe one of you can get somewhere with this? 455058 1 pkasting 2011-08-22 16:46:22 -0700 More flaky WebSocket tests on Chromium Win: http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header.html http/tests/websocket/tests/hybi/masked-frames.html See e.g. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40DEPS%20-%20chromium.org&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fhandshake-fail-by-no-upgrade-header.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fmasked-frames.html&showExpectations=true 473533 2 mihaip 2011-09-26 16:44:30 -0700 http/tests/websocket/tests/hybi/close.html is flaky too: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fclose.html I'll add it to test_expectations.txt. See also 61767 for more flaky WebSocket tests. 476049 3 toyoshim 2011-09-30 05:58:01 -0700 I found a bug on Chromium side. I'm preparing a change for this issue. http://code.google.com/p/chromium/issues/detail?id=98664 481466 4 toyoshim 2011-10-10 23:12:15 -0700 I landed Chromium change to fix a socket termination problem on Windows. I believe this change will fix many WebSocket close related flaky tests. 481819 5 mihaip 2011-10-11 12:25:49 -0700 Looking at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fclose.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fhandshake-fail-by-no-upgrade-header.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fmasked-frames.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhixie76%2Fhandshake-fail-by-no-connection-header.html I'm not seeing any failures since http://crrev.com/104852. If things stay green for another day, can you remove the failing expectations from test_expectations.txt? 486613 6 yutak 2011-10-19 01:29:08 -0700 *** Bug 61767 has been marked as a duplicate of this bug. *** 486618 7 111576 yutak 2011-10-19 01:37:32 -0700 Created attachment 111576 Patch 486621 8 yutak 2011-10-19 01:41:41 -0700 (In reply to comment #7) > Created an attachment (id=111576) [details] > Patch Here's flakiness dashboard link for tests whose test expectation is being removed: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhixie76%2Fclient-close.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fclient-close.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhixie76%2Fhandshake-fail-by-no-connection-header.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fhandshake-fail-by-no-upgrade-header.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fmasked-frames.html%2Chttp%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fclose.html These tests stay green these days. 487291 9 111576 webkit.review.bot 2011-10-19 21:02:30 -0700 Comment on attachment 111576 Patch Clearing flags on attachment: 111576 Committed r97930: <http://trac.webkit.org/changeset/97930> 487292 10 webkit.review.bot 2011-10-19 21:02:35 -0700 All reviewed patches have been landed. Closing bug. 111576 2011-10-19 01:37:32 -0700 2011-10-19 21:02:30 -0700 Patch bug-66730-20111019173731.patch text/plain 2423 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3MjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNDBlZjgxOWZkMjY5MzA3ODk3N2Rh OTY1ZTRjNjYxNmNlYWM0NjMzLi5mY2EzNTM1NTY4ZDZlMjA0MDAxYjBhNGI1ODBlNWNmY2RjYTFl MjYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTkgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViU29ja2V0IGxheW91dCB0ZXN0cyBhcmUg Zmxha3kgb24gQ2hyb21pdW0gV2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NjczMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbW92ZSB0ZXN0IGV4cGVjdGF0aW9ucyBmb3IgV2ViU29ja2V0IHRlc3Rz IHdoaWNoIGhhdmUgbm90IGJlZW4gZmFpbGluZyBzaW5jZQorICAgICAgICBUY3BDbGllbnRTb2Nr ZXRXaW4gZml4IG9uIENocm9taXVtIChodHRwOi8vY3JyZXYuY29tLzEwNDg1MikuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTAt MTggIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NzY5Ny4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA3ODVjNzllODdjNjdjYjdhMTZm MTgxOWVjYmQ3NmJkMzZhMzBkNzNiLi41Nzk5Mzg0MzExMzdhMjVkYjg3NzY4NTFiNzFjMDU3MTVh N2YwYjZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CkBAIC0zMjI1LDkgKzMyMjUsNiBAQCBCVUdXSzYxNjY0IExJTlVYIDog c3ZnL3pvb20vcGFnZS9yZWxhdGl2ZS1zaXplZC1kb2N1bWVudC1zY3JvbGxiYXJzLnN2ZyA9IElN QUdFCiBCVUdDUjg0MzE3IERFQlVHIDogc3ZnL3dpY2QvdGVzdC1zY2FsYWJsZS1iYWNrZ3JvdW5k LWltYWdlMS54aHRtbCA9IENSQVNICiBCVUdDUjg0MzE3IE1BQyBMRU9QQVJEIFJFTEVBU0UgOiBz dmcvd2ljZC90ZXN0LXNjYWxhYmxlLWJhY2tncm91bmQtaW1hZ2UxLnhodG1sID0gSU1BR0UKIAot QlVHV0s2MTc2NyBXSU4gREVCVUcgOiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2 L2NsaWVudC1jbG9zZS5odG1sID0gUEFTUyBURVhUCi1CVUdXSzYxNzY3IFdJTiBERUJVRyA6IGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xpZW50LWNsb3NlLmh0bWwgPSBQQVNTIFRF WFQKLQogQlVHQUJBUlRIIExJTlVYIDogc3ZnL3RleHQvc2NhbGluZy1mb250LXdpdGgtZ2VvbWV0 cmljLXByZWNpc2lvbi5odG1sID0gUEFTUyBJTUFHRQogCiBCVUdDUjg0MTU3IFdJTiBHUFUgOiBm YXN0L2NhbnZhcy9jYW52YXMtY3VycmVudENvbG9yLmh0bWwgPSBURVhUCkBAIC0zNDg5LDExICsz NDg2LDYgQEAgQlVHV0s2NjU3NyBMRU9QQVJEIDogZmFzdC9ldmVudHMvdG91Y2gvdGFwLWhpZ2hs aWdodC1jb2xvci5odG1sID0gVElNRU9VVAogCiBCVUdWOF8xNjM0IDogZmFzdC9qcy9jb25zdC5o dG1sID0gVEVYVAogCi1CVUdXSzY2NzMwIFdJTiA6IGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2hpeGllNzYvaGFuZHNoYWtlLWZhaWwtYnktbm8tY29ubmVjdGlvbi1oZWFkZXIuaHRtbCA9IFBB U1MgVEVYVAotQlVHV0s2NjczMCBXSU4gOiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJp L2hhbmRzaGFrZS1mYWlsLWJ5LW5vLXVwZ3JhZGUtaGVhZGVyLmh0bWwgPSBQQVNTIFRFWFQKLUJV R1dLNjY3MzAgV0lOIDogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9tYXNrZWQtZnJh bWVzLmh0bWwgPSBQQVNTIFRFWFQKLUJVR1dLNjY3MzAgV0lOIDogaHR0cC90ZXN0cy93ZWJzb2Nr ZXQvdGVzdHMvaHliaS9jbG9zZS5odG1sID0gUEFTUyBURVhUCi0KIEJVR1dLNjYyMTcgV0lOIFJF TEVBU0UgOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS10cmVlL3Jlc291cmNlLXRyZWUt ZXJyb3JzLXJlbG9hZC5odG1sID0gUEFTUyBURVhUCiBCVUdXSzY2MjE3IFNMT1cgTElOVVggV0lO IERFQlVHIDogaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtdHJlZS9yZXNvdXJjZS10cmVl LWVycm9ycy1yZWxvYWQuaHRtbCA9IFBBU1MKIAo=